aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Re-introduce data migrations" #1757

Merged
hansegucker merged 5 commits from 137-re-introduce-data-migrations into master 2020-01-09 21:29:07 +01:00
Conversation 21 Commits 5 Files changed 2 +52
tteichler commented 2020-01-09 15:54:23 +01:00
Owner
Copy link

Closes #137

Closes #137
tteichler commented 2020-01-09 15:58:07 +01:00
Author
Owner
Copy link

added 1 commit

  • 2ba8f32a - Re-introduce data migrations for admin user and school term

Compare with previous version

added 1 commit <ul><li>2ba8f32a - Re-introduce data migrations for admin user and school term</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1064&start_sha=bc009767bd54ff7800954399ae8d2f57f58dfbb6)
tteichler commented 2020-01-09 15:58:59 +01:00
Author
Owner
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
tteichler commented 2020-01-09 15:59:03 +01:00
Author
Owner
Copy link

assigned to @nik

assigned to @nik
nik commented 2020-01-09 18:00:18 +01:00
Owner
Copy link

Nver import the User model directly. Please see the original migration code from BiscuIT or Django docs on what to do.

Nver import the User model directly. Please see the original migration code from BiscuIT or Django docs on what to do.
nik commented 2020-01-09 18:01:41 +01:00
Owner
Copy link

You need to do a few extra tricks to ensure the data access works in all configurations (for instance, use using t oselect the correct database). See the original migration code from BiscuIT.

You need to do a few extra tricks to ensure the data access works in all configurations (for instance, use `using` t oselect the correct database). See the original migration code from BiscuIT.
tteichler commented 2020-01-09 18:37:23 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-01-09 18:37:24 +01:00
Author
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1069&start_sha=2ba8f32a2769aa583f914394f6baa4a2b7b18f02#ef5cd24d5a2fcb1989bbb07b1b85c5f7173fbd08_2_3)
tteichler commented 2020-01-09 18:37:25 +01:00
Author
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1069&start_sha=2ba8f32a2769aa583f914394f6baa4a2b7b18f02#ed81fabf551f0fb2ee34c9bcd285b77430369ba6_8_12)
tteichler commented 2020-01-09 18:37:28 +01:00
Author
Owner
Copy link

added 1 commit

  • a07b3513 - Re-introduce data migrations for admin user and school term

Compare with previous version

added 1 commit <ul><li>a07b3513 - Re-introduce data migrations for admin user and school term</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1069&start_sha=2ba8f32a2769aa583f914394f6baa4a2b7b18f02)
nik commented 2020-01-09 20:30:42 +01:00
Owner
Copy link

This will fail if no SchoolTerm exists.

Actually, setting a schoolterm to current manually was only necessary because the migration was added after there already was one that created the term.

Now that we are recreating everything, just create the thing if none exists yet and forget about it.

This will fail if no SchoolTerm exists. Actually, setting a schoolterm to current manually was only necessary because the migration was added after there already was one that created the term. Now that we are recreating everything, just create the thing if none exists yet and forget about it.
nik commented 2020-01-09 20:33:11 +01:00
Owner
Copy link

What are these two migrations good for? ALso, why is the migration this is actually about (the data migration for the school term) not included ;)?

What are these two migrations good for? ALso, why is the migration this is actually about (the data migration for the school term) *not* included ;)?
tteichler commented 2020-01-09 20:38:54 +01:00
Author
Owner
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1070&start_sha=a07b351329ff288a2aabcefdc1ac65a1d16070ea#ed81fabf551f0fb2ee34c9bcd285b77430369ba6_10_11)
tteichler commented 2020-01-09 20:38:55 +01:00
Author
Owner
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1070&start_sha=a07b351329ff288a2aabcefdc1ac65a1d16070ea#ed81fabf551f0fb2ee34c9bcd285b77430369ba6_20_24)
tteichler commented 2020-01-09 20:38:57 +01:00
Author
Owner
Copy link

added 2 commits

  • 7f5f8fab - 1 commit from branch master
  • 3107e9e6 - Merge branch 'master' into 137-re-introduce-data-migrations

Compare with previous version

added 2 commits <ul><li>7f5f8fab - 1 commit from branch <code>master</code></li><li>3107e9e6 - Merge branch &#39;master&#39; into 137-re-introduce-data-migrations</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1070&start_sha=a07b351329ff288a2aabcefdc1ac65a1d16070ea)
tteichler commented 2020-01-09 20:41:20 +01:00
Author
Owner
Copy link

Because someone wrote a migration which had never worked and pushed it to master without testing ;).

No idea who „someone“ is :P…

Because someone wrote a migration which had never worked and pushed it to master without testing ;). No idea who „someone“ is :P…
tteichler commented 2020-01-09 20:41:20 +01:00
Author
Owner
Copy link

added 1 commit

  • 3ab70d86 - Merge branch 'master' into 137-re-introduce-data-migrations

Compare with previous version

added 1 commit <ul><li>3ab70d86 - Merge branch &#39;master&#39; into 137-re-introduce-data-migrations</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1071&start_sha=3107e9e6a63c666cc3d905f4b100156b8db36f92)
tteichler commented 2020-01-09 20:41:24 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-01-09 21:09:47 +01:00
Author
Owner
Copy link

added 3 commits

  • 2d9cb6a7 - 1 commit from branch master
  • c683e6ba - Merge branch 'master' into 137-re-introduce-data-migrations
  • 6ab452cd - Fix migration.

Compare with previous version

added 3 commits <ul><li>2d9cb6a7 - 1 commit from branch <code>master</code></li><li>c683e6ba - Merge branch &#39;master&#39; into 137-re-introduce-data-migrations</li><li>6ab452cd - Fix migration.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1072&start_sha=3ab70d86f31a3e201712dc39f592abc340a775ab)
tteichler commented 2020-01-09 21:25:18 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c43ebd2a - FIx migration.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/112/diffs?diff_id=1073&start_sha=6ab452cdb9edf2f0f57c57f768aee52976fe2898)
nik commented 2020-01-09 21:29:07 +01:00
Owner
Copy link

mentioned in commit f6625580c6

mentioned in commit f6625580c64bda5ff52c8599e57d7b4f6bf439bd
nik commented 2020-01-09 21:29:07 +01:00
Owner
Copy link

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!1757
No description provided.