aleksis/AlekSIS-Core
9
0
Fork 0
Code Issues 197 Pull requests 63 Projects Releases 14 Packages 1 Wiki Activity Actions

Resolve "Dashboard" #1745

Merged
hansegucker merged 18 commits from 30-dashboard into master 2020-01-06 22:27:30 +01:00
Conversation 52 Commits 18 Files changed 4 +109 -21
tteichler commented 2020-01-04 17:24:37 +01:00
Owner
Copy link
No description provided.
hansegucker commented 2020-01-04 17:25:09 +01:00
Owner
Copy link

changed the description

changed the description
tteichler commented 2020-01-04 17:25:18 +01:00
Author
Owner
Copy link

added 1 commit

  • d1606ab4 - Add basic view and template for dashboard.

Compare with previous version

added 1 commit <ul><li>d1606ab4 - Add basic view and template for dashboard.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1014&start_sha=de16ace3655181599e54012f2be7cd6d4aa921ef)
hansegucker commented 2020-01-04 17:26:51 +01:00
Owner
Copy link

We shouldn't include that in AlekSIS.

We shouldn't include that in AlekSIS.
hansegucker commented 2020-01-04 17:27:16 +01:00
Owner
Copy link

Finish translation.

Finish translation.
tteichler commented 2020-01-04 17:40:30 +01:00
Author
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1015&start_sha=d1606ab40baa8d3ff7f7f13859d7200f4b13e5df#c70246bfe92cadfda1fc62372879594d38d383ba_7_7)
tteichler commented 2020-01-04 17:40:32 +01:00
Author
Owner
Copy link

added 1 commit

  • d0fc5044 - Remove superflous stuff from dashboard.

Compare with previous version

added 1 commit <ul><li>d0fc5044 - Remove superflous stuff from dashboard.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1015&start_sha=d1606ab40baa8d3ff7f7f13859d7200f4b13e5df)
tteichler commented 2020-01-04 20:53:45 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c651ef22 - Make strings translatable.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1016&start_sha=d0fc504472aaa5cbd5a9882f0d9013874af452ff)
tteichler commented 2020-01-04 20:54:57 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-01-05 12:45:44 +01:00
Author
Owner
Copy link

added 30 commits

  • c651ef22...b40be365 - 28 commits from branch master
  • 9b99b876 - Add function to mark notifications as read.
  • f1f890f5 - Merge branch 'master' into 30-dashboard

Compare with previous version

added 30 commits <ul><li>c651ef22...b40be365 - 28 commits from branch <code>master</code></li><li>9b99b876 - Add function to mark notifications as read.</li><li>f1f890f5 - Merge branch &#39;master&#39; into 30-dashboard</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1032&start_sha=c651ef228eda546381a414b5ca4bbc576b68fb0c)
hansegucker commented 2020-01-05 15:12:33 +01:00
Owner
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1033&start_sha=f1f890f59f83cc14838fbc63ab0aad0891c468fe#c70246bfe92cadfda1fc62372879594d38d383ba_11_5)
hansegucker commented 2020-01-05 15:12:34 +01:00
Owner
Copy link

added 2 commits

  • 0c7d5a4f - Fix way for marking notifications as read
  • 3ad44c4d - Update dashboard template

Compare with previous version

added 2 commits <ul><li>0c7d5a4f - Fix way for marking notifications as read</li><li>3ad44c4d - Update dashboard template</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1033&start_sha=f1f890f59f83cc14838fbc63ab0aad0891c468fe)
hansegucker commented 2020-01-05 19:42:09 +01:00
Owner
Copy link

added 5 commits

  • 3ad44c4d...c27ce08c - 3 commits from branch master
  • ece7161e - Merge branch 'master' into 30-dashboard
  • 5b444ff9 - Update dashboard views to use person model instead of user model

Compare with previous version

added 5 commits <ul><li>3ad44c4d...c27ce08c - 3 commits from branch <code>master</code></li><li>ece7161e - Merge branch &#39;master&#39; into 30-dashboard</li><li>5b444ff9 - Update dashboard views to use person model instead of user model</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1039&start_sha=3ad44c4d33e6db43a6da27796f321642e9247f87)
tteichler commented 2020-01-06 20:14:03 +01:00
Author
Owner
Copy link

added 1 commit

  • 1b484b4b - Fix view if person is not authenticated.

Compare with previous version

added 1 commit <ul><li>1b484b4b - Fix view if person is not authenticated.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1041&start_sha=5b444ff9fae8b86461caa5ffbeb409001002cfa5)
hansegucker commented 2020-01-06 20:25:12 +01:00
Owner
Copy link

added 1 commit

  • d5b47039 - Add login_required to dashboard in order to show login page if not authenticated

Compare with previous version

added 1 commit <ul><li>d5b47039 - Add login_required to dashboard in order to show login page if not authenticated</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1042&start_sha=1b484b4beeda9ed7d2e7432b2ddc84982d118716)
hansegucker commented 2020-01-06 20:26:21 +01:00
Owner
Copy link

@debdolph @nik I think we can merge this request. The other dashboard features can be added later.

@debdolph @nik I think we can merge this request. The other dashboard features can be added later.
tteichler commented 2020-01-06 20:34:28 +01:00
Author
Owner
Copy link

Everything works fine with the dashboard. Maybe @nik can take a quick look and merge this MR after review.

Everything works fine with the dashboard. Maybe @nik can take a quick look and merge this MR after review.
tteichler commented 2020-01-06 21:00:51 +01:00
Author
Owner
Copy link

added 18 commits

  • d5b47039...4b045281 - 15 commits from branch master
  • 224420bd - Merge branch 'master' into 30-dashboard
  • 1741b6cf - Merge branch '30-dashboard' of edugit.org:AlekSIS/AlekSIS into 30-dashboard
  • b8617090 - Merge branch 'master' into 30-dashboard

Compare with previous version

added 18 commits <ul><li>d5b47039...4b045281 - 15 commits from branch <code>master</code></li><li>224420bd - Merge branch &#39;master&#39; into 30-dashboard</li><li>1741b6cf - Merge branch &#39;30-dashboard&#39; of edugit.org:AlekSIS/AlekSIS into 30-dashboard</li><li>b8617090 - Merge branch &#39;master&#39; into 30-dashboard</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1044&start_sha=d5b47039000d2a9987c4c2cfda857f07fc4b73dd)
tteichler commented 2020-01-06 21:46:05 +01:00
Author
Owner
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nik commented 2020-01-06 21:51:22 +01:00
Owner
Copy link

Unrelated change - also, it seems the overriding of thepage title from sub-templates has gone missing somewhere... Please open a new issue for that so we remember it beore resolving this thread.

Unrelated change - also, it seems the overriding of thepage title from sub-templates has gone missing somewhere... Please open a new issue for that so we remember it beore resolving this thread.
nik commented 2020-01-06 21:53:17 +01:00
Owner
Copy link

This should be ENglish and more general.

This should be ENglish and more general.
nik commented 2020-01-06 21:57:45 +01:00
Owner
Copy link

The ordering should be the default for the model. Please move it to its Meta definition. Also, what is wrong with request.user.person.activities instead of this query?

        activities = request.user.person.activities.all()[:5]

Lastly, please note that you need to check whether the user is actually linked to a person before using the .person relation.

The ordering should be the default for the model. Please move it to its Meta definition. Also, what is wrong with `request.user.person.activities` instead of this query? ```suggestion:-0+0 activities = request.user.person.activities.all()[:5] ``` Lastly, please note that you need to check whether the user is actually linked to a person before using the `.person` relation.
nik commented 2020-01-06 21:58:25 +01:00
Owner
Copy link

If you use this renaming, please use the short name in all places later. Or remove this and use explicit request.user everywhere.

If you use this renaming, please use the short name in all places later. Or remove this and use explicit `request.user` everywhere.
tteichler commented 2020-01-06 21:59:18 +01:00
Author
Owner
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1045&start_sha=b8617090aa0e7f81472aa0ba8d4c3f221253c544#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_30_30)
tteichler commented 2020-01-06 21:59:19 +01:00
Author
Owner
Copy link

added 1 commit

  • deec0fe5 - Apply suggestion to aleksis/core/views.py

Compare with previous version

added 1 commit <ul><li>deec0fe5 - Apply suggestion to aleksis/core/views.py</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1045&start_sha=b8617090aa0e7f81472aa0ba8d4c3f221253c544)
nik commented 2020-01-06 21:59:32 +01:00
Owner
Copy link

The .filter() does not make sense as you are operating on the relation on Person nayway. For the order_by, please see above.

The `.filter()` does not make sense as you are operating on the relation on `Person` nayway. For the `order_by`, please see above.
nik commented 2020-01-06 21:59:59 +01:00
Owner
Copy link

See above.

See above.
nik commented 2020-01-06 22:00:06 +01:00
Owner
Copy link

See above.

See above.
tteichler commented 2020-01-06 22:00:17 +01:00
Author
Owner
Copy link

created #146 to continue this discussion

created #146 to continue this discussion
tteichler commented 2020-01-06 22:00:17 +01:00
Author
Owner
Copy link

mentioned in issue #146

mentioned in issue #146
nik commented 2020-01-06 22:00:40 +01:00
Owner
Copy link

Only admins are able to mark notifications as read?

Only admins are able to mark notifications as read?
nik commented 2020-01-06 22:01:55 +01:00
Owner
Copy link

This function is insecure. It allows everyone (assuming the admin_required is wrong) to mark everyone's notifications as read. You need to check that the notification to act upon is related to the user calling the view.

This function is insecure. It allows everyone (assuming the `admin_required` is wrong) to mark everyone's notifications as read. You need to check that the notification to act upon is related to the user calling the view.
nik commented 2020-01-06 22:04:41 +01:00
Owner
Copy link

removed milestone

removed milestone
tteichler commented 2020-01-06 22:10:51 +01:00
Author
Owner
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1046&start_sha=deec0fe52f65288e02e08a9a47974e0708615e14#afebbb8b618230f7d6b0b696821439e7450eb037_13_13)
tteichler commented 2020-01-06 22:10:53 +01:00
Author
Owner
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1046&start_sha=deec0fe52f65288e02e08a9a47974e0708615e14#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_27_27)
tteichler commented 2020-01-06 22:10:53 +01:00
Author
Owner
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1046&start_sha=deec0fe52f65288e02e08a9a47974e0708615e14#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_33_31)
tteichler commented 2020-01-06 22:10:53 +01:00
Author
Owner
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1046&start_sha=deec0fe52f65288e02e08a9a47974e0708615e14#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_37_34)
tteichler commented 2020-01-06 22:10:54 +01:00
Author
Owner
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1046&start_sha=deec0fe52f65288e02e08a9a47974e0708615e14#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_38_34)
tteichler commented 2020-01-06 22:10:54 +01:00
Author
Owner
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1046&start_sha=deec0fe52f65288e02e08a9a47974e0708615e14#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_262_258)
tteichler commented 2020-01-06 22:10:55 +01:00
Author
Owner
Copy link

added 1 commit

  • f31818df - Improve code of dashboard.

Compare with previous version

added 1 commit <ul><li>f31818df - Improve code of dashboard.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1046&start_sha=deec0fe52f65288e02e08a9a47974e0708615e14)
tteichler commented 2020-01-06 22:11:51 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ab4a07b8 - Improve code of dashboard.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1047&start_sha=f31818df31e95f49bb4b7fbc2a14d311fd594fd7)
tteichler commented 2020-01-06 22:12:36 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
nik commented 2020-01-06 22:12:50 +01:00
Owner
Copy link

Please make this thread translatable.

Please make this thread translatable.
tteichler commented 2020-01-06 22:12:54 +01:00
Author
Owner
Copy link

assigned to @nik

assigned to @nik
nik commented 2020-01-06 22:14:35 +01:00
Owner
Copy link

Please throw a matching HTTP error instead.

Please throw a matching HTTP error instead.
tteichler commented 2020-01-06 22:14:41 +01:00
Author
Owner
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1048&start_sha=ab4a07b8d46d208a5bd440b70e4e000bb65b8813#afebbb8b618230f7d6b0b696821439e7450eb037_15_15)
tteichler commented 2020-01-06 22:14:42 +01:00
Author
Owner
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1048&start_sha=ab4a07b8d46d208a5bd440b70e4e000bb65b8813#afebbb8b618230f7d6b0b696821439e7450eb037_13_13)
tteichler commented 2020-01-06 22:14:43 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ea317c6a - Make strings translateable.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1048&start_sha=ab4a07b8d46d208a5bd440b70e4e000bb65b8813)
tteichler commented 2020-01-06 22:25:23 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
tteichler commented 2020-01-06 22:25:26 +01:00
Author
Owner
Copy link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1049&start_sha=ea317c6afe58c74b7faae3f49fda838306b5dfd6#ca5e4a886c594c4b59402dbdbd16348bdbcddf3a_267_268)
tteichler commented 2020-01-06 22:25:27 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ad3a5f45 - Raise exception.</li></ul> [Compare with previous version](/AlekSIS/AlekSIS/merge_requests/100/diffs?diff_id=1049&start_sha=ea317c6afe58c74b7faae3f49fda838306b5dfd6)
nik commented 2020-01-06 22:27:30 +01:00
Owner
Copy link

merged

merged
nik commented 2020-01-06 22:27:31 +01:00
Owner
Copy link

mentioned in commit 227d1a6b88

mentioned in commit 227d1a6b887b697ae95323a8eb1e11fa5d602765
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-Core!1745
No description provided.