added 1 commit <ul><li>77054aa0 - Introduce option for configuring the creating of course groups</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=17981&start_sha=15d4152441d3dc0f170834f4149c193e42aa8900)

hansegucker commented

2022-02-05 14:04:22 +01:00

Author

Owner

added 1 commit

23cb5092 - Introduce option for configuring the creating of course groups

Compare with previous version

added 1 commit <ul><li>23cb5092 - Introduce option for configuring the creating of course groups</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=17985&start_sha=77054aa081373e3e250cf8a5476d2e97e708ce6b)

hansegucker commented

2022-02-05 17:04:23 +01:00

Author

Owner

added 3 commits

23cb5092...7519ac31 - 2 commits from branch master
54aa0bf6 - Merge branch 'master' into 41-create-match-failures-as-data-checks

Compare with previous version

added 3 commits <ul><li>23cb5092...7519ac31 - 2 commits from branch <code>master</code></li><li>54aa0bf6 - Merge branch 'master' into 41-create-match-failures-as-data-checks</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=17997&start_sha=23cb50927e9292eb1afb8547a0664d9145716242)

hansegucker commented

2022-02-05 17:22:59 +01:00

Author

Owner

added 1 commit

d12186a1 - Fix wrong import

Compare with previous version

added 1 commit <ul><li>d12186a1 - Fix wrong import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18001&start_sha=54aa0bf6421a876f1339045cb76e2aaad37fd29a)

hansegucker commented

2022-02-05 18:05:27 +01:00

Author

Owner

added 1 commit

c64ac004 - Fix preference name

Compare with previous version

added 1 commit <ul><li>c64ac004 - Fix preference name</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18004&start_sha=d12186a1276c4b2d0f54d18a95c50eb0d4be6950)

hansegucker commented

2022-02-05 18:15:38 +01:00

Author

Owner

added 1 commit

c4220f31 - Fix preference name

Compare with previous version

added 1 commit <ul><li>c4220f31 - Fix preference name</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18006&start_sha=c64ac0047de1ad3559be721fc72f07c6d6972652)

hansegucker commented

2022-02-05 21:43:25 +01:00

Author

Owner

added 1 commit

240db7e2 - Fix is_untis_primary_source helper method

Compare with previous version

added 1 commit <ul><li>240db7e2 - Fix is_untis_primary_source helper method</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18011&start_sha=c4220f311bf7c6355c4822ff165fcfd8a54bdaa6)

hansegucker commented

2022-02-05 22:01:18 +01:00

Author

Owner

added 1 commit

27b2390f - Fix preference name

Compare with previous version

added 1 commit <ul><li>27b2390f - Fix preference name</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18015&start_sha=240db7e2c24d5c2f2aa348fbf890d1eecc0cd531)

hansegucker commented

2022-02-05 22:19:08 +01:00

Author

Owner

added 1 commit

c5938c38 - Add missing preference registration

Compare with previous version

added 1 commit <ul><li>c5938c38 - Add missing preference registration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18017&start_sha=27b2390fd795d6009293e847fbef349be72832f5)

nik commented

2022-02-06 11:43:22 +01:00

Owner

The import does not create new groups, but there are also no data check results.

nik commented

2022-02-06 11:43:53 +01:00

Owner

Don't forget to document the preference in the manual.

hansegucker commented

2022-02-06 13:34:51 +01:00

Author

Owner

added 1 commit

893420bc - Limit match configuration and data check result creation to course groups

Compare with previous version

added 1 commit <ul><li>893420bc - Limit match configuration and data check result creation to course groups</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18038&start_sha=c5938c3873c8b45ff7afa15eafa2dc7df58f4a33)

hansegucker commented

2022-02-06 15:12:44 +01:00

Author

Owner

added 1 commit

8f1d864e - [Docs] Update information on usage for preferences

Compare with previous version

added 1 commit <ul><li>8f1d864e - [Docs] Update information on usage for preferences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18062&start_sha=893420bc5b5f01a1f0ee3beb5d3907b660cb106e)

hansegucker commented

2022-02-06 17:29:09 +01:00

Author

Owner

Done.

hansegucker commented

2022-02-06 17:29:10 +01:00

Author

Owner

resolved all threads

hansegucker commented

2022-02-06 17:29:19 +01:00

Author

Owner

Please test again with current changes.

nik commented

2022-02-07 18:29:12 +01:00

Owner

added 11 commits

8f1d864e...97f3c2da - 10 commits from branch master
0c5c088d - Merge branch 'master' into 41-create-match-failures-as-data-checks

Compare with previous version

added 11 commits <ul><li>8f1d864e...97f3c2da - 10 commits from branch <code>master</code></li><li>0c5c088d - Merge branch 'master' into 41-create-match-failures-as-data-checks</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18198&start_sha=8f1d864e362388f88fbd1ba73cb4cce50b37905e)

nik commented

2022-02-07 19:06:53 +01:00

Owner

    s = str(s)
  File "/usr/local/lib/python3.9/dist-packages/aleksis/core/models.py", line 1131, in __str__
    return f"{self.related_object}: {self.related_check.problem_name}"
  File "/usr/local/lib/python3.9/dist-packages/aleksis/core/models.py", line 1125, in related_check
    return DataCheckRegistry.data_checks_by_name[self.check]
KeyError: 'untis_not_created_not_primary_source'

@hansegucker

```plain s = str(s) File "/usr/local/lib/python3.9/dist-packages/aleksis/core/models.py", line 1131, in __str__ return f"{self.related_object}: {self.related_check.problem_name}" File "/usr/local/lib/python3.9/dist-packages/aleksis/core/models.py", line 1125, in related_check return DataCheckRegistry.data_checks_by_name[self.check] KeyError: 'untis_not_created_not_primary_source' ``` @hansegucker

hansegucker commented

2022-02-07 19:36:32 +01:00

Author

Owner

added 3 commits

0c5c088d...5ce243b5 - 2 commits from branch master
56c7e46e - Merge branch 'master' into 41-create-match-failures-as-data-checks

Compare with previous version

added 3 commits <ul><li>0c5c088d...5ce243b5 - 2 commits from branch <code>master</code></li><li>56c7e46e - Merge branch 'master' into 41-create-match-failures-as-data-checks</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18202&start_sha=0c5c088d82caa0af65b3066ecbb9173388803e8d)

hansegucker commented

2022-02-07 19:51:01 +01:00

Author

Owner

added 1 commit

c917e415 - Register data checks

Compare with previous version

added 1 commit <ul><li>c917e415 - Register data checks</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=18205&start_sha=56c7e46e7e2df15a63c7077c59d8c625fcc45a45)

tteichler commented

2022-02-16 10:43:31 +01:00

Owner

    Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/celery/app/trace.py", line 451, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/sentry_sdk/integrations/celery.py", line 200, in _inner
    reraise(*exc_info)
  File "/usr/local/lib/python3.9/dist-packages/sentry_sdk/_compat.py", line 54, in reraise
    raise value
  File "/usr/local/lib/python3.9/dist-packages/sentry_sdk/integrations/celery.py", line 195, in _inner
    return f(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/celery/app/trace.py", line 734, in __protected_call__
    return self.run(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/aleksis/apps/untis/tasks.py", line 11, in _task
    import_command.run(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/aleksis/apps/untis/commands.py", line 38, in run
    _untis_import_mysql(cls.get_terms(), version=version)
  File "/usr/local/lib/python3.9/dist-packages/aleksis/apps/untis/util/mysql/main.py", line 60, in untis_import_mysql
    import_lessons(
  File "/usr/local/lib/python3.9/dist-packages/aleksis/apps/untis/util/mysql/importers/lessons.py", line 248, in import_lessons
    CourseGroupNotFoundAndNotCreated.register_result(lesson)
  File "/usr/local/lib/python3.9/dist-packages/aleksis/core/data_checks.py", line 201, in register_result
    result, __ = DataCheckResult.objects.get_or_create(
  File "/usr/local/lib/python3.9/dist-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/django/db/models/query.py", line 581, in get_or_create
    return self.get(**kwargs), False
  File "/usr/local/lib/python3.9/dist-packages/django/db/models/query.py", line 439, in get
    raise self.model.MultipleObjectsReturned(
aleksis.core.models.DataCheckResult.MultipleObjectsReturned: get() returned more than one DataCheckResult -- it returned 2!

``` Traceback (most recent call last): File "/usr/local/lib/python3.9/dist-packages/celery/app/trace.py", line 451, in trace_task R = retval = fun(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/sentry_sdk/integrations/celery.py", line 200, in _inner reraise(*exc_info) File "/usr/local/lib/python3.9/dist-packages/sentry_sdk/_compat.py", line 54, in reraise raise value File "/usr/local/lib/python3.9/dist-packages/sentry_sdk/integrations/celery.py", line 195, in _inner return f(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/celery/app/trace.py", line 734, in __protected_call__ return self.run(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/aleksis/apps/untis/tasks.py", line 11, in _task import_command.run(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/aleksis/apps/untis/commands.py", line 38, in run _untis_import_mysql(cls.get_terms(), version=version) File "/usr/local/lib/python3.9/dist-packages/aleksis/apps/untis/util/mysql/main.py", line 60, in untis_import_mysql import_lessons( File "/usr/local/lib/python3.9/dist-packages/aleksis/apps/untis/util/mysql/importers/lessons.py", line 248, in import_lessons CourseGroupNotFoundAndNotCreated.register_result(lesson) File "/usr/local/lib/python3.9/dist-packages/aleksis/core/data_checks.py", line 201, in register_result result, __ = DataCheckResult.objects.get_or_create( File "/usr/local/lib/python3.9/dist-packages/django/db/models/manager.py", line 85, in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) File "/usr/local/lib/python3.9/dist-packages/django/db/models/query.py", line 581, in get_or_create return self.get(**kwargs), False File "/usr/local/lib/python3.9/dist-packages/django/db/models/query.py", line 439, in get raise self.model.MultipleObjectsReturned( aleksis.core.models.DataCheckResult.MultipleObjectsReturned: get() returned more than one DataCheckResult -- it returned 2! ```

hansegucker commented

2022-03-22 20:34:28 +01:00

Author

Owner

added 20 commits

c917e415...40a2a7b8 - 18 commits from branch master
2f4d6f55 - Merge branch 'master' into 41-create-match-failures-as-data-checks
3e4c0f97 - Don't run delete logic on manual created data checks

Compare with previous version

added 20 commits <ul><li>c917e415...40a2a7b8 - 18 commits from branch <code>master</code></li><li>2f4d6f55 - Merge branch 'master' into 41-create-match-failures-as-data-checks</li><li>3e4c0f97 - Don't run delete logic on manual created data checks</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=19875&start_sha=c917e415a89550a4ceeb7cd0f1c5db9f4953fdb6)

hansegucker commented

2022-03-22 20:34:52 +01:00

Author

Owner

resolved all threads

hansegucker commented

2022-03-31 21:12:55 +02:00

Author

Owner

added 5 commits

3e4c0f97...c57a5129 - 4 commits from branch master
a0cb5fd9 - Merge branch 'master' into 41-create-match-failures-as-data-checks

Compare with previous version

added 5 commits <ul><li>3e4c0f97...c57a5129 - 4 commits from branch <code>master</code></li><li>a0cb5fd9 - Merge branch 'master' into 41-create-match-failures-as-data-checks</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=20177&start_sha=3e4c0f97846748f42002fdf60daf8cf50e6a7dcf)

hansegucker commented

2022-03-31 21:13:42 +02:00

Author

Owner

added 1 commit

39363a96 - Update changelog

Compare with previous version

added 1 commit <ul><li>39363a96 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Untis/-/merge_requests/120/diffs?diff_id=20178&start_sha=a0cb5fd9f766271a2f9dfe70e630e77f3b5b17d5)

hansegucker commented

2022-03-31 21:13:59 +02:00

Author

Owner

marked this merge request as ready

marked this merge request as **ready**

hansegucker merged commit 0de901045f into master

2022-03-31 21:14:09 +02:00

hansegucker commented

2022-03-31 21:14:10 +02:00

Author

Owner