aleksis/AlekSIS-App-Tezor
Watch
10
0
Fork
You've already forked AlekSIS-App-Tezor
 0
Code Issues 13 Pull requests 4 Projects Releases 1 Packages 1 Activity Actions

Migrate remaining legacy pages to Vue #168

Merged
hansegucker merged 8 commits from migrate/vue into master 2026-09-15 12:59:24 +02:00
Conversation 1 Commits 8 Files changed 40 +1165 -824
hansegucker commented 2026-08-19 12:05:22 +02:00
Owner
Copy link

Information and screenshots

image

image

image

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

## Information and screenshots ![image](/attachments/db066992-e4c6-43b0-9c1f-86e140e29421) ![image](/attachments/1f57b1ce-a96e-4556-959d-891afd003f95) ![image](/attachments/dc43814f-ccd7-4df3-a5e4-4005b7639475) ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [x] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [x] Adhere to [URL scheme](https://code.teckids.org/aleksis/aleksis/issues/86) - [x] Tested with admin account - [x] Tested with normal account (based on permissions) ## Backend checklist - [x] Use permissions for all GraphQL mutations - [x] Use query optimizer for all GraphQL queries - [x] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [x] Screenshots are attached (mobile and desktop) - [x] Tested on mobile, tablet, and desktop sizes - [x] Adhered to [frontend guidelines](hhttps://code.teckids.org/aleksis/AlekSIS/src/branch/master/project/frontend_guidelines.rst) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/)
image.png
36 KiB
image.png
44 KiB
image.png
71 KiB
Migrate invoice groups to vue
Some checks failed
CI / lock (push) Successful in 40s
Details
CI / test (push) Failing after 2m3s
Details
CI / lint (push) Successful in 2m31s
Details
CI / tests-done (push) Failing after 2s
Details
CI / build (push) Successful in 2m51s
Details
CI / publish (push) Has been skipped
Details
0356c2e202
Migrate payment variants to Vue frontend
Some checks failed
CI / lint (push) Has been cancelled
Details
CI / test (push) Has been cancelled
Details
CI / tests-done (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details
CI / publish (push) Has been cancelled
Details
CI / lock (push) Has been cancelled
Details
8579a51202
Update copyright
All checks were successful
CI / lock (push) Successful in 29s
Details
CI / lint (push) Successful in 1m8s
Details
CI / build (push) Successful in 1m11s
Details
CI / test (push) Successful in 1m50s
Details
CI / tests-done (push) Successful in 2s
Details
CI / publish (push) Successful in 16s
Details
9bc4654e8f
Update changelog
Some checks failed
CI / lock (push) Successful in 40s
Details
CI / test (push) Failing after 3m19s
Details
CI / lint (push) Successful in 3m38s
Details
CI / tests-done (push) Failing after 1s
Details
CI / build (push) Successful in 3m49s
Details
CI / publish (push) Has been skipped
Details
acceeb6f0d
hansegucker changed title from WIP: Migrate remaining legacy pages to Vue to Migrate remaining legacy pages to Vue 2026-09-05 18:11:03 +02:00
leuckeju requested changes 2026-09-15 07:32:57 +02:00
aleksis/apps/tezor/frontend/components/client/ClientList.vue Outdated
@ -0,0 +6,4 @@
<c-r-u-d-provider
:object-schema="{ type: 'PaymentClientType' }"
disable-inline-edit
> </c-r-u-d-provider>
leuckeju commented 2026-09-15 07:20:32 +02:00
Member
Copy link

Please replace
> </c-r-u-d-provider>
with />

Please replace ` > </c-r-u-d-provider> ` with `/>`
hansegucker marked this conversation as resolved
aleksis/apps/tezor/frontend/components/invoice_group/InvoiceGroupList.vue Outdated
@ -0,0 +6,4 @@
<c-r-u-d-provider
:object-schema="{ type: 'InvoiceGroupType' }"
disable-inline-edit
> </c-r-u-d-provider>
leuckeju commented 2026-09-15 07:20:49 +02:00
Member
Copy link

here as well

here as well
hansegucker marked this conversation as resolved
aleksis/apps/tezor/frontend/objectSchemas.js Outdated
@ -5,0 +28,4 @@
} from "./components/payment_variant/queries.graphql";
export const paymentVariantObjectSchema = {
type: "PaymentVariantType",
leuckeju commented 2026-09-15 07:25:08 +02:00
Member
Copy link

It might be that you need something like aleksis/AlekSIS-Core#3950/files after the recent core changes, but maybe not, did you test this with a recent enough core?

It might be that you need something like https://code.teckids.org/aleksis/AlekSIS-Core/pulls/3950/files after the recent core changes, but maybe not, did you test this with a recent enough core?
hansegucker marked this conversation as resolved
aleksis/apps/tezor/models/invoice.py Outdated
@ -141,3 +140,3 @@
def get_absolute_url(self):
return reverse("invoice_by_token", kwargs={"slug": self.token})
return f"/o/invoice/{self.token}"
leuckeju commented 2026-09-15 07:26:44 +02:00
Member
Copy link

this seems wrong, there is e.g. no app label in this url?

this seems wrong, there is e.g. no app label in this url?
leuckeju commented 2026-09-15 07:31:26 +02:00
Member
Copy link

btw, if you need this url in the frontend, there is now a field for this in the objectschema, which will automatically add a link in the action column of a crudlist

btw, if you need this url in the frontend, there is now a field for this in the objectschema, which will automatically add a link in the action column of a crudlist
leuckeju commented 2026-09-15 07:34:40 +02:00
Member
Copy link

@hansegucker Take a look at

Line 589 in aleksis/AlekSIS-Core@6ca7b33
absoluteUrl: (group) => ({

this is probably what you want to use

@hansegucker Take a look at https://code.teckids.org/aleksis/AlekSIS-Core/src/commit/6ca7b3331d5a9a5ca16a3f28f14661cdfa32dfa3/aleksis/core/frontend/objectSchemas.js#L589 this is probably what you want to use
hansegucker marked this conversation as resolved
Fix things from review
Some checks failed
CI / lint (push) Has been cancelled
Details
CI / test (push) Has been cancelled
Details
CI / tests-done (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details
CI / publish (push) Has been cancelled
Details
CI / lock (push) Has been cancelled
Details
888bf81d32
hansegucker force-pushed migrate/vue from 888bf81d32
Some checks failed
CI / lint (push) Has been cancelled
Details
CI / test (push) Has been cancelled
Details
CI / tests-done (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details
CI / publish (push) Has been cancelled
Details
CI / lock (push) Has been cancelled
Details
to d281d71efd
Some checks failed
CI / lock (push) Successful in 30s
Details
CI / build (push) Failing after 1m20s
Details
CI / lint (push) Successful in 1m36s
Details
CI / test (push) Successful in 2m39s
Details
CI / tests-done (push) Successful in 3s
Details
CI / publish (push) Has been skipped
Details
2026-09-15 12:56:02 +02:00 Compare
hansegucker scheduled this pull request to auto merge when all checks succeed 2026-09-15 12:57:12 +02:00
hansegucker deleted branch migrate/vue 2026-09-15 12:59:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
yuha
leuckeju
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Tezor!168
No description provided.