aleksis/AlekSIS-App-Stoelindeling
Watch
10
0
Fork
You've already forked AlekSIS-App-Stoelindeling
 0
Code Issues 4 Pull requests 4 Projects Releases Packages 1 Activity Actions

Resolve "Add integration in Alsijil" #23

Merged
hansegucker merged 13 commits from 2-add-integration-in-alsijil into master 2022-06-05 11:23:13 +02:00
Conversation 23 Commits 13 Files changed 10 +295 -36
hansegucker commented 2022-04-06 21:32:51 +02:00
Owner
Copy link

Closes #2

Closes #2
hansegucker commented 2022-04-09 16:59:28 +02:00
Author
Owner
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>d479a3cd - Add missing migration</li><li>412153bf - Add intergration of seating plans</li><li>7c1ecce6 - Fix permissions</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Stoelindeling/-/merge_requests/3/diffs?diff_id=20329&start_sha=ddf81aba3912d23109afbac56e907f1f05ce68c9)
hansegucker commented 2022-04-09 16:59:55 +02:00
Author
Owner
Copy link

Related: https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/278

Related: https://edugit.org/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/278
hansegucker commented 2022-04-09 16:59:57 +02:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2022-04-09 17:00:01 +02:00
Author
Owner
Copy link

assigned to @nik

assigned to @nik
hansegucker commented 2022-04-11 11:14:21 +02:00
Author
Owner
Copy link

added 1h of time spent

added 1h of time spent
hansegucker commented 2022-04-11 16:21:56 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e72d5a40 - Fix migration dep</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Stoelindeling/-/merge_requests/3/diffs?diff_id=20363&start_sha=7c1ecce6db68c09de421883f7ba2a665b9834e23)
nik commented 2022-04-12 19:45:37 +02:00
Owner
Copy link

I am not convinced this can be considered "readable".

Can this be re-arranged to not have so many conditionals chained, let alone several if subject blocks?

I am not convinced this can be considered "readable". Can this be re-arranged to not have so many conditionals chained, let alone several `if subject` blocks?
nik commented 2022-04-12 19:45:37 +02:00
Owner
Copy link

Missing doc string.

Missing doc string.
nik commented 2022-04-12 19:45:37 +02:00
Owner
Copy link

Missing doc string.

Missing doc string.
hansegucker commented 2022-04-13 15:35:05 +02:00
Author
Owner
Copy link

added 3 commits

  • e72d5a40...3c7e8cbc - 2 commits from branch master
  • 34a4354f - Merge branch 'master' into 2-add-integration-in-alsijil

Compare with previous version

added 3 commits <ul><li>e72d5a40...3c7e8cbc - 2 commits from branch <code>master</code></li><li>34a4354f - Merge branch &#39;master&#39; into 2-add-integration-in-alsijil</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Stoelindeling/-/merge_requests/3/diffs?diff_id=20397&start_sha=e72d5a407d965f24acf55033491a3961c4a400eb)
hansegucker commented 2022-04-13 16:04:05 +02:00
Author
Owner
Copy link

added 2 commits

  • a977b64b - Fix some permissions for use in Alsijil
  • d423655f - Reduce menu as there is just one menu item

Compare with previous version

added 2 commits <ul><li>a977b64b - Fix some permissions for use in Alsijil</li><li>d423655f - Reduce menu as there is just one menu item</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Stoelindeling/-/merge_requests/3/diffs?diff_id=20398&start_sha=34a4354fb1bc72e3c4d4d3692df667b144393814)
magicfelix commented 2022-04-13 16:27:47 +02:00
Member
Copy link

added 1 commit

  • b62877f8 - [CI] Publish package

Compare with previous version

added 1 commit <ul><li>b62877f8 - [CI] Publish package</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Stoelindeling/-/merge_requests/3/diffs?diff_id=20402&start_sha=d423655fced1ce3ceed9d8d5aa2f315e0edbca63)
nik commented 2022-04-13 20:21:45 +02:00
Owner
Copy link

requested review from @magicfelix

requested review from @magicfelix
magicfelix commented 2022-04-24 12:39:03 +02:00
Member
Copy link

Using an admin account I created a seating plan (regular teachers don't have the necessary permission) for group 2b, subject D.
On the Alsijil page for such a lesson (2b, D) it says "There is no seating plan for this lesson.".

This problem probably occurs, because we don't have rooms for our lesson periods.
Do we want to support this use case and fix it in AlekSIS or is a lesson period required to have a room assigned?

Using an admin account I created a seating plan (regular teachers don't have the necessary permission) for group 2b, subject D. On the Alsijil page for such a lesson (2b, D) it says "There is no seating plan for this lesson.". This problem probably occurs, because we don't have rooms for our lesson periods. Do we want to support this use case and fix it in AlekSIS or is a lesson period required to have a room assigned?
magicfelix commented 2022-04-25 21:51:31 +02:00
Member
Copy link

added 4 commits

  • 5bae62cf - Fix permission names
  • 8fa12ebc - Fix some permissions for use in Alsijil
  • ef670485 - Reduce menu as there is just one menu item
  • 472eecc1 - [CI] Publish package

Compare with previous version

added 4 commits <ul><li>5bae62cf - Fix permission names</li><li>8fa12ebc - Fix some permissions for use in Alsijil</li><li>ef670485 - Reduce menu as there is just one menu item</li><li>472eecc1 - [CI] Publish package</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Stoelindeling/-/merge_requests/3/diffs?diff_id=20703&start_sha=b62877f8578a0bb44b963a8ca88c4d2d63c8fefe)
magicfelix commented 2022-04-25 21:54:19 +02:00
Member
Copy link

Eh? copy_seatingplan_predicate = a and a few lines below copy_seatingplans_predicate = b?

Eh? `copy_seatingplan_predicate = a` and a few lines below `copy_seatingplans_predicate = b`?
hansegucker commented 2022-05-01 18:22:16 +02:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/onboarding/AlekSIS-App-Stoelindeling/-/merge_requests/3/diffs?diff_id=20784&start_sha=472eecc1356accd61d8e61d4378e4c1860d1e23f#b7f734abc939169ac17fa88e5ba46a586d6e1f21_21_24)
hansegucker commented 2022-05-01 18:22:17 +02:00
Author
Owner
Copy link

added 7 commits

  • 472eecc1...3c7e8cbc - 2 commits from branch master
  • 34a4354f - Merge branch 'master' into 2-add-integration-in-alsijil
  • a977b64b - Fix some permissions for use in Alsijil
  • d423655f - Reduce menu as there is just one menu item
  • 201c9a09 - Merge branch '2-add-integration-in-alsijil' of...
  • 8dd17b56 - Make code better readable and add docstrings

Compare with previous version

added 7 commits <ul><li>472eecc1...3c7e8cbc - 2 commits from branch <code>master</code></li><li>34a4354f - Merge branch &#39;master&#39; into 2-add-integration-in-alsijil</li><li>a977b64b - Fix some permissions for use in Alsijil</li><li>d423655f - Reduce menu as there is just one menu item</li><li>201c9a09 - Merge branch &#39;2-add-integration-in-alsijil&#39; of...</li><li>8dd17b56 - Make code better readable and add docstrings</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Stoelindeling/-/merge_requests/3/diffs?diff_id=20784&start_sha=472eecc1356accd61d8e61d4378e4c1860d1e23f)
hansegucker commented 2022-05-01 18:22:33 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
nik commented 2022-06-04 12:42:26 +02:00
Owner
Copy link

@hansegucker Please reply here.

@hansegucker Please reply here.
nik commented 2022-06-05 11:22:55 +02:00
Owner
Copy link

Dev sprint decision: Seating plans for lessons without rooms are unsupported (actually, lessons without rooms are somewhat unsupported ;).

Dev sprint decision: Seating plans for lessons without rooms are unsupported (actually, lessons without rooms are somewhat unsupported ;).
nik commented 2022-06-05 11:22:56 +02:00
Owner
Copy link

resolved all threads

resolved all threads
nik merged commit e7c8963915 into master 2022-06-05 11:23:13 +02:00
nik commented 2022-06-05 11:23:14 +02:00
Owner
Copy link

mentioned in commit e7c8963915

mentioned in commit e7c8963915cbe5e2803e2e3873fac4dc754b4223
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
2022.6 — "Cohn"
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Stoelindeling!23
No description provided.