aleksis/AlekSIS-App-Resint
8
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases 1 Packages Activity Actions

Resolve "Provide infrastructure for live documents" #39

Merged
hansegucker merged 13 commits from 3-provide-infrastructure-for-live-documents into master 2021-11-03 13:09:51 +01:00
Conversation 33 Commits 13 Files changed 12 +564 -160
hansegucker commented 2021-08-03 18:15:13 +02:00 (Migrated from edugit.org)
Copy link

Closes #3

Closes #3
hansegucker commented 2021-08-03 18:15:18 +02:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2021-08-03 20:23:01 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 1b20eb62 - Add model for live documents
  • 7b20ab35 - Add views for managing live documents

Compare with previous version

added 2 commits <ul><li>1b20eb62 - Add model for live documents</li><li>7b20ab35 - Add views for managing live documents</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10976&start_sha=3ddc0ec5fa17105f03497e1cb5cd879bb3684085)
hansegucker commented 2021-08-03 21:10:01 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • cdf1eb56 - Update poetry.lock
  • 4d233879 - Add missing changes in livedocument migration
  • 44613036 - Raise 404 error if live document has no current PDF file
  • a5f77438 - Show filename in table for live documents
  • 8dc87f2b - Reformat

Compare with previous version

added 5 commits <ul><li>cdf1eb56 - Update poetry.lock</li><li>4d233879 - Add missing changes in livedocument migration</li><li>44613036 - Raise 404 error if live document has no current PDF file</li><li>a5f77438 - Show filename in table for live documents</li><li>8dc87f2b - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10982&start_sha=7b20ab352323ccd8413b7d956983e4fd86eb7ada)
hansegucker commented 2021-08-03 21:11:42 +02:00 (Migrated from edugit.org)
Copy link

mentioned in merge request AlekSIS/official/AlekSIS-App-Chronos!214

mentioned in merge request AlekSIS/official/AlekSIS-App-Chronos!214
nik commented 2021-08-03 21:45:46 +02:00 (Migrated from edugit.org)
Copy link

Shouldn't this use reversion to discover the most recent revision?

Shouldn't this use reversion to discover the most recent revision?
nik commented 2021-08-03 21:45:46 +02:00 (Migrated from edugit.org)
Copy link

Why only PDF?

(Same for subsequent comments/docstrings)

Why only PDF? (Same for subsequent comments/docstrings)
nik commented 2021-08-03 21:45:46 +02:00 (Migrated from edugit.org)
Copy link

The slug should be part of the filename.

The slug should be part of the filename.
nik commented 2021-08-03 21:45:47 +02:00 (Migrated from edugit.org)
Copy link

This should create a revision instead.

This should create a revision instead.
nik commented 2021-08-03 21:45:47 +02:00 (Migrated from edugit.org)
Copy link

What is the benefit in this instead of just using current_file?

What is the benefit in this instead of just using `current_file`?
nik commented 2021-08-03 21:45:47 +02:00 (Migrated from edugit.org)
Copy link

Simply redirect to the absolute URL of the file field instead.

(Also, no need to run get_current_file() twice)

Simply redirect to the absolute URL of the file field instead. (Also, no need to run `get_current_file()` twice)
hansegucker commented 2021-08-05 16:38:58 +02:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker commented 2021-08-05 16:51:35 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10997&start_sha=8dc87f2b0c78b92bcf01b41965e28c22e3c63c67#96194f65ae8ac49a35d9ad053a843dcd382ea38d_159_158)
hansegucker commented 2021-08-05 16:51:36 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10997&start_sha=8dc87f2b0c78b92bcf01b41965e28c22e3c63c67#96194f65ae8ac49a35d9ad053a843dcd382ea38d_149_149)
hansegucker commented 2021-08-05 16:51:36 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10997&start_sha=8dc87f2b0c78b92bcf01b41965e28c22e3c63c67#96194f65ae8ac49a35d9ad053a843dcd382ea38d_171_169)
hansegucker commented 2021-08-05 16:51:36 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10997&start_sha=8dc87f2b0c78b92bcf01b41965e28c22e3c63c67#96194f65ae8ac49a35d9ad053a843dcd382ea38d_172_169)
hansegucker commented 2021-08-05 16:51:37 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10997&start_sha=8dc87f2b0c78b92bcf01b41965e28c22e3c63c67#96194f65ae8ac49a35d9ad053a843dcd382ea38d_179_189)
hansegucker commented 2021-08-05 16:51:37 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10997&start_sha=8dc87f2b0c78b92bcf01b41965e28c22e3c63c67#bd3f27ab95cbac7e388ac8b38dcd99c5e8ec0021_235_235)
hansegucker commented 2021-08-05 16:51:37 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • f3007ba0 - Restructure and cleanup LiveDocument model using revisions
  • be45ba11 - Show more information in the LiveDocument table
  • 3f43259a - Remove button for creating plain live documents

Compare with previous version

added 3 commits <ul><li>f3007ba0 - Restructure and cleanup LiveDocument model using revisions</li><li>be45ba11 - Show more information in the LiveDocument table</li><li>3f43259a - Remove button for creating plain live documents</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=10997&start_sha=8dc87f2b0c78b92bcf01b41965e28c22e3c63c67)
hansegucker commented 2021-08-05 16:51:56 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-08-05 16:52:05 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-10-22 09:05:30 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 3f43259a...2e7dee00 - 2 commits from branch master
  • 93cc50a8 - Merge branch 'master' into 3-provide-infrastructure-for-live-documents

Compare with previous version

added 3 commits <ul><li>3f43259a...2e7dee00 - 2 commits from branch <code>master</code></li><li>93cc50a8 - Merge branch &#39;master&#39; into 3-provide-infrastructure-for-live-documents</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=12438&start_sha=3f43259a3c37061e0e46a7e3f5405fc7221cf56f)
nik commented 2021-10-23 18:17:41 +02:00 (Migrated from edugit.org)
Copy link

assigned to @nik and unassigned @hansegucker

assigned to @nik and unassigned @hansegucker
nik commented 2021-10-23 18:23:39 +02:00 (Migrated from edugit.org)
Copy link
        raise NotImplementedError("Subclasses of LiveDocument must implement update()")
```suggestion:-0+0 raise NotImplementedError("Subclasses of LiveDocument must implement update()") ```
nik commented 2021-10-23 18:25:43 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
nik commented 2021-10-23 18:25:44 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=12553&start_sha=93cc50a8c3bfa4f34cb37e36d0406e63498d2188#96194f65ae8ac49a35d9ad053a843dcd382ea38d_205_205)
nik commented 2021-10-23 18:25:44 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • afe8031f - Raise NotImplementedError instead of silently passing in update()

Compare with previous version

added 1 commit <ul><li>afe8031f - Raise NotImplementedError instead of silently passing in update()</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=12553&start_sha=93cc50a8c3bfa4f34cb37e36d0406e63498d2188)
nik (Migrated from edugit.org) scheduled this pull request to auto merge when all checks succeed 2021-10-23 18:26:37 +02:00
hansegucker commented 2021-11-02 10:59:45 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
hansegucker commented 2021-11-02 13:54:21 +01:00 (Migrated from edugit.org)
Copy link

aborted the automatic merge because source branch was updated

aborted the automatic merge because source branch was updated
hansegucker commented 2021-11-02 13:54:21 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3de969a3 - Bump version of AleKSIS-Core to ^2.1

Compare with previous version

added 1 commit <ul><li>3de969a3 - Bump version of AleKSIS-Core to ^2.1</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Resint/-/merge_requests/16/diffs?diff_id=12896&start_sha=afe8031fc2838c99d1de42bda62161b3b0bd56ec)
hansegucker commented 2021-11-02 18:55:51 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-11-02 18:56:03 +01:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker commented 2021-11-02 18:57:01 +01:00 (Migrated from edugit.org)
Copy link

There is no changelog update because there is no changelog. I will add it after this is merged while I am preparing the release.

There is no changelog update because there is no changelog. I will add it after this is merged while I am preparing the release.
nik commented 2021-11-03 13:09:51 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit d8cd078e0f

mentioned in commit d8cd078e0f7aa3fa3fddd06be2aa58068ae626fb
nik (Migrated from edugit.org) merged commit d8cd078e0f into master 2021-11-03 13:09:51 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Resint!39
No description provided.