aleksis/AlekSIS-App-Resint
8
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases 1 Packages Activity Actions

Resolve "Not mensa-specific" #37

Merged
fph merged 16 commits from 1-not-mensa-specific into master 2021-07-30 14:02:42 +02:00
Conversation 24 Commits 16 Files changed 28 +2677 -955
fph commented 2021-04-10 10:03:44 +02:00 (Migrated from edugit.org)
Copy link

Closes #1

Closes #2

Closes #1 Closes #2
fph commented 2021-06-27 09:05:22 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • aa35d19e - add class based views

Compare with previous version

added 1 commit <ul><li>aa35d19e - add class based views</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10272&start_sha=a41e41c28240c468b956215c7ad8a5a1ee23b5f3)
hansegucker commented 2021-06-27 12:21:08 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 103d9614 - Update pyproject.toml according to current Core
  • fcc5b132 - Update poetry.lock
  • fde1e905 - Update CI configuration

Compare with previous version

added 3 commits <ul><li>103d9614 - Update pyproject.toml according to current Core</li><li>fcc5b132 - Update poetry.lock</li><li>fde1e905 - Update CI configuration</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10275&start_sha=aa35d19e997255d98d95fd5e9ad49597bf4dd0ea)
hansegucker commented 2021-06-27 12:30:24 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>48284886 - Update tox.ini</li><li>b5496c79 - Update copyright information</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10278&start_sha=fde1e9055cc72c22c064e42ffea96c8460a12d31)
hansegucker commented 2021-06-30 20:22:23 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0aca15a4 - Fix app config</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10301&start_sha=b5496c798046116ebae5d7a44dd0c66c3f025c1d)
hansegucker commented 2021-06-30 20:24:15 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 5cc3f858 - Refactor this app to support multiple poster groups with own configuration

Compare with previous version

added 1 commit <ul><li>5cc3f858 - Refactor this app to support multiple poster groups with own configuration</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10304&start_sha=0aca15a45e038d1b9f30bc5d70e1a54213bd951a)
hansegucker commented 2021-06-30 20:25:23 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 0f276fb3 - Refactor this app to support multiple poster groups with own configuration

Compare with previous version

added 1 commit <ul><li>0f276fb3 - Refactor this app to support multiple poster groups with own configuration</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10306&start_sha=5cc3f858b738a51c10508b8e0324312c8e9ab09a)
hansegucker commented 2021-07-03 11:29:36 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>521544b0 - Update poetry.lock</li><li>ff0887b9 - Add permissions for everything</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10326&start_sha=0f276fb3ae9a7e27a1ee1e5f0843fc9d0b871c12)
hansegucker commented 2021-07-03 11:29:57 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-07-03 11:30:01 +02:00 (Migrated from edugit.org)
Copy link

requested review from @ZugBahnHof

requested review from @ZugBahnHof
hansegucker commented 2021-07-03 11:30:03 +02:00 (Migrated from edugit.org)
Copy link

requested review from @yuha and removed review request for @ZugBahnHof

requested review from @yuha and removed review request for @ZugBahnHof
hansegucker commented 2021-07-03 11:30:22 +02:00 (Migrated from edugit.org)
Copy link

@fph Please review.

@yuha Please review the permissions 😉

@fph Please review. @yuha Please review the permissions :wink:
hansegucker commented 2021-07-03 11:30:55 +02:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
fph commented 2021-07-03 19:03:56 +02:00 (Migrated from edugit.org)
Copy link
  • The week number refers to the previous week, example: If you select week 27, the document is displayed between 28.06. and 04.07. However, my calendar says that calendar week 27 is from 05.07.-11.07.
  • Uploaded posters can only be displayed or deleted. Why is it not possible to edit them, e.g. to update the document?
  • You cannot upload a document to poster group B in week X if one already exists in poster group A for this week.
  • Menu entry of a second poster group is not displayed.
- [ ] The week number refers to the previous week, example: If you select week 27, the document is displayed between 28.06. and 04.07. However, my calendar says that calendar week 27 is from 05.07.-11.07. - [x] Uploaded posters can only be displayed or deleted. Why is it not possible to edit them, e.g. to update the document? - [x] You cannot upload a document to poster group B in week X if one already exists in poster group A for this week. - [x] Menu entry of a second poster group is not displayed.
hansegucker commented 2021-07-04 18:11:38 +02:00 (Migrated from edugit.org)
Copy link

The week number refers to the previous week, example: If you select week 27, the document is displayed between 28.06. and 04.07. However, my calendar says that calendar week 27 is from 05.07.-11.07.

What did you select as publishing day?

> The week number refers to the previous week, example: If you select week 27, the document is displayed between 28.06. and 04.07. However, my calendar says that calendar week 27 is from 05.07.-11.07. What did you select as publishing day?
hansegucker commented 2021-07-04 18:13:22 +02:00 (Migrated from edugit.org)
Copy link

You cannot upload a document to poster group B in week X if one already exists in poster group A for this week.

Now fixed. Please pull and migrate to test.

> You cannot upload a document to poster group B in week X if one already exists in poster group A for this week. Now fixed. Please pull and migrate to test.
hansegucker commented 2021-07-04 18:13:31 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • b63c3afa - Include poster group in unique constraint for posters
  • c9361381 - Reformat

Compare with previous version

added 2 commits <ul><li>b63c3afa - Include poster group in unique constraint for posters</li><li>c9361381 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10393&start_sha=ff0887b9d203c8916b2b6d2135be61d308955e13)
hansegucker commented 2021-07-04 18:13:48 +02:00 (Migrated from edugit.org)
Copy link

Menu entry of a second poster group is not displayed.

I can't reproduce this. Can you please give some additional information on this? What did you select for "Show in menu" and "Show for not-logged in users"?

> Menu entry of a second poster group is not displayed. I can't reproduce this. Can you please give some additional information on this? What did you select for "Show in menu" and "Show for not-logged in users"?
hansegucker commented 2021-07-14 12:30:11 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6ce4fbfc - Show PDF files always in new tabs

Compare with previous version

added 1 commit <ul><li>6ce4fbfc - Show PDF files always in new tabs</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10515&start_sha=c936138108aef9ebb6af5cc88486a63a5cbb081d)
hansegucker commented 2021-07-14 12:50:16 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 27c05995 - Fix page titles for poster management views
  • 1573dcf2 - Use correct permissions in templates
  • a6400c89 - Filter selectable groups in upload form by permissions
  • 691131e7 - Add view for editing posters

Compare with previous version

added 4 commits <ul><li>27c05995 - Fix page titles for poster management views</li><li>1573dcf2 - Use correct permissions in templates</li><li>a6400c89 - Filter selectable groups in upload form by permissions</li><li>691131e7 - Add view for editing posters</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Resint/-/merge_requests/14/diffs?diff_id=10517&start_sha=6ce4fbfc361990c8126b052c85ebe40a69dcbc32)
hansegucker commented 2021-07-18 16:56:57 +02:00 (Migrated from edugit.org)
Copy link

@fph Can you please give some feedback?

@fph Can you please give some feedback?
hansegucker commented 2021-07-18 16:57:10 +02:00 (Migrated from edugit.org)
Copy link

@yuha, too.

@yuha, too.
fph commented 2021-07-26 09:45:36 +02:00 (Migrated from edugit.org)
Copy link

Everything's fine. All items checked.

Everything's fine. All items checked.
hansegucker commented 2021-07-30 14:02:39 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit f75031e358

mentioned in commit f75031e3589dd50dc92b9687d1277a7347e6aa6b
hansegucker (Migrated from edugit.org) merged commit f75031e358 into master 2021-07-30 14:02:42 +02:00
nik commented 2025-02-24 12:19:16 +01:00 (Migrated from edugit.org)
Copy link

unassigned @fph

unassigned @fph
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Resint!37
No description provided.