aleksis/AlekSIS-App-Postbuero
8
0
Fork 0
Code Issues 10 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Resolve "Initialise app and move mailaddress stuff from TIC-Desk" #33

Merged
debdolph merged 41 commits from 1-initialise-app-and-move-mailaddress-stuff-form-tic-desk into master 2022-04-15 22:12:39 +02:00
Conversation 114 Commits 41 Files changed 26 +600 -2809
debdolph commented 2021-04-14 16:18:05 +02:00 (Migrated from edugit.org)
Copy link

Closes #1

Closes #1
debdolph commented 2021-04-14 16:19:35 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 22f79c6f...fa5e9029 - 2 commits from branch master

Compare with previous version

added 2 commits <ul><li>22f79c6f...fa5e9029 - 2 commits from branch <code>master</code></li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7205&start_sha=22f79c6f1816eafb5eb646cc8e37ee6787732bc5)
debdolph commented 2021-04-17 16:29:05 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 97d0dd84 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1

Compare with previous version

added 1 commit <ul><li>97d0dd84 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7416&start_sha=fa5e90290c9fdeac46e9bb016eba8072cb7ffbc7)
debdolph commented 2021-04-17 16:47:10 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 4c8ee157 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1

Compare with previous version

added 1 commit <ul><li>4c8ee157 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7418&start_sha=97d0dd847b30b7256218c5bb5e54d6588706f4a8)
debdolph commented 2021-04-17 16:54:22 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 33e64541 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1

Compare with previous version

added 1 commit <ul><li>33e64541 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7419&start_sha=4c8ee1577db498e2ed09c7ec442c103aab5570d3)
debdolph commented 2021-04-17 17:11:49 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 4a781823 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1

Compare with previous version

added 1 commit <ul><li>4a781823 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7421&start_sha=33e645414f8b2651efe53d043d0a5c71d42fb763)
debdolph commented 2021-04-17 17:36:30 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 397da077 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1

Compare with previous version

added 1 commit <ul><li>397da077 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7426&start_sha=4a78182387309c97eda44ec26d8ae6679c49d70f)
debdolph commented 2021-04-17 17:53:21 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cd9a2258 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1

Compare with previous version

added 1 commit <ul><li>cd9a2258 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7427&start_sha=397da07730bd807fd8af0964f0d18031086b74cd)
debdolph commented 2021-04-17 17:59:04 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 81e18551 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1

Compare with previous version

added 1 commit <ul><li>81e18551 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7429&start_sha=cd9a2258a57535c723ee96132175aabecba44fc2)
debdolph commented 2021-04-17 18:44:45 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c1e2c1d5 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1

Compare with previous version

added 1 commit <ul><li>c1e2c1d5 - Initialise app and move mailaddress stuff from TIC-Desk. Closes #1</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7431&start_sha=81e18551b3e56679477c0c404c15ac2321c15b19)
debdolph commented 2021-04-17 19:00:08 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
debdolph commented 2021-04-17 19:00:48 +02:00 (Migrated from edugit.org)
Copy link

requested review from @hansegucker

requested review from @hansegucker
debdolph commented 2021-04-17 19:00:50 +02:00 (Migrated from edugit.org)
Copy link

assigned to @nik and unassigned @debdolph

assigned to @nik and unassigned @debdolph
nik commented 2021-04-17 21:52:09 +02:00 (Migrated from edugit.org)
Copy link

changed title from Resolve "Initialise app and move mailaddress stuff f{-o-}rm TIC-Desk" to Resolve "Initialise app and move mailaddress stuff fr{+o+}m TIC-Desk"

changed title from **Resolve "Initialise app and move mailaddress stuff f{-o-}rm TIC-Desk"** to **Resolve "Initialise app and move mailaddress stuff fr{+o+}m TIC-Desk"**
nik commented 2021-04-17 22:46:56 +02:00 (Migrated from edugit.org)
Copy link

What's this ticdesk thing ;)?

What's this `ticdesk` thing ;)?
nik commented 2021-04-17 22:46:56 +02:00 (Migrated from edugit.org)
Copy link

We need a more specific permission/rule here.

We need a more specific permission/rule here.
nik commented 2021-04-17 22:46:57 +02:00 (Migrated from edugit.org)
Copy link

The length should either be derived from the MIME RFCs, or be configurable.

Also, can we add validation for these fields?

The length should either be derived from the MIME RFCs, or be configurable. Also, can we add validation for these fields?
nik commented 2021-04-17 22:46:57 +02:00 (Migrated from edugit.org)
Copy link

All new views in AlekSIS official apps need to be class-based.

Also, a permission check is missing here.

All new views in AlekSIS official apps need to be class-based. Also, a permission check is missing here.
nik commented 2021-04-17 22:46:57 +02:00 (Migrated from edugit.org)
Copy link

Should this be hardcoded? I think we should rather use the app_label.

Should this be hardcoded? I think we should rather use the `app_label`.
debdolph commented 2021-04-17 23:01:19 +02:00 (Migrated from edugit.org)
Copy link

mentioned in issue AlekSIS/official/AlekSIS-Core#425

mentioned in issue AlekSIS/official/AlekSIS-Core#425
debdolph commented 2021-04-17 23:16:39 +02:00 (Migrated from edugit.org)
Copy link

https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/425

https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/425
hansegucker commented 2021-04-18 10:14:22 +02:00 (Migrated from edugit.org)
Copy link

Teckids?

Teckids?
hansegucker commented 2021-04-18 10:14:22 +02:00 (Migrated from edugit.org)
Copy link
    <li>{% blocktrans %}You currently not own any addresses.{% endblocktrans %}</li>
```suggestion:-0+0 <li>{% blocktrans %}You currently not own any addresses.{% endblocktrans %}</li> ```
hansegucker commented 2021-04-18 10:14:23 +02:00 (Migrated from edugit.org)
Copy link

card-panel won't work without including extra CSS.

`card-panel` won't work without including extra CSS.
hansegucker commented 2021-04-18 10:14:42 +02:00 (Migrated from edugit.org)
Copy link

@debdolph Please also add some screenshots.

@debdolph Please also add some screenshots.
debdolph commented 2021-04-24 20:23:05 +02:00 (Migrated from edugit.org)
Copy link

https://tools.ietf.org/html/rfc3696#section-3

https://tools.ietf.org/html/rfc3696#section-3
debdolph commented 2021-04-24 20:44:51 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7655&start_sha=c1e2c1d57d26b193aea48ac90103d53a235e8154#c3e155b40d774d5b6be217bbff259fb38694f671_13_13)
debdolph commented 2021-04-24 20:44:52 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7655&start_sha=c1e2c1d57d26b193aea48ac90103d53a235e8154#4eae848ad07f83f875b49446a9d0bce5b37855f7_12_12)
debdolph commented 2021-04-24 20:44:52 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7655&start_sha=c1e2c1d57d26b193aea48ac90103d53a235e8154#a4004cde9549530dd3ded0c8cb4b6744c7e322bd_20_20)
debdolph commented 2021-04-24 20:44:52 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7655&start_sha=c1e2c1d57d26b193aea48ac90103d53a235e8154#a4004cde9549530dd3ded0c8cb4b6744c7e322bd_28_28)
debdolph commented 2021-04-24 20:44:53 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7655&start_sha=c1e2c1d57d26b193aea48ac90103d53a235e8154#d7a4409fa8274e817c7d8277c23d642c9144beea_22_22)
debdolph commented 2021-04-24 20:44:54 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8506b67c - Rewrite logic</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=7655&start_sha=c1e2c1d57d26b193aea48ac90103d53a235e8154)
debdolph commented 2021-06-03 20:27:17 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=9515&start_sha=8506b67c17648101509c57453ff9387911a50c93#892a528ca43bdc69c024f7c314a67cca5236cf54_20_20)
debdolph commented 2021-06-03 20:27:18 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>66f74732 - Use stricter permission</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=9515&start_sha=8506b67c17648101509c57453ff9387911a50c93)
hansegucker commented 2021-06-03 20:39:32 +02:00 (Migrated from edugit.org)
Copy link

In general, permission names should not include can_ (only verbose names should so). Additionally, all permission rules in all official apps now have _rule as suffix. I think we should adapt this here.

In general, permission names should not include `can_` (only verbose names should so). Additionally, all permission rules in all official apps now have `_rule` as suffix. I think we should adapt this here.
debdolph commented 2021-06-03 21:03:31 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 305888c0 - Use beta version of AlekSIS core

Compare with previous version

added 1 commit <ul><li>305888c0 - Use beta version of AlekSIS core</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=9517&start_sha=66f747323c42650bb9823b9e952b656232f4ea02)
debdolph commented 2021-09-11 20:46:32 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 0e6f7980 - Fix rule name
  • 41a88b19 - Update lockfile

Compare with previous version

added 2 commits <ul><li>0e6f7980 - Fix rule name</li><li>41a88b19 - Update lockfile</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=11570&start_sha=305888c03f9377df92294a7da2661b779cc54226)
debdolph commented 2021-09-11 20:52:11 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • a3567676 - Update lockfile
  • ee14ad66 - Fix rule name

Compare with previous version

added 2 commits <ul><li>a3567676 - Update lockfile</li><li>ee14ad66 - Fix rule name</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=11572&start_sha=41a88b19bb57102c3f08ceb418c0b2aa5b5dd12f)
debdolph commented 2021-09-12 20:22:58 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>1771dad4 - Fix rule name</li><li>8c838169 - Fix tox config</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=11602&start_sha=ee14ad66fae8ddf83c3d60bdb25f2c5675dc9c5f)
debdolph commented 2022-01-18 17:40:30 +01:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 8c838169...707b3708 - 2 commits from branch master
  • c708e75e - Merge branch 'master' into 1-initialise-app-and-move-mailaddress-stuff-form-tic-desk
  • 6b8a9b6a - Update ci config and gitignore

Compare with previous version

added 4 commits <ul><li>8c838169...707b3708 - 2 commits from branch <code>master</code></li><li>c708e75e - Merge branch &#39;master&#39; into 1-initialise-app-and-move-mailaddress-stuff-form-tic-desk</li><li>6b8a9b6a - Update ci config and gitignore</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16797&start_sha=8c838169984248c4618452585ee5b97ffdc2b3df)
debdolph commented 2022-01-18 17:41:05 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>34842867 - Update to latest core</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16799&start_sha=6b8a9b6a9a77ffca3307eaea62e7dfde899b7220)
debdolph commented 2022-01-18 18:19:55 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7eaeeae5 - Add missing dependencies</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16802&start_sha=34842867452e58d286424eee3911c40d84d5e09e)
nik commented 2022-01-18 20:46:22 +01:00 (Migrated from edugit.org)
Copy link

Does this really need a core newer than 2.6?

Does this really need a core newer than 2.6?
nik commented 2022-01-18 20:47:57 +01:00 (Migrated from edugit.org)
Copy link

I am pretty sure you cannot use get_site_preferences at import time.

I am pretty sure you cannot use `get_site_preferences` at import time.
nik commented 2022-01-18 20:47:57 +01:00 (Migrated from edugit.org)
Copy link

This should probably be SET_NULL, and allow null values, ebcause it might occur that people want a cool-down period for mail addresses before allowing re-registration.

This should probably be `SET_NULL`, and allow null values, ebcause it might occur that people want a cool-down period for mail addresses before allowing re-registration.
nik commented 2022-01-18 20:47:57 +01:00 (Migrated from edugit.org)
Copy link

unique_together is deprecated. Use a UniqueConstraint.

`unique_together` is deprecated. Use a `UniqueConstraint`.
nik commented 2022-01-18 20:47:57 +01:00 (Migrated from edugit.org)
Copy link

This should return a HttpResponse of some sort as well, or not?

This should return a `HttpResponse` of some sort as well, or not?
debdolph commented 2022-01-18 21:15:41 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16812&start_sha=7eaeeae5f6808be5e5b354f034e2f80269e37054#c3e155b40d774d5b6be217bbff259fb38694f671_13_10)
debdolph commented 2022-01-18 21:15:41 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16812&start_sha=7eaeeae5f6808be5e5b354f034e2f80269e37054#199d5db9804a448934a12a28739cd74a401907a6_11_11)
debdolph commented 2022-01-18 21:15:41 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16812&start_sha=7eaeeae5f6808be5e5b354f034e2f80269e37054#199d5db9804a448934a12a28739cd74a401907a6_17_19)
debdolph commented 2022-01-18 21:15:41 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16812&start_sha=7eaeeae5f6808be5e5b354f034e2f80269e37054#4eae848ad07f83f875b49446a9d0bce5b37855f7_25_28)
debdolph commented 2022-01-18 21:15:41 +01:00 (Migrated from edugit.org)
Copy link

added 7 commits

Compare with previous version

added 7 commits <ul><li>c9e89d88 - Remove dependency on POSIX</li><li>70b9ab9d - Return HTTPResponse on POST</li><li>87e56203 - Remove deprecated unique_together</li><li>a4153499 - Allow null values</li><li>570af46b - Move preferences to postbuero</li><li>9ae4761f - Add migration</li><li>c3e94a5b - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16812&start_sha=7eaeeae5f6808be5e5b354f034e2f80269e37054)
nik commented 2022-01-18 21:22:52 +01:00 (Migrated from edugit.org)
Copy link

You can not use get_site_preferences at import time.

You can not use `get_site_preferences` at import time.
nik commented 2022-01-18 21:26:34 +01:00 (Migrated from edugit.org)
Copy link

The preference queried here does not exist.

I think you should jsut not use permissions for now, and jsut allow self-editing for everyone.

The preference queried here does not exist. I think you should jsut not use permissions for now, and jsut allow self-editing for everyone.
debdolph commented 2022-01-18 21:50:01 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 19 of the diff

changed this line in [version 19 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16814&start_sha=c3e94a5b4ecde027c91ec988be363602239a6437#c3e155b40d774d5b6be217bbff259fb38694f671_13_11)
debdolph commented 2022-01-18 21:50:01 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 19 of the diff

changed this line in [version 19 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16814&start_sha=c3e94a5b4ecde027c91ec988be363602239a6437#4bedb07d369511cebc943b9c5700a86a1c363c93_5_0)
debdolph commented 2022-01-18 21:50:01 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • fd6cd31d - Only allow self-editing for now
  • 343842ce - Validate form

Compare with previous version

added 2 commits <ul><li>fd6cd31d - Only allow self-editing for now</li><li>343842ce - Validate form</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16814&start_sha=c3e94a5b4ecde027c91ec988be363602239a6437)
debdolph commented 2022-01-18 21:59:45 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>723aa35f - Validate form</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16816&start_sha=343842ce9d0c474c0c26b3a5dde837d934317443)
nik commented 2022-01-18 22:30:29 +01:00 (Migrated from edugit.org)
Copy link

This should use the email absetemplate from core.

This should use the email absetemplate from core.
nik commented 2022-01-18 22:30:29 +01:00 (Migrated from edugit.org)
Copy link

This variablke is used nowhere.

Also, it should be lower case.

This variablke is used nowhere. Also, it should be lower case.
nik commented 2022-01-18 22:30:29 +01:00 (Migrated from edugit.org)
Copy link

Variables should be lower case.

Variables should be lower case.
nik commented 2022-01-18 22:30:29 +01:00 (Migrated from edugit.org)
Copy link

You should add this as a field error. Either by using the clean_FIELD methods, or better by attaching a validation function to the field, or by adding to field_errors.

You should add this as a field error. Either by using the `clean_FIELD` methods, or better by attaching a validation function to the field, or by adding to field_errors.
nik commented 2022-01-18 22:30:29 +01:00 (Migrated from edugit.org)
Copy link
        super().clean()

ALso, maybe jsut move this to the bottom as return super().clean()?

```suggestion:-0+0 super().clean() ``` ALso, maybe jsut move this to the bottom as `return super().clean()`?
nik commented 2022-01-18 22:30:29 +01:00 (Migrated from edugit.org)
Copy link

A domain is arequired.

A domain is arequired.
nik commented 2022-01-18 22:30:29 +01:00 (Migrated from edugit.org)
Copy link

Isn't person in initial data, and should thus be in the form? How is it attached, if not?

Isn't `person` in initial data, and should thus be in the form? How is it attached, if not?
nik commented 2022-01-18 22:30:30 +01:00 (Migrated from edugit.org)
Copy link

Didn't you drop the rules?

Didn't you drop the rules?
nik commented 2022-01-18 22:30:30 +01:00 (Migrated from edugit.org)
Copy link

Shouldn't this get the person as initial data?

Shouldn't this get the person as initial data?
nik commented 2022-01-18 22:30:30 +01:00 (Migrated from edugit.org)
Copy link

Please set a reverse name here.

Please set a reverse name here.
nik commented 2022-01-18 22:30:30 +01:00 (Migrated from edugit.org)
Copy link

Use the reverse field (as named above).

Use the reverse field (as named above).
nik commented 2022-01-18 22:30:30 +01:00 (Migrated from edugit.org)
Copy link
        mail_add_form = MailAddForm(request.POST)

Also, same remarks as in get.

```suggestion:-0+0 mail_add_form = MailAddForm(request.POST) ``` Also, same remarks as in `get`.
nik commented 2022-01-18 22:30:30 +01:00 (Migrated from edugit.org)
Copy link

I see this preference nowhere.

I see this preference nowhere.
nik commented 2022-01-18 22:30:30 +01:00 (Migrated from edugit.org)
Copy link

Please use the utility method for sending mail to admins from core.

Please use the utility method for sending mail to admins from core.
hansegucker commented 2022-01-19 16:41:31 +01:00 (Migrated from edugit.org)
Copy link

That should make use of a collection.

That should make use of a collection.
debdolph commented 2022-01-19 20:55:22 +01:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 723aa35f...cdb7da47 - 3 commits from branch master
  • 565b3ed5 - Merge branch 'master' into 1-initialise-app-and-move-mailaddress-stuff-form-tic-desk

Compare with previous version

added 4 commits <ul><li>723aa35f...cdb7da47 - 3 commits from branch <code>master</code></li><li>565b3ed5 - Merge branch &#39;master&#39; into 1-initialise-app-and-move-mailaddress-stuff-form-tic-desk</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16839&start_sha=723aa35f7e6f5143cb952b7f8be90b7b2a9aecf1)
debdolph commented 2022-01-19 21:41:47 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#c3e155b40d774d5b6be217bbff259fb38694f671_26_25)
debdolph commented 2022-01-19 21:41:47 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#c3e155b40d774d5b6be217bbff259fb38694f671_29_28)
debdolph commented 2022-01-19 21:41:47 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#c3e155b40d774d5b6be217bbff259fb38694f671_19_18)
debdolph commented 2022-01-19 21:41:47 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#c3e155b40d774d5b6be217bbff259fb38694f671_14_14)
debdolph commented 2022-01-19 21:41:47 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#4eae848ad07f83f875b49446a9d0bce5b37855f7_16_14)
debdolph commented 2022-01-19 21:41:48 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#199d5db9804a448934a12a28739cd74a401907a6_12_12)
debdolph commented 2022-01-19 21:41:48 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#4eae848ad07f83f875b49446a9d0bce5b37855f7_23_20)
debdolph commented 2022-01-19 21:41:48 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#4eae848ad07f83f875b49446a9d0bce5b37855f7_41_40)
debdolph commented 2022-01-19 21:41:48 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0#a4004cde9549530dd3ded0c8cb4b6744c7e322bd_24_24)
debdolph commented 2022-01-19 21:41:48 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>859ef6b5 - Use email template from core</li><li>f4a947e0 - Rewrite form and templatek</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16841&start_sha=565b3ed5949a471224681c26e51a3886939544d0)
nik commented 2022-01-19 21:50:02 +01:00 (Migrated from edugit.org)
Copy link

Use SET_NULL (for the reasons described in another thread)

Use `SET_NULL` (for the reasons described in another thread)
nik commented 2022-01-19 21:50:02 +01:00 (Migrated from edugit.org)
Copy link

Are we sure this does not collide?

Are we sure this does not collide?
nik commented 2022-01-19 21:50:02 +01:00 (Migrated from edugit.org)
Copy link

Doesn't this already exist in the core?

Doesn't this already exist in the core?
nik commented 2022-01-19 21:50:02 +01:00 (Migrated from edugit.org)
Copy link
    path("mails/manage/", views.ManageMail.as_view(), name="manage_mail"),
```suggestion:-0+0 path("mails/manage/", views.ManageMail.as_view(), name="manage_mail"), ```
nik commented 2022-01-19 21:50:02 +01:00 (Migrated from edugit.org)
Copy link

This effectively saves the mdoel twice, while one database hit would be sufficient.

This effectively saves the mdoel twice, while one database hit would be sufficient.
debdolph commented 2022-01-19 21:51:25 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 23 of the diff

changed this line in [version 23 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16843&start_sha=f4a947e0f72747debf2fa3d492dd9fa4e0653c30#8ed9698c8b053f7a431b7e515547ebde0701873f_6_6)
debdolph commented 2022-01-19 21:51:26 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 60d21cc5 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>60d21cc5 - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16843&start_sha=f4a947e0f72747debf2fa3d492dd9fa4e0653c30)
debdolph commented 2022-01-19 22:19:07 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16846&start_sha=60d21cc50430909a3b773ac25d8561b0dd4c4bc2#4eae848ad07f83f875b49446a9d0bce5b37855f7_37_35)
debdolph commented 2022-01-19 22:19:07 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16846&start_sha=60d21cc50430909a3b773ac25d8561b0dd4c4bc2#199d5db9804a448934a12a28739cd74a401907a6_15_15)
debdolph commented 2022-01-19 22:19:07 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16846&start_sha=60d21cc50430909a3b773ac25d8561b0dd4c4bc2#199d5db9804a448934a12a28739cd74a401907a6_16_15)
debdolph commented 2022-01-19 22:19:07 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16846&start_sha=60d21cc50430909a3b773ac25d8561b0dd4c4bc2#4eae848ad07f83f875b49446a9d0bce5b37855f7_31_30)
debdolph commented 2022-01-19 22:19:08 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • afbadd0c - Fix creation of mailaddress
  • c2ee8714 - Merge branch '1-initialise-app-and-move-mailaddress-stuff-form-tic-desk' of...

Compare with previous version

added 2 commits <ul><li>afbadd0c - Fix creation of mailaddress</li><li>c2ee8714 - Merge branch &#39;1-initialise-app-and-move-mailaddress-stuff-form-tic-desk&#39; of...</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16846&start_sha=60d21cc50430909a3b773ac25d8561b0dd4c4bc2)
debdolph commented 2022-01-19 22:20:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ad7dc9c1 - Fix mail</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16848&start_sha=c2ee87149cb83cb9ae9cebdbc0a7cf7cdb1a8ee4)
debdolph commented 2022-01-19 23:20:57 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 26 of the diff

changed this line in [version 26 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16850&start_sha=ad7dc9c105700fb29118502f48e52ebed2285c3c#4eae848ad07f83f875b49446a9d0bce5b37855f7_26_30)
debdolph commented 2022-01-19 23:20:58 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>9c1c0b0b - fuckoff</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=16850&start_sha=ad7dc9c105700fb29118502f48e52ebed2285c3c)
debdolph commented 2022-02-01 15:29:27 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>aa9bbcec - fix migration</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17653&start_sha=9c1c0b0ba1fce6c5fcf0ffae2a8ec38973cec85c)
debdolph commented 2022-02-01 15:51:26 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17657&start_sha=aa9bbcece0ede94cd9cd5fb988b2c71a1457ced3#5d07e7d72637aa0d59c89d381fe6dc4cf46e2491_28_28)
debdolph commented 2022-02-01 15:51:27 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>83e86914 - Update core</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17657&start_sha=aa9bbcece0ede94cd9cd5fb988b2c71a1457ced3)
debdolph commented 2022-02-01 20:07:53 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 29 of the diff

changed this line in [version 29 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17675&start_sha=83e8691469d7b63212dfd140b484e328e894a6b9#be3b21e79e90210b54605fae9555e418ec51f366_43_31)
debdolph commented 2022-02-01 20:07:53 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6888b518 - Add new model for mail domain

Compare with previous version

added 1 commit <ul><li>6888b518 - Add new model for mail domain</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17675&start_sha=83e8691469d7b63212dfd140b484e328e894a6b9)
debdolph commented 2022-02-01 22:10:22 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 30 of the diff

changed this line in [version 30 of the diff](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17687&start_sha=6888b5180e8401486356976eb0d489cc76b1728a#4eae848ad07f83f875b49446a9d0bce5b37855f7_29_30)
debdolph commented 2022-02-01 22:10:23 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 38ee0c76 - Add permissions for mail domains

Compare with previous version

added 1 commit <ul><li>38ee0c76 - Add permissions for mail domains</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17687&start_sha=6888b5180e8401486356976eb0d489cc76b1728a)
debdolph commented 2022-02-01 23:07:32 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1ef270df - Implement rest framework</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17689&start_sha=38ee0c766d92e7d9fc882ef7399aded76173d046)
debdolph commented 2022-02-01 23:22:07 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4b4feed9 - Add serializer</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17693&start_sha=1ef270df40adf04b045724432cd024723c7e4aaa)
debdolph commented 2022-02-01 23:36:32 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>44aa1023 - Fix serializer</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=17695&start_sha=4b4feed9f07a42812da701b5e033642ff8c26ae5)
debdolph commented 2022-02-11 18:16:38 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 13e8d06c - reformat
  • 81d1d990 - Merge branch '1-initialise-app-and-move-mailaddress-stuff-form-tic-desk' of...

Compare with previous version

added 2 commits <ul><li>13e8d06c - reformat</li><li>81d1d990 - Merge branch &#39;1-initialise-app-and-move-mailaddress-stuff-form-tic-desk&#39; of...</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=18467&start_sha=44aa1023f4033880ea11160903d6ae78217bac1b)
debdolph commented 2022-02-17 22:55:03 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 39cc69ae - Show only public domains to unauthenticated users

Compare with previous version

added 1 commit <ul><li>39cc69ae - Show only public domains to unauthenticated users</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=18596&start_sha=81d1d9901ae2e267758edb9db10409a5846b0014)
debdolph commented 2022-02-19 00:38:45 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • a212f707 - Fix creation of new mail addresses

Compare with previous version

added 1 commit <ul><li>a212f707 - Fix creation of new mail addresses</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=18638&start_sha=39cc69ae23ca8964424ba1b0b0eb3438eb604548)
debdolph commented 2022-02-21 21:20:37 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0f273c8b - Use only public domains</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=18848&start_sha=a212f7074411b16aadbd9aecdd421baa8ad6e7f9)
debdolph commented 2022-03-13 20:08:06 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>d6375d54 - Remove unused import</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Postbuero/-/merge_requests/7/diffs?diff_id=19543&start_sha=0f273c8b0b16b9463863f955c9b11a9af1fe7173)
debdolph (Migrated from edugit.org) merged commit 2f6ba44014 into master 2022-04-15 22:12:39 +02:00
debdolph commented 2022-04-15 22:12:41 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 2f6ba44014

mentioned in commit 2f6ba440140b138501b2d6e3c6fa819de198e435
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Postbuero!33
No description provided.