Resolve "Initialise app and move mailaddress stuff from TIC-Desk" #33
No reviewers
Labels
No labels
Security
TeX
auto-update
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
aleksis/AlekSIS-App-Postbuero!33
Loading…
Reference in a new issue
No description provided.
Delete branch "1-initialise-app-and-move-mailaddress-stuff-form-tic-desk"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1
added 2 commits
masterCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
c1e2c1d5- Initialise app and move mailaddress stuff from TIC-Desk. Closes #1Compare with previous version
marked this merge request as ready
requested review from @hansegucker
assigned to @nik and unassigned @debdolph
changed title from Resolve "Initialise app and move mailaddress stuff f{-o-}rm TIC-Desk" to Resolve "Initialise app and move mailaddress stuff fr{+o+}m TIC-Desk"
What's this
ticdeskthing ;)?We need a more specific permission/rule here.
The length should either be derived from the MIME RFCs, or be configurable.
Also, can we add validation for these fields?
All new views in AlekSIS official apps need to be class-based.
Also, a permission check is missing here.
Should this be hardcoded? I think we should rather use the
app_label.mentioned in issue AlekSIS/official/AlekSIS-Core#425
https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/425
Teckids?
card-panelwon't work without including extra CSS.@debdolph Please also add some screenshots.
https://tools.ietf.org/html/rfc3696#section-3
changed this line in version 9 of the diff
changed this line in version 9 of the diff
changed this line in version 9 of the diff
changed this line in version 9 of the diff
changed this line in version 9 of the diff
added 1 commit
8506b67c- Rewrite logicCompare with previous version
changed this line in version 10 of the diff
added 1 commit
66f74732- Use stricter permissionCompare with previous version
In general, permission names should not include
can_(only verbose names should so). Additionally, all permission rules in all official apps now have_ruleas suffix. I think we should adapt this here.added 1 commit
305888c0- Use beta version of AlekSIS coreCompare with previous version
added 2 commits
Compare with previous version
added 2 commits
a3567676- Update lockfileCompare with previous version
added 2 commits
1771dad4- Fix rule name8c838169- Fix tox configCompare with previous version
added 4 commits
masterc708e75e- Merge branch 'master' into 1-initialise-app-and-move-mailaddress-stuff-form-tic-desk6b8a9b6a- Update ci config and gitignoreCompare with previous version
added 1 commit
34842867- Update to latest coreCompare with previous version
added 1 commit
7eaeeae5- Add missing dependenciesCompare with previous version
Does this really need a core newer than 2.6?
I am pretty sure you cannot use
get_site_preferencesat import time.This should probably be
SET_NULL, and allow null values, ebcause it might occur that people want a cool-down period for mail addresses before allowing re-registration.unique_togetheris deprecated. Use aUniqueConstraint.This should return a
HttpResponseof some sort as well, or not?changed this line in version 18 of the diff
changed this line in version 18 of the diff
changed this line in version 18 of the diff
changed this line in version 18 of the diff
added 7 commits
c9e89d88- Remove dependency on POSIX70b9ab9d- Return HTTPResponse on POST87e56203- Remove deprecated unique_togethera4153499- Allow null values570af46b- Move preferences to postbuero9ae4761f- Add migrationc3e94a5b- ReformatCompare with previous version
You can not use
get_site_preferencesat import time.The preference queried here does not exist.
I think you should jsut not use permissions for now, and jsut allow self-editing for everyone.
changed this line in version 19 of the diff
changed this line in version 19 of the diff
added 2 commits
fd6cd31d- Only allow self-editing for nowCompare with previous version
added 1 commit
723aa35f- Validate formCompare with previous version
This should use the email absetemplate from core.
This variablke is used nowhere.
Also, it should be lower case.
Variables should be lower case.
You should add this as a field error. Either by using the
clean_FIELDmethods, or better by attaching a validation function to the field, or by adding to field_errors.ALso, maybe jsut move this to the bottom as
return super().clean()?A domain is arequired.
Isn't
personin initial data, and should thus be in the form? How is it attached, if not?Didn't you drop the rules?
Shouldn't this get the person as initial data?
Please set a reverse name here.
Use the reverse field (as named above).
Also, same remarks as in
get.I see this preference nowhere.
Please use the utility method for sending mail to admins from core.
That should make use of a collection.
added 4 commits
master565b3ed5- Merge branch 'master' into 1-initialise-app-and-move-mailaddress-stuff-form-tic-deskCompare with previous version
changed this line in version 22 of the diff
changed this line in version 22 of the diff
changed this line in version 22 of the diff
changed this line in version 22 of the diff
changed this line in version 22 of the diff
changed this line in version 22 of the diff
changed this line in version 22 of the diff
changed this line in version 22 of the diff
changed this line in version 22 of the diff
added 2 commits
859ef6b5- Use email template from coref4a947e0- Rewrite form and templatekCompare with previous version
Use
SET_NULL(for the reasons described in another thread)Are we sure this does not collide?
Doesn't this already exist in the core?
This effectively saves the mdoel twice, while one database hit would be sufficient.
changed this line in version 23 of the diff
added 1 commit
60d21cc5- Apply 1 suggestion(s) to 1 file(s)Compare with previous version
changed this line in version 24 of the diff
changed this line in version 24 of the diff
changed this line in version 24 of the diff
changed this line in version 24 of the diff
added 2 commits
afbadd0c- Fix creation of mailaddressc2ee8714- Merge branch '1-initialise-app-and-move-mailaddress-stuff-form-tic-desk' of...Compare with previous version
added 1 commit
ad7dc9c1- Fix mailCompare with previous version
changed this line in version 26 of the diff
added 1 commit
9c1c0b0b- fuckoffCompare with previous version
added 1 commit
aa9bbcec- fix migrationCompare with previous version
changed this line in version 28 of the diff
added 1 commit
83e86914- Update coreCompare with previous version
changed this line in version 29 of the diff
added 1 commit
6888b518- Add new model for mail domainCompare with previous version
changed this line in version 30 of the diff
added 1 commit
38ee0c76- Add permissions for mail domainsCompare with previous version
added 1 commit
1ef270df- Implement rest frameworkCompare with previous version
added 1 commit
4b4feed9- Add serializerCompare with previous version
added 1 commit
44aa1023- Fix serializerCompare with previous version
added 2 commits
13e8d06c- reformat81d1d990- Merge branch '1-initialise-app-and-move-mailaddress-stuff-form-tic-desk' of...Compare with previous version
added 1 commit
39cc69ae- Show only public domains to unauthenticated usersCompare with previous version
added 1 commit
a212f707- Fix creation of new mail addressesCompare with previous version
added 1 commit
0f273c8b- Use only public domainsCompare with previous version
added 1 commit
d6375d54- Remove unused importCompare with previous version
mentioned in commit
2f6ba44014