aleksis/AlekSIS-App-Matrix
Watch
10
0
Fork
You've already forked AlekSIS-App-Matrix
 0
Code Issues 19 Pull requests 6 Projects Releases Packages 1 Activity Actions

Resolve "Add periodic task for syncing rooms" #58

Merged
hansegucker merged 5 commits from 18-add-periodic-task-for-syncing-rooms into master 2022-06-08 11:31:21 +02:00
Conversation 26 Commits 5 Files changed 7 +271 -27
hansegucker commented 2022-04-10 15:07:14 +02:00
Owner
Copy link

Closes #18

Closes #18
hansegucker commented 2022-04-10 16:05:35 +02:00
Author
Owner
Copy link

added 1 commit

  • 6e6218e6 - Add tasks for syncing rooms periodically or after changes

Compare with previous version

added 1 commit <ul><li>6e6218e6 - Add tasks for syncing rooms periodically or after changes</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Matrix/-/merge_requests/7/diffs?diff_id=20340&start_sha=5c6d77f5e2d80acd9bf632f50345cbb1215fb616)
hansegucker commented 2022-04-10 16:05:55 +02:00
Author
Owner
Copy link

assigned to @nik

assigned to @nik
hansegucker commented 2022-04-10 16:05:55 +02:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2022-04-11 11:13:54 +02:00
Author
Owner
Copy link

added 15m of time spent

added 15m of time spent
nik commented 2022-04-12 19:39:39 +02:00
Owner
Copy link

Why do you want to skip sync on creation?

Why do you want to skip sync on creation?
hansegucker commented 2022-04-12 20:45:00 +02:00
Author
Owner
Copy link

MatrixRoom objects are usually created in the provisioning process which also includes a full sync. Therefore, this would mean doing two complete syncs.

MatrixRoom objects are usually created in the provisioning process which also includes a full sync. Therefore, this would mean doing two complete syncs.
hansegucker commented 2022-04-12 20:48:07 +02:00
Author
Owner
Copy link

added 1m of time spent

added 1m of time spent
nik commented 2022-04-13 20:20:50 +02:00
Owner
Copy link

We also need to react to:

  • Changes on Group.members
  • Changes on Group.owners
  • Changes on MatrixRoom.group
  • Changes on MatrixProfile.person
  • Changes on MatrixProfile
We also need to react to: * Changes on `Group.members` * Changes on `Group.owners` * Changes on `MatrixRoom.group` * Changes on `MatrixProfile.person` * Changes on `MatrixProfile`
hansegucker commented 2022-04-15 17:33:07 +02:00
Author
Owner
Copy link

added 1 commit

  • 0f47c6a7 - Register more signals to detect changes that need a Matrix room sync

Compare with previous version

added 1 commit <ul><li>0f47c6a7 - Register more signals to detect changes that need a Matrix room sync</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Matrix/-/merge_requests/7/diffs?diff_id=20438&start_sha=6e6218e69994e66b7df44ff3645e7c741ad143f1)
hansegucker commented 2022-04-15 17:33:19 +02:00
Author
Owner
Copy link

added 1h 12m of time spent

added 1h 12m of time spent
nik commented 2022-04-16 20:57:31 +02:00
Owner
Copy link

This should probably use sub-tasks](https://docs.celeryq.dev/en/2.4-archived/userguide/tasksets.html) or a taskset, so that we don't get one long-running task and failures in syncing one room don't prevent others from getting synced.

This should probably use sub-tasks](https://docs.celeryq.dev/en/2.4-archived/userguide/tasksets.html) or a taskset, so that we don't get one long-running task and failures in syncing one room don't prevent others from getting synced.
nik commented 2022-04-16 20:57:52 +02:00
Owner
Copy link

This should also use a task set.

This should also use a [task set](https://docs.celeryq.dev/en/2.4-archived/userguide/tasksets.html).
hansegucker commented 2022-05-01 18:30:42 +02:00
Author
Owner
Copy link

This is a little bit antique. And I am not able to find current information on tasksets.

This is a little bit antique. And I am not able to find current information on tasksets.
hansegucker commented 2022-05-01 18:30:50 +02:00
Author
Owner
Copy link

see above

see above
hansegucker commented 2022-06-03 22:06:05 +02:00
Author
Owner
Copy link

@nik Any update?

@nik Any update?
nik commented 2022-06-05 11:18:22 +02:00
Owner
Copy link

"usually" depends on the use case. For Teckids, all Matrix rooms already exist and are linked by an existing room ID, outside the automatic provisioning process. And this is also true for (at least) all schools who already use solutions like Logineo Messenger and add AlekSIS to the stack now.

"usually" depends on the use case. For Teckids, *all* Matrix rooms already exist and are linked by an existing room ID, outside the automatic provisioning process. And this is also true for (at least) all schools who already use solutions like Logineo Messenger and add AlekSIS to the stack now.
nik commented 2022-06-05 11:19:42 +02:00
Owner
Copy link

https://docs.celeryq.dev/en/stable/userguide/tasks.html#avoid-launching-synchronous-subtasks

https://docs.celeryq.dev/en/stable/userguide/tasks.html#avoid-launching-synchronous-subtasks
nik commented 2022-06-05 11:19:57 +02:00
Owner
Copy link

see above ;)

see above ;)
nik commented 2022-06-05 15:39:09 +02:00
Owner
Copy link

Ne war Quatsch

Ne war Quatsch
hansegucker commented 2022-06-05 16:13:24 +02:00
Author
Owner
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Matrix/-/merge_requests/7/diffs?diff_id=21807&start_sha=0f47c6a79f68755ac1931eff5048cda67d5fd8d1#ca95e920433501ede336cade8e01dfda6ea073fc_12_11)
hansegucker commented 2022-06-05 16:13:24 +02:00
Author
Owner
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Matrix/-/merge_requests/7/diffs?diff_id=21807&start_sha=0f47c6a79f68755ac1931eff5048cda67d5fd8d1#9ca0f3078ade138c203fbc6e9eb6c2426538a766_36_38)
hansegucker commented 2022-06-05 16:13:24 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>92224d6d - Sync rooms in separate tasks</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Matrix/-/merge_requests/7/diffs?diff_id=21807&start_sha=0f47c6a79f68755ac1931eff5048cda67d5fd8d1)
hansegucker commented 2022-06-05 16:13:47 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2022-06-05 16:15:03 +02:00
Author
Owner
Copy link

added 10 commits

  • 92224d6d...c9a8e559 - 9 commits from branch master
  • b6730fc4 - Merge branch 'master' into 18-add-periodic-task-for-syncing-rooms

Compare with previous version

added 10 commits <ul><li>92224d6d...c9a8e559 - 9 commits from branch <code>master</code></li><li>b6730fc4 - Merge branch &#39;master&#39; into 18-add-periodic-task-for-syncing-rooms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Matrix/-/merge_requests/7/diffs?diff_id=21809&start_sha=92224d6dc9a07be059c517d90d23329127e985f8)
hansegucker commented 2022-06-07 22:36:59 +02:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a85d41c5 - Fix lint and tests</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Matrix/-/merge_requests/7/diffs?diff_id=21926&start_sha=b6730fc45da9155b586ab8ab228dfb25d30b81c2)
nik commented 2022-06-08 11:31:20 +02:00
Owner
Copy link

mentioned in commit 41d34239dd

mentioned in commit 41d34239dd5b8c5a339d4ed5db94794d798aa1ab
nik merged commit 41d34239dd into master 2022-06-08 11:31:21 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Matrix!58
No description provided.