aleksis/AlekSIS-App-Matrix
Watch
9
0
Fork
You've already forked AlekSIS-App-Matrix
 0
Code Issues 19 Pull requests 6 Projects Releases Packages 1 Activity Actions

Improve error handling #168

Merged
hansegucker merged 1 commit from improve-error-handling into master 2026-11-05 21:21:46 +01:00
Conversation 1 Commits 1 Files changed 6 +125 -17
magicfelix commented 2026-11-02 12:43:26 +01:00
Member
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

## Information and screenshots No further information have been provided. ## Checklist - [ ] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://code.teckids.org/aleksis/aleksis/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to [frontend guidelines](hhttps://code.teckids.org/aleksis/AlekSIS/src/branch/master/project/frontend_guidelines.rst) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/)
Improve error handling
Some checks failed
CI / lock (push) Successful in 44s
Details
CI / build (push) Failing after 44s
Details
CI / lint (push) Failing after 49s
Details
CI / tests-done (push) Failing after 3s
Details
CI / publish (push) Has been skipped
Details
b92d6d24a7
magicfelix force-pushed improve-error-handling from b92d6d24a7
Some checks failed
CI / lock (push) Successful in 44s
Details
CI / build (push) Failing after 44s
Details
CI / lint (push) Failing after 49s
Details
CI / tests-done (push) Failing after 3s
Details
CI / publish (push) Has been skipped
Details
to 5de1bbde57
Some checks failed
CI / lock (push) Successful in 41s
Details
CI / build (push) Failing after 39s
Details
CI / lint (push) Failing after 47s
Details
CI / tests-done (push) Failing after 2s
Details
CI / publish (push) Has been skipped
Details
2026-11-02 14:11:40 +01:00 Compare
magicfelix force-pushed improve-error-handling from 5de1bbde57
Some checks failed
CI / lock (push) Successful in 41s
Details
CI / build (push) Failing after 39s
Details
CI / lint (push) Failing after 47s
Details
CI / tests-done (push) Failing after 2s
Details
CI / publish (push) Has been skipped
Details
to 27f1bcd908
All checks were successful
CI / lock (push) Successful in 31s
Details
CI / lint (push) Successful in 1m6s
Details
CI / tests-done (push) Successful in 2s
Details
CI / build (push) Successful in 1m13s
Details
CI / publish (push) Successful in 1m22s
Details
2026-11-02 14:22:11 +01:00 Compare
hansegucker requested changes 2026-11-03 12:59:42 +01:00
aleksis/apps/matrix/model_extensions.py Outdated
@ -23,3 +23,2 @@
if sync and task is not None:
task.do_sync_task()
if sync and task is not None and task.do_sync_task():
hansegucker commented 2026-11-03 12:54:24 +01:00
Owner
Copy link
if sync and task is not None:
  success = task.do_sync_task()
  if success:
    task.delete()

to make it more clear what happens here

``` if sync and task is not None: success = task.do_sync_task() if success: task.delete() ``` to make it more clear what happens here
hansegucker commented 2026-11-03 12:55:52 +01:00
Owner
Copy link

Or even better, why isn't an exception used for this?

Or even better, why isn't an exception used for this?
hansegucker marked this conversation as resolved
magicfelix force-pushed improve-error-handling from 27f1bcd908
All checks were successful
CI / lock (push) Successful in 31s
Details
CI / lint (push) Successful in 1m6s
Details
CI / tests-done (push) Successful in 2s
Details
CI / build (push) Successful in 1m13s
Details
CI / publish (push) Successful in 1m22s
Details
to e01839849a
Some checks failed
CI / lock (push) Failing after 3m53s
Details
CI / lint (push) Has been skipped
Details
CI / build (push) Has been skipped
Details
CI / tests-done (push) Failing after 23s
Details
CI / publish (push) Has been skipped
Details
2026-11-05 09:45:25 +01:00 Compare
magicfelix force-pushed improve-error-handling from e01839849a
Some checks failed
CI / lock (push) Failing after 3m53s
Details
CI / lint (push) Has been skipped
Details
CI / build (push) Has been skipped
Details
CI / tests-done (push) Failing after 23s
Details
CI / publish (push) Has been skipped
Details
to 728e6948a7
All checks were successful
CI / lock (push) Successful in 37s
Details
CI / lint (push) Successful in 1m3s
Details
CI / build (push) Successful in 1m5s
Details
CI / tests-done (push) Successful in 2s
Details
CI / publish (push) Successful in 8s
Details
2026-11-05 10:17:58 +01:00 Compare
magicfelix force-pushed improve-error-handling from 728e6948a7
All checks were successful
CI / lock (push) Successful in 37s
Details
CI / lint (push) Successful in 1m3s
Details
CI / build (push) Successful in 1m5s
Details
CI / tests-done (push) Successful in 2s
Details
CI / publish (push) Successful in 8s
Details
to 719142e90b
Some checks failed
CI / lock (push) Has been cancelled
Details
CI / lint (push) Has been cancelled
Details
CI / tests-done (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details
CI / publish (push) Has been cancelled
Details
2026-11-05 21:01:02 +01:00 Compare
magicfelix force-pushed improve-error-handling from 719142e90b
Some checks failed
CI / lock (push) Has been cancelled
Details
CI / lint (push) Has been cancelled
Details
CI / tests-done (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details
CI / publish (push) Has been cancelled
Details
to 36ef725c88
Some checks failed
CI / lock (push) Successful in 36s
Details
CI / lint (push) Failing after 1m31s
Details
CI / build (push) Successful in 1m42s
Details
CI / tests-done (push) Failing after 3s
Details
CI / publish (push) Has been skipped
Details
2026-11-05 21:01:33 +01:00 Compare
hansegucker scheduled this pull request to auto merge when all checks succeed 2026-11-05 21:03:45 +01:00
magicfelix force-pushed improve-error-handling from 36ef725c88
Some checks failed
CI / lock (push) Successful in 36s
Details
CI / lint (push) Failing after 1m31s
Details
CI / build (push) Successful in 1m42s
Details
CI / tests-done (push) Failing after 3s
Details
CI / publish (push) Has been skipped
Details
to 374b35fbc4
All checks were successful
CI / lock (push) Successful in 30s
Details
CI / lint (push) Successful in 1m4s
Details
CI / tests-done (push) Successful in 2s
Details
CI / build (push) Successful in 1m12s
Details
CI / publish (push) Successful in 7s
Details
2026-11-05 21:20:01 +01:00 Compare
hansegucker deleted branch improve-error-handling 2026-11-05 21:21:47 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Matrix!168
No description provided.