aleksis/AlekSIS-App-Maka
Watch
10
0
Fork
You've already forked AlekSIS-App-Maka
 0
Code Issues 8 Pull requests Projects Releases Packages 1 Activity Actions

Resolve "Migrate to Vue 3/Vuetify 3" #55

Merged
hansegucker merged 26 commits from 18-migrate-to-vue-3-vuetify-3 into main 2025-11-11 11:00:23 +01:00
Conversation 16 Commits 26 Files changed 29 +9080 -1200
leuckeju commented 2025-10-29 10:23:10 +01:00
Member
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

  • Screenshots are attached (mobile and desktop)
  • Tested on mobile, tablet, and desktop sizes
  • Adhered to frontend guidelines
  • Checked with Firefox Accessibility Checker

Closes #18

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [x] Documentation (incl. Screenshots) up-to-date - [x] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [x] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [x] Tested with admin account - [x] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [x] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to frontend guidelines - [ ] Checked with Firefox Accessibility Checker Closes #18
leuckeju commented 2025-11-03 17:18:13 +01:00
Author
Member
Copy link

added 17 commits

  • b2ab2142...ee65cb98 - 7 earlier commits
  • 9cb487d2 - Fix EffortColumnHeader.vue to display value at all
  • bffc3cf1 - Migrate UnwrappedEffortTab.vue to vue(tify)3
  • 49aa19b1 - Display name of effort instead of effort type
  • e250b236 - Fix linking to group tab
  • eff945e3 - Fix component export for collection
  • 902af116 - Create display component for grade sets
  • 36199251 - Adapt to personGroupThrough
  • 4b833abd - Start migration of UpdateOrCreateGrade.vue
  • d2b8cc92 - Migrate the edit function from the EffortColumnHeader
  • 3377294c - Reformat and fix lint

Compare with previous version

added 17 commits <ul><li>b2ab2142...ee65cb98 - 7 earlier commits</li><li>9cb487d2 - Fix EffortColumnHeader.vue to display value at all</li><li>bffc3cf1 - Migrate UnwrappedEffortTab.vue to vue(tify)3</li><li>49aa19b1 - Display name of effort instead of effort type</li><li>e250b236 - Fix linking to group tab</li><li>eff945e3 - Fix component export for collection</li><li>902af116 - Create display component for grade sets</li><li>36199251 - Adapt to personGroupThrough</li><li>4b833abd - Start migration of UpdateOrCreateGrade.vue</li><li>d2b8cc92 - Migrate the edit function from the EffortColumnHeader</li><li>3377294c - Reformat and fix lint</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/37/diffs?diff_id=77823&start_sha=b2ab2142a57fec1b75dde72f3030b7ba623274dc)
leuckeju commented 2025-11-10 10:41:22 +01:00
Author
Member
Copy link

added 9 commits

  • 91889a9a - Drop unused field weight
  • 76bedcd0 - Disallow creating grade choices for nonexisting gradesets
  • ef942fb4 - Use Crudproviders in GroupGradeTab
  • 6fac934f - Reimplement cache updates in UpdateOrCreateGrade.vue
  • 8dd7e38f - Drop CreateEffort
  • 954ac3f2 - Update translations in maka
  • 617ea367 - Limit editing of efforts to the field `name`
  • 47a6748f - Update copyright and changelog for the vue3 migration
  • a57252d1 - Reformat

Compare with previous version

added 9 commits <ul><li>91889a9a - Drop unused field weight</li><li>76bedcd0 - Disallow creating grade choices for nonexisting gradesets</li><li>ef942fb4 - Use Crudproviders in GroupGradeTab</li><li>6fac934f - Reimplement cache updates in UpdateOrCreateGrade.vue</li><li>8dd7e38f - Drop CreateEffort</li><li>954ac3f2 - Update translations in maka</li><li>617ea367 - Limit editing of efforts to the field `name`</li><li>47a6748f - Update copyright and changelog for the vue3 migration</li><li>a57252d1 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/37/diffs?diff_id=77930&start_sha=3377294c18d3b706434ff5c0f089850f6376b6dc)
leuckeju commented 2025-11-10 13:31:34 +01:00
Author
Member
Copy link

assigned to @hansegucker

assigned to @hansegucker
leuckeju commented 2025-11-10 13:31:37 +01:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
leuckeju commented 2025-11-10 13:31:40 +01:00
Author
Member
Copy link

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **`tox -e reformat,lint` used** as completed
leuckeju commented 2025-11-10 13:31:41 +01:00
Author
Member
Copy link

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed
leuckeju commented 2025-11-10 13:31:43 +01:00
Author
Member
Copy link

marked the checklist item Documentation (incl. Screenshots) up-to-date as completed

marked the checklist item **Documentation (incl. Screenshots) up-to-date** as completed
leuckeju commented 2025-11-10 13:31:49 +01:00
Author
Member
Copy link

marked the checklist item Copyright in apps.py and README.rst up-to-date as completed

marked the checklist item **Copyright in `apps.py` and `README.rst` up-to-date** as completed
leuckeju commented 2025-11-10 13:31:51 +01:00
Author
Member
Copy link

marked the checklist item Adhere to URL scheme as completed

marked the checklist item **Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86)** as completed
leuckeju commented 2025-11-10 13:31:55 +01:00
Author
Member
Copy link

marked the checklist item Tested with admin account as completed

marked the checklist item **Tested with admin account** as completed
leuckeju commented 2025-11-10 13:31:57 +01:00
Author
Member
Copy link

marked the checklist item Tested with normal account (based on permissions) as completed

marked the checklist item **Tested with normal account (based on permissions)** as completed
leuckeju commented 2025-11-10 13:32:09 +01:00
Author
Member
Copy link

marked the checklist item Tested on mobile, tablet, and desktop sizes as completed

marked the checklist item **Tested on mobile, tablet, and desktop sizes** as completed
leuckeju commented 2025-11-10 13:32:29 +01:00
Author
Member
Copy link

Screenshots not necessary, as there is no new frontend

Screenshots not necessary, as there is no new frontend
hansegucker commented 2025-11-11 10:55:20 +01:00
Owner
Copy link

approved this merge request

approved this merge request
hansegucker commented 2025-11-11 11:00:20 +01:00
Owner
Copy link

mentioned in commit 234a1b154e

mentioned in commit 234a1b154e159957cd88771194add34227d37ad8
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Maka!55
No description provided.