aleksis/AlekSIS-App-Maka
Watch
10
0
Fork
You've already forked AlekSIS-App-Maka
 0
Code Issues 8 Pull requests Projects Releases Packages 1 Activity Actions

Resolve "Adapt to active school term" #31

Merged
hansegucker merged 1 commit from 17-adapt-to-active-school-term into main 2025-04-09 20:25:09 +02:00
Conversation 18 Commits 1 Files changed 4 +88 -87
magicfelix commented 2024-11-20 15:48:21 +01:00
Member
Copy link

Closes #17

Closes #17
magicfelix commented 2024-11-20 16:29:56 +01:00
Author
Member
Copy link

added 1 commit

  • bc9c76bf - Adapt to active school term and optimize queries

Compare with previous version

added 1 commit <ul><li>bc9c76bf - Adapt to active school term and optimize queries</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/13/diffs?diff_id=50623&start_sha=4e3fc6a8c6a19f365e5d92a7f71755e35b6b5420)
magicfelix commented 2024-11-20 16:30:08 +01:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
magicfelix commented 2024-11-20 16:32:08 +01:00
Author
Member
Copy link

@ZugBahnHof please test, as I don't exactly know what you meant with „Efforts page breaks, because the groups of the efforts are required but cannot be loaded somehow.” When I tested (before my changes) nothing broke in terms of throwing errors (but there were data from other school terms, maybe that's it).

@ZugBahnHof please test, as I don't exactly know what you meant with „Efforts page breaks, because the groups of the efforts are required but cannot be loaded somehow.” When I tested (before my changes) nothing broke in terms of throwing errors (but there were data from other school terms, maybe that's it).
leuckeju commented 2024-11-20 17:41:41 +01:00
Member
Copy link

If you create efforts for groups of the current school term, and then switch the active schoolterm, still all efforts were tried to be loaded, but the group couldn't be resolved (as the groups Queryset only contains groups from the active schoolterm), so I got an error message, because the graphql type for efforts is not allowed to not receive a value for the group field.

If you create efforts for groups of the current school term, and then switch the active schoolterm, still all efforts were tried to be loaded, but the group couldn't be resolved (as the groups Queryset only contains groups from the active schoolterm), so I got an error message, because the graphql type for efforts is not allowed to not receive a value for the group field.
hansegucker commented 2024-11-20 20:19:23 +01:00
Owner
Copy link

marked this merge request as draft

marked this merge request as **draft**
hansegucker commented 2024-11-20 20:20:27 +01:00
Owner
Copy link

Does this work with empty groups?

Does this work with empty groups?
hansegucker commented 2024-11-20 20:21:47 +01:00
Owner
Copy link

Where is this used?

Where is this used?
hansegucker commented 2024-11-20 20:22:45 +01:00
Owner
Copy link

No optimizer here

No optimizer here
magicfelix commented 2024-11-20 20:49:39 +01:00
Author
Member
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/13/diffs?diff_id=50660&start_sha=bc9c76bf267e6ac6eef8833a8fbe15b43fb1017c#8f4db07baef5dbd97c7a5e376071cc129ba8927f_70_67)
magicfelix commented 2024-11-20 20:49:39 +01:00
Author
Member
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/13/diffs?diff_id=50660&start_sha=bc9c76bf267e6ac6eef8833a8fbe15b43fb1017c#8f4db07baef5dbd97c7a5e376071cc129ba8927f_140_128)
magicfelix commented 2024-11-20 20:49:39 +01:00
Author
Member
Copy link

added 1 commit

  • aaed3cb0 - Adapt to active school term and optimize queries

Compare with previous version

added 1 commit <ul><li>aaed3cb0 - Adapt to active school term and optimize queries</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/13/diffs?diff_id=50660&start_sha=bc9c76bf267e6ac6eef8833a8fbe15b43fb1017c)
magicfelix commented 2024-11-20 20:49:56 +01:00
Author
Member
Copy link

Probably nowhere, as grade choices will always be queried inside grade set queries.

Query removed.

Probably nowhere, as grade choices will always be queried inside grade set queries. Query removed.
magicfelix commented 2024-11-20 20:51:19 +01:00
Author
Member
Copy link

Yes, tested.

GradeSets with no groups assigned are always returned.

Yes, tested. GradeSets with no groups assigned are always returned.
magicfelix commented 2024-11-20 20:53:30 +01:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-11-27 20:27:13 +01:00
Owner
Copy link

@magicfelix @ZugBahnHof Please solve.

@magicfelix @ZugBahnHof Please solve.
magicfelix commented 2025-04-01 20:59:05 +02:00
Author
Member
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2025-04-09 20:24:57 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-04-09 20:25:09 +02:00
Owner
Copy link

mentioned in commit cbb4bb8b25

mentioned in commit cbb4bb8b255a8a341b66de3b444f4cc0ce16fe53
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Maka!31
No description provided.