aleksis/AlekSIS-App-Maka
8
0
Fork 0
Code Issues 8 Pull requests 1 Projects Releases Packages Activity Actions

WIP: Draft: Resolve "Implement shared secret mechanism" #21

Closed
yuha wants to merge 0 commits from 2-implement-shared-secret-mechanism into main
pull from: 2-implement-shared-secret-mechanism
merge into: aleksis:main
Conversation 24 Commits - Files changed -
yuha commented 2024-09-19 09:33:38 +02:00 (Migrated from edugit.org)
Copy link

Closes #2

Closes #2
yuha commented 2024-09-19 09:33:38 +02:00 (Migrated from edugit.org)
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2024-09-19 11:02:42 +02:00 (Migrated from edugit.org)
Copy link

added 7 commits

  • bbfa7802 - Implement models
  • f2f527b0 - Adjust pyproject and tox configuration
  • f75d5984 - Implement CRUD schema
  • 67f7f7c1 - Fix typos
  • 324b67a0 - Rename imported Models to avoid confusion with graphql types
  • 752416ea - Add unique constraint for EffortType default
  • ea5a6e8e - WIP: Add preference for shared secret

Compare with previous version

added 7 commits <ul><li>bbfa7802 - Implement models</li><li>f2f527b0 - Adjust pyproject and tox configuration</li><li>f75d5984 - Implement CRUD schema</li><li>67f7f7c1 - Fix typos</li><li>324b67a0 - Rename imported Models to avoid confusion with graphql types</li><li>752416ea - Add unique constraint for EffortType default</li><li>ea5a6e8e - WIP: Add preference for shared secret</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=47906&start_sha=a40762ae44474427134df38992235ed669b78727)
yuha commented 2024-09-19 23:50:45 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 64a496df - WIP: Add shared secret mechanism

Compare with previous version

added 1 commit <ul><li>64a496df - WIP: Add shared secret mechanism</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=47915&start_sha=ea5a6e8e9d992eaed9a0444082f58a6c8d124b48)
yuha commented 2024-09-20 00:26:01 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c47b8849 - WIP: Add shared secret mechanism

Compare with previous version

added 1 commit <ul><li>c47b8849 - WIP: Add shared secret mechanism</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=47917&start_sha=64a496df035a42f0eef37dab7dfb139ded203ffd)
yuha commented 2024-09-20 00:36:53 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 31d8c91b - WIP: Add shared secret mechanism

Compare with previous version

added 1 commit <ul><li>31d8c91b - WIP: Add shared secret mechanism</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=47918&start_sha=c47b88490a8a3e51307f10a9f6f8f3f95253294a)
ZugBahnHof commented 2024-09-20 12:58:17 +02:00 (Migrated from edugit.org)
Copy link

Why is this a query and not a mutation? I get that you are technically not mutating database state, but there are still some side-effects

Why is this a query and not a mutation? I get that you are technically not mutating database state, but there are still some side-effects
hansegucker commented 2024-09-20 14:44:07 +02:00 (Migrated from edugit.org)
Copy link

Yes, this has to be a mutation.

Yes, this has to be a mutation.
yuha commented 2024-09-23 23:56:25 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2024-09-24 10:24:47 +02:00 (Migrated from edugit.org)
Copy link

TODO: convert all types & mutations so that they check for the session attribute

TODO: convert all types & mutations so that they check for the session attribute
yuha commented 2024-09-24 10:25:05 +02:00 (Migrated from edugit.org)
Copy link

TODO: convert shared secret component to wrapper component

TODO: convert shared secret component to wrapper component
yuha commented 2024-09-24 22:42:19 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48015&start_sha=31d8c91b563dcd56007ad9894a2ccd9389446ad4#8f4db07baef5dbd97c7a5e376071cc129ba8927f_56_52)
yuha commented 2024-09-24 22:42:19 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 915bd460 - Use mutation for submitting shared secret

Compare with previous version

added 1 commit <ul><li>915bd460 - Use mutation for submitting shared secret</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48015&start_sha=31d8c91b563dcd56007ad9894a2ccd9389446ad4)
yuha commented 2024-09-24 23:31:38 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c623d2b8 - Add mixins for object types and mutations for checking shared secret

Compare with previous version

added 1 commit <ul><li>c623d2b8 - Add mixins for object types and mutations for checking shared secret</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48019&start_sha=915bd460ae25580268122e4b55cb5bfb56556ca4)
yuha commented 2024-09-26 21:36:43 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 80cbe1e3 - Convert shared secret component into wrapper
  • a3dcc02a - Add error message

Compare with previous version

added 2 commits <ul><li>80cbe1e3 - Convert shared secret component into wrapper</li><li>a3dcc02a - Add error message</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48067&start_sha=c623d2b8cf93896151b8dcc18f334e13c9a1a955)
yuha commented 2024-09-26 22:45:48 +02:00 (Migrated from edugit.org)
Copy link

added 32 commits

  • a3dcc02a...1d13e9f6 - 22 earlier commits
  • a4a9ad5f - Create Create effort component
  • 78a00097 - Allow creation of efforts
  • 255f966b - Fix infinite render loop bug
  • d58d27c4 - Use autocomplete instead of select
  • 92157bd3 - Disable groups for effort creation and update cache correctly
  • b8efb3b8 - Reduce visual load of grade book
  • b8c07823 - Allow tabbing column-wise through the table
  • 35c1f837 - Display loading page & check for shared secret in session on initial load
  • c67e68ac - Merge branch 'frontend' into 2-implement-shared-secret-mechanism
  • 7b7c9308 - Refactor shared secret related mixins

Compare with previous version

added 32 commits <ul><li>a3dcc02a...1d13e9f6 - 22 earlier commits</li><li>a4a9ad5f - Create Create effort component</li><li>78a00097 - Allow creation of efforts</li><li>255f966b - Fix infinite render loop bug</li><li>d58d27c4 - Use autocomplete instead of select</li><li>92157bd3 - Disable groups for effort creation and update cache correctly</li><li>b8efb3b8 - Reduce visual load of grade book</li><li>b8c07823 - Allow tabbing column-wise through the table</li><li>35c1f837 - Display loading page &amp; check for shared secret in session on initial load</li><li>c67e68ac - Merge branch &#39;frontend&#39; into 2-implement-shared-secret-mechanism</li><li>7b7c9308 - Refactor shared secret related mixins</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48070&start_sha=a3dcc02af820d7d15f2fc5a42ce4510bcee31d5d)
yuha commented 2024-09-26 22:50:37 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 20b3b9c6 - Refactor shared secret related mixins

Compare with previous version

added 1 commit <ul><li>20b3b9c6 - Refactor shared secret related mixins</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48072&start_sha=7b7c930841e9c8e634e81cbfe03ca773e392ab08)
yuha commented 2024-09-26 22:51:48 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 73680ae9 - Fix checking mechanism for session attribute

Compare with previous version

added 1 commit <ul><li>73680ae9 - Fix checking mechanism for session attribute</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48074&start_sha=20b3b9c6f32b6e50c8b9c0aa4b11fa7e2e551e4a)
yuha commented 2024-09-26 22:54:16 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f5ca4181 - Move shared secret component

Compare with previous version

added 1 commit <ul><li>f5ca4181 - Move shared secret component</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48076&start_sha=73680ae94febd7f3935435a20d47286fddb62941)
yuha commented 2024-09-26 22:57:36 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • e03a569f - Rename shared secret wrapper
  • 2558d470 - Add shared secret wrapper to all pages

Compare with previous version

added 2 commits <ul><li>e03a569f - Rename shared secret wrapper</li><li>2558d470 - Add shared secret wrapper to all pages</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48078&start_sha=f5ca4181a7fb2525f9122e67e78400e345d28630)
yuha commented 2024-09-26 22:58:23 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • d9fe93fa - Add translation for checking shared secret

Compare with previous version

added 1 commit <ul><li>d9fe93fa - Add translation for checking shared secret</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48080&start_sha=2558d4701b14c22d710245ca9fa20b6977e41255)
yuha commented 2024-09-26 23:03:54 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 8f81d7f0 - Refactor shared secret related mixins
  • aa65539e - Fix checking mechanism for session attribute
  • aab26f7e - Move shared secret component
  • 7f575aeb - Rename shared secret wrapper
  • 812a396e - Add shared secret wrapper to all pages
  • f0300efd - Add translation for checking shared secret

Compare with previous version

added 6 commits <ul><li>8f81d7f0 - Refactor shared secret related mixins</li><li>aa65539e - Fix checking mechanism for session attribute</li><li>aab26f7e - Move shared secret component</li><li>7f575aeb - Rename shared secret wrapper</li><li>812a396e - Add shared secret wrapper to all pages</li><li>f0300efd - Add translation for checking shared secret</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48082&start_sha=d9fe93fabe1dfbfb72e34960517b97e066e4547d)
yuha commented 2024-09-26 23:08:25 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • d6211984 - Fix checking mechanism for session attribute
  • 86503e41 - Move shared secret component
  • 8aefd1a9 - Rename shared secret wrapper
  • f92f2cfd - Add shared secret wrapper to all pages
  • de1a1135 - Add translation for checking shared secret
  • ca035885 - Re-add shared secret submitting mutation

Compare with previous version

added 6 commits <ul><li>d6211984 - Fix checking mechanism for session attribute</li><li>86503e41 - Move shared secret component</li><li>8aefd1a9 - Rename shared secret wrapper</li><li>f92f2cfd - Add shared secret wrapper to all pages</li><li>de1a1135 - Add translation for checking shared secret</li><li>ca035885 - Re-add shared secret submitting mutation</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/3/diffs?diff_id=48084&start_sha=f0300efd11a8d9b1df696ea2a212033c7ed8b140)
yuha commented 2024-09-26 23:12:38 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2024-09-26 23:12:40 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha (Migrated from edugit.org) closed this pull request 2024-09-30 22:38:52 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Maka!21
No description provided.