aleksis/AlekSIS-App-Maka
8
0
Fork 0
Code Issues 8 Pull requests 1 Projects Releases Packages Activity Actions

Frontend #20

Merged
ZugBahnHof merged 98 commits from frontend into main 2024-10-11 12:34:29 +02:00
Conversation 127 Commits 98 Files changed 51 +4316 -178
ZugBahnHof commented 2024-09-18 21:53:41 +02:00 (Migrated from edugit.org)
Copy link

Closes #4

Closes #2

Closes #4 Closes #2
ZugBahnHof commented 2024-09-18 21:53:41 +02:00 (Migrated from edugit.org)
Copy link

assigned to @ZugBahnHof

assigned to @ZugBahnHof
ZugBahnHof commented 2024-09-25 20:07:26 +02:00 (Migrated from edugit.org)
Copy link

added 21 commits

  • 324b67a0...7eb6b870 - 11 earlier commits
  • 466389d6 - Fix casing typo in effort mutation fields
  • 678c2855 - Mark required fields as required
  • 5d3b1659 - Add field grades to efforts gql type
  • 0d4cb746 - Generic chip to display grades
  • 7a3ddb37 - Fix gql queries for gradechoices
  • 71b3be06 - Display efforts on group page
  • 0b72230e - Simplify table
  • 14c0b9e8 - More translations
  • 983312fd - UpdateOrCreateGrade.vue grade selector
  • c727ca51 - Use UpdateOrCreateGrade

Compare with previous version

added 21 commits <ul><li>324b67a0...7eb6b870 - 11 earlier commits</li><li>466389d6 - Fix casing typo in effort mutation fields</li><li>678c2855 - Mark required fields as required</li><li>5d3b1659 - Add field grades to efforts gql type</li><li>0d4cb746 - Generic chip to display grades</li><li>7a3ddb37 - Fix gql queries for gradechoices</li><li>71b3be06 - Display efforts on group page</li><li>0b72230e - Simplify table</li><li>14c0b9e8 - More translations</li><li>983312fd - UpdateOrCreateGrade.vue grade selector</li><li>c727ca51 - Use UpdateOrCreateGrade</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48027&start_sha=324b67a06ab90743c2dade917770791682d03bb0)
ZugBahnHof commented 2024-09-26 13:22:25 +02:00 (Migrated from edugit.org)
Copy link

added 8 commits

  • 1d13e9f6 - Create grades
  • a4a9ad5f - Create Create effort component
  • 78a00097 - Allow creation of efforts
  • 255f966b - Fix infinite render loop bug
  • d58d27c4 - Use autocomplete instead of select
  • 92157bd3 - Disable groups for effort creation and update cache correctly
  • b8efb3b8 - Reduce visual load of grade book
  • b8c07823 - Allow tabbing column-wise through the table

Compare with previous version

added 8 commits <ul><li>1d13e9f6 - Create grades</li><li>a4a9ad5f - Create Create effort component</li><li>78a00097 - Allow creation of efforts</li><li>255f966b - Fix infinite render loop bug</li><li>d58d27c4 - Use autocomplete instead of select</li><li>92157bd3 - Disable groups for effort creation and update cache correctly</li><li>b8efb3b8 - Reduce visual load of grade book</li><li>b8c07823 - Allow tabbing column-wise through the table</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48060&start_sha=c727ca516b4e176d17f0c79a70bb860085787f19)
magicfelix commented 2024-09-28 13:21:53 +02:00 (Migrated from edugit.org)
Copy link

deleted the 1-new-app-gradebook branch. This merge request now targets the main branch

deleted the `1-new-app-gradebook` branch. This merge request now targets the `main` branch
yuha commented 2024-09-30 22:42:02 +02:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
yuha commented 2024-09-30 22:43:45 +02:00 (Migrated from edugit.org)
Copy link

this now includes the shared secret mechanism

this now includes the shared secret mechanism
yuha commented 2024-09-30 22:51:48 +02:00 (Migrated from edugit.org)
Copy link

added 17 commits

  • 752416ea - 1 commit from branch main
  • 752416ea...35c1f837 - 6 earlier commits
  • c67e68ac - Merge branch 'frontend' into 2-implement-shared-secret-mechanism
  • 8f81d7f0 - Refactor shared secret related mixins
  • d6211984 - Fix checking mechanism for session attribute
  • 86503e41 - Move shared secret component
  • 8aefd1a9 - Rename shared secret wrapper
  • f92f2cfd - Add shared secret wrapper to all pages
  • de1a1135 - Add translation for checking shared secret
  • ca035885 - Re-add shared secret submitting mutation
  • 3b481310 - Do not load shared secred wrapper slot content before initial query check is finished
  • 1fe1ef97 - Use correct toolbar keys

Compare with previous version

added 17 commits <ul><li>752416ea - 1 commit from branch <code>main</code></li><li>752416ea...35c1f837 - 6 earlier commits</li><li>c67e68ac - Merge branch &#39;frontend&#39; into 2-implement-shared-secret-mechanism</li><li>8f81d7f0 - Refactor shared secret related mixins</li><li>d6211984 - Fix checking mechanism for session attribute</li><li>86503e41 - Move shared secret component</li><li>8aefd1a9 - Rename shared secret wrapper</li><li>f92f2cfd - Add shared secret wrapper to all pages</li><li>de1a1135 - Add translation for checking shared secret</li><li>ca035885 - Re-add shared secret submitting mutation</li><li>3b481310 - Do not load shared secred wrapper slot content before initial query check is finished</li><li>1fe1ef97 - Use correct toolbar keys</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48180&start_sha=b8c07823bea02d42dedb82175676d4f8c5dd76bd)
hansegucker commented 2024-10-01 17:32:26 +02:00 (Migrated from edugit.org)
Copy link

FIXME Real permissions

FIXME Real permissions
hansegucker commented 2024-10-01 17:32:26 +02:00 (Migrated from edugit.org)
Copy link
    return request.session.get("maka_shared_secret_correct", False)

as you return bool type

```suggestion:-0+0 return request.session.get("maka_shared_secret_correct", False) ``` as you return `bool` type
hansegucker commented 2024-10-01 17:32:26 +02:00 (Migrated from edugit.org)
Copy link

This mutation probably should not return ok if the secret is wrong

This mutation probably should not return ok if the secret is wrong
hansegucker commented 2024-10-01 17:32:26 +02:00 (Migrated from edugit.org)
Copy link

Grade sets don't need the shared secret.

Grade sets don't need the shared secret.
hansegucker commented 2024-10-01 17:32:27 +02:00 (Migrated from edugit.org)
Copy link

Effort types don't need a shared secret.

Effort types don't need a shared secret.
hansegucker commented 2024-10-01 17:32:27 +02:00 (Migrated from edugit.org)
Copy link
        return info.context.session.get("maka_shared_secret_correct", False)
```suggestion:-0+0 return info.context.session.get("maka_shared_secret_correct", False) ```
hansegucker commented 2024-10-01 17:32:27 +02:00 (Migrated from edugit.org)
Copy link

Use menu permission

Use menu permission
hansegucker commented 2024-10-01 17:32:27 +02:00 (Migrated from edugit.org)
Copy link

FIXME permission

FIXME permission
hansegucker commented 2024-10-01 17:32:27 +02:00 (Migrated from edugit.org)
Copy link

FIXME permission

FIXME permission
hansegucker commented 2024-10-01 17:32:27 +02:00 (Migrated from edugit.org)
Copy link

FIXME permission

FIXME permission
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

Should not be necessary to refetch, the status should come as response from the mutation and the cache of sharedSecretStatus should be updated accordingly.

Should not be necessary to refetch, the status should come as response from the mutation and the cache of `sharedSecretStatus` should be updated accordingly.
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

Debug log

Debug log
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

TODO

TODO
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

TODO

TODO
hansegucker commented 2024-10-01 17:32:28 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2024-10-01 17:32:29 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2024-10-01 17:32:29 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2024-10-01 17:32:29 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\ No newline at end of file
hansegucker commented 2024-10-01 17:32:29 +02:00 (Migrated from edugit.org)
Copy link

TODO

TODO
hansegucker commented 2024-10-01 17:32:29 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\\ No newline at end of file
hansegucker commented 2024-10-01 17:32:29 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\\ No newline at end of file
hansegucker commented 2024-10-01 17:32:29 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\\ No newline at end of file
hansegucker commented 2024-10-01 17:32:30 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\\ No newline at end of file
hansegucker commented 2024-10-01 17:32:30 +02:00 (Migrated from edugit.org)
Copy link

\ No newline at end of file

\\ No newline at end of file
yuha commented 2024-10-01 22:06:07 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48223&start_sha=1fe1ef978d26c37ff6ad3d478ca4330a1b360b16#edd7084fd319086389578e80f9b50ffc27ccefeb_10_0)
yuha commented 2024-10-01 22:06:07 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48223&start_sha=1fe1ef978d26c37ff6ad3d478ca4330a1b360b16#fa304ec9f5bf8fc2591e1ddb4af7331dde4df5a0_9_0)
yuha commented 2024-10-01 22:06:08 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3d6464a8 - Remove unneeded shared secret rule

Compare with previous version

added 1 commit <ul><li>3d6464a8 - Remove unneeded shared secret rule</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48223&start_sha=1fe1ef978d26c37ff6ad3d478ca4330a1b360b16)
yuha commented 2024-10-01 22:52:44 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48234&start_sha=3d6464a8680a939d8763c5e43003364d153ebc0c#d91acf48bde00d19c031b4c699c4262da70b7505_18_18)
yuha commented 2024-10-01 22:52:45 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48234&start_sha=3d6464a8680a939d8763c5e43003364d153ebc0c#538485209bac524e4aa3705b3d9ef3306228d902_55_59)
yuha commented 2024-10-01 22:52:46 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 60442f8e - Directly check if shared secret is correct in mutation

Compare with previous version

added 1 commit <ul><li>60442f8e - Directly check if shared secret is correct in mutation</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48234&start_sha=3d6464a8680a939d8763c5e43003364d153ebc0c)
yuha commented 2024-10-02 00:11:57 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 76af73d6 - Skip queries of efforts overview page until correct shared secret is entered

Compare with previous version

added 1 commit <ul><li>76af73d6 - Skip queries of efforts overview page until correct shared secret is entered</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48237&start_sha=60442f8ef158191860b96e55a67e96d2dd02fb7f)
yuha commented 2024-10-02 00:46:01 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • b6e05f09 - Use correct name for effort related mutations

Compare with previous version

added 1 commit <ul><li>b6e05f09 - Use correct name for effort related mutations</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48238&start_sha=76af73d6d18bd3e458be9cccac4bf760aa3d324b)
yuha commented 2024-10-02 01:12:20 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48239&start_sha=b6e05f0917528190cfa81ab88dec55ddc4bcb286#3d8a754cfdae11e7cac0204f59edce1db188f71c_85_19)
yuha commented 2024-10-02 01:12:20 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48239&start_sha=b6e05f0917528190cfa81ab88dec55ddc4bcb286#3d8a754cfdae11e7cac0204f59edce1db188f71c_28_15)
yuha commented 2024-10-02 01:12:21 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cf1f2c97 - Use separate components for wrapping components that make queries on their own

Compare with previous version

added 1 commit <ul><li>cf1f2c97 - Use separate components for wrapping components that make queries on their own</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48239&start_sha=b6e05f0917528190cfa81ab88dec55ddc4bcb286)
ZugBahnHof commented 2024-10-02 01:22:07 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • 228740fb - Order grade choices per default
  • 36d6912c - Merge remote-tracking branch 'origin/frontend' into frontend
  • 83e79352 - Merge remote-tracking branch 'origin/frontend' into frontend
  • ea964229 - Redesign shared secret wrapper
  • 209c00cd - Merge remote-tracking branch 'origin/frontend' into frontend

Compare with previous version

added 5 commits <ul><li>228740fb - Order grade choices per default</li><li>36d6912c - Merge remote-tracking branch &#39;origin/frontend&#39; into frontend</li><li>83e79352 - Merge remote-tracking branch &#39;origin/frontend&#39; into frontend</li><li>ea964229 - Redesign shared secret wrapper</li><li>209c00cd - Merge remote-tracking branch &#39;origin/frontend&#39; into frontend</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48240&start_sha=cf1f2c97559601921821aaec1536465d8d05c3a7)
ZugBahnHof commented 2024-10-02 02:11:26 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#6951e25a2130c8f1fddf8d8dd6510338809aa5c9_16_21)
ZugBahnHof commented 2024-10-02 02:11:26 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#0953a991cbdfab291841821488f4c9a5046d3531_25_22)
ZugBahnHof commented 2024-10-02 02:11:26 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#538485209bac524e4aa3705b3d9ef3306228d902_114_99)
ZugBahnHof commented 2024-10-02 02:11:26 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#41dfe26143633914c182f9a4b04526d3467ee273_66_66)
ZugBahnHof commented 2024-10-02 02:11:27 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#bd3402ac4febc7da76c96d8978c45619fa4f70ce_96_96)
ZugBahnHof commented 2024-10-02 02:11:27 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#5a896d2e21779e38f9bb5d96c3199a402de88a2d_97_101)
ZugBahnHof commented 2024-10-02 02:11:27 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#5a896d2e21779e38f9bb5d96c3199a402de88a2d_46_49)
ZugBahnHof commented 2024-10-02 02:11:27 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#7be9287d181e5133ff4d94dcac92f5ab284e88cf_21_17)
ZugBahnHof commented 2024-10-02 02:11:27 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#c8b36f74582a4b8efba9c80da49b0d97363f588b_92_92)
ZugBahnHof commented 2024-10-02 02:11:27 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#4b1286c8b32832ad6e7410540da074dec8bc18b2_38_38)
ZugBahnHof commented 2024-10-02 02:11:28 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#6cd8195e9de1c81b18df55bd7b3e326c199f32f2_131_155)
ZugBahnHof commented 2024-10-02 02:11:28 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#793b238337115b7070b9f39b5aecc926eee6eaea_187_216)
ZugBahnHof commented 2024-10-02 02:11:28 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#56004324e69d65ac18e737bae82c56cbc527c114_45_45)
ZugBahnHof commented 2024-10-02 02:11:28 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#38875780b49b4ab8b275d412ee05a806fc99b454_124_124)
ZugBahnHof commented 2024-10-02 02:11:28 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df#f2931eed04e3052fa65624a45b57998a90e560b5_29_22)
ZugBahnHof commented 2024-10-02 02:11:28 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>1c392c90 - Use current version of build config files</li><li>34cb5b72 - Reformat automatically</li><li>652b24d1 - Reformat manually</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48243&start_sha=209c00cd5ef6104e65c68185ceb1630c45da22df)
ZugBahnHof commented 2024-10-02 02:14:50 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48245&start_sha=652b24d19a50a718a80e1ad7a6d96870d9f11e48#610bdfb57ad0684ec41037adfc88ac8ffe2fb0c1_76_75)
ZugBahnHof commented 2024-10-02 02:14:51 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>289404f4 - Remove debug log</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48245&start_sha=652b24d19a50a718a80e1ad7a6d96870d9f11e48)
ZugBahnHof commented 2024-10-02 16:49:33 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48258&start_sha=289404f4290032de63c8564bce8e1a19a63f3123#610bdfb57ad0684ec41037adfc88ac8ffe2fb0c1_58_67)
ZugBahnHof commented 2024-10-02 16:49:34 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

Compare with previous version

added 6 commits <ul><li>4cce9316 - Allow updating of grades</li><li>b81fd77c - Dsiplay loading state</li><li>37a6d111 - Fix styling of SharedSecretWrapper.vue if secret is correct</li><li>611075a0 - Allow deletion of grades</li><li>7d6cdcd3 - Reformat</li><li>24eecd84 - Use change event instead of input</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48258&start_sha=289404f4290032de63c8564bce8e1a19a63f3123)
yuha commented 2024-10-02 20:25:12 +02:00 (Migrated from edugit.org)
Copy link

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4
yuha commented 2024-10-02 22:50:28 +02:00 (Migrated from edugit.org)
Copy link

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4
yuha commented 2024-10-02 22:50:32 +02:00 (Migrated from edugit.org)
Copy link

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4
yuha commented 2024-10-02 22:50:37 +02:00 (Migrated from edugit.org)
Copy link

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4
yuha commented 2024-10-02 22:50:41 +02:00 (Migrated from edugit.org)
Copy link

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4

see https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/4
yuha commented 2024-10-02 22:51:04 +02:00 (Migrated from edugit.org)
Copy link

status now already comes from mutation; TODO: update cache

status now already comes from mutation; TODO: update cache
yuha commented 2024-10-02 22:51:36 +02:00 (Migrated from edugit.org)
Copy link

can't we just use the weight property?

can't we just use the weight property?
hansegucker commented 2024-10-03 16:04:38 +02:00 (Migrated from edugit.org)
Copy link

Color picker does 8-digit hex, backend wants 6-digit

Color picker does 8-digit hex, backend wants 6-digit
hansegucker commented 2024-10-03 16:05:48 +02:00 (Migrated from edugit.org)
Copy link

grafik

IDs?

![grafik](/uploads/c1c58f132d0f2bc183efd2c83d5ad8a8/grafik.png) IDs?
hansegucker commented 2024-10-03 16:09:20 +02:00 (Migrated from edugit.org)
Copy link

Auto select first entry in autocomplete

Auto select first entry in autocomplete
hansegucker commented 2024-10-03 16:10:01 +02:00 (Migrated from edugit.org)
Copy link

Why is there a red border?

grafik

Why is there a red border? ![grafik](/uploads/201d98f1a08e64520e7e18f13a94597b/grafik.png)
hansegucker commented 2024-10-03 16:13:39 +02:00 (Migrated from edugit.org)
Copy link

grafik

Ugly here

![grafik](/uploads/7beb0bbbe9600e2bfb8b5f6478a92773/grafik.png) Ugly here
ZugBahnHof commented 2024-10-04 16:28:07 +02:00 (Migrated from edugit.org)
Copy link

This is the color of the effort type you defined

This is the color of the effort type you defined
ZugBahnHof commented 2024-10-04 16:28:16 +02:00 (Migrated from edugit.org)
Copy link

Need to be removed

Need to be removed
ZugBahnHof commented 2024-10-04 16:28:40 +02:00 (Migrated from edugit.org)
Copy link

There is an issue for this in the Aleksis core

There is an issue for this in the Aleksis core
ZugBahnHof commented 2024-10-04 16:29:48 +02:00 (Migrated from edugit.org)
Copy link

The question is not, what the correct value is (would be the value of the grade property btw), but how to access it...

The question is not, what the correct value is (would be the `value` of the grade property btw), but _how_ to access it...
hansegucker commented 2024-10-04 16:31:19 +02:00 (Migrated from edugit.org)
Copy link

Wouldn't it be great to include the effort type (color) in the heading of the column?

Wouldn't it be great to include the effort type (color) in the heading of the column?
hansegucker commented 2024-10-05 14:05:12 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48385&start_sha=24eecd84e91e7c492ddb0064a9240b06e1439a01#f8b118ae331b058b12c6a6bd3f752fe3f60412ff_45_45)
hansegucker commented 2024-10-05 14:05:12 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48385&start_sha=24eecd84e91e7c492ddb0064a9240b06e1439a01#0953a991cbdfab291841821488f4c9a5046d3531_36_36)
hansegucker commented 2024-10-05 14:05:12 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48385&start_sha=24eecd84e91e7c492ddb0064a9240b06e1439a01#0953a991cbdfab291841821488f4c9a5046d3531_49_49)
hansegucker commented 2024-10-05 14:05:13 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48385&start_sha=24eecd84e91e7c492ddb0064a9240b06e1439a01#0953a991cbdfab291841821488f4c9a5046d3531_62_62)
hansegucker commented 2024-10-05 14:05:13 +02:00 (Migrated from edugit.org)
Copy link

added 15 commits

  • 24eecd84...3469334c - 5 earlier commits
  • 2c34edf3 - Actually allow for filtering grades & efforts by group ID as needed by group overview page
  • 9eca127e - Include subgroups in effort/grade query filtering
  • 01b96b63 - Remove shared secret check from grade set and effort type types/mutations/pages
  • f88817ba - Apply 2 suggestion(s) to 1 file(s)
  • 75681d41 - Rename rules
  • 9ec6b33d - Fix get_queryset with shared secret mixin
  • 39d0aa7c - Fix permission filtering for viewing own grades
  • 980c5cee - Separate fetch and view rules
  • b9a63416 - Reformat
  • a56a2fc6 - Merge branch '9-add-permissions-rules' into 'frontend'

Compare with previous version

added 15 commits <ul><li>24eecd84...3469334c - 5 earlier commits</li><li>2c34edf3 - Actually allow for filtering grades &amp; efforts by group ID as needed by group overview page</li><li>9eca127e - Include subgroups in effort/grade query filtering</li><li>01b96b63 - Remove shared secret check from grade set and effort type types/mutations/pages</li><li>f88817ba - Apply 2 suggestion(s) to 1 file(s)</li><li>75681d41 - Rename rules</li><li>9ec6b33d - Fix get_queryset with shared secret mixin</li><li>39d0aa7c - Fix permission filtering for viewing own grades</li><li>980c5cee - Separate fetch and view rules</li><li>b9a63416 - Reformat</li><li>a56a2fc6 - Merge branch &#39;9-add-permissions-rules&#39; into &#39;frontend&#39;</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48385&start_sha=24eecd84e91e7c492ddb0064a9240b06e1439a01)
hansegucker commented 2024-10-05 14:29:20 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cd4af30d - Add fixture for common German grade systems

Compare with previous version

added 1 commit <ul><li>cd4af30d - Add fixture for common German grade systems</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48391&start_sha=a56a2fc6dd4a78dd83f0a80c2c04dbe25a4fff43)
hansegucker commented 2024-10-06 16:50:23 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>848dd22b - Add translation files</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48410&start_sha=cd4af30d197e9b858d013970fb03d0ed53ffa4e9)
hansegucker commented 2024-10-06 17:19:23 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 6db0d464 - Translated using Weblate (German)
  • 922c028e - Merge branch 'weblate' into 'frontend'

Compare with previous version

added 2 commits <ul><li>6db0d464 - Translated using Weblate (German)</li><li>922c028e - Merge branch &#39;weblate&#39; into &#39;frontend&#39;</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48421&start_sha=848dd22b727f027ccd2b530031ee44ad19d891ff)
hansegucker commented 2024-10-06 17:19:27 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 613d2099 - Added translation using Weblate (German)
  • bb76873e - Translated using Weblate (German)
  • 48769ceb - Merge branch 'weblate-frontend' into 'frontend'

Compare with previous version

added 3 commits <ul><li>613d2099 - Added translation using Weblate (German)</li><li>bb76873e - Translated using Weblate (German)</li><li>48769ceb - Merge branch &#39;weblate-frontend&#39; into &#39;frontend&#39;</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48424&start_sha=922c028e4828b65429d6fe07ba17fd737db76162)
ZugBahnHof commented 2024-10-06 19:59:09 +02:00 (Migrated from edugit.org)
Copy link

Is this important right now @hansegucker ?

Is this important right now @hansegucker ?
ZugBahnHof commented 2024-10-06 19:59:56 +02:00 (Migrated from edugit.org)
Copy link

I think for that we should wait until we can assign icons to effort types

I think for that we should wait until we can assign icons to effort types
ZugBahnHof commented 2024-10-06 20:02:30 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>2a71c364 - Remove id column</li><li>ecd5e77f - Force flat shared secret wrapper</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48426&start_sha=48769ceb3fcb7550faa14b47c3e4df6cecf1b2cb)
ZugBahnHof commented 2024-10-06 20:03:00 +02:00 (Migrated from edugit.org)
Copy link

@yuha please have a look

@yuha please have a look
ZugBahnHof commented 2024-10-06 20:03:13 +02:00 (Migrated from edugit.org)
Copy link

@yuha whats the status on this?

@yuha whats the status on this?
ZugBahnHof commented 2024-10-06 20:03:58 +02:00 (Migrated from edugit.org)
Copy link

created #10 to continue this discussion

created #10 to continue this discussion
ZugBahnHof commented 2024-10-06 20:03:58 +02:00 (Migrated from edugit.org)
Copy link

mentioned in issue #10

mentioned in issue #10
ZugBahnHof commented 2024-10-06 20:32:08 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 1c5f8e57 - Show efforts of first-level child groups
  • 14013823 - Auto-select first grade
  • 96b992c8 - Translate grade removal confirmation dialog
  • c4a61263 - Display message for empty efforts

Compare with previous version

added 4 commits <ul><li>1c5f8e57 - Show efforts of first-level child groups</li><li>14013823 - Auto-select first grade</li><li>96b992c8 - Translate grade removal confirmation dialog</li><li>c4a61263 - Display message for empty efforts</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48428&start_sha=ecd5e77ff1b181ea9b346168780714f08dcebdbd)
ZugBahnHof commented 2024-10-06 20:40:34 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • dbaa5541 - Show message if group is a child group

Compare with previous version

added 1 commit <ul><li>dbaa5541 - Show message if group is a child group</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48430&start_sha=c4a61263c1be4491d775ca41ae8d6af1a3b57d1f)
ZugBahnHof commented 2024-10-06 20:42:11 +02:00 (Migrated from edugit.org)
Copy link

@yuha can you do this please?

@yuha can you do this please?
yuha commented 2024-10-06 23:19:46 +02:00 (Migrated from edugit.org)
Copy link

i need to check

i need to check
yuha commented 2024-10-06 23:21:58 +02:00 (Migrated from edugit.org)
Copy link

no, the cache of the sharedSecretStatus query isn't getting updated yet. I wouldn't consider this to be particularly important, but still as nice to have. Could we just put that into a follow-up issue?

no, the cache of the `sharedSecretStatus` query isn't getting updated yet. I wouldn't consider this to be particularly important, but still as nice to have. Could we just put that into a follow-up issue?
yuha commented 2024-10-07 11:40:59 +02:00 (Migrated from edugit.org)
Copy link

TODO: check that permissions are checked properly in for can_edit/can_delete gql type fields

TODO: check that permissions are checked properly in for `can_edit`/`can_delete` gql type fields
yuha commented 2024-10-07 11:41:02 +02:00 (Migrated from edugit.org)
Copy link

.

.
yuha commented 2024-10-07 11:42:08 +02:00 (Migrated from edugit.org)
Copy link

TODO: Add preference that switches whether parent group owners may edit grades/efforts of child groups

TODO: Add preference that switches whether parent group owners may edit grades/efforts of child groups
yuha commented 2024-10-07 12:00:58 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48440&start_sha=dbaa55417ea2b071b3cf24a5b951abb4ab0c07d2#8f4db07baef5dbd97c7a5e376071cc129ba8927f_47_47)
yuha commented 2024-10-07 12:00:59 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 763b8149 - Add default value when getting shared secret status from session

Compare with previous version

added 1 commit <ul><li>763b8149 - Add default value when getting shared secret status from session</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48440&start_sha=dbaa55417ea2b071b3cf24a5b951abb4ab0c07d2)
yuha commented 2024-10-07 13:44:28 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 23 of the diff

changed this line in [version 23 of the diff](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48442&start_sha=763b81497d1ad4383720663e0278916ce81b66dc#0bd15140bfded86139248bafb43ad73556694814_64_68)
yuha commented 2024-10-07 13:44:28 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2796c21f - Check for permissions when displaying create effort button

Compare with previous version

added 1 commit <ul><li>2796c21f - Check for permissions when displaying create effort button</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48442&start_sha=763b81497d1ad4383720663e0278916ce81b66dc)
hansegucker commented 2024-10-07 16:18:23 +02:00 (Migrated from edugit.org)
Copy link

Yes

Yes
hansegucker commented 2024-10-07 16:18:43 +02:00 (Migrated from edugit.org)
Copy link

I don't know, I didn't write TODO there.

I don't know, I didn't write TODO there.
hansegucker commented 2024-10-07 16:19:08 +02:00 (Migrated from edugit.org)
Copy link

Follow up issue please

Follow up issue please
yuha commented 2024-10-07 18:42:49 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9af966ad - Make child group effort/grade viewing/managing configurable

Compare with previous version

added 1 commit <ul><li>9af966ad - Make child group effort/grade viewing/managing configurable</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48453&start_sha=2796c21fd46e27f81df1277fe9f11c27bce194ae)
yuha commented 2024-10-07 18:45:02 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 10d8b55c - Reformat

Compare with previous version

added 1 commit <ul><li>10d8b55c - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48455&start_sha=9af966adc95ca74d9002e0df5573130294568c02)
yuha commented 2024-10-07 18:48:49 +02:00 (Migrated from edugit.org)
Copy link

mentioned in issue #12

mentioned in issue #12
yuha commented 2024-10-07 18:48:55 +02:00 (Migrated from edugit.org)
Copy link

https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/issues/12

https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Maka/-/issues/12
yuha commented 2024-10-07 19:00:21 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3a79b9f7 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Maka/-/merge_requests/2/diffs?diff_id=48459&start_sha=10d8b55c1d7f0b94bc0430e0ce751a95364bf063)
yuha commented 2024-10-09 20:24:08 +02:00 (Migrated from edugit.org)
Copy link

created #13 to continue this discussion

created #13 to continue this discussion
yuha commented 2024-10-09 20:24:08 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2024-10-09 20:24:09 +02:00 (Migrated from edugit.org)
Copy link

mentioned in issue #13

mentioned in issue #13
hansegucker commented 2024-10-11 12:34:09 +02:00 (Migrated from edugit.org)
Copy link

requested review from @hansegucker

requested review from @hansegucker
hansegucker commented 2024-10-11 12:34:12 +02:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker and unassigned @ZugBahnHof

assigned to @hansegucker and unassigned @ZugBahnHof
hansegucker commented 2024-10-11 12:34:15 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-10-11 12:34:30 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 867262a617

mentioned in commit 867262a6174545c80114c16aee206b55743878d6
hansegucker (Migrated from edugit.org) merged commit 867262a617 into main 2024-10-11 12:34:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Maka!20
No description provided.