aleksis/AlekSIS-App-Lesrooster
Watch
10
0
Fork
You've already forked AlekSIS-App-Lesrooster
 0
Code Issues 45 Pull requests 2 Projects Releases Packages 1 Activity Actions

Resolve "Add model for planning of courses (dependend on ValidityRange)" #98

Merged
hansegucker merged 31 commits from 2-add-model-for-planning-of-courses-dependend-on-validityrange into 1-frontend-for-models 2023-07-31 23:17:05 +02:00
Conversation 17 Commits 31 Files changed 37 +2617 -1584
leuckeju commented 2023-07-12 13:44:48 +02:00
Member
Copy link

Closes #2

Closes #2
leuckeju commented 2023-07-12 13:50:21 +02:00
Author
Member
Copy link

There is an interface in cursus that is a supertype of courses which you could implement, so that we wouldn't need this additional type.

See:
https://docs.graphene-python.org/en/latest/types/interfaces/
https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/2/diffs#a81fc04014516b978c11ae4b968d93b6d93e1dec_0_62

I think this would be the better way to do this (and would probably also require less work in the magnet board)

There is an interface in cursus that is a supertype of courses which you could implement, so that we wouldn't need this additional type. See: https://docs.graphene-python.org/en/latest/types/interfaces/ https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/2/diffs#a81fc04014516b978c11ae4b968d93b6d93e1dec_0_62 I think this would be the better way to do this (and would probably also require less work in the magnet board)
yuha commented 2023-07-14 00:32:50 +02:00
Member
Copy link

wouldn't this also require defining an additional type as can be seen in the graphene docs?

wouldn't this also require defining an additional type as can be seen in the graphene docs?
leuckeju commented 2023-07-14 13:20:32 +02:00
Author
Member
Copy link

I don't understand what you mean

I don't understand what you mean
yuha commented 2023-07-15 18:29:40 +02:00
Member
Copy link

added 1 commit

  • 78d36d1e - Actually save and sort modified course config data

Compare with previous version

added 1 commit <ul><li>78d36d1e - Actually save and sort modified course config data</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/10/diffs?diff_id=32597&start_sha=5bfbfe8a06af6cdbee27909ef37a1127034ffd91)
yuha commented 2023-07-15 23:13:38 +02:00
Member
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>bd0eee36 - Add column for subject</li><li>2cc36737 - Remove unneeded methods</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/10/diffs?diff_id=32598&start_sha=78d36d1e2ee534f1257474e4d1c43bcabad048fb)
yuha commented 2023-07-18 19:40:50 +02:00
Member
Copy link

added 2 commits

  • f83b711d - Allow creating and updating course configs
  • 2947619d - Specify fields for timebound course config mutations

Compare with previous version

added 2 commits <ul><li>f83b711d - Allow creating and updating course configs</li><li>2947619d - Specify fields for timebound course config mutations</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/10/diffs?diff_id=32701&start_sha=2cc367370293d323fe7b7e75499561ebc69073ac)
yuha commented 2023-07-19 19:08:59 +02:00
Member
Copy link

added 3 commits

  • 9af3ef14 - Fix creating/editing course configs when switching between validityranges
  • c243f06b - Prevent duplicate courses in table
  • 94808f58 - Only show classes of a pre-selected grade in course config raster

Compare with previous version

added 3 commits <ul><li>9af3ef14 - Fix creating/editing course configs when switching between validityranges</li><li>c243f06b - Prevent duplicate courses in table</li><li>94808f58 - Only show classes of a pre-selected grade in course config raster</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/10/diffs?diff_id=32756&start_sha=2947619d9440ee5249ce629d20d5a4b8976937ae)
yuha commented 2023-07-23 15:33:03 +02:00
Member
Copy link

added 4 commits

  • 521a8dd7 - Re-add mutation to create timebound course config
  • c43cc570 - Beautify course config raster and differentiate teacher selection
  • b2e25c85 - Add model and form extensions for assigning lesson quotas to teachers
  • 1a8aa626 - Fix typo

Compare with previous version

added 4 commits <ul><li>521a8dd7 - Re-add mutation to create timebound course config</li><li>c43cc570 - Beautify course config raster and differentiate teacher selection</li><li>b2e25c85 - Add model and form extensions for assigning lesson quotas to teachers</li><li>1a8aa626 - Fix typo</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/10/diffs?diff_id=32996&start_sha=94808f584e9445d7f0c096bd8be3360d47e1f77c)
hansegucker commented 2023-07-31 14:17:05 +02:00
Owner
Copy link

added 23 commits

  • 1a8aa626...b76e47ce - 14 commits from branch 1-frontend-for-models
  • dbba2166 - Add missing docstrings
  • 38cf45c6 - Add status field to ValidityRange model
  • a6c69da1 - Fix managers
  • 84ad45ed - Skip recurrences if there are no recurrences
  • dcf4f581 - Fix version in pyproject.toml
  • 51659d20 - Rename Break to BreakSlot
  • f3c962e0 - Merge branch 'models' into 'master'
  • 1bf54e78 - Merge branch 'master' into 2-add-model-for-planning-of-courses-dependend-on-validityrange
  • 2e955c6d - Fix migration history

Compare with previous version

added 23 commits <ul><li>1a8aa626...b76e47ce - 14 commits from branch <code>1-frontend-for-models</code></li><li>dbba2166 - Add missing docstrings</li><li>38cf45c6 - Add status field to ValidityRange model</li><li>a6c69da1 - Fix managers</li><li>84ad45ed - Skip recurrences if there are no recurrences</li><li>dcf4f581 - Fix version in pyproject.toml</li><li>51659d20 - Rename Break to BreakSlot</li><li>f3c962e0 - Merge branch &#39;models&#39; into &#39;master&#39;</li><li>1bf54e78 - Merge branch &#39;master&#39; into 2-add-model-for-planning-of-courses-dependend-on-validityrange</li><li>2e955c6d - Fix migration history</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/10/diffs?diff_id=33185&start_sha=1a8aa6260f75341a351de918f892f931e97daf9e)
hansegucker commented 2023-07-31 22:25:11 +02:00
Owner
Copy link

added 1 commit

  • f8081833 - Fix bugs with queryset and rename Break to BreakSlot

Compare with previous version

added 1 commit <ul><li>f8081833 - Fix bugs with queryset and rename Break to BreakSlot</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/10/diffs?diff_id=33202&start_sha=2e955c6d71e551a42f8de0db5eeb85c217cb96cc)
hansegucker commented 2023-07-31 22:28:53 +02:00
Owner
Copy link

Set fields explicitly for all queries/mutations.

Set `fields` explicitly for all queries/mutations.
hansegucker commented 2023-07-31 22:29:17 +02:00
Owner
Copy link

FIXME

FIXME
hansegucker commented 2023-07-31 23:16:16 +02:00
Owner
Copy link

added 57 commits

  • f8081833...1f3e30d8 - 54 commits from branch 1-frontend-for-models
  • de4decc5 - Merge branch '1-frontend-for-models' into...
  • 6a97051f - Reformat
  • eea6bf35 - Fix lint

Compare with previous version

added 57 commits <ul><li>f8081833...1f3e30d8 - 54 commits from branch <code>1-frontend-for-models</code></li><li>de4decc5 - Merge branch &#39;1-frontend-for-models&#39; into...</li><li>6a97051f - Reformat</li><li>eea6bf35 - Fix lint</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/10/diffs?diff_id=33205&start_sha=f8081833c5138a9cdba5a6a977f90e1e34e49da9)
hansegucker commented 2023-07-31 23:16:50 +02:00
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2023-07-31 23:17:05 +02:00
Owner
Copy link

mentioned in commit 3df2b59cf3

mentioned in commit 3df2b59cf3d29069fb53e06f6ba825ec1581cfa6
hansegucker merged commit 3df2b59cf3 into 1-frontend-for-models 2023-07-31 23:17:05 +02:00
hansegucker commented 2023-11-01 18:33:36 +01:00
Owner
Copy link

created #24 to continue this discussion

created #24 to continue this discussion
hansegucker commented 2023-11-01 18:33:36 +01:00
Owner
Copy link

mentioned in issue #24

mentioned in issue #24
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Lesrooster!98
No description provided.