Resolve "Migrate to Vue 3/Vuetify 3" #207
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
aleksis/AlekSIS-App-Lesrooster!207
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "78-migrate-to-vue-3-vuetify-3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Information and screenshots
No further information have been provided.
Checklist
tox -e reformat,lintusedapps.pyandREADME.rstup-to-dateBackend checklist
Frontend checklist (mandatory with ~"part::frontend")
Closes #78
assigned to @yuha
added 2 commits
dc9d6d57- Update dev reformatter and linter to new versions2436d012- Semi-automatic eslint migrationCompare with previous version
added 2 commits
1b9ed47b- Add objectSchemasaa8945a4- Remove reference to parent component in routesCompare with previous version
added 3 commits
7cc337ad- WIP: Adapt validity range list to vue357a78204- Remove duplicated variant prop8b596092- WIP: adapt (break) slot listsCompare with previous version
added 2 commits
543815cf- Remove duplicated variantcd2f52eb- Remove duplicated variantCompare with previous version
added 6 commits
37419eb2- Adapt TimeGridField to composition APIf12e0854- Make TGF return objectc3f0512d- WIP: Adapt lesson raster page (show items only; CRUD stuff broken)0f0126b7- Fix hovering838d6b02- Use icon buttons, fix weekday carry over menu and hide it when there are no other weekdays5506704e- Fix buttons triggered by hovering of weekday cardCompare with previous version
added 3 commits
7473d3bd- Adapt slot creatione4aabcab- Fix deletion of slots00ef7feb- Fix weekday carry over listCompare with previous version
added 1 commit
78a0b8b0- WIP: fix carry over cache handlingCompare with previous version
added 1 commit
6c2fdd2f- Fix carry over cache updatingCompare with previous version
added 2 commits
e86aafac- Fix copy from time grid menuc885c91d- Add todoCompare with previous version
added 1 commit
2dfac4b3- Fix importCompare with previous version
added 2 commits
99bcbb74- Fix DragGrid model value prop naming428717c3- Add todoCompare with previous version
added 2 commits
2b869a3e- Remove & add fixme323adaf3- Roughly adapt timetable planningCompare with previous version
added 2 commits
db2b65e5- Make lesson card hover menu look agreeabledcb8e845- Fix lesson moving cache updateCompare with previous version
added 2 commits
3c5e948f- Fix lesson bundle slot change mutation update functionCompare with previous version
added 1 commit
caf2f291- WIP: use CRUDProvider for parts of timetable raster mechanismCompare with previous version
added 1 commit
7769a581- Remove todos & get item naming in delete dialog rightCompare with previous version
added 8 commits
a61ca9e0- Restrict editable lesson fields83b1605f- Add some translation keys15223b70- WIP: fix subject field recursion1e0b814e- Add title function0d43cef8- Remove some legacy codee0451ff6- Remove todoe298306c- Use translation keys for VR/group selectCompare with previous version
added 1 commit
Compare with previous version
added 2 commits
098c9612- WIP: adapt supervision raster6703b4d9- WIP: Adapt supervision CRUD listCompare with previous version
added 2 commits
4f530c30- WIP: adapt TCC CRUD list0c7d70b6- WIP: adapt TCC rasterCompare with previous version
added 10 commits
60db17a3- Use correct rule53fc4b3e- Use new base mutation classes from core2335bef4- Finish adapting TCC raster88dd519e- Remove todofe3c48e3- Fix mini timetables64df7013- Fix mini timetable styles1837d1af- Add missing translation key38711d72- Drop unused style574e8d38- Fix display of fields in TCC CRUD tableCompare with previous version
added 1 commit
14736184- ReformatCompare with previous version
added 2 commits
99885cd5- Reformat II739e72f6- Only fetch lesson raster items when ITG is selectedCompare with previous version
marked the checklist item
tox -e reformat,lintused as completedmarked the checklist item Changelog updated/No update necessary as completed
marked the checklist item Changelog updated/No update necessary as incomplete
there might still be some bugs (see todos, partly – it's getting a bit messy and i suggest moving small stuff that gets discovered in follow up issues), the weekday translation lables are missing in the core and i'm not entirely sure how to apply the URL scheme to lesrooster (what URL should the timebound course config raster page get, for example?)
marked this merge request as ready
assigned to @nik and unassigned @yuha
marked the checklist item Screenshots are attached (mobile and desktop) as completed
marked the checklist item Tested on mobile, tablet, and desktop sizes as completed
marked the checklist item Adhered to frontend guidelines as completed
marked the checklist item Use permissions for all GraphQL mutations as completed
marked the checklist item Use query optimizer for all GraphQL queries as completed
marked the checklist item Don't use inefficient DB queries as completed
marked the checklist item Tested with normal account (based on permissions) as completed
marked the checklist item Tested with admin account as completed
marked the checklist item Documentation (incl. Screenshots) up-to-date as completed
marked the checklist item Changelog updated/No update necessary as completed
assigned to @yuha and unassigned @nik
requested review from @hansegucker
The weekday labels are now different because the
WeekdayFieldshould be used for weekdays. Please adhere to this.Seems to be legacy (v-on no longer is a thing in Vue 3), as well as the attrs has been moved to
propsForField.Why aren't they
computed? Especially the later one also could move directly into the template.Same thing as above, should me mostly an easy fix.
Should be easy enough to port to new toast architecture.
There should be some kind of success, if this is needed for the success message, please adapt to new toasts.
Why is this commented out?
Does this work at all with that many lines commented out?
See above
computed?
computed?
???
???
????
????
requested changes
added 1 commit
Compare with previous version
added 1 commit
e5185bcd- Use WeekdayFieldCompare with previous version
mentioned in issue AlekSIS-Core#1405
changed this line in version 26 of the diff
changed this line in version 26 of the diff
added 2 commits
54f4862d- Fix BreakSlot filtersd2806071- Fix Slot CRUD list filtersCompare with previous version
changed this line in version 27 of the diff
added 1 commit
5fbc8187- Refactor BreakSlotDisplayCompare with previous version
added 2 commits
2bc9f2ae- Remove todosfe03f09b- Add snacksCompare with previous version
changed this line in version 29 of the diff
added 1 commit
a33beed5- Add more snacksCompare with previous version
changed this line in version 30 of the diff
added 1 commit
a625032a- Fix filters and remove commented out sections in supervision managementCompare with previous version
yes;)
changed this line in version 31 of the diff
added 1 commit
3cfc9a2b- Remove commented out sections and fix deletionCompare with previous version
changed this line in version 32 of the diff
changed this line in version 32 of the diff
changed this line in version 32 of the diff
added 2 commits
1f6f0948- Re-add toasts198cbdcc- Re-add snacksCompare with previous version
changed this line in version 33 of the diff
added 2 commits
31ed11ab- Fix wrong filters5a8d98cd- Fix TCC CRUD filterrsCompare with previous version
changed this line in version 34 of the diff
added 1 commit
aeb60d1c- Use computed for time grid display stringCompare with previous version
see https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/1376
no, since the
name-propprop takes functions onlyresolved all threads
added 1 commit
d401bb11- Drop todoCompare with previous version
added 1 commit
e02baa5b- Add more todo infosCompare with previous version
changed this line in version 37 of the diff
added 2 commits
2f875518- Fix/refactor some VR/TG related thingse41ac582- (Partly) use object based routesCompare with previous version
i've fixed some more stuff & partly ported the routes to the new URL scheme – regarding the remaining ones: i don't know how they would be represented correctly under the new scheme; can someone help?
and ( @ZugBahnHof , @permcu ?) there's still some problems i have with the new CRUD architecture in the
ValidityRangeCRUD list and theTimeGridField. could you have a look, maybe? i'd suggest to move that in a follow-up.added 5 commits
aaf306bc- Make slot card layout more consistentef97d48f- Some changes to delete/copy buttons74c61646- Use form validation in slot creatord5253aca- Drop todo807f53f1- Adapt period card to new weekday namesCompare with previous version
added 1 commit
8f424221- Fix blocking card overlayCompare with previous version
added 2 commits
361af246- Remove todo7bed88dd- Drop unrelated todoCompare with previous version
added 6 commits
dbee66b6- Add orderBy for slotsba80c419- Layout improvementsf6183a6c- Remove todobac724a8- Remove todo0676643d- Remove todo48306e07- Remove return-object in TimeGridFieldCompare with previous version
added 1 commit
3c47042a- WIP: try to fix TG CRUDCompare with previous version
@permcu looks into subject recursion issue
TimeGrid CRUD bugs need several fixes in core in order to be properly resolved (row expanding bug, OS merging, …)
created #83 to continue this discussion
resolved all threads
mentioned in issue #83
.
created #84 to continue this discussion
resolved all threads
added 1 commit
e5a93749- Quick fix for extended course/subject type issuesCompare with previous version
added 2 commits
2a9dae82- only run getRRule in write when no recurrence is already set7ef1ab21- Comment out TeacherField since it seems to cause recursionsCompare with previous version
added 1 commit
a583e8d6- Fix lesson editing in timetable managementCompare with previous version
added 1 commit
d0caf061- ReformatCompare with previous version
assigned to @nik and unassigned @yuha
assigned to @hansegucker and unassigned @nik
added 2 commits
014aa4e8- Fix mini timetable tabs807de03c- Fix mini timetable gridsCompare with previous version
added 1 commit
1072b372- Remove breakSlot field from supervision planning raster edit dialogCompare with previous version
added 1 commit
3f8163a9- ReformatCompare with previous version
@hansegucker @nik i just fixed the two issues noticed yesterday, please have a look again
mentioned in commit
23de7e363d