aleksis/AlekSIS-App-Lesrooster
Watch
10
0
Fork
You've already forked AlekSIS-App-Lesrooster
 0
Code Issues 45 Pull requests 2 Projects Releases Packages 1 Activity Actions

Resolve "[TCC planning] Frontend is incredibly slow with large amounts of entries" #135

Merged
hansegucker merged 37 commits from 49-tcc-planning-frontend-is-incredibly-slow-with-large-amounts-of-groups into master 2025-04-11 15:42:00 +02:00
Conversation 44 Commits 37 Files changed 9 +554 -413
yuha commented 2024-05-11 17:57:08 +02:00
Member
Copy link

Closes #49

Closes #49
yuha commented 2024-05-11 17:57:08 +02:00
Author
Member
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2024-05-11 23:24:23 +02:00
Author
Member
Copy link

added 1 commit

  • ff61c3ba - Allow for including courses of child groups in TCC raster

Compare with previous version

added 1 commit <ul><li>ff61c3ba - Allow for including courses of child groups in TCC raster</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42839&start_sha=db2cabf0003a88b523c1b1a1fcaa3eaf1e71cd9b)
yuha commented 2024-05-12 02:04:10 +02:00
Author
Member
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>df4de0b6 - Add loading indicators</li><li>e1720c32 - Set fixed width in TCC raster</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42841&start_sha=ff61c3ba997ac65fe20521ba1b57d762ba6900cf)
yuha commented 2024-05-12 20:46:09 +02:00
Author
Member
Copy link

added 1 commit

  • ee9165da - Compute group combinations more efficiently and without duplicates

Compare with previous version

added 1 commit <ul><li>ee9165da - Compute group combinations more efficiently and without duplicates</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42875&start_sha=e1720c322b6a82b6d463e51e7f865017ee47c77f)
yuha commented 2024-05-13 13:36:16 +02:00
Author
Member
Copy link

added 2 commits

  • d454ea9e - Fix subject resolving mechanism
  • 00139d24 - Make header generation mechanism more efficient

Compare with previous version

added 2 commits <ul><li>d454ea9e - Fix subject resolving mechanism</li><li>00139d24 - Make header generation mechanism more efficient</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42893&start_sha=ee9165da4c20712b9f45c13f546b92c3dc2913de)
yuha commented 2024-05-13 13:39:42 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4c12d985 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42894&start_sha=00139d2487c217ffd9310cec107e8ee4db94d253)
yuha commented 2024-05-13 16:24:08 +02:00
Author
Member
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>f222ea86 - Some optimisations in frontend</li><li>6cae2deb - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42895&start_sha=4c12d98598653e82eb850b8435a4e922d83ef36e)
yuha commented 2024-05-13 16:24:37 +02:00
Author
Member
Copy link

@hansegucker could you have a look what else could be optimised?

@hansegucker could you have a look what else could be optimised?
yuha commented 2024-05-14 12:02:17 +02:00
Author
Member
Copy link

added 1 commit

  • 53a38d26 - Move filtering of TCCs for ValidityRange to backend

Compare with previous version

added 1 commit <ul><li>53a38d26 - Move filtering of TCCs for ValidityRange to backend</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42901&start_sha=6cae2debe76c80e8c043c154dec54ac43764efc0)
yuha commented 2024-05-14 12:04:14 +02:00
Author
Member
Copy link

added 8 commits

  • 63f7bd9b - Add optional course group creation
  • 8439c05c - Reformat
  • 447dd161 - Set parent groups when creating course group
  • 4bb59c5b - Use preference for course group group type
  • e747f66f - Make adding of group members to course groups configurable
  • 8a10b823 - Change preference comment wording
  • f510699c - Set both name and shortname on newly created course groups
  • 80a427a9 - Merge branch '47-tcc-planning-add-option-to-create-course-groups' into...

Compare with previous version

added 8 commits <ul><li>63f7bd9b - Add optional course group creation</li><li>8439c05c - Reformat</li><li>447dd161 - Set parent groups when creating course group</li><li>4bb59c5b - Use preference for course group group type</li><li>e747f66f - Make adding of group members to course groups configurable</li><li>8a10b823 - Change preference comment wording</li><li>f510699c - Set both name and shortname on newly created course groups</li><li>80a427a9 - Merge branch &#39;47-tcc-planning-add-option-to-create-course-groups&#39; into...</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42903&start_sha=53a38d26be2cb8b64663c6200b142f95e2194e79)
yuha commented 2024-05-14 12:22:07 +02:00
Author
Member
Copy link

added 1 commit

  • 303ce99e - Move course name generation to backend

Compare with previous version

added 1 commit <ul><li>303ce99e - Move course name generation to backend</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42905&start_sha=80a427a98445b43e50381db255c8ec925335b0c2)
yuha commented 2024-05-14 13:57:45 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>d4a3d428 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=42927&start_sha=303ce99e0f40b8cc61a947e7f2a7f980e336ee2f)
hansegucker commented 2024-05-14 15:21:44 +02:00
Owner
Copy link

I am not sure. How fast is this currently?

I am not sure. How fast is this currently?
yuha commented 2024-05-14 19:04:36 +02:00
Author
Member
Copy link

Not fast enough to be really nice to use with a realistic dataset, at least. Initial loading took some seconds with the site being unresponsive; and changing values causes some stuttering. Could you maybe try it out?

Not fast enough to be really nice to use with a realistic dataset, at least. Initial loading took some seconds with the site being unresponsive; and changing values causes some stuttering. Could you maybe try it out?
yuha commented 2025-01-28 23:59:46 +01:00
Author
Member
Copy link

added 242 commits

  • d4a3d428...90605579 - 241 commits from branch master
  • 7ef331fa - Merge branch 'master' into 49-tcc-planning-frontend-is-incredibly-slow-with-large-amounts-of-groups

Compare with previous version

added 242 commits <ul><li>d4a3d428...90605579 - 241 commits from branch <code>master</code></li><li>7ef331fa - Merge branch &#39;master&#39; into 49-tcc-planning-frontend-is-incredibly-slow-with-large-amounts-of-groups</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=55056&start_sha=d4a3d428d593e0dbc6b85f0eb75beae9d1895e89)
yuha commented 2025-01-29 14:03:02 +01:00
Author
Member
Copy link

added 6 commits

  • cbccc175 - Use active school term for filtering TCCs
  • 340ab9f3 - Remove sending of school term when creating courses in TCC raster
  • ab4c4d61 - Remove unused copy from last VR button
  • 13f2a005 - Remove unneeded imports
  • 77f05c6e - Auto-create TCC when using course pöanning feature
  • 6b87f2ac - Set translated default label for VR field

Compare with previous version

added 6 commits <ul><li>cbccc175 - Use active school term for filtering TCCs</li><li>340ab9f3 - Remove sending of school term when creating courses in TCC raster</li><li>ab4c4d61 - Remove unused copy from last VR button</li><li>13f2a005 - Remove unneeded imports</li><li>77f05c6e - Auto-create TCC when using course pöanning feature</li><li>6b87f2ac - Set translated default label for VR field</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=55070&start_sha=7ef331fac642b0e94041c3324cfd3e99d9eaa4b9)
yuha commented 2025-01-29 14:44:28 +01:00
Author
Member
Copy link

added 1 commit

  • 4ac86f4f - Avoid refetch after saving by updating subjects cache with results

Compare with previous version

added 1 commit <ul><li>4ac86f4f - Avoid refetch after saving by updating subjects cache with results</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=55072&start_sha=6b87f2acd74e46968acd1c027f5ff45717a416c5)
yuha commented 2025-02-27 00:33:55 +01:00
Author
Member
Copy link

added 1 commit

  • 68f8d4b2 - WIP: Autosave

Compare with previous version

added 1 commit <ul><li>68f8d4b2 - WIP: Autosave</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=56467&start_sha=4ac86f4fbebabc659c4225ece323664a4f5a7d07)
yuha commented 2025-02-28 09:57:04 +01:00
Author
Member
Copy link

added 1 commit

  • 333c55fc - Implement TCC raster autosave

Compare with previous version

added 1 commit <ul><li>333c55fc - Implement TCC raster autosave</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=56560&start_sha=68f8d4b2ae9f76ca1ec831b0d505ff39e329edd2)
yuha commented 2025-02-28 20:20:07 +01:00
Author
Member
Copy link

needs https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/84

needs https://edugit.org/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/84
yuha commented 2025-02-28 20:23:07 +01:00
Author
Member
Copy link

added 4 commits

  • ee768cd2 - Make lesson quota field required & fire setting course data only on change
  • 7f4c51c2 - Make lessonQuota not required
  • 548e9d71 - Use TeacherField instead of custom autocomplete
  • c58789ee - Make TeacherField required

Compare with previous version

added 4 commits <ul><li>ee768cd2 - Make lesson quota field required &amp; fire setting course data only on change</li><li>7f4c51c2 - Make lessonQuota not required</li><li>548e9d71 - Use TeacherField instead of custom autocomplete</li><li>c58789ee - Make TeacherField required</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=56591&start_sha=333c55fc366386efb18c25e5106be42288345661)
yuha commented 2025-03-05 08:25:44 +01:00
Author
Member
Copy link

added 1 commit

  • f0c2b7f0 - Properly set data table loading state

Compare with previous version

added 1 commit <ul><li>f0c2b7f0 - Properly set data table loading state</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=56714&start_sha=c58789ee625a12c38885dd4fca4e8fca04b9b4f7)
yuha commented 2025-03-05 08:26:53 +01:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1982f79f - Move permission check</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=56715&start_sha=f0c2b7f0f77c051d6c49718ce837944f4b43fd5a)
yuha commented 2025-03-06 23:44:51 +01:00
Author
Member
Copy link

added 1 commit

  • 908ef394 - WIP: Speed TCC raster up by refactoring coomponents

Compare with previous version

added 1 commit <ul><li>908ef394 - WIP: Speed TCC raster up by refactoring coomponents</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=56783&start_sha=1982f79ffa1b021bbc201bee9256868214e6b4bd)
yuha commented 2025-03-17 00:27:56 +01:00
Author
Member
Copy link

added 1 commit

  • 29e259ca - Speed TCC raster up by refactoring components and using v-lazy

Compare with previous version

added 1 commit <ul><li>29e259ca - Speed TCC raster up by refactoring components and using v-lazy</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=57274&start_sha=908ef39494bf06310e46bfab3e99fc5bb62ee3a4)
hansegucker commented 2025-03-30 15:08:14 +02:00
Owner
Copy link
    def create(cls, info, course_input, validity_range):
```suggestion:-0+0 def create(cls, info, course_input, validity_range): ```
hansegucker commented 2025-03-30 15:08:14 +02:00
Owner
Copy link

There should be at least one permission check, but probably just a global one.

There should be at least one permission check, but probably just a global one.
hansegucker commented 2025-03-30 15:08:14 +02:00
Owner
Copy link

Drop stuff commented out

Drop stuff commented out
hansegucker commented 2025-03-30 15:08:15 +02:00
Owner
Copy link

Please add some commentary in TimeboundCourseConfigRaster.

Please add some commentary in `TimeboundCourseConfigRaster`.
yuha commented 2025-04-10 16:46:01 +02:00
Author
Member
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59675&start_sha=29e259cabbf6d75c7008d748e8f6e89e5bd09d71#8cd00a9f61e0b57b456d7ad6a4a392ae42c390f9_120_120)
yuha commented 2025-04-10 16:46:02 +02:00
Author
Member
Copy link

added 1 commit

  • 2edc01bf - Rename VR ID function argument

Compare with previous version

added 1 commit <ul><li>2edc01bf - Rename VR ID function argument</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59675&start_sha=29e259cabbf6d75c7008d748e8f6e89e5bd09d71)
yuha commented 2025-04-10 16:47:54 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>744ebb13 - Re-add perm check</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59676&start_sha=2edc01bf382ade60f6c9bcb6d77aa0fa0949d4dd)
yuha commented 2025-04-10 16:47:55 +02:00
Author
Member
Copy link

like this?

like this?
yuha commented 2025-04-10 16:48:39 +02:00
Author
Member
Copy link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59677&start_sha=744ebb137981306826ff0f3575eb3fdc2cfaa20a#b8ac4e40ec3c9a6c68f6d85a0f3237483c31e81e_96_95)
yuha commented 2025-04-10 16:48:40 +02:00
Author
Member
Copy link

added 1 commit

  • bc78eedf - Drop commented out code sections

Compare with previous version

added 1 commit <ul><li>bc78eedf - Drop commented out code sections</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59677&start_sha=744ebb137981306826ff0f3575eb3fdc2cfaa20a)
yuha commented 2025-04-10 17:08:58 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>61a8bd19 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59681&start_sha=bc78eedf05d7f837147396370459e54cbfdd7d0b)
yuha commented 2025-04-10 17:09:54 +02:00
Author
Member
Copy link

added 6 commits

  • 61a8bd19...0407e61f - 5 commits from branch master
  • abd23bfd - Merge branch 'master' into 49-tcc-planning-frontend-is-incredibly-slow-with-large-amounts-of-groups

Compare with previous version

added 6 commits <ul><li>61a8bd19...0407e61f - 5 commits from branch <code>master</code></li><li>abd23bfd - Merge branch &#39;master&#39; into 49-tcc-planning-frontend-is-incredibly-slow-with-large-amounts-of-groups</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59682&start_sha=61a8bd19fb2a02d139d7cbbf078f538b5f35aca1)
hansegucker commented 2025-04-10 17:17:57 +02:00
Owner
Copy link

Yes

Yes
yuha commented 2025-04-10 17:27:35 +02:00
Author
Member
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>bcdf89a1 - Remove debugging prints</li><li>f45a9e33 - Add comments</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59687&start_sha=abd23bfd5f873290b35d1d7bf33659ea0dc45445)
yuha commented 2025-04-10 17:27:41 +02:00
Author
Member
Copy link

done

done
hansegucker commented 2025-04-10 17:31:06 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-04-10 17:31:53 +02:00
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2025-04-11 15:41:51 +02:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>68824efa - Fix lint and reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/47/diffs?diff_id=59827&start_sha=f45a9e3310b137baa04189165601056ec94663e4)
hansegucker commented 2025-04-11 15:42:01 +02:00
Owner
Copy link

mentioned in commit 3566a73099

mentioned in commit 3566a73099ceb5fc471aa10c1cc8fc1c211b4547
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
yuha
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Lesrooster!135
No description provided.