aleksis/AlekSIS-App-Lesrooster
8
0
Fork 0
Code Issues 43 Pull requests 3 Projects Releases Packages Activity Actions

Resolve "[New data model] PDF export for "regular" timetable" #124

Merged
hansegucker merged 13 commits from 46-new-data-model-pdf-export-for-regular-timetable into master 2025-04-12 16:15:19 +02:00
Conversation 40 Commits 13 Files changed 35 +884 -59
hansegucker commented 2024-04-12 21:43:30 +02:00 (Migrated from edugit.org)
Copy link

Closes #46

Closes #46
hansegucker commented 2024-04-12 21:51:00 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 0371a745 - Improve and restructure mini timetables, include mini timetable for teachers
  • 25c3aeaa - Support displaying dates of validity ranges in TimeGridField
  • a3c51cfd - Introduce view for regular timetables

Compare with previous version

added 3 commits <ul><li>0371a745 - Improve and restructure mini timetables, include mini timetable for teachers</li><li>25c3aeaa - Support displaying dates of validity ranges in TimeGridField</li><li>a3c51cfd - Introduce view for regular timetables</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=41789&start_sha=843b18208ae6486a51b31e89758320cbd9be4182)
hansegucker commented 2024-04-12 21:51:40 +02:00 (Migrated from edugit.org)
Copy link

This doesn't work perfect. If you call the URL directly, it won't work.

This doesn't work perfect. If you call the URL directly, it won't work.
hansegucker commented 2024-04-19 18:30:05 +02:00 (Migrated from edugit.org)
Copy link

grafik

grafik

grafik

![grafik](/uploads/15526312cc52f622ed05025e562f4fd7/grafik.png) ![grafik](/uploads/64a7d47a8d99cc817e4730b6d6f2bcb0/grafik.png) ![grafik](/uploads/7946f907cf277486d7ff0715f55e9eb2/grafik.png)
hansegucker commented 2024-04-22 19:56:39 +02:00 (Migrated from edugit.org)
Copy link

added 15 commits

  • a3c51cfd...3a47eb8e - 9 commits from branch master
  • a6c397f2 - Improve and restructure mini timetables, include mini timetable for teachers
  • ce6f8c64 - Support displaying dates of validity ranges in TimeGridField
  • 258c882d - Introduce view for regular timetables
  • e3eed6cc - Fix mobile view for validity range select in timetables
  • ef7b2083 - Add print view for regular timetables
  • bf56787f - Add print button to timetable view

Compare with previous version

added 15 commits <ul><li>a3c51cfd...3a47eb8e - 9 commits from branch <code>master</code></li><li>a6c397f2 - Improve and restructure mini timetables, include mini timetable for teachers</li><li>ce6f8c64 - Support displaying dates of validity ranges in TimeGridField</li><li>258c882d - Introduce view for regular timetables</li><li>e3eed6cc - Fix mobile view for validity range select in timetables</li><li>ef7b2083 - Add print view for regular timetables</li><li>bf56787f - Add print button to timetable view</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=42199&start_sha=a3c51cfd793e7b5b613b168f81111184ae8a9231)
hansegucker commented 2024-04-22 19:58:53 +02:00 (Migrated from edugit.org)
Copy link

requested review from @ZugBahnHof

requested review from @ZugBahnHof
hansegucker commented 2024-04-23 17:20:59 +02:00 (Migrated from edugit.org)
Copy link

~"workflow::blocked" by https://edugit.org/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/347

~"workflow::blocked" by https://edugit.org/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/347
ZugBahnHof commented 2024-04-26 01:48:13 +02:00 (Migrated from edugit.org)
Copy link
```suggestion:-0+0 ```
ZugBahnHof commented 2024-04-26 01:51:05 +02:00 (Migrated from edugit.org)
Copy link

What about a skeleton loader? Users™ are said to respond better to them. But if it is not feasible here, especially as we probably don't have slot info yet etc., a normal circular loader is alright as well

What about a skeleton loader? Users™ are said to respond better to them. But if it is not feasible here, especially as we probably don't have slot info yet etc., a normal circular loader is alright as well
ZugBahnHof commented 2024-04-26 01:52:13 +02:00 (Migrated from edugit.org)
Copy link

If the prop is named the same it should probably be in the supercomponent (but maybe not as it isn't used there, what do you think?)

If the prop is named the same it should probably be in the supercomponent (but maybe not as it isn't used there, what do you think?)
ZugBahnHof commented 2024-04-26 01:53:35 +02:00 (Migrated from edugit.org)
Copy link

what

what
ZugBahnHof commented 2024-04-26 01:59:39 +02:00 (Migrated from edugit.org)
Copy link
  1. I like transitions
  2. Maybe use a <component :is="..."> (probably with keep-alive, as this is right now basically three times the same logical line of code
1. I like transitions 2. Maybe use a `<component :is="...">` (probably with [`keep-alive`](https://v2.vuejs.org/v2/guide/components-dynamic-async#keep-alive-with-Dynamic-Components), as this is right now basically three times the same logical line of code
ZugBahnHof commented 2024-04-26 02:02:02 +02:00 (Migrated from edugit.org)
Copy link

Not sure if this shouldn't rather be a generic action inside the core translations

Not sure if this shouldn't rather be a generic action inside the core translations
ZugBahnHof commented 2024-04-26 02:04:22 +02:00 (Migrated from edugit.org)
Copy link

short_name is not required

short_name is not required
ZugBahnHof commented 2024-04-26 02:04:36 +02:00 (Migrated from edugit.org)
Copy link

at least for persons

at least for persons
ZugBahnHof commented 2024-04-26 02:05:27 +02:00 (Migrated from edugit.org)
Copy link

debug print?

debug print?
ZugBahnHof commented 2024-04-26 02:06:58 +02:00 (Migrated from edugit.org)
Copy link

why is 7 a default?

why is 7 a default?
ZugBahnHof commented 2024-04-26 02:11:26 +02:00 (Migrated from edugit.org)
Copy link

I don't like these types of urls, that execute some action without user confirmation just by visiting the page. Printing a timetable is probably not a dangerous thing, but it can still be something unintended. Imagine you get an email with a seemingly safe and unsuspicious aleksis link and you click it and some data is deleted (I know, that's not the case here).

Also, why do we need this url, can't we do this already some better way with graphql and celery?

I don't like these types of urls, that execute some action without user confirmation just by visiting the page. Printing a timetable is probably not a dangerous thing, but it can still be something unintended. Imagine you get an email with a seemingly safe and unsuspicious aleksis link and you click it and some data is deleted (I know, that's not the case here). Also, why do we need this url, can't we do this already some better way with graphql and celery?
ZugBahnHof commented 2024-04-26 02:13:22 +02:00 (Migrated from edugit.org)
Copy link

you never read the properties of context, so instead of defining them row by row you could just create a context dict with all properties at once

you never read the properties of context, so instead of defining them row by row you could just create a context dict with all properties at once
hansegucker commented 2024-04-26 09:37:59 +02:00 (Migrated from edugit.org)
Copy link

added 8 commits

  • bf56787f...b40146fb - 2 commits from branch master
  • 07e54625 - Improve and restructure mini timetables, include mini timetable for teachers
  • 0409ac29 - Support displaying dates of validity ranges in TimeGridField
  • ba0f1b66 - Introduce view for regular timetables
  • 49149426 - Fix mobile view for validity range select in timetables
  • caa31f34 - Add print view for regular timetables
  • 245fb121 - Add print button to timetable view

Compare with previous version

added 8 commits <ul><li>bf56787f...b40146fb - 2 commits from branch <code>master</code></li><li>07e54625 - Improve and restructure mini timetables, include mini timetable for teachers</li><li>0409ac29 - Support displaying dates of validity ranges in TimeGridField</li><li>ba0f1b66 - Introduce view for regular timetables</li><li>49149426 - Fix mobile view for validity range select in timetables</li><li>caa31f34 - Add print view for regular timetables</li><li>245fb121 - Add print button to timetable view</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=42384&start_sha=bf56787f648fb6a202905fedb44ca9483c0fd88d)
hansegucker commented 2024-04-26 10:19:49 +02:00 (Migrated from edugit.org)
Copy link

This is exactly my argument

This is exactly my argument
hansegucker commented 2024-04-26 10:19:49 +02:00 (Migrated from edugit.org)
Copy link

No, I won't change this in Core.

No, I won't change this in Core.
hansegucker commented 2024-04-26 10:19:50 +02:00 (Migrated from edugit.org)
Copy link

No, there is currently no way to do this with GraphQL. This internally will correctly resolve to a Celery progress page. As this is just a view action, an URL is fine.

No, there is currently no way to do this with GraphQL. This internally will correctly resolve to a Celery progress page. As this is just a view action, an URL is fine.
hansegucker commented 2024-04-26 10:21:34 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=42386&start_sha=245fb121dd085b19197a12fee5934691602238b2#bc9602230bf49f48d7db827e735657d14602b867_27_27)
hansegucker commented 2024-04-26 10:21:36 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=42386&start_sha=245fb121dd085b19197a12fee5934691602238b2#67707c17cfd6d02f037bd11efae226193c88fbed_52_44)
hansegucker commented 2024-04-26 10:21:36 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 71106734 - Remove debug prints

Compare with previous version

added 1 commit <ul><li>71106734 - Remove debug prints</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=42386&start_sha=245fb121dd085b19197a12fee5934691602238b2)
yuha commented 2024-05-08 20:27:21 +02:00 (Migrated from edugit.org)
Copy link

@hansegucker what is the status here?

@hansegucker what is the status here?
hansegucker commented 2024-08-02 21:33:15 +02:00 (Migrated from edugit.org)
Copy link

added 42 commits

  • 71106734...da8b6c2f - 35 commits from branch master
  • c17a003a - Improve and restructure mini timetables, include mini timetable for teachers
  • 54fb4873 - Support displaying dates of validity ranges in TimeGridField
  • d1fa1023 - Introduce view for regular timetables
  • d4de8d39 - Fix mobile view for validity range select in timetables
  • 248d0e7f - Add print view for regular timetables
  • b69acd13 - Add print button to timetable view
  • 3204c261 - Remove debug prints

Compare with previous version

added 42 commits <ul><li>71106734...da8b6c2f - 35 commits from branch <code>master</code></li><li>c17a003a - Improve and restructure mini timetables, include mini timetable for teachers</li><li>54fb4873 - Support displaying dates of validity ranges in TimeGridField</li><li>d1fa1023 - Introduce view for regular timetables</li><li>d4de8d39 - Fix mobile view for validity range select in timetables</li><li>248d0e7f - Add print view for regular timetables</li><li>b69acd13 - Add print button to timetable view</li><li>3204c261 - Remove debug prints</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=46270&start_sha=71106734a1eecc7520c60e5e7c89767e1cf0382a)
yuha commented 2024-11-06 01:42:21 +01:00 (Migrated from edugit.org)
Copy link

FSS kind of needs this. What is the status? As far as I can see, the workflow is not blocked anymore by the mentioned issue in Chronos. @hansegucker

FSS kind of needs this. What is the status? As far as I can see, the workflow is not blocked anymore by the mentioned issue in Chronos. @hansegucker
hansegucker commented 2024-11-07 18:31:23 +01:00 (Migrated from edugit.org)
Copy link

added 71 commits

  • 3204c261...b740e39c - 64 commits from branch master
  • 2a425bbe - Improve and restructure mini timetables, include mini timetable for teachers
  • 13009da2 - Support displaying dates of validity ranges in TimeGridField
  • 34f18aa6 - Introduce view for regular timetables
  • 1a5a39a8 - Fix mobile view for validity range select in timetables
  • 7b2dee32 - Add print view for regular timetables
  • fb4e3f09 - Add print button to timetable view
  • 2e1c62d4 - Remove debug prints

Compare with previous version

added 71 commits <ul><li>3204c261...b740e39c - 64 commits from branch <code>master</code></li><li>2a425bbe - Improve and restructure mini timetables, include mini timetable for teachers</li><li>13009da2 - Support displaying dates of validity ranges in TimeGridField</li><li>34f18aa6 - Introduce view for regular timetables</li><li>1a5a39a8 - Fix mobile view for validity range select in timetables</li><li>7b2dee32 - Add print view for regular timetables</li><li>fb4e3f09 - Add print button to timetable view</li><li>2e1c62d4 - Remove debug prints</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=50165&start_sha=3204c26160e6c0e0d21b782cb38118975dfb5ad1)
hansegucker commented 2024-11-12 23:48:31 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • b49a907d - Fix PDF export

Compare with previous version

added 1 commit <ul><li>b49a907d - Fix PDF export</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=50291&start_sha=2e1c62d480df4d79213314761fb12cd10212077c)
hansegucker commented 2024-11-12 23:50:06 +01:00 (Migrated from edugit.org)
Copy link

Make menu item clearly distinguishable from Chronos menu item

Make menu item clearly distinguishable from Chronos menu item
hansegucker commented 2024-11-25 16:13:01 +01:00 (Migrated from edugit.org)
Copy link

What is this thing with transitions?

What is this thing with transitions?
hansegucker commented 2024-12-29 12:27:06 +01:00 (Migrated from edugit.org)
Copy link

added 159 commits

  • b49a907d...151b9e88 - 151 commits from branch master
  • b7101882 - Improve and restructure mini timetables, include mini timetable for teachers
  • 726e66fe - Support displaying dates of validity ranges in TimeGridField
  • 24244976 - Introduce view for regular timetables
  • 604247f6 - Fix mobile view for validity range select in timetables
  • 502836d4 - Add print view for regular timetables
  • a0e2fe1e - Add print button to timetable view
  • 668c111b - Remove debug prints
  • fc1a3826 - Fix PDF export

Compare with previous version

added 159 commits <ul><li>b49a907d...151b9e88 - 151 commits from branch <code>master</code></li><li>b7101882 - Improve and restructure mini timetables, include mini timetable for teachers</li><li>726e66fe - Support displaying dates of validity ranges in TimeGridField</li><li>24244976 - Introduce view for regular timetables</li><li>604247f6 - Fix mobile view for validity range select in timetables</li><li>502836d4 - Add print view for regular timetables</li><li>a0e2fe1e - Add print button to timetable view</li><li>668c111b - Remove debug prints</li><li>fc1a3826 - Fix PDF export</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=53044&start_sha=b49a907d2547ce4b8e2aebfebfed763bf8aed761)
hansegucker commented 2024-12-29 13:16:43 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • c9c874ce - Fix and update translation (keys)
  • de33dc2d - Update timetable printing for lesson bundles
  • 4dc81d21 - Update changelog

Compare with previous version

added 3 commits <ul><li>c9c874ce - Fix and update translation (keys)</li><li>de33dc2d - Update timetable printing for lesson bundles</li><li>4dc81d21 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=53046&start_sha=fc1a38264fb5eb9f634fd025d7f66f1dc1ccd803)
hansegucker commented 2025-04-12 16:04:56 +02:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2025-04-12 16:13:13 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-04-12 16:14:37 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=59888&start_sha=4dc81d217f6d56cb3f5752f8ea06aa199178c22c#4cb9dc8b3b8f054f3a5c33ee54f3c8d469954037_10_10)
hansegucker commented 2025-04-12 16:14:39 +02:00 (Migrated from edugit.org)
Copy link

added 47 commits

  • 4dc81d21...3566a730 - 45 commits from branch master
  • af5c17d1 - Merge branch 'master' into 46-new-data-model-pdf-export-for-regular-timetable
  • f523066a - Fix some bugs with regular/print timetable

Compare with previous version

added 47 commits <ul><li>4dc81d21...3566a730 - 45 commits from branch <code>master</code></li><li>af5c17d1 - Merge branch &#39;master&#39; into 46-new-data-model-pdf-export-for-regular-timetable</li><li>f523066a - Fix some bugs with regular/print timetable</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/36/diffs?diff_id=59888&start_sha=4dc81d217f6d56cb3f5752f8ea06aa199178c22c)
hansegucker commented 2025-04-12 16:15:16 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker (Migrated from edugit.org) merged commit 14b41932c8 into master 2025-04-12 16:15:20 +02:00
hansegucker commented 2025-04-12 16:15:21 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 14b41932c8

mentioned in commit 14b41932c8fcdc5c71c9f9fdebad2542bf2349f1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Lesrooster!124
No description provided.