aleksis/AlekSIS-App-Lesrooster
8
0
Fork 0
Code Issues 43 Pull requests 3 Projects Releases Packages Activity Actions

Resolve "Improve publishing process of validity ranges" #111

Merged
hansegucker merged 12 commits from 10-improve-publishing-process-of-validity-ranges into master 2024-08-02 21:08:20 +02:00
Conversation 26 Commits 12 Files changed 14 +747 -139
hansegucker commented 2024-01-22 21:45:25 +01:00 (Migrated from edugit.org)
Copy link

Closes #10

Closes #10
hansegucker commented 2024-01-22 21:49:16 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c77547f3 - Sync events on publishing of validity ranges

Compare with previous version

added 1 commit <ul><li>c77547f3 - Sync events on publishing of validity ranges</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=38312&start_sha=f98edca89e8af76ee348c102e5c726053440373d)
hansegucker commented 2024-02-24 15:16:39 +01:00 (Migrated from edugit.org)
Copy link

added 21 commits

  • c77547f3...0f8acffd - 20 commits from branch master
  • 1a314d09 - Sync events on publishing of validity ranges

Compare with previous version

added 21 commits <ul><li>c77547f3...0f8acffd - 20 commits from branch <code>master</code></li><li>1a314d09 - Sync events on publishing of validity ranges</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=39623&start_sha=c77547f3b74e08c4f6f4a20fa014aa708c279ff8)
hansegucker commented 2024-02-28 18:18:36 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • bd57c967 - Improve validation of validity ranges and add tests for it

Compare with previous version

added 1 commit <ul><li>bd57c967 - Improve validation of validity ranges and add tests for it</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=39842&start_sha=1a314d0914e4db19e9325554e02838a1742cddce)
hansegucker commented 2024-02-28 19:12:02 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 0fe2f550 - Fix CI

Compare with previous version

added 1 commit <ul><li>0fe2f550 - Fix CI</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=39849&start_sha=bd57c96799eb49346cac2efb82004e3ab6786280)
hansegucker commented 2024-02-28 19:43:59 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 8767b826 - Add tests for default timegrid and current validity range

Compare with previous version

added 1 commit <ul><li>8767b826 - Add tests for default timegrid and current validity range</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=39851&start_sha=0fe2f550d3cd41f81724487040c8e7a0db61b48a)
hansegucker commented 2024-03-10 15:41:12 +01:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 8767b826...87511023 - 2 commits from branch master
  • dc7925c5 - Sync events on publishing of validity ranges
  • a58dee6e - Improve validation of validity ranges and add tests for it
  • 33af0f7a - Fix CI
  • 6997658e - Add tests for default timegrid and current validity range

Compare with previous version

added 6 commits <ul><li>8767b826...87511023 - 2 commits from branch <code>master</code></li><li>dc7925c5 - Sync events on publishing of validity ranges</li><li>a58dee6e - Improve validation of validity ranges and add tests for it</li><li>33af0f7a - Fix CI</li><li>6997658e - Add tests for default timegrid and current validity range</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=40441&start_sha=8767b826aa72f4f69a5b4222981207fd4b3125dd)
hansegucker commented 2024-03-15 09:57:55 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 257cc5f4 - [CI] Fix reference to test
  • 597bceab - [Validity ranges] Use CRUDList instead of InlineCRUDList, fix filtering and...

Compare with previous version

added 2 commits <ul><li>257cc5f4 - [CI] Fix reference to test</li><li>597bceab - [Validity ranges] Use CRUDList instead of InlineCRUDList, fix filtering and...</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=40636&start_sha=6997658ec8b7aeed0f0c9b36fa1d55f2db9eeb86)
hansegucker commented 2024-03-15 10:00:23 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 54a3bd5a - Introduce task for syncing a published validity range

Compare with previous version

added 1 commit <ul><li>54a3bd5a - Introduce task for syncing a published validity range</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=40637&start_sha=597bceab708459b1538f444f518cd746f5f56041)
hansegucker commented 2024-03-19 21:22:46 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • e3888c3c - Fix status filter for validity ranges
  • 79a9afb0 - Add dedicated button for publishing validity ranges

Compare with previous version

added 2 commits <ul><li>e3888c3c - Fix status filter for validity ranges</li><li>79a9afb0 - Add dedicated button for publishing validity ranges</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=40827&start_sha=54a3bd5a11ce8f3a4355099fe00a375b5b50ad29)
ZugBahnHof commented 2024-03-27 19:09:31 +01:00 (Migrated from edugit.org)
Copy link

Is this ready @hansegucker ?

Is this ready @hansegucker ?
hansegucker commented 2024-03-27 19:31:07 +01:00 (Migrated from edugit.org)
Copy link

No, the validation process still doesn't work due to django-graphene-cud.

No, the validation process still doesn't work due to django-graphene-cud.
hansegucker commented 2024-03-28 17:45:41 +01:00 (Migrated from edugit.org)
Copy link

mentioned in issue #44

mentioned in issue #44
hansegucker commented 2024-04-07 16:10:13 +02:00 (Migrated from edugit.org)
Copy link

Also test sync with empty attributes ...

Also test sync with empty attributes ...
hansegucker commented 2024-04-22 21:13:08 +02:00 (Migrated from edugit.org)
Copy link

added 37 commits

  • 79a9afb0...3a47eb8e - 30 commits from branch master
  • 215cef01 - Sync events on publishing of validity ranges
  • fb0757ba - Improve validation of validity ranges and add tests for it
  • 4d71dff5 - Add tests for default timegrid and current validity range
  • 308e2356 - [Validity ranges] Use CRUDList instead of InlineCRUDList, fix filtering and...
  • 19048262 - Introduce task for syncing a published validity range
  • 159737f3 - Fix status filter for validity ranges
  • 16368cd4 - Add dedicated button for publishing validity ranges

Compare with previous version

added 37 commits <ul><li>79a9afb0...3a47eb8e - 30 commits from branch <code>master</code></li><li>215cef01 - Sync events on publishing of validity ranges</li><li>fb0757ba - Improve validation of validity ranges and add tests for it</li><li>4d71dff5 - Add tests for default timegrid and current validity range</li><li>308e2356 - [Validity ranges] Use CRUDList instead of InlineCRUDList, fix filtering and...</li><li>19048262 - Introduce task for syncing a published validity range</li><li>159737f3 - Fix status filter for validity ranges</li><li>16368cd4 - Add dedicated button for publishing validity ranges</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=42202&start_sha=79a9afb09c91d3b0be449c051a79afaf358f7ffd)
hansegucker commented 2024-04-22 22:26:06 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=42209&start_sha=16368cd4524bdc27fd421c395fcd47c17d23096d#e524660629c47b90fd9df944d188e1a732bcc9f7_115_121)
hansegucker commented 2024-04-22 22:26:07 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 35cc100f - Reformat and fix tests

Compare with previous version

added 1 commit <ul><li>35cc100f - Reformat and fix tests</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=42209&start_sha=16368cd4524bdc27fd421c395fcd47c17d23096d)
hansegucker commented 2024-04-23 17:29:49 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 47506f46 - Fix build_recurrence method to use correct until value
  • 6d1c289f - Extend tests for validity range and syncing
  • 08bf983c - Clear groups if no course is set

Compare with previous version

added 3 commits <ul><li>47506f46 - Fix build_recurrence method to use correct until value</li><li>6d1c289f - Extend tests for validity range and syncing</li><li>08bf983c - Clear groups if no course is set</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=42284&start_sha=35cc100f58d6554f7c7401c12035fdc4d238e1e4)
ZugBahnHof commented 2024-07-04 13:24:29 +02:00 (Migrated from edugit.org)
Copy link

@hansegucker whats the status on this?

@hansegucker whats the status on this?
hansegucker commented 2024-07-04 18:14:54 +02:00 (Migrated from edugit.org)
Copy link

MR in Core not merged yet

MR in Core not merged yet
hansegucker commented 2024-07-21 13:47:26 +02:00 (Migrated from edugit.org)
Copy link

added 33 commits

  • 08bf983c...f6a1ead7 - 22 commits from branch master
  • 878f8193 - 1 earlier commit
  • d6654a66 - Improve validation of validity ranges and add tests for it
  • c97c282d - Add tests for default timegrid and current validity range
  • e744eba5 - [Validity ranges] Use CRUDList instead of InlineCRUDList, fix filtering and...
  • 83097ee2 - Introduce task for syncing a published validity range
  • 1f2ee1bc - Fix status filter for validity ranges
  • 29309413 - Add dedicated button for publishing validity ranges
  • 3782e520 - Reformat and fix tests
  • 0a81bd77 - Fix build_recurrence method to use correct until value
  • 722795d2 - Extend tests for validity range and syncing
  • f65733e1 - Clear groups if no course is set

Compare with previous version

added 33 commits <ul><li>08bf983c...f6a1ead7 - 22 commits from branch <code>master</code></li><li>878f8193 - 1 earlier commit</li><li>d6654a66 - Improve validation of validity ranges and add tests for it</li><li>c97c282d - Add tests for default timegrid and current validity range</li><li>e744eba5 - [Validity ranges] Use CRUDList instead of InlineCRUDList, fix filtering and...</li><li>83097ee2 - Introduce task for syncing a published validity range</li><li>1f2ee1bc - Fix status filter for validity ranges</li><li>29309413 - Add dedicated button for publishing validity ranges</li><li>3782e520 - Reformat and fix tests</li><li>0a81bd77 - Fix build_recurrence method to use correct until value</li><li>722795d2 - Extend tests for validity range and syncing</li><li>f65733e1 - Clear groups if no course is set</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=45673&start_sha=08bf983c2e61718491ee9fc92ded5dcb50780bff)
hansegucker commented 2024-07-21 17:35:13 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 1bc1f933 - Fix some bugs with publishing and changing of validity ranges

Compare with previous version

added 1 commit <ul><li>1bc1f933 - Fix some bugs with publishing and changing of validity ranges</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Lesrooster/-/merge_requests/23/diffs?diff_id=45686&start_sha=f65733e1c91357b5a79da66af99e7c97d5386b97)
hansegucker commented 2024-07-21 17:35:40 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-07-21 17:36:17 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-07-21 17:36:25 +02:00 (Migrated from edugit.org)
Copy link

assigned to @nik

assigned to @nik
hansegucker commented 2024-07-21 17:36:32 +02:00 (Migrated from edugit.org)
Copy link

requested review from @ZugBahnHof

requested review from @ZugBahnHof
hansegucker (Migrated from edugit.org) merged commit da8b6c2f33 into master 2024-08-02 21:08:20 +02:00
hansegucker commented 2024-08-02 21:08:21 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit da8b6c2f33

mentioned in commit da8b6c2f332beca8cafc02fdd6483c7a99195fd6
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Lesrooster!111
No description provided.