WIP: Draft: Read an write from and to LDAP based on MappingSets #167
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
aleksis/AlekSIS-App-LDAP!167
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "43-write-attrs-to-ldap"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #43
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 2 commits
Compare with previous version
added 3 commits
Compare with previous version
added 2 commits
Compare with previous version
added 4 commits
0b510097- Create mapping modelsCompare with previous version
added 2 commits
Compare with previous version
added 2 commits
Compare with previous version
added 3 commits
Compare with previous version
added 3 commits
Compare with previous version
added 4 commits
a139ec8d- Implement LDAP readb449326d- Implement LDAP write for new objectsd17cf33d- Implement LDAP write for existing objectscb77c8af- Split up functionsCompare with previous version
added 1 commit
583b9a86- Implement rename operation and optimize codeCompare with previous version
added 2 commits
Compare with previous version
Missing doc string
Missing doc string.
Why do we introduce Jinja2?
Is this always correct? I imagine we might get a
valuethat is already a bytes-like object...Missing doc string.
Rather, add a class method to
LDAPMappingSetandLDAPFieldMappingcalledget_for_model(etc.) that goes through the content types framework and retrieves the ContentType. Please mimic theContentTypeAPI as closely as possible doing so.Missing doc string.
Please use parantheses do make that expression more readable.
Shouldn't this be validated in the model?
Please use the Django template engine rather than Jinja 2 (or provide a good reason why we should introduce another template language).
Please move these lines out of the
withblock. Only code that needs the temporary context should be wrapped to not hide unrelated exceptions.Your function is called
get_ldap_object(singular), but it looks like it returns a list. Please decide.readfromsomething, so I proposeread_model_from_ldapMissing doc string.
Same as above, please use Django Templates, or justify the introduction of Jinja.
That looks like one big
withblock! Please restructure this to only wrap the code that uses the bind.changed this line in version 16 of the diff
added 1 commit
0a89cae1- Prepare timestamp-based updateCompare with previous version
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
changed this line in version 17 of the diff
added 8 commits
41deb87f- Use Django's template engineafabc832- Move code out of with blocksad6d2e96- Rename function to match its purpose6c2eaae8- Create class methods for getting MappingSets and MappingFieldsc2808cae- Remove unnecessary else blockbffa2799- Rename read function3ff3abf5- Clarify if statements9bdbbfd1- Add docstringsCompare with previous version
added 1 commit
ae616320- Support non-ExtensibleModels and subfieldsCompare with previous version
added 1 commit
075aca95- Fix linterCompare with previous version
added 1 commit
8ed3cdf1- Make regex optional to allow special casesCompare with previous version
added 1 commit
Compare with previous version
changed title from Draft: {-Implement LDAP user creation-} to Draft: {+Read an write from and to LDAP based on MappingSets+}
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
8450db27- Make template optional and support write of FileFieldCompare with previous version
added 1 commit
Compare with previous version
added 2 commits
f7740b64- Do not write empty fields to LDAPCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 4 commits
Compare with previous version
added 6 commits
4f6d3060- Convert LDAP datetime to Django DateTimeFieldCompare with previous version
added 5 commits
f9b7310b- Fix creation of new objects from LDAPcf92fec1- Fix setattr for related fields650a2fce- Fix null modlist error4824a6c2- Fix to_ldap conversion of non-string objectscd15f1a0- Convert DateField to LDAP valueCompare with previous version
added 1 commit
cdb0dfd1- Add utility method for resolving model field pathsCompare with previous version
added 1 commit
902e6f50- Fix utility functionCompare with previous version
added 1 commit
060ffc86- Add utility function to recursively resolve model fieldCompare with previous version
added 6 commits
193b1b8e- Fix utility functionsb4f8348f- Use new utility function9c3f9356- Remove unnecessary variablesab0f3e33- Make code more readable93dd9881- Refactor LDAP conversion3eac5567- Implement m2m syncCompare with previous version
added 1 commit
722bba64- Fix Core dependencyCompare with previous version
Please merge this migration into 0002.
Please merge this migration into 0002.
Why do we import this here?
changed this line in version 39 of the diff
changed this line in version 39 of the diff
changed this line in version 39 of the diff
added 2 commits
96a82df7- Merge migrationsCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
923b6627- Move imports out of functionCompare with previous version
added 2 commits
5b082684- Explain new LDAP syncing code7bfa238c- Remove old dynamic preferences codeCompare with previous version
added 2 commits
d8e2716d- Use new utility function instead of relying on syncable fields1bbf46b6- Fix invalid template usageCompare with previous version
added 1 commit
d242c3eb- Implement user creationCompare with previous version
This is not the initial migration, despite its name...
added 4 commits
14277ec7- Add pool attributes70a4a35d- Move re-usable code into function1d4dea69- Fix template-based LDAP writing59a8b65a- Implement LDAP poolCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 2 commits
Compare with previous version
changed this line in version 49 of the diff
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 2 commits
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 7 commits
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 9 commits
Compare with previous version
added 10 commits
a25e843f- Introduce LDAP MappingSet/FieldMapping frontend90b6d4b7- Make second migration non-initial58cc858d- Auto-sync models on changeseefdaaf6- Fix migrations on new databases37d3e5d7- Fix sync on login and account creation53c98cf8- Implement bool sync361cb4d4- Fix m2m sync9f05e349- Catch errors on LDAP writea5b8ac57- Allow empty read_regexa9bd3145- Use new generic attributesCompare with previous version
added 3 commits
d3cf9dde- Rename MappingSet batch patch mutation to batch mutation6de52b88- Set title for MappingSet creating DialogObjectForm5aaea3d9- Pass I18n keys needed to DialogObjectForm in order to show snackbar on save successCompare with previous version
added 1 commit
52648e30- Add required rules to some FieldMapping fieldsCompare with previous version
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.