WIP: Draft: Read an write from and to LDAP based on MappingSets #167

Draft
magicfelix wants to merge 61 commits from 43-write-attrs-to-ldap into master
magicfelix commented 2022-10-22 15:26:43 +02:00 (Migrated from edugit.org)

Closes #43

Closes #43
magicfelix commented 2022-10-22 18:53:04 +02:00 (Migrated from edugit.org)

added 1 commit

  • 8bdd5d4f - Create mapping models

Compare with previous version

added 1 commit <ul><li>8bdd5d4f - Create mapping models</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=24857&start_sha=2d811ac6562e254553aeaf37a32686d3c135154c)
magicfelix commented 2022-10-27 21:47:34 +02:00 (Migrated from edugit.org)

added 1 commit

  • 37a3f5bc - Implement LDAP-read mapping

Compare with previous version

added 1 commit <ul><li>37a3f5bc - Implement LDAP-read mapping</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25012&start_sha=8bdd5d4f81fcf1446eb3f65773d1818304d52d49)
magicfelix commented 2022-10-28 21:42:13 +02:00 (Migrated from edugit.org)

added 1 commit

  • 22e5b023 - Implement LDAP-read mapping

Compare with previous version

added 1 commit <ul><li>22e5b023 - Implement LDAP-read mapping</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25019&start_sha=37a3f5bc626a5960cc9121ec7b94b6a1f370e158)
magicfelix commented 2022-11-04 20:19:37 +01:00 (Migrated from edugit.org)

added 2 commits

  • 8ea0d9fb - Create mapping models
  • ec5b4bab - Implement LDAP-read mapping

Compare with previous version

added 2 commits <ul><li>8ea0d9fb - Create mapping models</li><li>ec5b4bab - Implement LDAP-read mapping</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25170&start_sha=22e5b023d76e858131bff26ec9d14bb2f6a3aeb7)
magicfelix commented 2022-11-04 23:16:15 +01:00 (Migrated from edugit.org)

added 3 commits

  • fbca4e87 - Create mapping models
  • ea5b4dac - Implement LDAP read
  • 32434aef - Implement LDAP write for new objects

Compare with previous version

added 3 commits <ul><li>fbca4e87 - Create mapping models</li><li>ea5b4dac - Implement LDAP read</li><li>32434aef - Implement LDAP write for new objects</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25202&start_sha=ec5b4babadf85250c1c898099e8cce7ae65040ff)
magicfelix commented 2022-11-05 20:24:51 +01:00 (Migrated from edugit.org)

added 2 commits

  • e416b991 - Implement LDAP write for new objects
  • f147c4a4 - Implement LDAP write for existing objects

Compare with previous version

added 2 commits <ul><li>e416b991 - Implement LDAP write for new objects</li><li>f147c4a4 - Implement LDAP write for existing objects</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25218&start_sha=32434aeffdfbbd44aeb56ec17c8354e69eb3fc2b)
magicfelix commented 2022-11-05 20:42:01 +01:00 (Migrated from edugit.org)

added 4 commits

  • 0b510097 - Create mapping models
  • 24cfccce - Implement LDAP read
  • f427384b - Implement LDAP write for new objects
  • 1621a78d - Implement LDAP write for existing objects

Compare with previous version

added 4 commits <ul><li>0b510097 - Create mapping models</li><li>24cfccce - Implement LDAP read</li><li>f427384b - Implement LDAP write for new objects</li><li>1621a78d - Implement LDAP write for existing objects</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25220&start_sha=f147c4a4839dfb78fa679434fed6c3ff8dc0ee32)
magicfelix commented 2022-11-05 23:15:31 +01:00 (Migrated from edugit.org)

added 2 commits

  • 16c269af - Implement LDAP write for new objects
  • 923d93ec - Implement LDAP write for existing objects

Compare with previous version

added 2 commits <ul><li>16c269af - Implement LDAP write for new objects</li><li>923d93ec - Implement LDAP write for existing objects</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25230&start_sha=1621a78d72cb8dfdcd9949846d294b983d5d0e74)
magicfelix commented 2022-11-05 23:27:35 +01:00 (Migrated from edugit.org)

added 2 commits

  • 56e4b6c1 - Implement LDAP write for new objects
  • 26654e69 - Implement LDAP write for existing objects

Compare with previous version

added 2 commits <ul><li>56e4b6c1 - Implement LDAP write for new objects</li><li>26654e69 - Implement LDAP write for existing objects</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25232&start_sha=923d93ecf601f08f34a5c849dcac861a44289c7a)
magicfelix commented 2022-11-08 18:45:00 +01:00 (Migrated from edugit.org)

added 3 commits

  • 058e245d - Implement LDAP read
  • 0fe10951 - Implement LDAP write for new objects
  • e6a29afb - Implement LDAP write for existing objects

Compare with previous version

added 3 commits <ul><li>058e245d - Implement LDAP read</li><li>0fe10951 - Implement LDAP write for new objects</li><li>e6a29afb - Implement LDAP write for existing objects</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25268&start_sha=26654e694ff4fda3523d8d7b583d0fdaf7ba9d3c)
magicfelix commented 2022-11-11 21:08:27 +01:00 (Migrated from edugit.org)

added 3 commits

  • bab661a1 - Implement LDAP read
  • 5dd664b6 - Implement LDAP write for new objects
  • 14e70413 - Implement LDAP write for existing objects

Compare with previous version

added 3 commits <ul><li>bab661a1 - Implement LDAP read</li><li>5dd664b6 - Implement LDAP write for new objects</li><li>14e70413 - Implement LDAP write for existing objects</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25333&start_sha=e6a29afbda6fde18c31a260a0b129cb0ca9f822b)
magicfelix commented 2022-11-12 22:46:40 +01:00 (Migrated from edugit.org)

added 4 commits

Compare with previous version

added 4 commits <ul><li>a139ec8d - Implement LDAP read</li><li>b449326d - Implement LDAP write for new objects</li><li>d17cf33d - Implement LDAP write for existing objects</li><li>cb77c8af - Split up functions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25344&start_sha=14e70413705102838a8197f18e418712d1f63326)
magicfelix commented 2022-11-14 17:18:28 +01:00 (Migrated from edugit.org)

added 1 commit

  • 583b9a86 - Implement rename operation and optimize code

Compare with previous version

added 1 commit <ul><li>583b9a86 - Implement rename operation and optimize code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25353&start_sha=cb77c8aff1fe0fcc33e4a7aac84dd6cfbf936e43)
magicfelix commented 2022-11-17 22:01:37 +01:00 (Migrated from edugit.org)

added 2 commits

  • c73208e0 - Prepare timestamp-based update
  • 58ba8f61 - Prepare special FieldType fix

Compare with previous version

added 2 commits <ul><li>c73208e0 - Prepare timestamp-based update</li><li>58ba8f61 - Prepare special FieldType fix</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25475&start_sha=583b9a86b70d97af2afe365eb75c193a503958bc)
nik commented 2022-11-19 16:00:37 +01:00 (Migrated from edugit.org)

Missing doc string

Missing doc string
nik commented 2022-11-19 16:00:38 +01:00 (Migrated from edugit.org)

Missing doc string.

Missing doc string.
nik commented 2022-11-19 16:00:38 +01:00 (Migrated from edugit.org)

Why do we introduce Jinja2?

Why do we introduce Jinja2?
nik commented 2022-11-19 16:00:38 +01:00 (Migrated from edugit.org)

Is this always correct? I imagine we might get a value that is already a bytes-like object...

Is this always correct? I imagine we might get a `value` that is already a bytes-like object...
nik commented 2022-11-19 16:00:39 +01:00 (Migrated from edugit.org)

Missing doc string.

Missing doc string.
nik commented 2022-11-19 16:00:39 +01:00 (Migrated from edugit.org)

Rather, add a class method to LDAPMappingSet and LDAPFieldMapping called get_for_model (etc.) that goes through the content types framework and retrieves the ContentType. Please mimic the ContentType API as closely as possible doing so.

Rather, add a class method to `LDAPMappingSet` and `LDAPFieldMapping` called `get_for_model` (etc.) that goes through the content types framework and retrieves the ContentType. Please mimic the `ContentType` API as closely as possible doing so.
nik commented 2022-11-19 16:00:40 +01:00 (Migrated from edugit.org)

Missing doc string.

Missing doc string.
nik commented 2022-11-19 16:00:40 +01:00 (Migrated from edugit.org)

Please use parantheses do make that expression more readable.

Please use parantheses do make that expression more readable.
nik commented 2022-11-19 16:00:41 +01:00 (Migrated from edugit.org)

Shouldn't this be validated in the model?

Shouldn't this be validated in the model?
nik commented 2022-11-19 16:00:43 +01:00 (Migrated from edugit.org)

Please use the Django template engine rather than Jinja 2 (or provide a good reason why we should introduce another template language).

Please use the Django template engine rather than Jinja 2 (or provide a good reason why we should introduce another template language).
nik commented 2022-11-19 16:00:44 +01:00 (Migrated from edugit.org)

Please move these lines out of the with block. Only code that needs the temporary context should be wrapped to not hide unrelated exceptions.

Please move these lines out of the `with` block. Only code that needs the temporary context should be wrapped to not hide unrelated exceptions.
nik commented 2022-11-19 16:00:45 +01:00 (Migrated from edugit.org)

Your function is called get_ldap_object (singular), but it looks like it returns a list. Please decide.

Your function is called `get_ldap_object` (singular), but it looks like it returns a list. Please decide.
nik commented 2022-11-19 16:00:46 +01:00 (Migrated from edugit.org)
  • Missing doc string
  • The name is unusual. Normally, you always read from something, so I propose read_model_from_ldap
* Missing doc string * The name is unusual. Normally, you always `read` `from` something, so I propose `read_model_from_ldap`
nik commented 2022-11-19 16:00:47 +01:00 (Migrated from edugit.org)

Missing doc string.

Missing doc string.
nik commented 2022-11-19 16:00:48 +01:00 (Migrated from edugit.org)

Same as above, please use Django Templates, or justify the introduction of Jinja.

Same as above, please use Django Templates, or justify the introduction of Jinja.
nik commented 2022-11-19 16:00:48 +01:00 (Migrated from edugit.org)

That looks like one big with block! Please restructure this to only wrap the code that uses the bind.

That looks like one big `with` block! Please restructure this to only wrap the code that uses the bind.
magicfelix commented 2022-11-19 16:05:39 +01:00 (Migrated from edugit.org)

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25494&start_sha=58ba8f61cb583d65b93afa947d8e6584426ff5ea#c33d3bebee06aec596b3ba501d9b4cbb66047970_63_63)
magicfelix commented 2022-11-19 16:05:44 +01:00 (Migrated from edugit.org)

added 1 commit

  • 0a89cae1 - Prepare timestamp-based update

Compare with previous version

added 1 commit <ul><li>0a89cae1 - Prepare timestamp-based update</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25494&start_sha=58ba8f61cb583d65b93afa947d8e6584426ff5ea)
magicfelix commented 2022-11-19 17:32:39 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_18_19)
magicfelix commented 2022-11-19 17:32:44 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_153_153)
magicfelix commented 2022-11-19 17:32:47 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_161_153)
magicfelix commented 2022-11-19 17:32:47 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_166_158)
magicfelix commented 2022-11-19 17:32:47 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_167_158)
magicfelix commented 2022-11-19 17:32:48 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_173_163)
magicfelix commented 2022-11-19 17:32:48 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_175_163)
magicfelix commented 2022-11-19 17:32:49 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_192_182)
magicfelix commented 2022-11-19 17:32:49 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_198_187)
magicfelix commented 2022-11-19 17:32:49 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_260_256)
magicfelix commented 2022-11-19 17:32:50 +01:00 (Migrated from edugit.org)

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90#c33d3bebee06aec596b3ba501d9b4cbb66047970_272_268)
magicfelix commented 2022-11-19 17:32:50 +01:00 (Migrated from edugit.org)

added 8 commits

  • 41deb87f - Use Django's template engine
  • afabc832 - Move code out of with blocks
  • ad6d2e96 - Rename function to match its purpose
  • 6c2eaae8 - Create class methods for getting MappingSets and MappingFields
  • c2808cae - Remove unnecessary else block
  • bffa2799 - Rename read function
  • 3ff3abf5 - Clarify if statements
  • 9bdbbfd1 - Add docstrings

Compare with previous version

added 8 commits <ul><li>41deb87f - Use Django&#39;s template engine</li><li>afabc832 - Move code out of with blocks</li><li>ad6d2e96 - Rename function to match its purpose</li><li>6c2eaae8 - Create class methods for getting MappingSets and MappingFields</li><li>c2808cae - Remove unnecessary else block</li><li>bffa2799 - Rename read function</li><li>3ff3abf5 - Clarify if statements</li><li>9bdbbfd1 - Add docstrings</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25496&start_sha=0a89cae1d499f54dd1275071fbbb5f2ddcd37c90)
magicfelix commented 2022-11-21 21:38:52 +01:00 (Migrated from edugit.org)

added 1 commit

  • ae616320 - Support non-ExtensibleModels and subfields

Compare with previous version

added 1 commit <ul><li>ae616320 - Support non-ExtensibleModels and subfields</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25521&start_sha=9bdbbfd123d1bd1977a5b87894aaf16f6ff6901e)
magicfelix commented 2022-11-21 22:11:26 +01:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>075aca95 - Fix linter</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25526&start_sha=ae616320ca91bdd8808e4411c1cf2c8697c1b92f)
magicfelix commented 2022-11-24 21:22:26 +01:00 (Migrated from edugit.org)

added 1 commit

  • 8ed3cdf1 - Make regex optional to allow special cases

Compare with previous version

added 1 commit <ul><li>8ed3cdf1 - Make regex optional to allow special cases</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25644&start_sha=075aca95bf2cbaa560370588b1d3795ab33cd21b)
magicfelix commented 2022-11-26 15:16:13 +01:00 (Migrated from edugit.org)

added 1 commit

  • 5e55fef1 - Make template optional and support write of FileField

Compare with previous version

added 1 commit <ul><li>5e55fef1 - Make template optional and support write of FileField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25676&start_sha=8ed3cdf16119d9b7492c7cc4522d20e21c703574)
magicfelix commented 2022-11-26 17:07:23 +01:00 (Migrated from edugit.org)

changed title from Draft: {-Implement LDAP user creation-} to Draft: {+Read an write from and to LDAP based on MappingSets+}

changed title from **Draft: {-Implement LDAP user creation-}** to **Draft: {+Read an write from and to LDAP based on MappingSets+}**
magicfelix commented 2022-11-26 17:08:33 +01:00 (Migrated from edugit.org)

added 1 commit

  • 30cf0f58 - Make template optional and support write of FileField

Compare with previous version

added 1 commit <ul><li>30cf0f58 - Make template optional and support write of FileField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25679&start_sha=5e55fef18c4147b4cbc438ead46f18a619f2e6a0)
magicfelix commented 2022-11-26 18:38:55 +01:00 (Migrated from edugit.org)

added 1 commit

  • cbd65771 - Make template optional and support write of FileField

Compare with previous version

added 1 commit <ul><li>cbd65771 - Make template optional and support write of FileField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25682&start_sha=30cf0f58b467ce359061d85cd0cb54685a947b6d)
magicfelix commented 2022-11-26 19:07:15 +01:00 (Migrated from edugit.org)

added 1 commit

  • b11454aa - Make template optional and support write of FileField

Compare with previous version

added 1 commit <ul><li>b11454aa - Make template optional and support write of FileField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25685&start_sha=cbd6577119dde82172b1522584bb7d574411a43f)
magicfelix commented 2022-11-26 20:43:07 +01:00 (Migrated from edugit.org)

added 1 commit

  • 49498437 - Make template optional and support write of FileField

Compare with previous version

added 1 commit <ul><li>49498437 - Make template optional and support write of FileField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25687&start_sha=b11454aafedd21a3e88390bc607268ead91c7fa6)
magicfelix commented 2022-11-26 21:31:39 +01:00 (Migrated from edugit.org)

added 1 commit

  • 8450db27 - Make template optional and support write of FileField

Compare with previous version

added 1 commit <ul><li>8450db27 - Make template optional and support write of FileField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25689&start_sha=494984372933f1a0da6cb497b78115026bac9b2e)
magicfelix commented 2022-12-08 19:00:50 +01:00 (Migrated from edugit.org)

added 1 commit

  • 39df601c - Do not write empty fields to LDAP

Compare with previous version

added 1 commit <ul><li>39df601c - Do not write empty fields to LDAP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25851&start_sha=8450db274bc19146d5095c0f3571570c6cc868d8)
magicfelix commented 2022-12-13 22:07:41 +01:00 (Migrated from edugit.org)

added 2 commits

  • f7740b64 - Do not write empty fields to LDAP
  • 26551867 - Convert LDAP datetime to Django DateTimeField

Compare with previous version

added 2 commits <ul><li>f7740b64 - Do not write empty fields to LDAP</li><li>26551867 - Convert LDAP datetime to Django DateTimeField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=25896&start_sha=39df601c321f8d4e99846bcc4b6986de99ea1ad0)
magicfelix commented 2022-12-23 20:31:18 +01:00 (Migrated from edugit.org)

added 1 commit

  • 107832fb - Fix creation of new objects from LDAP

Compare with previous version

added 1 commit <ul><li>107832fb - Fix creation of new objects from LDAP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26424&start_sha=265518670edb46b37b8380a5ab22e7870759d44a)
magicfelix commented 2022-12-28 12:23:51 +01:00 (Migrated from edugit.org)

added 1 commit

  • 7933d463 - Fix setattr for related fields

Compare with previous version

added 1 commit <ul><li>7933d463 - Fix setattr for related fields</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26445&start_sha=107832fb8ace5c4c6bbe975746371f30b02d243c)
magicfelix commented 2022-12-28 14:59:33 +01:00 (Migrated from edugit.org)

added 4 commits

  • 751246e7 - Fix setattr for related fields
  • 77d309e6 - Fix null modlist error
  • 8ae4a58c - Fix to_ldap conversion of non-string objects
  • 11955e85 - Convert DateField to LDAP value

Compare with previous version

added 4 commits <ul><li>751246e7 - Fix setattr for related fields</li><li>77d309e6 - Fix null modlist error</li><li>8ae4a58c - Fix to_ldap conversion of non-string objects</li><li>11955e85 - Convert DateField to LDAP value</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26446&start_sha=7933d4635a77ccd32dfa73c761f9a84be2fea0e6)
magicfelix commented 2022-12-28 15:14:47 +01:00 (Migrated from edugit.org)

added 6 commits

  • 4f6d3060 - Convert LDAP datetime to Django DateTimeField
  • 4bfa8c11 - Fix creation of new objects from LDAP
  • cd494762 - Fix setattr for related fields
  • defdf6f7 - Fix null modlist error
  • dab7f001 - Fix to_ldap conversion of non-string objects
  • 84818fc0 - Convert DateField to LDAP value

Compare with previous version

added 6 commits <ul><li>4f6d3060 - Convert LDAP datetime to Django DateTimeField</li><li>4bfa8c11 - Fix creation of new objects from LDAP</li><li>cd494762 - Fix setattr for related fields</li><li>defdf6f7 - Fix null modlist error</li><li>dab7f001 - Fix to_ldap conversion of non-string objects</li><li>84818fc0 - Convert DateField to LDAP value</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26447&start_sha=11955e85a37a5723b2af27d396e907f0c922818c)
magicfelix commented 2022-12-28 16:31:21 +01:00 (Migrated from edugit.org)

added 5 commits

  • f9b7310b - Fix creation of new objects from LDAP
  • cf92fec1 - Fix setattr for related fields
  • 650a2fce - Fix null modlist error
  • 4824a6c2 - Fix to_ldap conversion of non-string objects
  • cd15f1a0 - Convert DateField to LDAP value

Compare with previous version

added 5 commits <ul><li>f9b7310b - Fix creation of new objects from LDAP</li><li>cf92fec1 - Fix setattr for related fields</li><li>650a2fce - Fix null modlist error</li><li>4824a6c2 - Fix to_ldap conversion of non-string objects</li><li>cd15f1a0 - Convert DateField to LDAP value</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26448&start_sha=84818fc05f69c41af85ba2095495518bf16b4a24)
nik commented 2022-12-30 14:48:32 +01:00 (Migrated from edugit.org)

added 1 commit

  • cdb0dfd1 - Add utility method for resolving model field paths

Compare with previous version

added 1 commit <ul><li>cdb0dfd1 - Add utility method for resolving model field paths</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26504&start_sha=cd15f1a0928559a7937b7489b3736bc44a844b4b)
magicfelix commented 2022-12-30 16:25:57 +01:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>902e6f50 - Fix utility function</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26506&start_sha=cdb0dfd172941b37f2441ad6ec2ba6c3342b22c1)
nik commented 2022-12-30 17:04:03 +01:00 (Migrated from edugit.org)

added 1 commit

  • 060ffc86 - Add utility function to recursively resolve model field

Compare with previous version

added 1 commit <ul><li>060ffc86 - Add utility function to recursively resolve model field</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26507&start_sha=902e6f50a3742a0d36d30e4714cfc5a48e7409a1)
magicfelix commented 2022-12-31 00:19:43 +01:00 (Migrated from edugit.org)

added 6 commits

Compare with previous version

added 6 commits <ul><li>193b1b8e - Fix utility functions</li><li>b4f8348f - Use new utility function</li><li>9c3f9356 - Remove unnecessary variables</li><li>ab0f3e33 - Make code more readable</li><li>93dd9881 - Refactor LDAP conversion</li><li>3eac5567 - Implement m2m sync</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26512&start_sha=060ffc867cbf71ee652891d5503d8b5e6a274935)
magicfelix commented 2022-12-31 00:26:25 +01:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>722bba64 - Fix Core dependency</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=26514&start_sha=3eac5567f716689c0e862e19a7d3d8b9fe342cf7)
nik commented 2023-01-24 13:11:43 +01:00 (Migrated from edugit.org)

Please merge this migration into 0002.

Please merge this migration into 0002.
nik commented 2023-01-24 13:11:43 +01:00 (Migrated from edugit.org)

Please merge this migration into 0002.

Please merge this migration into 0002.
nik commented 2023-01-24 13:11:44 +01:00 (Migrated from edugit.org)

Why do we import this here?

Why do we import this here?
magicfelix commented 2023-01-24 19:35:24 +01:00 (Migrated from edugit.org)

changed this line in version 39 of the diff

changed this line in [version 39 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=27144&start_sha=722bba6433ae8f160e438b33b167ad6594ebde48#7288e99c4433e30226607b57f5c99c0e919f2a07_1_0)
magicfelix commented 2023-01-24 19:35:25 +01:00 (Migrated from edugit.org)

changed this line in version 39 of the diff

changed this line in [version 39 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=27144&start_sha=722bba6433ae8f160e438b33b167ad6594ebde48#5d3f5ae82fa5cdacace707f698a129f7aae533a5_1_0)
magicfelix commented 2023-01-24 19:35:25 +01:00 (Migrated from edugit.org)

changed this line in version 39 of the diff

changed this line in [version 39 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=27144&start_sha=722bba6433ae8f160e438b33b167ad6594ebde48#c33d3bebee06aec596b3ba501d9b4cbb66047970_159_160)
magicfelix commented 2023-01-24 19:35:26 +01:00 (Migrated from edugit.org)

added 2 commits

  • 96a82df7 - Merge migrations
  • bcfdb16c - Move import out of function

Compare with previous version

added 2 commits <ul><li>96a82df7 - Merge migrations</li><li>bcfdb16c - Move import out of function</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=27144&start_sha=722bba6433ae8f160e438b33b167ad6594ebde48)
magicfelix commented 2023-01-24 19:42:35 +01:00 (Migrated from edugit.org)

added 1 commit

  • 098cce7c - Move imports out of function

Compare with previous version

added 1 commit <ul><li>098cce7c - Move imports out of function</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=27146&start_sha=bcfdb16c43c6640fff5bbe743fbdaffcf52a32f8)
magicfelix commented 2023-01-24 19:45:22 +01:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>923b6627 - Move imports out of function</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=27147&start_sha=098cce7c1c894bdbe3d60643993427c43a75fafb)
nik commented 2023-01-24 20:48:26 +01:00 (Migrated from edugit.org)

added 2 commits

  • 5b082684 - Explain new LDAP syncing code
  • 7bfa238c - Remove old dynamic preferences code

Compare with previous version

added 2 commits <ul><li>5b082684 - Explain new LDAP syncing code</li><li>7bfa238c - Remove old dynamic preferences code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=27152&start_sha=923b6627d35e31d327f6104861b145dea387e2f3)
magicfelix commented 2023-01-24 21:28:13 +01:00 (Migrated from edugit.org)

added 2 commits

  • d8e2716d - Use new utility function instead of relying on syncable fields
  • 1bbf46b6 - Fix invalid template usage

Compare with previous version

added 2 commits <ul><li>d8e2716d - Use new utility function instead of relying on syncable fields</li><li>1bbf46b6 - Fix invalid template usage</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=27158&start_sha=7bfa238c550b185b86c8092ae4e116b47c04a524)
magicfelix commented 2023-03-20 21:10:24 +01:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>d242c3eb - Implement user creation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=28869&start_sha=1bbf46b62abe5ca3603f934de2619b2897e8c1f3)
nik commented 2023-03-27 14:19:30 +02:00 (Migrated from edugit.org)

This is not the initial migration, despite its name...

This is not the initial migration, despite its name...
magicfelix commented 2023-03-27 15:20:42 +02:00 (Migrated from edugit.org)

added 4 commits

Compare with previous version

added 4 commits <ul><li>14277ec7 - Add pool attributes</li><li>70a4a35d - Move re-usable code into function</li><li>1d4dea69 - Fix template-based LDAP writing</li><li>59a8b65a - Implement LDAP pool</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29002&start_sha=d242c3eb42b979d8efe51b622da3faf7732dabe1)
yuha commented 2023-03-29 01:40:37 +02:00 (Migrated from edugit.org)

added 1 commit

  • 58e6278d - WIP: LDAP mapping frontend

Compare with previous version

added 1 commit <ul><li>58e6278d - WIP: LDAP mapping frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29018&start_sha=59a8b65a6b19e8ee4fd08f7d99e282e3f3153946)
yuha commented 2023-04-03 16:07:38 +02:00 (Migrated from edugit.org)

added 1 commit

  • d6c43f06 - Re-implement data table with new generic data table from core

Compare with previous version

added 1 commit <ul><li>d6c43f06 - Re-implement data table with new generic data table from core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29067&start_sha=58e6278d0504c44ca9363df034dd533a15769e93)
yuha commented 2023-04-03 16:33:01 +02:00 (Migrated from edugit.org)

added 2 commits

  • 303fc606 - Re-implement data table with new generic data table from core
  • 75196d62 - WIP frontend

Compare with previous version

added 2 commits <ul><li>303fc606 - Re-implement data table with new generic data table from core</li><li>75196d62 - WIP frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29075&start_sha=d6c43f06eaf8b2346582e21e52e8b570d5325b13)
magicfelix commented 2023-04-03 17:06:37 +02:00 (Migrated from edugit.org)

changed this line in version 49 of the diff

changed this line in [version 49 of the diff](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29081&start_sha=75196d62a8c0886dd512fbac74432b1a39e980ed#d95f059afd888b6b7ca9416a7341511889cd1cd9_11_0)
magicfelix commented 2023-04-03 17:06:38 +02:00 (Migrated from edugit.org)

added 1 commit

  • 91abbc15 - Make second migration non-initial

Compare with previous version

added 1 commit <ul><li>91abbc15 - Make second migration non-initial</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29081&start_sha=75196d62a8c0886dd512fbac74432b1a39e980ed)
nik commented 2023-04-03 17:45:09 +02:00 (Migrated from edugit.org)

added 1 commit

  • 7d510d89 - Auto-sync models on changes

Compare with previous version

added 1 commit <ul><li>7d510d89 - Auto-sync models on changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29083&start_sha=91abbc15a18803536abbf933343ee23102f90f83)
nik commented 2023-04-03 17:47:13 +02:00 (Migrated from edugit.org)

added 1 commit

  • 25b7785b - Auto-sync models on changes

Compare with previous version

added 1 commit <ul><li>25b7785b - Auto-sync models on changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29084&start_sha=7d510d89f8521349374e9853a054a6242f1fb0c0)
nik commented 2023-04-03 17:54:23 +02:00 (Migrated from edugit.org)

added 1 commit

  • 790d7c98 - Auto-sync models on changes

Compare with previous version

added 1 commit <ul><li>790d7c98 - Auto-sync models on changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29086&start_sha=25b7785bfc74cd51d66d3089bf07a06156497389)
nik commented 2023-04-03 18:14:30 +02:00 (Migrated from edugit.org)

added 1 commit

  • 1a1bdb53 - Auto-sync models on changes

Compare with previous version

added 1 commit <ul><li>1a1bdb53 - Auto-sync models on changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29088&start_sha=790d7c9841a69f37427e93ba88e852f0bbba9f13)
magicfelix commented 2023-04-05 19:06:17 +02:00 (Migrated from edugit.org)

added 2 commits

  • b2279cf9 - Fix migrations on new databases
  • c0fd3657 - Fix sync on login and account creation

Compare with previous version

added 2 commits <ul><li>b2279cf9 - Fix migrations on new databases</li><li>c0fd3657 - Fix sync on login and account creation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29102&start_sha=1a1bdb534733e03a7cb50ede98621e5baeef1114)
magicfelix commented 2023-04-05 20:18:24 +02:00 (Migrated from edugit.org)

added 1 commit

  • c7de8a56 - Implement bool sync

Compare with previous version

added 1 commit <ul><li>c7de8a56 - Implement bool sync</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29105&start_sha=c0fd36577c03965dd333b5f602db63d82888d210)
magicfelix commented 2023-04-06 18:29:14 +02:00 (Migrated from edugit.org)

added 1 commit

  • 252a3947 - Fix m2m sync

Compare with previous version

added 1 commit <ul><li>252a3947 - Fix m2m sync</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29109&start_sha=c7de8a56d42cc2a3a523c0e9aed85286abb94f0b)
yuha commented 2023-04-07 22:20:15 +02:00 (Migrated from edugit.org)

added 7 commits

  • 885884fa - WIP: LDAP mapping frontend
  • 45d9982f - Make second migration non-initial
  • 723e8fae - Auto-sync models on changes
  • af8c28ad - Fix migrations on new databases
  • 92570274 - Fix sync on login and account creation
  • d4d37330 - Implement bool sync
  • 9c9c526a - Fix m2m sync

Compare with previous version

added 7 commits <ul><li>885884fa - WIP: LDAP mapping frontend</li><li>45d9982f - Make second migration non-initial</li><li>723e8fae - Auto-sync models on changes</li><li>af8c28ad - Fix migrations on new databases</li><li>92570274 - Fix sync on login and account creation</li><li>d4d37330 - Implement bool sync</li><li>9c9c526a - Fix m2m sync</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29123&start_sha=252a39475a66c0e2c25c4948b578f59867b0227d)
magicfelix commented 2023-04-08 16:45:51 +02:00 (Migrated from edugit.org)

added 1 commit

  • 0ee2052d - Catch errors on LDAP write

Compare with previous version

added 1 commit <ul><li>0ee2052d - Catch errors on LDAP write</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29133&start_sha=9c9c526afad7159f23373e81c8e22f7dda7b86d0)
magicfelix commented 2023-04-14 21:23:10 +02:00 (Migrated from edugit.org)

added 1 commit

  • a86ec655 - Allow empty read_regex

Compare with previous version

added 1 commit <ul><li>a86ec655 - Allow empty read_regex</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29215&start_sha=0ee2052d0f7313ef38b2872a0c95e4406757b69f)
yuha commented 2023-04-25 00:02:21 +02:00 (Migrated from edugit.org)

added 9 commits

  • 83819455 - Introduce LDAP MappingSet/FieldMapping frontend
  • 32d8b502 - Make second migration non-initial
  • 4f131e08 - Auto-sync models on changes
  • ecc931f8 - Fix migrations on new databases
  • 6ca5b331 - Fix sync on login and account creation
  • 8c41b0d9 - Implement bool sync
  • c0a2c8cb - Fix m2m sync
  • 51fad8fd - Catch errors on LDAP write
  • ef062caa - Allow empty read_regex

Compare with previous version

added 9 commits <ul><li>83819455 - Introduce LDAP MappingSet/FieldMapping frontend</li><li>32d8b502 - Make second migration non-initial</li><li>4f131e08 - Auto-sync models on changes</li><li>ecc931f8 - Fix migrations on new databases</li><li>6ca5b331 - Fix sync on login and account creation</li><li>8c41b0d9 - Implement bool sync</li><li>c0a2c8cb - Fix m2m sync</li><li>51fad8fd - Catch errors on LDAP write</li><li>ef062caa - Allow empty read_regex</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29399&start_sha=a86ec65524bd25496ebcbc087d6d0f9750984217)
yuha commented 2023-04-25 00:28:20 +02:00 (Migrated from edugit.org)

added 10 commits

Compare with previous version

added 10 commits <ul><li>a25e843f - Introduce LDAP MappingSet/FieldMapping frontend</li><li>90b6d4b7 - Make second migration non-initial</li><li>58cc858d - Auto-sync models on changes</li><li>eefdaaf6 - Fix migrations on new databases</li><li>37d3e5d7 - Fix sync on login and account creation</li><li>53c98cf8 - Implement bool sync</li><li>361cb4d4 - Fix m2m sync</li><li>9f05e349 - Catch errors on LDAP write</li><li>a5b8ac57 - Allow empty read_regex</li><li>a9bd3145 - Use new generic attributes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29400&start_sha=ef062caa96db93c69521febef88dc5c453727333)
yuha commented 2023-04-25 01:43:37 +02:00 (Migrated from edugit.org)

added 3 commits

  • d3cf9dde - Rename MappingSet batch patch mutation to batch mutation
  • 6de52b88 - Set title for MappingSet creating DialogObjectForm
  • 5aaea3d9 - Pass I18n keys needed to DialogObjectForm in order to show snackbar on save success

Compare with previous version

added 3 commits <ul><li>d3cf9dde - Rename MappingSet batch patch mutation to batch mutation</li><li>6de52b88 - Set title for MappingSet creating DialogObjectForm</li><li>5aaea3d9 - Pass I18n keys needed to DialogObjectForm in order to show snackbar on save success</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29404&start_sha=a9bd3145b8fa109a8791703de8e82e6de51876c4)
yuha commented 2023-04-27 23:42:12 +02:00 (Migrated from edugit.org)

added 1 commit

  • 52648e30 - Add required rules to some FieldMapping fields

Compare with previous version

added 1 commit <ul><li>52648e30 - Add required rules to some FieldMapping fields</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/110/diffs?diff_id=29511&start_sha=5aaea3d98ce319ce5fa06232e9c97c67a2c6f003)
This pull request has changes conflicting with the target branch.
  • aleksis/apps/ldap/apps.py
  • aleksis/apps/ldap/frontend/index.js
  • aleksis/apps/ldap/frontend/messages/en.json
  • aleksis/apps/ldap/migrations/0001_preferences.py
  • aleksis/apps/ldap/models.py
  • aleksis/apps/ldap/util/ldap_sync.py
  • pyproject.toml
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 43-write-attrs-to-ldap:43-write-attrs-to-ldap
git switch 43-write-attrs-to-ldap
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-LDAP!167
No description provided.