aleksis/AlekSIS-App-LDAP
8
0
Fork 0
Code Issues 17 Pull requests 3 Projects Releases 1 Packages Activity Actions

Resolve "Hook into django-allauth" #105

Merged
nik merged 16 commits from 22-hook-into-django-allauth-password-change-from-core into master 2021-05-22 15:27:25 +02:00
Conversation 32 Commits 16 Files changed 5 +154 -3
nik commented 2021-02-08 13:29:38 +01:00 (Migrated from edugit.org)
Copy link

Closes #22

Closes #22
nik commented 2021-02-08 13:45:09 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f95a1549 - Implement signal to change password in LDAP

Compare with previous version

added 1 commit <ul><li>f95a1549 - Implement signal to change password in LDAP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4693&start_sha=5e5716de71397b325edd9c7489f7ba4b674ea60e)
nik commented 2021-02-08 13:51:24 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3cf37384 - Add a preference to control password changes in LDAP

Compare with previous version

added 1 commit <ul><li>3cf37384 - Add a preference to control password changes in LDAP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4694&start_sha=f95a15494dd3ba72f84914026bdfc81993857f33)
nik commented 2021-02-08 14:02:05 +01:00 (Migrated from edugit.org)
Copy link

Depends on changes in core that were not merged yet.

Depends on changes in core that were not merged yet.
nik commented 2021-02-08 22:12:17 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
nik commented 2021-02-08 22:12:25 +01:00 (Migrated from edugit.org)
Copy link

requested review from @debdolph

requested review from @debdolph
nik commented 2021-02-08 22:12:28 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
debdolph commented 2021-02-08 22:15:35 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>988a7a70 - Bind as current user</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4710&start_sha=3cf373840dc1e65be9fa48796965a3cb416c83b5)
nik commented 2021-02-08 22:31:04 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • a6ec6558 - Support (re)setting passwords with an admin account

Compare with previous version

added 1 commit <ul><li>a6ec6558 - Support (re)setting passwords with an admin account</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4711&start_sha=988a7a7020bab7a2760a3c660a2a685b9f3eeba1)
nik commented 2021-02-08 22:32:49 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 39664d0d - Unbind after changing password

Compare with previous version

added 1 commit <ul><li>39664d0d - Unbind after changing password</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4712&start_sha=a6ec6558afe2b23bdf1a416bbbfa7352b7d0304f)
nik commented 2021-02-08 22:37:29 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9e64092d - Update copyright to 2021 for myself

Compare with previous version

added 1 commit <ul><li>9e64092d - Update copyright to 2021 for myself</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4713&start_sha=39664d0d57e8a580018cf82a668e4749af24336c)
nik commented 2021-02-08 22:57:36 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • c770c4c4 - Support (re)setting passwords with an admin account
  • 4a9810f8 - Unbind after changing password
  • 7c135a2e - Update copyright to 2021 for myself

Compare with previous version

added 3 commits <ul><li>c770c4c4 - Support (re)setting passwords with an admin account</li><li>4a9810f8 - Unbind after changing password</li><li>7c135a2e - Update copyright to 2021 for myself</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4716&start_sha=9e64092df27b05ee300cb7d23b8ac3d37016bf3e)
nik commented 2021-02-08 23:01:58 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
debdolph commented 2021-02-09 20:40:44 +01:00 (Migrated from edugit.org)
Copy link
lint run-test-pre: commands[2] | poetry run aleksis-admin collectstatic --no-input

1467 static files copied to '/srv/www/aleksis/data/static', 463 unmodified.
lint run-test: commands[0] | poetry run black --check --diff aleksis/
All done! ✨ 🍰 ✨
9 files would be left unchanged.
lint run-test: commands[1] | poetry run isort -c --diff --stdout aleksis/
Skipped 1 files
lint run-test: commands[2] | poetry run flake8 aleksis/
/usr/src/AlekSIS-App-LDAP/.tox/globalenv/lib/python3.7/site-packages is in the MYPYPATH. Please remove it.
See https://mypy.readthedocs.io/en/latest/running_mypy.html#how-mypy-handles-imports for more info
____________________________________________________________________________________________________ summary _____________________________________________________________________________________________________
  lint: commands succeeded
  congratulations :)

Works with allauth from AlekSIS-Core#331

``` lint run-test-pre: commands[2] | poetry run aleksis-admin collectstatic --no-input 1467 static files copied to '/srv/www/aleksis/data/static', 463 unmodified. lint run-test: commands[0] | poetry run black --check --diff aleksis/ All done! ✨ 🍰 ✨ 9 files would be left unchanged. lint run-test: commands[1] | poetry run isort -c --diff --stdout aleksis/ Skipped 1 files lint run-test: commands[2] | poetry run flake8 aleksis/ /usr/src/AlekSIS-App-LDAP/.tox/globalenv/lib/python3.7/site-packages is in the MYPYPATH. Please remove it. See https://mypy.readthedocs.io/en/latest/running_mypy.html#how-mypy-handles-imports for more info ____________________________________________________________________________________________________ summary _____________________________________________________________________________________________________ lint: commands succeeded congratulations :) ``` Works with allauth from AlekSIS-Core#331
debdolph commented 2021-02-09 20:41:58 +01:00 (Migrated from edugit.org)
Copy link

approved this merge request

approved this merge request
debdolph commented 2021-02-09 20:42:13 +01:00 (Migrated from edugit.org)
Copy link

blocked by AlekSIS-Core#331

blocked by AlekSIS-Core#331
nik commented 2021-02-09 22:32:05 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 27d1c6aa - Add ldap_user relation to user if not available yet

Compare with previous version

added 1 commit <ul><li>27d1c6aa - Add ldap_user relation to user if not available yet</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4720&start_sha=7c135a2eafee13aac50021c55804a5170500e690)
nik commented 2021-02-09 23:25:39 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 82344b97 - Add ldap_user relation to user if not available yet
  • 5d9d40d4 - Use binding API from django-auth-ldap

Compare with previous version

added 2 commits <ul><li>82344b97 - Add ldap_user relation to user if not available yet</li><li>5d9d40d4 - Use binding API from django-auth-ldap</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4721&start_sha=27d1c6aaebcb371cfa8f2249e0505ece1e749f85)
nik commented 2021-02-09 23:36:08 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • b1873d22 - Wrap temporary bind into context manager

Compare with previous version

added 1 commit <ul><li>b1873d22 - Wrap temporary bind into context manager</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4722&start_sha=5d9d40d415a607a0444d06fabb7c734dc69618a9)
nik commented 2021-02-09 23:52:25 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 37036b2f - Emit logging message when elevating LDAP privileges
  • 09fad1f4 - Fix variable name dn → bind_dn

Compare with previous version

added 2 commits <ul><li>37036b2f - Emit logging message when elevating LDAP privileges</li><li>09fad1f4 - Fix variable name dn → bind_dn</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4726&start_sha=b1873d228145cde9744f3f25c22263f41b3b603b)
nik commented 2021-02-09 23:52:45 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
debdolph commented 2021-02-17 11:06:16 +01:00 (Migrated from edugit.org)
Copy link

unapproved this merge request

unapproved this merge request
nik commented 2021-02-21 21:11:15 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2021-02-21 21:11:15 +01:00 (Migrated from edugit.org)
Copy link

changed title from {-Resolve "Hook into django-allauth password change from core-}" to {+Draft: Resolve "Hook into django-allauth+}"

changed title from **{-Resolve "Hook into django-allauth password change from core-}"** to **{+Draft: Resolve "Hook into django-allauth+}"**
nik commented 2021-02-21 21:14:01 +01:00 (Migrated from edugit.org)
Copy link

added 8 commits

  • 09fad1f4...4e8cac67 - 7 commits from branch master
  • 3f95114c - Merge branch 'master' into 22-hook-into-django-allauth-password-change-from-core

Compare with previous version

added 8 commits <ul><li>09fad1f4...4e8cac67 - 7 commits from branch <code>master</code></li><li>3f95114c - Merge branch &#39;master&#39; into 22-hook-into-django-allauth-password-change-from-core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4933&start_sha=09fad1f4a9b3a87060ac44d6713553a109806af8)
nik commented 2021-02-21 21:46:11 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2a553a31 - WIP: Implement ldap_create_user

Compare with previous version

added 1 commit <ul><li>2a553a31 - WIP: Implement ldap_create_user</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=4939&start_sha=3f95114cd5d87592e3c99bc32ad349da499203cf)
debdolph commented 2021-04-17 20:07:20 +02:00 (Migrated from edugit.org)
Copy link

added 31 commits

  • 2a553a31...684496e5 - 30 commits from branch master
  • efd586ab - Merge branch 'master' into 22-hook-into-django-allauth-password-change-from-core

Compare with previous version

added 31 commits <ul><li>2a553a31...684496e5 - 30 commits from branch <code>master</code></li><li>efd586ab - Merge branch &#39;master&#39; into 22-hook-into-django-allauth-password-change-from-core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=7444&start_sha=2a553a317451baf748c4a60a6e117515d0e6f82c)
debdolph commented 2021-04-19 18:44:00 +02:00 (Migrated from edugit.org)
Copy link

approved this merge request

approved this merge request
nik commented 2021-05-21 17:51:43 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-05-22 14:46:32 +02:00 (Migrated from edugit.org)
Copy link

added 17 commits

  • efd586ab...c6b491c4 - 16 commits from branch master
  • d40d0677 - Merge branch 'master' into 22-hook-into-django-allauth-password-change-from-core

Compare with previous version

added 17 commits <ul><li>efd586ab...c6b491c4 - 16 commits from branch <code>master</code></li><li>d40d0677 - Merge branch &#39;master&#39; into 22-hook-into-django-allauth-password-change-from-core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=9122&start_sha=efd586aba3ca4b6c15862d6cf17031ea1dde45be)
hansegucker commented 2021-05-22 15:21:55 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>887d1fbd - Reformat and make lint clean</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/48/diffs?diff_id=9129&start_sha=d40d067771c599cd82bf6127341f90be73a2aa75)
hansegucker (Migrated from edugit.org) scheduled this pull request to auto merge when all checks succeed 2021-05-22 15:23:46 +02:00
hansegucker commented 2021-05-22 15:27:21 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 878ce9e464

mentioned in commit 878ce9e4644c9554c0d6847cb44543911ce293a1
hansegucker (Migrated from edugit.org) merged commit 878ce9e464 into master 2021-05-22 15:27:25 +02:00
debdolph (Migrated from edugit.org) approved these changes 2026-07-14 16:15:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
debdolph
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-LDAP!105
No description provided.