aleksis/AlekSIS-App-LDAP
8
0
Fork 0
Code Issues 17 Pull requests 3 Projects Releases 1 Packages Activity Actions

Resolve "LDAP sync on login takes very long" #104

Merged
nik merged 4 commits from 10-ldap-sync-on-login-takes-very-long into master 2021-02-14 13:15:58 +01:00
Conversation 25 Commits 4 Files changed 3 +66 -72
nik commented 2021-02-07 21:57:27 +01:00 (Migrated from edugit.org)
Copy link

Closes #10

Closes #10
nik commented 2021-02-07 22:06:48 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 118e5e7d - Use populate_user signal form django_auth_ldap

Compare with previous version

added 1 commit <ul><li>118e5e7d - Use populate_user signal form django_auth_ldap</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4677&start_sha=5e5716de71397b325edd9c7489f7ba4b674ea60e)
nik commented 2021-02-07 22:15:33 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 35c8d4a6 - Use populate_user signal form django_auth_ldap

Compare with previous version

added 1 commit <ul><li>35c8d4a6 - Use populate_user signal form django_auth_ldap</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4678&start_sha=118e5e7de9077e127e2c649a0ae6556f8cec96d2)
nik commented 2021-02-07 22:21:34 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 86d29c50 - Use populate_user signal form django_auth_ldap

Compare with previous version

added 1 commit <ul><li>86d29c50 - Use populate_user signal form django_auth_ldap</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4679&start_sha=35c8d4a6b60ee9bff0ee1541b8888986ad382b94)
nik commented 2021-02-07 22:30:28 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • e11795c7 - Use populate_user signal form django_auth_ldap

Compare with previous version

added 1 commit <ul><li>e11795c7 - Use populate_user signal form django_auth_ldap</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4680&start_sha=86d29c50a669f4c2eb51a40db53c8191f6ff8623)
debdolph commented 2021-02-07 22:34:43 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • eede9edb - Use populate_user signal form django_auth_ldap

Compare with previous version

added 1 commit <ul><li>eede9edb - Use populate_user signal form django_auth_ldap</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4681&start_sha=e11795c7765915ec4b4c4a902524f894949bbead)
nik commented 2021-02-14 00:15:36 +01:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • e11795c7 - Use populate_user signal form django_auth_ldap
  • 804154fa - Use only one transaction per outer operation
  • d44d2bae - Rewrite groups import to use bulk operations
  • 529c9ce9 - Rewrite primary group sync to use bulk operation

Compare with previous version

added 4 commits <ul><li>e11795c7 - Use populate_user signal form django_auth_ldap</li><li>804154fa - Use only one transaction per outer operation</li><li>d44d2bae - Rewrite groups import to use bulk operations</li><li>529c9ce9 - Rewrite primary group sync to use bulk operation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4775&start_sha=eede9edb967d524e24c6dbda64aea70013f26a7f)
nik commented 2021-02-14 00:34:54 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • f6d4bb9e - Use populate_user signal form django_auth_ldap
  • 64554e1b - Rewrite groups import to use bulk operations
  • 8d619b6c - Rewrite primary group sync to use bulk operation

Compare with previous version

added 3 commits <ul><li>f6d4bb9e - Use populate_user signal form django_auth_ldap</li><li>64554e1b - Rewrite groups import to use bulk operations</li><li>8d619b6c - Rewrite primary group sync to use bulk operation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4776&start_sha=529c9ce920a46c98e40b135e082ac1249fb0947d)
nik commented 2021-02-14 00:52:08 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • f84fed25 - Use populate_user signal form django_auth_ldap
  • ca52d41f - Rewrite groups import to use bulk operations
  • 843599f6 - Rewrite primary group sync to use bulk operation

Compare with previous version

added 3 commits <ul><li>f84fed25 - Use populate_user signal form django_auth_ldap</li><li>ca52d41f - Rewrite groups import to use bulk operations</li><li>843599f6 - Rewrite primary group sync to use bulk operation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4777&start_sha=8d619b6cb180e120348ae07924e62b211e6c8f36)
nik commented 2021-02-14 01:08:08 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • d8c03a9d - Rewrite primary group sync to use bulk operation

Compare with previous version

added 1 commit <ul><li>d8c03a9d - Rewrite primary group sync to use bulk operation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4778&start_sha=843599f6290c2c83cab653a78a4fa9200a928c84)
nik commented 2021-02-14 01:19:36 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • a861b27b - Fix total count for group member sync

Compare with previous version

added 1 commit <ul><li>a861b27b - Fix total count for group member sync</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4779&start_sha=d8c03a9d70fa77bf0c4dddb8ed018e841ebe8733)
nik commented 2021-02-14 01:31:29 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6725a19f - Rewrite group membership sync to work selectively

Compare with previous version

added 1 commit <ul><li>6725a19f - Rewrite group membership sync to work selectively</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4780&start_sha=a861b27bdd7abeb88d449b0687fc74b690664c36)
nik commented 2021-02-14 01:35:11 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f1728a73 - Rewrite group membership sync to work selectively

Compare with previous version

added 1 commit <ul><li>f1728a73 - Rewrite group membership sync to work selectively</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4781&start_sha=6725a19f65f717474e153bb386d2029d168f1d82)
nik commented 2021-02-14 02:22:20 +01:00 (Migrated from edugit.org)
Copy link

I still need to verify the new import is correct, because somehow duplicates of some groups show up in between (but are gone later).

The import still spends a lot of time processing signals, but this is due to #23 and will be fixed separately.

I still need to verify the new import is correct, because somehow duplicates of some groups show up in between (but are gone later). The import still spends a lot of time processing signals, but this is due to #23 and will be fixed separately.
nik commented 2021-02-14 12:44:04 +01:00 (Migrated from edugit.org)
Copy link

So, the issue that caused existing vs. nonexisting groups to not be properly detected is a jsonstore issue: https://github.com/viewflow/jsonstore/issues/7

So, the issue that caused existing vs. nonexisting groups to not be properly detected is a jsonstore issue: https://github.com/viewflow/jsonstore/issues/7
nik commented 2021-02-14 12:47:26 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • a2de19bb - Work sround bug in jsonstore that breaks values_list

Compare with previous version

added 1 commit <ul><li>a2de19bb - Work sround bug in jsonstore that breaks values_list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4785&start_sha=a861b27bdd7abeb88d449b0687fc74b690664c36)
nik commented 2021-02-14 12:47:38 +01:00 (Migrated from edugit.org)
Copy link

Workaround implemented in a2de19bb949e7c82769cc05456281816f784fc79

Workaround implemented in a2de19bb949e7c82769cc05456281816f784fc79
nik commented 2021-02-14 12:47:38 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
nik commented 2021-02-14 12:47:55 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2021-02-14 12:48:00 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker and unassigned @nik

assigned to @hansegucker and unassigned @nik
nik commented 2021-02-14 12:48:06 +01:00 (Migrated from edugit.org)
Copy link

requested review from @debdolph

requested review from @debdolph
hansegucker commented 2021-02-14 12:59:43 +01:00 (Migrated from edugit.org)
Copy link

Please fix the pipeline.

Please fix the pipeline.
nik commented 2021-02-14 13:13:19 +01:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • aaa6befb - Use populate_user signal form django_auth_ldap
  • 0e78e80c - Rewrite groups import to use bulk operations
  • 7cd1bf87 - Rewrite primary group sync to use bulk operation
  • b5549898 - Work sround bug in jsonstore that breaks values_list

Compare with previous version

added 4 commits <ul><li>aaa6befb - Use populate_user signal form django_auth_ldap</li><li>0e78e80c - Rewrite groups import to use bulk operations</li><li>7cd1bf87 - Rewrite primary group sync to use bulk operation</li><li>b5549898 - Work sround bug in jsonstore that breaks values_list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-LDAP/-/merge_requests/47/diffs?diff_id=4789&start_sha=a2de19bb949e7c82769cc05456281816f784fc79)
debdolph commented 2021-02-14 13:14:28 +01:00 (Migrated from edugit.org)
Copy link

approved this merge request

approved this merge request
hansegucker commented 2021-02-14 13:15:58 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 503a8d1fa8

mentioned in commit 503a8d1fa895f45365e562f9a199525f6ea03f15
hansegucker (Migrated from edugit.org) merged commit 503a8d1fa8 into master 2021-02-14 13:15:58 +01:00
debdolph (Migrated from edugit.org) approved these changes 2026-07-14 16:15:48 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
debdolph
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-LDAP!104
No description provided.