aleksis/AlekSIS-App-Kompjuter
8
0
Fork 0
Code Issues 17 Pull requests Projects Releases Packages Wiki Activity Actions

Resolve "Frontend for managing SSH keys" #95

Merged
magicfelix merged 19 commits from 24-frontend-for-managing-ssh-keys into master 2026-04-06 21:52:28 +02:00
Conversation 51 Commits 19 Files changed 16 +564
magicfelix commented 2026-03-25 13:31:13 +01:00 (Migrated from edugit.org)
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

Closes #24

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [ ] Changelog updated/No update necessary - [x] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [x] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [x] Tested with admin account - [x] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [x] Screenshots are attached (mobile and desktop) - [x] Tested on mobile, tablet, and desktop sizes - [x] Adhered to [frontend guidelines](https://edugit.org/AlekSIS/official/AlekSIS/-/blob/master/project/frontend_guidelines.rst?ref_type=heads) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/) Closes #24
magicfelix commented 2026-03-25 13:31:52 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 27e0b590 - Add schema and rules for SSHKey
  • f0198083 - WIP: Add frontend for SSHKeys

Compare with previous version

added 2 commits <ul><li>27e0b590 - Add schema and rules for SSHKey</li><li>f0198083 - WIP: Add frontend for SSHKeys</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85160&start_sha=442b865a07292ae4c304818c5ff772e51eab25da)
magicfelix commented 2026-03-25 13:39:52 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 04fea604 - Add schema and rules for SSHKey
  • 5f15a23d - WIP: Add frontend for SSHKeys

Compare with previous version

added 2 commits <ul><li>04fea604 - Add schema and rules for SSHKey</li><li>5f15a23d - WIP: Add frontend for SSHKeys</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85162&start_sha=f019808317189b4c71fd00c2e612c9933a21f85f)
ZugBahnHof commented 2026-03-25 15:37:16 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 879ba58f - Query uuid of key person as well

Compare with previous version

added 1 commit <ul><li>879ba58f - Query uuid of key person as well</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85167&start_sha=5f15a23d88cb5594012ed3bf70841e0012475d7c)
ZugBahnHof commented 2026-03-25 17:21:01 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • dc11d3e2 - Display ssh keys more beautiful by parsing them

Compare with previous version

added 1 commit <ul><li>dc11d3e2 - Display ssh keys more beautiful by parsing them</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85192&start_sha=879ba58f365e464e847b0d311f86bf0f0b3d8fe4)
ZugBahnHof commented 2026-03-25 23:49:23 +01:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 27cc84ca - Fix default filters for ssh keys
  • 8689f4d2 - Create widget for person page to manage their own ssh keys
  • a960dad7 - Set keyData as nameProp for ssh keys
  • ce130518 - Reformat

Compare with previous version

added 4 commits <ul><li>27cc84ca - Fix default filters for ssh keys</li><li>8689f4d2 - Create widget for person page to manage their own ssh keys</li><li>a960dad7 - Set keyData as nameProp for ssh keys</li><li>ce130518 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85299&start_sha=dc11d3e2dfb94d595604cccf7322217110ddbd2c)
nik commented 2026-03-26 10:10:12 +01:00 (Migrated from edugit.org)
Copy link

What is the reason for this? Why does the frontend need to know which key types OpenSSH supports?

The list above is, right now, very incomplete and my personal SSH key would not work.

What is the reason for this? Why does the frontend need to know which key types OpenSSH supports? The list above is, right now, very incomplete and my personal SSH key would not work.
nik commented 2026-03-26 10:10:12 +01:00 (Migrated from edugit.org)
Copy link

WTF?

WTF?
nik commented 2026-03-26 10:10:13 +01:00 (Migrated from edugit.org)
Copy link

?????? What does this do, and if so, why is it in the frontend?

?????? What does this do, and if so, why is it in the frontend?
nik commented 2026-03-26 10:10:13 +01:00 (Migrated from edugit.org)
Copy link

When we discussed this feature, I requests a generic tab for Kompjuter things i nthe Person detail page, which will for now contain an SSH widget. I do not find such a general Kompjuter tab anywhere in the components in this MR.

When we discussed this feature, I requests a generic tab for Kompjuter things i nthe Person detail page, which will for now contain an SSH widget. I do not find such a general Kompjuter tab anywhere in the components in this MR.
nik commented 2026-03-26 10:10:14 +01:00 (Migrated from edugit.org)
Copy link

requested changes

requested changes
ZugBahnHof commented 2026-03-27 20:38:17 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 2d057947 - Wrap ssh key widget into kompjuter tabs block
  • 7c46e2bc - Shorten min-width of key display
  • cf417610 - Add more key names/aliases to the ssh key display field

Compare with previous version

added 3 commits <ul><li>2d057947 - Wrap ssh key widget into kompjuter tabs block</li><li>7c46e2bc - Shorten min-width of key display</li><li>cf417610 - Add more key names/aliases to the ssh key display field</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85318&start_sha=ce130518ed34875976f43e1d0a603eef99d0c578)
ZugBahnHof commented 2026-03-27 21:11:50 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 3f6578de - Make add button for ssh keys secondary
  • 951acaab - Change icon of ssh keys

Compare with previous version

added 2 commits <ul><li>3f6578de - Make add button for ssh keys secondary</li><li>951acaab - Change icon of ssh keys</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85319&start_sha=cf41761062322a848acd74ea506e92b9d0842ff3)
ZugBahnHof commented 2026-03-27 21:15:02 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **tox \-e reformat,lint used** as completed
ZugBahnHof commented 2026-03-27 21:15:29 +01:00 (Migrated from edugit.org)
Copy link

only for display purposes, not used for input validation

only for display purposes, not used for input validation
ZugBahnHof commented 2026-03-27 21:16:05 +01:00 (Migrated from edugit.org)
Copy link

assigning icons and colors to different key types, to make them more easily distinguishable

assigning icons and colors to different key types, to make them more easily distinguishable
ZugBahnHof commented 2026-03-27 21:17:07 +01:00 (Migrated from edugit.org)
Copy link

this unifies aliases of keys

this unifies aliases of keys
ZugBahnHof commented 2026-03-27 21:17:07 +01:00 (Migrated from edugit.org)
Copy link

done

done
ZugBahnHof commented 2026-03-27 21:17:08 +01:00 (Migrated from edugit.org)
Copy link

left review comments

left review comments
ZugBahnHof commented 2026-03-27 21:17:22 +01:00 (Migrated from edugit.org)
Copy link

grafik{width=900 height=563}

![grafik](/uploads/b04cb54dde8facee68d45bf3145e2b0d/grafik.png){width=900 height=563}
ZugBahnHof commented 2026-03-27 21:23:08 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Documentation incl\. Screenshots up-to-date as completed

marked the checklist item **Documentation \(incl\. Screenshots\) up\-to\-date** as completed
ZugBahnHof commented 2026-03-27 21:23:09 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Adhere to URL scheme as completed

marked the checklist item **Adhere to URL scheme** as completed
ZugBahnHof commented 2026-03-27 21:23:10 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Tested with admin account as completed

marked the checklist item **Tested with admin account** as completed
ZugBahnHof commented 2026-03-27 21:23:12 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Tested with normal account (based on permissions) as completed

marked the checklist item **Tested with normal account \(based on permissions\)** as completed
ZugBahnHof commented 2026-03-27 21:23:18 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Screenshots are attached (mobile and desktop) as completed

marked the checklist item **Screenshots are attached \(mobile and desktop\)** as completed
ZugBahnHof commented 2026-03-27 21:23:19 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Tested on mobile, tablet, and desktop sizes as completed

marked the checklist item **Tested on mobile, tablet, and desktop sizes** as completed
ZugBahnHof commented 2026-03-27 21:23:20 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Adhered to frontend guidelines as completed

marked the checklist item **Adhered to frontend guidelines** as completed
ZugBahnHof commented 2026-03-27 21:23:57 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 44c811fd - Use object routes

Compare with previous version

added 1 commit <ul><li>44c811fd - Use object routes</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85323&start_sha=951acaabb7819d0f07908991cafd62d7fb6c0280)
ZugBahnHof commented 2026-03-27 21:24:26 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
ZugBahnHof commented 2026-03-27 21:24:53 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2026-03-31 01:11:51 +02:00 (Migrated from edugit.org)
Copy link

why is this outlined? at least add some default margin

why is this outlined? at least add some default margin
yuha commented 2026-03-31 01:12:27 +02:00 (Migrated from edugit.org)
Copy link

i don't really understand the icon and color choices. do they carry some hidden meaning?

i don't really understand the icon and color choices. do they carry some hidden meaning?
yuha commented 2026-03-31 01:13:11 +02:00 (Migrated from edugit.org)
Copy link

what is this good for?

what is this good for?
yuha commented 2026-03-31 01:13:28 +02:00 (Migrated from edugit.org)
Copy link

at least add some person-related predicate

at least add some person-related predicate
ZugBahnHof commented 2026-03-31 18:03:21 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85501&start_sha=44c811fda11f5560905f840afb793b9f5f2a9210#339881ac67277fcada6d2e78acf30356ec3457fb_12_0)
ZugBahnHof commented 2026-03-31 18:03:23 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85501&start_sha=44c811fda11f5560905f840afb793b9f5f2a9210#339881ac67277fcada6d2e78acf30356ec3457fb_25_0)
ZugBahnHof commented 2026-03-31 18:03:23 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85501&start_sha=44c811fda11f5560905f840afb793b9f5f2a9210#339881ac67277fcada6d2e78acf30356ec3457fb_47_0)
ZugBahnHof commented 2026-03-31 18:03:24 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85501&start_sha=44c811fda11f5560905f840afb793b9f5f2a9210#37832ea0a12c248629f9af3efc5e140ad493d6e4_48_48)
ZugBahnHof commented 2026-03-31 18:03:25 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85501&start_sha=44c811fda11f5560905f840afb793b9f5f2a9210#339881ac67277fcada6d2e78acf30356ec3457fb_47_0)
ZugBahnHof commented 2026-03-31 18:03:27 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 4618b161 - Remove outline from ssh key cards
  • 7869d921 - Remove visual distinction between key types

Compare with previous version

added 2 commits <ul><li>4618b161 - Remove outline from ssh key cards</li><li>7869d921 - Remove visual distinction between key types</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85501&start_sha=44c811fda11f5560905f840afb793b9f5f2a9210)
ZugBahnHof commented 2026-03-31 18:04:53 +02:00 (Migrated from edugit.org)
Copy link

grafik{width=900 height=459}

![grafik](/uploads/86ed8936afadf456715270b42d5621da/grafik.png){width=900 height=459}
magicfelix commented 2026-03-31 21:12:16 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cc6c5578 - Fix rules, query and mutation

Compare with previous version

added 1 commit <ul><li>cc6c5578 - Fix rules, query and mutation</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85515&start_sha=7869d921c3cab1c29079c7c9c2a0d53d83e8ad46)
magicfelix commented 2026-03-31 21:20:19 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 74fc6130 - Fix rules, query and mutation

Compare with previous version

added 1 commit <ul><li>74fc6130 - Fix rules, query and mutation</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85517&start_sha=cc6c5578d0a05199afe70ff6a51ff9ad4380fa62)
magicfelix commented 2026-03-31 21:32:18 +02:00 (Migrated from edugit.org)
Copy link

It does now use has_any_object to only show the CRUD list to users allowed to see more than their own keys.

It does now use `has_any_object` to only show the CRUD list to users allowed to see more than their own keys.
magicfelix commented 2026-03-31 21:33:56 +02:00 (Migrated from edugit.org)
Copy link

Done. Only for delete, because I suggest not to allow editing keys. One can delete it and create a new one.

Done. Only for delete, because I suggest not to allow editing keys. One can delete it and create a new one.
magicfelix commented 2026-03-31 21:33:56 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2026-04-01 20:14:54 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2026-04-01 20:15:13 +02:00 (Migrated from edugit.org)
Copy link

approved this merge request

approved this merge request
magicfelix commented 2026-04-01 20:16:23 +02:00 (Migrated from edugit.org)
Copy link

added 20 commits

  • 74fc6130...2b1ee279 - 2 commits from branch master
  • 2b1ee279...6fb9123c - 8 earlier commits
  • a75519c9 - Wrap ssh key widget into kompjuter tabs block
  • b1c1aa0c - Shorten min-width of key display
  • bc45cf4c - Add more key names/aliases to the ssh key display field
  • f375e06b - Make add button for ssh keys secondary
  • 556332d1 - Change icon of ssh keys
  • 02b88cd9 - Use object routes
  • e7aed63c - Remove outline from ssh key cards
  • 949e1434 - Remove visual distinction between key types
  • 1e6591d6 - Fix rules, query and mutation
  • f63e1340 - Add UUID migration

Compare with previous version

added 20 commits <ul><li>74fc6130...2b1ee279 - 2 commits from branch <code>master</code></li><li>2b1ee279...6fb9123c - 8 earlier commits</li><li>a75519c9 - Wrap ssh key widget into kompjuter tabs block</li><li>b1c1aa0c - Shorten min-width of key display</li><li>bc45cf4c - Add more key names/aliases to the ssh key display field</li><li>f375e06b - Make add button for ssh keys secondary</li><li>556332d1 - Change icon of ssh keys</li><li>02b88cd9 - Use object routes</li><li>e7aed63c - Remove outline from ssh key cards</li><li>949e1434 - Remove visual distinction between key types</li><li>1e6591d6 - Fix rules, query and mutation</li><li>f63e1340 - Add UUID migration</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85567&start_sha=74fc613074e999c30ff77be066e2580fcb925049)
magicfelix commented 2026-04-01 21:04:09 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>afffe6e1 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/63/diffs?diff_id=85618&start_sha=f63e134040df9eb090c3352dd53911b7f332fd9b)
debdolph (Migrated from edugit.org) merged commit 1054bbe2ea into master 2026-04-06 21:52:28 +02:00
debdolph commented 2026-04-06 21:52:29 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 1054bbe2ea

mentioned in commit 1054bbe2eaea8eb16a12acb67a572b10ebebe2ec
hansegucker (Migrated from edugit.org) approved these changes 2026-07-14 18:39:07 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Kompjuter!95
No description provided.