aleksis/AlekSIS-App-Kompjuter
8
0
Fork 0
Code Issues 17 Pull requests Projects Releases Packages Wiki Activity Actions

Auto-create of NIS attrs #89

Merged
hansegucker merged 7 commits from feature/auto-create-nis-attrs into master 2025-08-18 23:00:12 +02:00
Conversation 16 Commits 7 Files changed 9 +224 -8
hansegucker commented 2025-08-17 12:39:30 +02:00 (Migrated from edugit.org)
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

  • Screenshots are attached (mobile and desktop)
  • Tested on mobile, tablet, and desktop sizes
  • Adhered to frontend guidelines
  • Checked with Firefox Accessibility Checker
## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [x] Copyright in `apps.py` and `README.rst` up-to-date - [x] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to frontend guidelines - [ ] Checked with Firefox Accessibility Checker
hansegucker commented 2025-08-17 12:48:48 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 0cc15ead - Fix copyright

Compare with previous version

added 1 commit <ul><li>0cc15ead - Fix copyright</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/57/diffs?diff_id=69751&start_sha=adf19f493ea35e0d105f2381f5ec1de869c1d342)
hansegucker commented 2025-08-17 12:51:49 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a039d8e4 - Fix copyright</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/57/diffs?diff_id=69753&start_sha=0cc15ead23bcc5aa0b26a78bc81fed6b7d9d6a0c)
nik commented 2025-08-17 16:27:56 +02:00 (Migrated from edugit.org)
Copy link

Should be two tests

Should be two tests
nik commented 2025-08-17 16:27:57 +02:00 (Migrated from edugit.org)
Copy link

Should be two tests

Should be two tests
nik commented 2025-08-17 16:27:57 +02:00 (Migrated from edugit.org)
Copy link

Should only trigger on persons having a user account linked.

Should only trigger on persons having a user account linked.
nik commented 2025-08-17 16:27:57 +02:00 (Migrated from edugit.org)
Copy link

Should only trigger on groups in current school term or without school term.

Another check should be added for NIS attrs that are linked to groups in non-current school terms.

Should only trigger on groups in current school term or without school term. Another check should be added for NIS attrs that are linked to groups in non-current school terms.
nik commented 2025-08-17 16:27:57 +02:00 (Migrated from edugit.org)
Copy link

Should only handle persons with user accounts.

Hence, the signal logic probably needs to be reworked to trigger on changes to the user field on Person…

Should only handle persons with user accounts. Hence, the signal logic probably needs to be reworked to trigger on changes to the `user` field on `Person`…
nik commented 2025-08-17 16:27:58 +02:00 (Migrated from edugit.org)
Copy link

requested changes

requested changes
hansegucker commented 2025-08-18 22:45:23 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/57/diffs?diff_id=70046&start_sha=a039d8e4544edf19ab2243852d992f4190cc2ef1#3d26275e012b61f58d2e48d2ca5fc3ce4e8d99eb_22_34)
hansegucker commented 2025-08-18 22:45:24 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/57/diffs?diff_id=70046&start_sha=a039d8e4544edf19ab2243852d992f4190cc2ef1#3d26275e012b61f58d2e48d2ca5fc3ce4e8d99eb_38_63)
hansegucker commented 2025-08-18 22:45:25 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/57/diffs?diff_id=70046&start_sha=a039d8e4544edf19ab2243852d992f4190cc2ef1#e2cdc129807c8d6657ea321b3cf2676a7387d789_36_37)
hansegucker commented 2025-08-18 22:45:25 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/57/diffs?diff_id=70046&start_sha=a039d8e4544edf19ab2243852d992f4190cc2ef1#e2cdc129807c8d6657ea321b3cf2676a7387d789_65_66)
hansegucker commented 2025-08-18 22:45:26 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 3ea5c07b - Split tests
  • 909ecbbe - Only create PersonNisAttrs for persons with user account
  • 6bbed59d - Fix data checks to select correct objects

Compare with previous version

added 3 commits <ul><li>3ea5c07b - Split tests</li><li>909ecbbe - Only create PersonNisAttrs for persons with user account</li><li>6bbed59d - Fix data checks to select correct objects</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/57/diffs?diff_id=70046&start_sha=a039d8e4544edf19ab2243852d992f4190cc2ef1)
hansegucker commented 2025-08-18 22:45:34 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-08-18 22:53:25 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 24417518 - Only run data checks if creation of NIS attrs is enabled

Compare with previous version

added 1 commit <ul><li>24417518 - Only run data checks if creation of NIS attrs is enabled</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Kompjuter/-/merge_requests/57/diffs?diff_id=70048&start_sha=6bbed59dee833a7ef85bb209491249f809378bbf)
nik (Migrated from edugit.org) scheduled this pull request to auto merge when all checks succeed 2025-08-18 22:53:42 +02:00
nik commented 2025-08-18 23:00:11 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 787b799344

mentioned in commit 787b799344abaa17dc9fba66585a8d881f2e799a
nik (Migrated from edugit.org) merged commit 787b799344 into master 2025-08-18 23:00:12 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Kompjuter!89
No description provided.