aleksis/AlekSIS-App-Kolego
8
0
Fork 0
Code Issues 21 Pull requests 2 Projects Releases Packages Activity Actions

Resolve "Add absence approval feature" #176

Merged
yuha merged 71 commits from 55-add-absence-approval-feature into master 2026-03-18 21:46:00 +01:00
Conversation 75 Commits 71 Files changed 23 +673 -172
yuha commented 2026-02-10 13:26:12 +01:00 (Migrated from edugit.org)
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

Closes #55

## Information and screenshots No further information have been provided. ## Checklist - [ ] `tox -e reformat,lint` used - [ ] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to [frontend guidelines](https://edugit.org/AlekSIS/official/AlekSIS/-/blob/master/project/frontend_guidelines.rst?ref_type=heads) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/) Closes #55
yuha commented 2026-02-10 13:26:14 +01:00 (Migrated from edugit.org)
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2026-02-10 13:43:25 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ed3cf29d - Add absence reason fields for approval

Compare with previous version

added 1 commit <ul><li>ed3cf29d - Add absence reason fields for approval</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83244&start_sha=22007765fa6da2d11239a5dfd32c8e5b5dd81ebf)
yuha commented 2026-02-10 13:58:03 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2867fd86 - Add absence reason approval fields to frontend

Compare with previous version

added 1 commit <ul><li>2867fd86 - Add absence reason approval fields to frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83246&start_sha=ed3cf29d497c14f0a162f030ff99471ae32c53c1)
yuha commented 2026-02-10 13:58:48 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b6df6d7b - Add uuid field for group</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83247&start_sha=2867fd86aaae06dc49bb289daf49c9b11012efd8)
yuha commented 2026-02-10 14:01:33 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • bdf1f8f4 - Make absence reason layout clearer & add hint

Compare with previous version

added 1 commit <ul><li>bdf1f8f4 - Make absence reason layout clearer &amp; add hint</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83249&start_sha=b6df6d7b67c66cf3f03faba5255f022a7b9f18cd)
yuha commented 2026-02-10 14:12:15 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1eb17940 - Add todo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83251&start_sha=bdf1f8f46692664df88b227716c9ac5ee7f1930f)
yuha commented 2026-02-11 17:25:56 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 86d380cb - Use attendance class for absence persons

Compare with previous version

added 1 commit <ul><li>86d380cb - Use attendance class for absence persons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83301&start_sha=1eb179409b0e6cca54d7663faabc75c896a040cc)
yuha commented 2026-02-12 19:06:50 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 55580e94 - Implement attendee by status method

Compare with previous version

added 1 commit <ul><li>55580e94 - Implement attendee by status method</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83368&start_sha=86d380cbd42ad4e38102f582877439161ef0d5ac)
yuha commented 2026-02-12 19:10:44 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 109e3097 - Implement attendee by status method

Compare with previous version

added 1 commit <ul><li>109e3097 - Implement attendee by status method</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83369&start_sha=55580e94976136ec838ce910adff31881366a2df)
yuha commented 2026-02-12 19:13:40 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2f53b2f9 - Further adapt methods of Absence to attendance

Compare with previous version

added 1 commit <ul><li>2f53b2f9 - Further adapt methods of Absence to attendance</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83370&start_sha=109e309773b8b6c0bbb498c4594677e66c7eded3)
yuha commented 2026-02-16 15:58:02 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c5d55891 - Add migration for attendance field

Compare with previous version

added 1 commit <ul><li>c5d55891 - Add migration for attendance field</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83445&start_sha=2f53b2f91f6dd7b65cedd9d3b492598c3c613f2a)
yuha commented 2026-02-16 16:49:16 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3e367bc9 - Query attendance instead of person for absences

Compare with previous version

added 1 commit <ul><li>3e367bc9 - Query attendance instead of person for absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83448&start_sha=c5d558914beafc04ea9fb52305a00bb07173dae1)
yuha commented 2026-02-16 16:50:48 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4175dd05 - Add todo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83449&start_sha=3e367bc984948c1d93ff81df3198f721823380c6)
yuha commented 2026-02-16 17:29:41 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>5a9b0245 - Adapt filters</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83450&start_sha=4175dd05f60b61a81d3f724356d7fc225574585a)
yuha commented 2026-02-16 17:29:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c48469ca - Directly use imported Attendance in FK definition

Compare with previous version

added 1 commit <ul><li>c48469ca - Directly use imported Attendance in FK definition</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83451&start_sha=5a9b02450aebf96ee83549644dffd9de78a3f3e7)
yuha commented 2026-02-16 17:39:38 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2e2c5975 - Explicitly declare person attendance field

Compare with previous version

added 1 commit <ul><li>2e2c5975 - Explicitly declare person attendance field</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83452&start_sha=c48469ca675983b58a4adbe77fcb01a0b6d2c4c7)
yuha commented 2026-02-18 20:05:02 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3a0c859d - WIP: implement attendance handling in absence mutations

Compare with previous version

added 1 commit <ul><li>3a0c859d - WIP: implement attendance handling in absence mutations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83546&start_sha=2e2c597575d1e9a2a6cf0d5d742faa4a36ec1107)
yuha commented 2026-02-19 18:35:08 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6a47208a - Fix usage of person in save function

Compare with previous version

added 1 commit <ul><li>6a47208a - Fix usage of person in save function</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83605&start_sha=3a0c859db202a86398c2f929bce1a0ced00b82ee)
yuha commented 2026-02-20 15:46:14 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 1e8f04b4 - WIP: use correct type for attendance haandling in mutation

Compare with previous version

added 1 commit <ul><li>1e8f04b4 - WIP: use correct type for attendance haandling in mutation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=83613&start_sha=6a47208a6c8861ccaa0cc3756394c2427c256003)
yuha commented 2026-03-11 18:22:46 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f5b08b4e - WIP: use correct type for attendance haandling in mutation

Compare with previous version

added 1 commit <ul><li>f5b08b4e - WIP: use correct type for attendance haandling in mutation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84242&start_sha=1e8f04b4bd43b61a759fab141b6f9dfaba9b7bce)
yuha commented 2026-03-11 18:34:20 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3b2a1963 - Refine absence RSVP logic</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84243&start_sha=f5b08b4ee778807bd91ec9c0eae21b2fdab04b36)
yuha commented 2026-03-11 18:37:59 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>135ae7b9 - add todo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84244&start_sha=3b2a1963d8dec374c3e301561e8b0d4ec4411d21)
yuha commented 2026-03-12 16:10:44 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0906a79d - Adapt predicates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84298&start_sha=135ae7b9533931991fe56e106e8e127f1eb2e5bc)
yuha commented 2026-03-12 16:37:29 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • b51ba7f2 - Add is_own_absence predicate
  • c2534b6e - Use new predicate for absence creation rule

Compare with previous version

added 2 commits <ul><li>b51ba7f2 - Add is_own_absence predicate</li><li>c2534b6e - Use new predicate for absence creation rule</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84300&start_sha=0906a79d53c87afeb469cee5475ba42ae814fdf7)
yuha commented 2026-03-12 17:59:52 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • b63f27f0 - Fix usage of timezones in overlap handling

Compare with previous version

added 1 commit <ul><li>b63f27f0 - Fix usage of timezones in overlap handling</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84302&start_sha=c2534b6efe21e0830935500121bfa0a16e3fc2b6)
yuha commented 2026-03-12 18:03:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>aaf74cea - Add some todo/fixme comments</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84303&start_sha=b63f27f020ee8f3e288fea2db1a72ab50fb479cb)
yuha commented 2026-03-12 18:04:38 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ce5a5a0b - Really fix automatic FK attendance handling

Compare with previous version

added 1 commit <ul><li>ce5a5a0b - Really fix automatic FK attendance handling</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84304&start_sha=aaf74cea2bb40e443d88c3dccb3beaf6138e4871)
yuha commented 2026-03-12 18:15:33 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • aa68b9ff - Query more person fields for attendance
  • 0b50b91d - Add display component for absence reason

Compare with previous version

added 2 commits <ul><li>aa68b9ff - Query more person fields for attendance</li><li>0b50b91d - Add display component for absence reason</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84305&start_sha=ce5a5a0b398c808da8364d592d14f108e6e9d423)
yuha commented 2026-03-12 18:15:49 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • d7558c88 - Drop inline default components in absences table

Compare with previous version

added 1 commit <ul><li>d7558c88 - Drop inline default components in absences table</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84306&start_sha=0b50b91dff8675c446189ad3e9af8f553c599725)
yuha commented 2026-03-12 18:16:15 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>98239226 - Drop unused import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84307&start_sha=d7558c886b8f2a0ccdfa29a89039737f00c7cb8a)
yuha commented 2026-03-12 18:24:44 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 1bef460f - Add basic absence approval page

Compare with previous version

added 1 commit <ul><li>1bef460f - Add basic absence approval page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84308&start_sha=98239226bae9899eaf50e05fb9c781a13126feaf)
yuha commented 2026-03-12 18:47:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c63996c6 - Add approval buttons in actions column of CRUD list

Compare with previous version

added 1 commit <ul><li>c63996c6 - Add approval buttons in actions column of CRUD list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84309&start_sha=1bef460f47e8f0380345864d3596c4e956c24e35)
yuha commented 2026-03-13 16:50:31 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 82633479 - Add todos

Compare with previous version

added 1 commit <ul><li>82633479 - Add todos</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84406&start_sha=c63996c62d1cb3f13ba4e89f4f1dd65ed8917b29)
yuha commented 2026-03-13 17:18:56 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>18db3088 - Add todos</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84413&start_sha=826334790e8a46d8fcf7992e3caa7e39c13b22e6)
yuha commented 2026-03-16 14:09:43 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 6ca66d04 - Add predicate to check for membership in approval groups
  • 56ec568d - Add rule for approving absences

Compare with previous version

added 2 commits <ul><li>6ca66d04 - Add predicate to check for membership in approval groups</li><li>56ec568d - Add rule for approving absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84469&start_sha=18db308884b37a7ccebef40e3ea602c10c0d0afb)
yuha commented 2026-03-16 14:09:56 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c8388726 - Add method ob absence class to check rule

Compare with previous version

added 1 commit <ul><li>c8388726 - Add method ob absence class to check rule</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84470&start_sha=56ec568d01248c765e12b08962502ff0214fbe80)
yuha commented 2026-03-16 14:14:34 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>88e71cb4 - Fix core migration reference</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84471&start_sha=c83887267057b925d1627a0487500cd26f12750a)
yuha commented 2026-03-16 14:30:23 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • ae8a5ea7 - Use OneToOneField for attendance

Compare with previous version

added 1 commit <ul><li>ae8a5ea7 - Use OneToOneField for attendance</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84472&start_sha=88e71cb43ec35fc15d7e673f634f2dfca7e0e905)
yuha commented 2026-03-16 14:50:33 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 63069636 - Integrate mutations into absence approval frontend and implement cache updating

Compare with previous version

added 1 commit <ul><li>63069636 - Integrate mutations into absence approval frontend and implement cache updating</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84475&start_sha=ae8a5ea702de17af342361ca147e52df4f226e4d)
yuha commented 2026-03-16 15:28:01 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cc0ff8e0 - Use dedicated query for absence approval page

Compare with previous version

added 1 commit <ul><li>cc0ff8e0 - Use dedicated query for absence approval page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84478&start_sha=6306963695857eb57271f0f1f7892dfea4c3d286)
yuha commented 2026-03-16 15:28:49 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a758724a - Drop deprecated todos</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84479&start_sha=cc0ff8e04b1587b930d7c441931d4ce62b3c6c45)
yuha commented 2026-03-16 15:42:31 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7349c871 - Add filters</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84480&start_sha=a758724a1f032701e6531b23b9eaf1174a0797b6)
yuha commented 2026-03-16 15:52:46 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>76bb8e10 - Add todo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84481&start_sha=7349c871899bc5f7e554f5a932be685c4d26c3e5)
yuha commented 2026-03-16 16:01:07 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2a68f230 - Disable patch for absence approval page

Compare with previous version

added 1 commit <ul><li>2a68f230 - Disable patch for absence approval page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84482&start_sha=76bb8e1081bd072f48b9b9964eaaf194c83e6dbb)
yuha commented 2026-03-16 16:12:34 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 7d873053 - Set NEEDS-ACTION as default attendance status for absence requiring approval

Compare with previous version

added 1 commit <ul><li>7d873053 - Set NEEDS-ACTION as default attendance status for absence requiring approval</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84483&start_sha=2a68f230fd50aa6a3bb9d741e6a9ae65efb8ce69)
yuha commented 2026-03-17 18:15:12 +01:00 (Migrated from edugit.org)
Copy link
  • Add free/busy status methods to Absence and take attendance status into regard there
  • Implement notifications on status change for persons creating absences
  • Implement a nicer UI for actually creating absences (maybe also tweak wording: not creating, but requesting?)
  • Absence approval CRUD list: think about item grouping (by reason? by status? maybe hide some groups by default?) and default ordering (by status?). just as it seems, passing orderBy doesn't work anymore after the CRUD rewrite?
  • Check permissions for creating/editing

    • For creating, at least check the person being used & don't only use global perms

      -> maybe: make configurable who can create absences with a certain reason (or just allow creation for all approval-based absence types, at least?)

    • For editing:

      main objective: once absences are created, there has to be a differentiation between edits:

      • if the absence is a "no-approval-needed" one, just do as before (or even allow edits of own absences; maybe: introduce some more elaborated logic of filtering which AbsenceTypes are allowed to be used by whom already at point of creation?)

      • if the absence is an "approval-needed" one, each edit at least has to reset the approval status OR be denied if performed by a non-administrator person who is allowed to create certain absences (but some marker of privileged positions has to be retained, like now, with the GroupType based approach)

      • maybe: some fields that can be edited by all persons involved without having to deal with the approval status? like the comment?

* [x] Add free/busy status methods to Absence and take attendance status into regard there * [ ] Implement notifications on status change for persons creating absences * [ ] Implement a nicer UI for actually creating absences (maybe also tweak wording: not creating, but requesting?) * [ ] Absence approval CRUD list: think about item grouping (by reason? by status? maybe hide some groups by default?) and default ordering (by status?). just as it seems, passing orderBy doesn't work anymore after the CRUD rewrite? * [ ] Check permissions for creating/editing * [x] For creating, at least check the person being used & don't only use global perms \-\> maybe: make configurable who can create absences with a certain reason (or just allow creation for all approval-based absence types, at least?) * [ ] For editing: main objective: once absences are created, there has to be a differentiation between edits: - if the absence is a "no-approval-needed" one, just do as before (or even allow edits of own absences; maybe: introduce some more elaborated logic of filtering which AbsenceTypes are allowed to be used by whom already at point of creation?) - if the absence is an "approval-needed" one, each edit at least has to reset the approval status OR be denied if performed by a non-administrator person who is allowed to create certain absences (but some marker of privileged positions has to be retained, like now, with the GroupType based approach) - maybe: some fields that can be edited by all persons involved without having to deal with the approval status? like the comment?
yuha commented 2026-03-17 18:15:52 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>83fdb5fa - Drop some todos</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84510&start_sha=7d8730530c1428279cf5548359eb65ffd24dbd16)
yuha commented 2026-03-17 18:31:20 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • fb7f0d9b - WIP: Add methods for f/b status

Compare with previous version

added 1 commit <ul><li>fb7f0d9b - WIP: Add methods for f/b status</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84512&start_sha=83fdb5fa725dd76a470141b075ffd9743cf0c2ca)
yuha commented 2026-03-18 16:49:17 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0271c7b0 - Add managers</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84521&start_sha=fb7f0d9b9a6cc397c0ddc9ecb0e261b02e666d0b)
yuha commented 2026-03-18 17:14:33 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • fb22d250 - Refactor params handling in get_objects and only show accepted absences per default

Compare with previous version

added 1 commit <ul><li>fb22d250 - Refactor params handling in get_objects and only show accepted absences per default</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84524&start_sha=0271c7b07f670d482c24fdb8c0598cde65ac6ba9)
yuha commented 2026-03-18 17:15:24 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 2044877a - Refactor params handling in get_objects and only show accepted absences per default
  • 33d82b3c - Add freebusy type property

Compare with previous version

added 2 commits <ul><li>2044877a - Refactor params handling in get_objects and only show accepted absences per default</li><li>33d82b3c - Add freebusy type property</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84525&start_sha=fb22d250d5c8403f83e78709ab959babf517f8c5)
yuha commented 2026-03-18 17:15:58 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 51c5d723 - Complete get_availability_objects

Compare with previous version

added 1 commit <ul><li>51c5d723 - Complete get_availability_objects</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84526&start_sha=33d82b3cca8481f225936db3eada3ba5326e8e5e)
yuha commented 2026-03-18 17:20:58 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 8a38b003 - Show absence feed in calendar overview and expose via CalDAV

Compare with previous version

added 1 commit <ul><li>8a38b003 - Show absence feed in calendar overview and expose via CalDAV</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84528&start_sha=51c5d72392edf87758038b83bd38f7efb8531deb)
yuha commented 2026-03-18 17:21:11 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>75c0ac18 - Add missing import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84529&start_sha=8a38b003c619c4e83109b1d8703e2b627202b33f)
yuha commented 2026-03-18 17:23:11 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>99bfbf5c - Fix get_objects arguments</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84531&start_sha=75c0ac1837e43fe3ffc3feccb0dfbc983bd6e446)
yuha commented 2026-03-18 17:23:37 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>60e9246d - Add missing import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84532&start_sha=99bfbf5c759d1bae52e49d9304eb7abef6328f86)
yuha commented 2026-03-18 17:41:17 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ab0f1cae - Fix params handling</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84536&start_sha=60e9246dc43455fff53dea8543d4867f8dcc9694)
yuha commented 2026-03-18 18:24:39 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 22eb6f91 - Fix resolve_planned_absences_for_person filter
  • 8be332c7 - Adapt planned absences query

Compare with previous version

added 2 commits <ul><li>22eb6f91 - Fix resolve_planned_absences_for_person filter</li><li>8be332c7 - Adapt planned absences query</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84538&start_sha=ab0f1cae6c027a6f086556dce7be07fd41842296)
yuha commented 2026-03-18 18:29:34 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2e7e202b - Fix absence widget handling of full day absences

Compare with previous version

added 1 commit <ul><li>2e7e202b - Fix absence widget handling of full day absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84540&start_sha=8be332c77e48b69a1f9822a60f484069e861c13b)
yuha commented 2026-03-18 18:37:07 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 6d5aeab1 - Show absence status in widget

Compare with previous version

added 1 commit <ul><li>6d5aeab1 - Show absence status in widget</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84543&start_sha=2e7e202be53ac8ca32b8147e6950504927bd7aa0)
yuha commented 2026-03-18 19:00:06 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 7b0aecfc - Allow non-admin users to access & create absences

Compare with previous version

added 1 commit <ul><li>7b0aecfc - Allow non-admin users to access &amp; create absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84547&start_sha=6d5aeab1dfada56d6bce2162312d8c24c5d5c259)
yuha commented 2026-03-18 19:10:42 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b36d2781 - Drop todo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84549&start_sha=7b0aecfc924be8824edfb8cc67d9e116a8c6c1ad)
yuha commented 2026-03-18 19:26:36 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3116f7cb - Use better wording in status chip

Compare with previous version

added 1 commit <ul><li>3116f7cb - Use better wording in status chip</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84553&start_sha=b36d278129b80db576a8d7e4a535ece3c87f744f)
yuha commented 2026-03-18 19:40:44 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2fab0d66 - Fix overlap handling with duplicated attendances

Compare with previous version

added 1 commit <ul><li>2fab0d66 - Fix overlap handling with duplicated attendances</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84556&start_sha=3116f7cb4cfa1b7480d98da1d00d714756d50413)
yuha commented 2026-03-18 19:40:55 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>bec66f80 - Adapt tests</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84557&start_sha=2fab0d662f00f981ba2c8e0af4942a7629cfc768)
yuha commented 2026-03-18 20:02:55 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>26817f4c - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84564&start_sha=bec66f808182253eb0eb51a81096bc5ce8bf3ace)
yuha commented 2026-03-18 20:12:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f359b278 - Aadapt migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84571&start_sha=26817f4c3d4bf8b7765e7cac71de724970a30024)
yuha commented 2026-03-18 20:28:49 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>de68cd0a - Fix migrations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84575&start_sha=f359b2780bc395b9a89f15ddee3af30076d3a015)
yuha commented 2026-03-18 20:33:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>151a100c - Add changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84581&start_sha=de68cd0a35a4dbede4231071ed5ea4070b1eb0ac)
yuha commented 2026-03-18 20:38:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e832337c - Fix menu rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84583&start_sha=151a100cebfd2ccde0cf78633c7dda8ac2c426f1)
yuha commented 2026-03-18 20:50:57 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2026-03-18 20:54:41 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1d875539 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84595&start_sha=e832337c8bd8f5fc00849a1801e532c168f831bd)
yuha commented 2026-03-18 20:55:08 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker and unassigned @yuha

assigned to @hansegucker and unassigned @yuha
yuha commented 2026-03-18 21:12:15 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f170b2a7 - Fix tox migration creationn</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/113/diffs?diff_id=84598&start_sha=1d875539ec5b830f897cdc3afd6c6e3957fbd1ba)
hansegucker commented 2026-03-18 21:46:00 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 046f0d351d

mentioned in commit 046f0d351d179c95439a269ec677a9ed03a6c1d4
hansegucker (Migrated from edugit.org) merged commit 046f0d351d into master 2026-03-18 21:46:01 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Kolego!176
No description provided.