aleksis/AlekSIS-App-Kolego
8
0
Fork 0
Code Issues 21 Pull requests 2 Projects Releases Packages Activity Actions

Resolve "Migrate to Vue 3/Vuetify 3" #165

Merged
yuha merged 42 commits from 50-migrate-to-vue-3-vuetify-3 into master 2025-10-02 23:11:20 +02:00
Conversation 31 Commits 42 Files changed 23 +710 -1255
yuha commented 2025-09-03 09:54:09 +02:00 (Migrated from edugit.org)
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

  • Screenshots are attached (mobile and desktop)
  • Tested on mobile, tablet, and desktop sizes
  • Adhered to frontend guidelines
  • Checked with Firefox Accessibility Checker

Closes #50

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [x] Tested with admin account - [x] Tested with normal account (based on permissions) ## Backend checklist - [x] Use permissions for all GraphQL mutations - [x] Use query optimizer for all GraphQL queries - [x] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to frontend guidelines - [ ] Checked with Firefox Accessibility Checker Closes #50
yuha commented 2025-09-03 09:54:09 +02:00 (Migrated from edugit.org)
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2025-09-03 11:01:57 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 315db7d4 - Include eslint --fix in tox.ini reformat command
  • 700be1b5 - Update linter version
  • 12cb994a - Apply adaptation changes detected by linter
  • 8cdca46c - Remove unused empty component
  • a8371383 - Define person widget as async
  • 82a54321 - WIP: Adapt to CRUD changes

Compare with previous version

added 6 commits <ul><li>315db7d4 - Include eslint --fix in tox.ini reformat command</li><li>700be1b5 - Update linter version</li><li>12cb994a - Apply adaptation changes detected by linter</li><li>8cdca46c - Remove unused empty component</li><li>a8371383 - Define person widget as async</li><li>82a54321 - WIP: Adapt to CRUD changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71106&start_sha=83f096591d87242a57e21f53d9b24f0b2f6acc6c)
yuha commented 2025-09-04 00:27:26 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 8eca2652 - WIP: Adapt to CRUD changes

Compare with previous version

added 1 commit <ul><li>8eca2652 - WIP: Adapt to CRUD changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71167&start_sha=82a54321bce576677e0ea31228c960f55dd8826a)
yuha commented 2025-09-04 18:05:33 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>2b36c948 - Adapt to CRUD changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71203&start_sha=8eca2652908cae387fbd0dc2c0f26484a66ab8c2)
yuha commented 2025-09-13 18:05:08 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3d7bcf72 - Adapt TimeQuotaField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71368&start_sha=2b36c9485faefbffa42dbf59ddc1834356696b92)
yuha commented 2025-09-15 14:58:31 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 098203ab - (Temporarily) use v-autocomplete for units instead of ChipSelectField
  • ac5fd64b - Adapt objectSchemas
  • 14c92a62 - Remove unused field templates
  • 0b44429b - WIP: Adapt employment contracts CRUD list dynamic mechanisms

Compare with previous version

added 4 commits <ul><li>098203ab - (Temporarily) use v-autocomplete for units instead of ChipSelectField</li><li>ac5fd64b - Adapt objectSchemas</li><li>14c92a62 - Remove unused field templates</li><li>0b44429b - WIP: Adapt employment contracts CRUD list dynamic mechanisms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71401&start_sha=3d7bcf72fb9be929a376c492b54dd2a1b82b833d)
yuha commented 2025-09-22 14:12:52 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c2a789f0 - Remove custom date fields in absence CRUD list

Compare with previous version

added 1 commit <ul><li>c2a789f0 - Remove custom date fields in absence CRUD list</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71586&start_sha=0b44429bb63f38c92d22bb168b146c690408f830)
yuha commented 2025-10-01 11:16:45 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 7cf7b204 - Adapt person overview planned absences widget
  • d8e98869 - Remove todo in absence reason list
  • f18225d2 - Add display component for time quotas

Compare with previous version

added 3 commits <ul><li>7cf7b204 - Adapt person overview planned absences widget</li><li>d8e98869 - Remove todo in absence reason list</li><li>f18225d2 - Add display component for time quotas</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71798&start_sha=c2a789f06c9dfaf7a57813f9907845ab3772afb4)
yuha commented 2025-10-01 16:18:44 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 5b3c582f - Also show tags on absence reason crud page
  • a46bb6e0 - Add properties to EC to define form order
  • bd3a8b87 - WIP: Add expandable rows to EC list to display subquotas

Compare with previous version

added 3 commits <ul><li>5b3c582f - Also show tags on absence reason crud page</li><li>a46bb6e0 - Add properties to EC to define form order</li><li>bd3a8b87 - WIP: Add expandable rows to EC list to display subquotas</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71803&start_sha=f18225d2c2dd69eac04bd2a75d7893330cb4e61e)
yuha commented 2025-10-02 02:04:10 +02:00 (Migrated from edugit.org)
Copy link

added 14 commits

  • bd3a8b87...32cb5f8b - 4 earlier commits
  • 376711c0 - Fix usage of time quota field for subquotas
  • e1d13b00 - Remove unused stuff
  • 7f127c25 - Add funcitonality for subquotas for handling time quotas
  • 7e338c59 - Fix computed import
  • abd95c41 - Fix translations in time quota display component
  • 2a9e968b - Fix typo
  • 3aa86248 - Add correct default value
  • 42e19d56 - Use correct query for subquotas
  • a02fe836 - Add edit button to subquota cards
  • 25379e0d - Remove card title

Compare with previous version

added 14 commits <ul><li>bd3a8b87...32cb5f8b - 4 earlier commits</li><li>376711c0 - Fix usage of time quota field for subquotas</li><li>e1d13b00 - Remove unused stuff</li><li>7f127c25 - Add funcitonality for subquotas for handling time quotas</li><li>7e338c59 - Fix computed import</li><li>abd95c41 - Fix translations in time quota display component</li><li>2a9e968b - Fix typo</li><li>3aa86248 - Add correct default value</li><li>42e19d56 - Use correct query for subquotas</li><li>a02fe836 - Add edit button to subquota cards</li><li>25379e0d - Remove card title</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71810&start_sha=bd3a8b87babcc63554cdc5e47b335ddb68371725)
yuha commented 2025-10-02 11:02:27 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 1e777972 - Show ATs/ARs in subquota card
  • 11cf67d0 - Hide subquotas in table and edit form for ECs

Compare with previous version

added 2 commits <ul><li>1e777972 - Show ATs/ARs in subquota card</li><li>11cf67d0 - Hide subquotas in table and edit form for ECs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71813&start_sha=25379e0d9be82a7bb4c69dffe9a8ea44da2fb68b)
yuha commented 2025-10-02 12:20:07 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • cd487e05 - Use CRUD list for subquotas
  • 8e272ca3 - Use v-number-input in TimeQuotaField

Compare with previous version

added 2 commits <ul><li>cd487e05 - Use CRUD list for subquotas</li><li>8e272ca3 - Use v-number-input in TimeQuotaField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71814&start_sha=11cf67d0bfa322a3ce18f9c5729fa24de87bf19e)
yuha commented 2025-10-02 12:21:29 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • eee0a05b - Use v-number-input in TimeQuotaField

Compare with previous version

added 1 commit <ul><li>eee0a05b - Use v-number-input in TimeQuotaField</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71815&start_sha=8e272ca398ee07e67848e117c4201b35959e3a3d)
yuha commented 2025-10-02 12:47:14 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

Compare with previous version

added 4 commits <ul><li>c4083e36 - Drop different create buttons</li><li>1f2e58c7 - Adapt comments</li><li>dddcc275 - Fix TimeQuotaField v-model handling</li><li>bbd23cd2 - Fix editing time quotas</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71816&start_sha=eee0a05bbd1eb53162d660c2a1bffed6f8d23e8d)
yuha commented 2025-10-02 12:58:37 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 26280f6c - Ensure time quota is always set in editItem

Compare with previous version

added 1 commit <ul><li>26280f6c - Ensure time quota is always set in editItem</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71817&start_sha=bbd23cd27ab3b94b007cf4112c08314686340971)
yuha commented 2025-10-02 13:02:05 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **`tox -e reformat,lint` used** as completed
yuha commented 2025-10-02 13:02:08 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed
yuha commented 2025-10-02 13:02:14 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Tested with admin account as completed

marked the checklist item **Tested with admin account** as completed
yuha commented 2025-10-02 13:02:15 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Tested with normal account (based on permissions) as completed

marked the checklist item **Tested with normal account (based on permissions)** as completed
yuha commented 2025-10-02 13:05:21 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>90b6c1b5 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/102/diffs?diff_id=71819&start_sha=26280f6c162ffe147bf3f2c46a7aa74a2d33cf70)
yuha commented 2025-10-02 13:06:09 +02:00 (Migrated from edugit.org)
Copy link

This still has two issues that makes the EmploymentContract list unusable, but that are not confined to Kolego:

https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/1376

https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/1375

Regarding both issues, I have no clue what's going on

This still has two issues that makes the EmploymentContract list unusable, but that are not confined to Kolego: https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/1376 https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/1375 Regarding both issues, I have no clue what's going on
yuha commented 2025-10-02 13:06:12 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2025-10-02 13:06:22 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Use permissions for all GraphQL mutations as completed

marked the checklist item **Use permissions for all GraphQL mutations** as completed
yuha commented 2025-10-02 13:06:23 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Use query optimizer for all GraphQL queries as completed

marked the checklist item **Use query optimizer for all GraphQL queries** as completed
yuha commented 2025-10-02 13:06:26 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Don't use inefficient DB queries as completed

marked the checklist item **Don't use inefficient DB queries** as completed
hansegucker commented 2025-10-02 14:08:21 +02:00 (Migrated from edugit.org)
Copy link

Why?

Why?
hansegucker commented 2025-10-02 14:08:21 +02:00 (Migrated from edugit.org)
Copy link

left review comments

left review comments
yuha commented 2025-10-02 19:28:06 +02:00 (Migrated from edugit.org)
Copy link

well if i knew

well if i knew
yuha commented 2025-10-02 19:29:34 +02:00 (Migrated from edugit.org)
Copy link

ah because now, the regular delete mutation is used – there's no need for having it in two places when both mutations refer to the same one

ah because now, the regular delete mutation is used – there's no need for having it in two places when both mutations refer to the same one
yuha commented 2025-10-02 19:29:35 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-10-02 23:11:20 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit bd0330016c

mentioned in commit bd0330016c65f002a47cda1f0bc573c004d0f609
hansegucker (Migrated from edugit.org) merged commit bd0330016c into master 2025-10-02 23:11:20 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Kolego!165
No description provided.