Resolve "Add management of working times" #153

Merged
permcu merged 73 commits from 46-add-management-of-working-times into master 2025-06-29 13:04:36 +02:00
permcu commented 2025-05-07 10:17:56 +02:00 (Migrated from edugit.org)

Closes #46

Closes #46
permcu commented 2025-05-07 10:17:57 +02:00 (Migrated from edugit.org)

assigned to @hansegucker

assigned to @hansegucker
permcu commented 2025-05-08 18:25:47 +02:00 (Migrated from edugit.org)

added 5 commits

  • 4ac38250 - Introduce a staff-related managed absence reason tag
  • d38684b5 - Introduce the EmploymentContract model
  • 76a969a8 - Make working_hours_per_week's expression work
  • 16a615db - Add migration for EmploymentContract
  • afa5443a - Add TODO

Compare with previous version

added 5 commits <ul><li>4ac38250 - Introduce a staff-related managed absence reason tag</li><li>d38684b5 - Introduce the EmploymentContract model</li><li>76a969a8 - Make working_hours_per_week&#39;s expression work</li><li>16a615db - Add migration for EmploymentContract</li><li>afa5443a - Add TODO</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=60830&start_sha=d8d0b18e5bccaab31bdef1fac46473c421e29fad)
permcu commented 2025-05-09 17:08:54 +02:00 (Migrated from edugit.org)

added 1 commit

  • ca8f8c69 - TMP WIP EmploymentContract-Frontend

Compare with previous version

added 1 commit <ul><li>ca8f8c69 - TMP WIP EmploymentContract-Frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=60860&start_sha=afa5443a669ba87845cc576a415ed083fd644885)
permcu commented 2025-05-14 19:21:13 +02:00 (Migrated from edugit.org)

added 5 commits

  • 72194e93 - Sketch and integrate EmploymentContract-Frontend
  • eef8ba28 - Change StaffAbsenceReasonQuota's quota field to duration
  • 81c7cdac - Implement frontend for StaffAbsenceReasonQuotas
  • f6aefdfc - Specify employment graphql file
  • d457ee9c - WIP Implement EmploymentContract schema

Compare with previous version

added 5 commits <ul><li>72194e93 - Sketch and integrate EmploymentContract-Frontend</li><li>eef8ba28 - Change StaffAbsenceReasonQuota&#39;s quota field to duration</li><li>81c7cdac - Implement frontend for StaffAbsenceReasonQuotas</li><li>f6aefdfc - Specify employment graphql file</li><li>d457ee9c - WIP Implement EmploymentContract schema</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=60962&start_sha=ca8f8c69e9d5c44dc846f1c2bc47197e6fb1f391)
permcu commented 2025-05-20 15:26:35 +02:00 (Migrated from edugit.org)

added 15 commits

  • d457ee9c...9749bb3d - 5 earlier commits
  • c9a31d58 - Adapt EmploymentContract migration to new uuid field
  • 4f322d6b - Add translations (en & de) for EmploymentContracts
  • f5417e3a - Change StaffAbsenceReasonQuota frontend
  • 23ae4af3 - Style EmploymentContract create dialoge
  • f3524519 - Add translations for employment_contract title_plural
  • bfb16805 - Fix EmploymentContract mutation declaration
  • 5ea9d87a - Properly align PersonChip
  • 2d5fd807 - Format duration to strings for frontend backend transfer
  • 3622893d - Handle StaffAbsenceReasonQuota values in display and create
  • 27980f7c - Fix EmploymentContractType schema by implementing what cud misses

Compare with previous version

added 15 commits <ul><li>d457ee9c...9749bb3d - 5 earlier commits</li><li>c9a31d58 - Adapt EmploymentContract migration to new uuid field</li><li>4f322d6b - Add translations (en &amp; de) for EmploymentContracts</li><li>f5417e3a - Change StaffAbsenceReasonQuota frontend</li><li>23ae4af3 - Style EmploymentContract create dialoge</li><li>f3524519 - Add translations for employment_contract title_plural</li><li>bfb16805 - Fix EmploymentContract mutation declaration</li><li>5ea9d87a - Properly align PersonChip</li><li>2d5fd807 - Format duration to strings for frontend backend transfer</li><li>3622893d - Handle StaffAbsenceReasonQuota values in display and create</li><li>27980f7c - Fix EmploymentContractType schema by implementing what cud misses</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=61623&start_sha=d457ee9c5069b2365f80e851920105e08dfe6de0)
permcu commented 2025-05-20 19:59:24 +02:00 (Migrated from edugit.org)

added 6 commits

  • b601babd - Switch from PositiveSmallIntegerField to PositiveFloatField
  • 68fc354c - Fix duration serialization
  • a92a033a - Add getNameOfItem for delete confirmation
  • d4367c3f - Show unit of quota
  • f69fd1fb - Add canEdit and canDelete to employmentContracts query
  • b8e9610b - Add _str_ and metaclass to EmploymentContract

Compare with previous version

added 6 commits <ul><li>b601babd - Switch from PositiveSmallIntegerField to PositiveFloatField</li><li>68fc354c - Fix duration serialization</li><li>a92a033a - Add getNameOfItem for delete confirmation</li><li>d4367c3f - Show unit of quota</li><li>f69fd1fb - Add canEdit and canDelete to employmentContracts query</li><li>b8e9610b - Add _str_ and metaclass to EmploymentContract</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=61666&start_sha=27980f7c11b7052b36ebe136759eec8a6de29b00)
permcu commented 2025-05-20 20:01:45 +02:00 (Migrated from edugit.org)

added 3 commits

  • dbeb0539 - Show unit of quota
  • 61b80698 - Add canEdit and canDelete to employmentContracts query
  • 1affac93 - Add _str_ and metaclass to EmploymentContract

Compare with previous version

added 3 commits <ul><li>dbeb0539 - Show unit of quota</li><li>61b80698 - Add canEdit and canDelete to employmentContracts query</li><li>1affac93 - Add _str_ and metaclass to EmploymentContract</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=61667&start_sha=b8e9610b246739a38461c4e0188b8af887048265)
permcu commented 2025-05-21 20:01:40 +02:00 (Migrated from edugit.org)

added 7 commits

  • f6428ebd - Add _str_ and metaclass to EmploymentContract
  • c33c8994 - Change time_logging_calendar_feeds to ArrayField
  • bf9d5a42 - Add missing CalendarFeedField import
  • 4472ad18 - Show timeLoggingCalendarFeeds with chips
  • eabc4fb7 - Rename EmploymentContracts queries and mutations
  • 331bd70f - Add rules to EmploymentContract frontend
  • 3cf67360 - Make updating EmploymentContracts work

Compare with previous version

added 7 commits <ul><li>f6428ebd - Add _str_ and metaclass to EmploymentContract</li><li>c33c8994 - Change time_logging_calendar_feeds to ArrayField</li><li>bf9d5a42 - Add missing CalendarFeedField import</li><li>4472ad18 - Show timeLoggingCalendarFeeds with chips</li><li>eabc4fb7 - Rename EmploymentContracts queries and mutations</li><li>331bd70f - Add rules to EmploymentContract frontend</li><li>3cf67360 - Make updating EmploymentContracts work</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=61742&start_sha=1affac9345fd5472886294d793535d47d9b4e676)
permcu commented 2025-05-21 20:49:46 +02:00 (Migrated from edugit.org)

added 1 commit

  • 0898c146 - Reformat

Compare with previous version

added 1 commit <ul><li>0898c146 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=61763&start_sha=3cf67360d0ff2fc1dec33473fb200de2b82676dd)
hansegucker commented 2025-05-28 20:46:46 +02:00 (Migrated from edugit.org)

marked this merge request as ready

marked this merge request as **ready**
permcu commented 2025-05-30 10:48:38 +02:00 (Migrated from edugit.org)
Needs: https://edugit.org/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/91
permcu commented 2025-05-30 11:25:22 +02:00 (Migrated from edugit.org)

added 46 commits

  • 0898c146...c3397ebf - 6 commits from branch master
  • c3397ebf...73c409c9 - 30 earlier commits
  • d4948f2e - Add _str_ and metaclass to EmploymentContract
  • 391277bf - Change time_logging_calendar_feeds to ArrayField
  • 0d0fd99e - Add missing CalendarFeedField import
  • d2fdec6f - Show timeLoggingCalendarFeeds with chips
  • f9b6ad0e - Rename EmploymentContracts queries and mutations
  • d18a5cea - Add rules to EmploymentContract frontend
  • 404af384 - Make updating EmploymentContracts work
  • d0ace01e - Reformat
  • b0f58180 - Fix missing icon
  • 621e51c8 - Reformat

Compare with previous version

added 46 commits <ul><li>0898c146...c3397ebf - 6 commits from branch <code>master</code></li><li>c3397ebf...73c409c9 - 30 earlier commits</li><li>d4948f2e - Add _str_ and metaclass to EmploymentContract</li><li>391277bf - Change time_logging_calendar_feeds to ArrayField</li><li>0d0fd99e - Add missing CalendarFeedField import</li><li>d2fdec6f - Show timeLoggingCalendarFeeds with chips</li><li>f9b6ad0e - Rename EmploymentContracts queries and mutations</li><li>d18a5cea - Add rules to EmploymentContract frontend</li><li>404af384 - Make updating EmploymentContracts work</li><li>d0ace01e - Reformat</li><li>b0f58180 - Fix missing icon</li><li>621e51c8 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=63353&start_sha=0898c14663fa4d925e784222e4a7eb5c0ec7abe7)
hansegucker commented 2025-06-04 18:25:59 +02:00 (Migrated from edugit.org)

This logic should live as properties in the model.

This logic should live as properties in the model.
hansegucker commented 2025-06-04 18:25:59 +02:00 (Migrated from edugit.org)

This logic should live as property in the model.

This logic should live as property in the model.
hansegucker commented 2025-06-04 18:25:59 +02:00 (Migrated from edugit.org)

This looks inefficient, nobody will set a permission for a single absence reason.

This looks inefficient, nobody will set a permission for a single absence reason.
hansegucker commented 2025-06-04 18:25:59 +02:00 (Migrated from edugit.org)

This concept now exists.

This concept now exists.
hansegucker commented 2025-06-04 18:25:59 +02:00 (Migrated from edugit.org)

Please use consistent capitalization.

Please use consistent capitalization.
hansegucker commented 2025-06-04 18:25:59 +02:00 (Migrated from edugit.org)

That should live in maintain_default_data instead of a migration.

That should live in `maintain_default_data` instead of a migration.
hansegucker commented 2025-06-04 18:26:00 +02:00 (Migrated from edugit.org)

TODO

TODO
hansegucker commented 2025-06-04 18:26:00 +02:00 (Migrated from edugit.org)

requested changes

requested changes
hansegucker commented 2025-06-04 19:50:49 +02:00 (Migrated from edugit.org)
Traceback (most recent call last):
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python3.13/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/usr/lib/python3.13/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/views/decorators/csrf.py", line 65, in _view_wrapper
    return view_func(request, *args, **kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/utils/decorators.py", line 48, in _wrapper
    return bound_method(*args, **kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/utils/decorators.py", line 192, in _view_wrapper
    result = _process_exception(request, e)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/utils/decorators.py", line 190, in _view_wrapper
    response = view_func(request, *args, **kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/views.py", line 201, in dispatch
    result, status_code = self.get_response(request, data, show_graphiql)
                          ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/views.py", line 218, in get_response
    execution_result = self.execute_graphql_request(
        request, data, query, variables, operation_name, show_graphiql
    )
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/views.py", line 785, in execute_graphql_request
    raise error
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphql/execution/execute.py", line 542, in execute_field
    completed = self.complete_value(
        return_type, field_nodes, info, path, result
    )
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphql/execution/execute.py", line 609, in complete_value
    raise result
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/debug/middleware.py", line 65, in resolve
    result = next(root, info, **args)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/schema/base.py", line 279, in mutate
    return super().mutate(root, info, *args, **kwargs)
           ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django_cud/mutations/batch_create.py", line 234, in mutate
    obj = cls.create_obj(
        data,
    ...<7 lines>...
        Model,
    )
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django_cud/mutations/core.py", line 409, in create_obj
    obj.save()
    ~~~~~~~~^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/mixins.py", line 168, in save
    super().save(*args, **kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/base.py", line 902, in save
    self.save_base(
    ~~~~~~~~~~~~~~^
        using=using,
        ^^^^^^^^^^^^
    ...<2 lines>...
        update_fields=update_fields,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/base.py", line 1008, in save_base
    updated = self._save_table(
        raw,
    ...<4 lines>...
        update_fields,
    )
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/base.py", line 1169, in _save_table
    results = self._do_insert(
        cls._base_manager, using, fields, returning_fields, raw
    )
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/base.py", line 1210, in _do_insert
    return manager._insert(
           ~~~~~~~~~~~~~~~^
        [self],
        ^^^^^^^
    ...<3 lines>...
        raw=raw,
        ^^^^^^^^
    )
    ^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/manager.py", line 87, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/query.py", line 1868, in _insert
    return query.get_compiler(using=using).execute_sql(returning_fields)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/sql/compiler.py", line 1882, in execute_sql
    cursor.execute(sql, params)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/debug/sql/tracking.py", line 153, in execute
    return self._record(self.cursor.execute, sql, params)
           ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/debug/sql/tracking.py", line 99, in _record
    return method(sql, params)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 122, in execute
    return super().execute(sql, params)
           ~~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 79, in execute
    return self._execute_with_wrappers(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sql, params, many=False, executor=self._execute
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 92, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 100, in _execute
    with self.db.wrap_database_errors:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 105, in _execute
    return self.cursor.execute(sql, params)
           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django_prometheus/db/common.py", line 69, in execute
    return super().execute(*args, **kwargs)
           ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/psycopg/cursor.py", line 97, in execute
    raise ex.with_traceback(None)
graphql.error.graphql_error.GraphQLError: Division durch Null

GraphQL request:2:3
1 | mutation createEmploymentContracts($input: [BatchCreateEmploymentContractInput]!) {
2 |   createEmploymentContracts(input: $input) {
  |   ^
3 |     items: employmentContracts {

grafik

``` Traceback (most recent call last): File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/core/handlers/exception.py", line 55, in inner response = get_response(request) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/core/handlers/base.py", line 197, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python3.13/contextlib.py", line 85, in inner return func(*args, **kwds) File "/usr/lib/python3.13/contextlib.py", line 85, in inner return func(*args, **kwds) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/views/decorators/csrf.py", line 65, in _view_wrapper return view_func(request, *args, **kwargs) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/views/generic/base.py", line 104, in view return self.dispatch(request, *args, **kwargs) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/utils/decorators.py", line 48, in _wrapper return bound_method(*args, **kwargs) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/utils/decorators.py", line 192, in _view_wrapper result = _process_exception(request, e) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/utils/decorators.py", line 190, in _view_wrapper response = view_func(request, *args, **kwargs) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/views.py", line 201, in dispatch result, status_code = self.get_response(request, data, show_graphiql) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/views.py", line 218, in get_response execution_result = self.execute_graphql_request( request, data, query, variables, operation_name, show_graphiql ) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/views.py", line 785, in execute_graphql_request raise error File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphql/execution/execute.py", line 542, in execute_field completed = self.complete_value( return_type, field_nodes, info, path, result ) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphql/execution/execute.py", line 609, in complete_value raise result File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/debug/middleware.py", line 65, in resolve result = next(root, info, **args) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/schema/base.py", line 279, in mutate return super().mutate(root, info, *args, **kwargs) ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django_cud/mutations/batch_create.py", line 234, in mutate obj = cls.create_obj( data, ...<7 lines>... Model, ) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django_cud/mutations/core.py", line 409, in create_obj obj.save() ~~~~~~~~^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/mixins.py", line 168, in save super().save(*args, **kwargs) ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/base.py", line 902, in save self.save_base( ~~~~~~~~~~~~~~^ using=using, ^^^^^^^^^^^^ ...<2 lines>... update_fields=update_fields, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ) ^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/base.py", line 1008, in save_base updated = self._save_table( raw, ...<4 lines>... update_fields, ) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/base.py", line 1169, in _save_table results = self._do_insert( cls._base_manager, using, fields, returning_fields, raw ) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/base.py", line 1210, in _do_insert return manager._insert( ~~~~~~~~~~~~~~~^ [self], ^^^^^^^ ...<3 lines>... raw=raw, ^^^^^^^^ ) ^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/manager.py", line 87, in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/query.py", line 1868, in _insert return query.get_compiler(using=using).execute_sql(returning_fields) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/models/sql/compiler.py", line 1882, in execute_sql cursor.execute(sql, params) ~~~~~~~~~~~~~~^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/debug/sql/tracking.py", line 153, in execute return self._record(self.cursor.execute, sql, params) ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/graphene_django/debug/sql/tracking.py", line 99, in _record return method(sql, params) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 122, in execute return super().execute(sql, params) ~~~~~~~~~~~~~~~^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 79, in execute return self._execute_with_wrappers( ~~~~~~~~~~~~~~~~~~~~~~~~~~~^ sql, params, many=False, executor=self._execute ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ) ^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 92, in _execute_with_wrappers return executor(sql, params, many, context) File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 100, in _execute with self.db.wrap_database_errors: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/utils.py", line 91, in __exit__ raise dj_exc_value.with_traceback(traceback) from exc_value File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django/db/backends/utils.py", line 105, in _execute return self.cursor.execute(sql, params) ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/django_prometheus/db/common.py", line 69, in execute return super().execute(*args, **kwargs) ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^ File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-App-Kolego/.venv/lib/python3.13/site-packages/psycopg/cursor.py", line 97, in execute raise ex.with_traceback(None) graphql.error.graphql_error.GraphQLError: Division durch Null GraphQL request:2:3 1 | mutation createEmploymentContracts($input: [BatchCreateEmploymentContractInput]!) { 2 | createEmploymentContracts(input: $input) { | ^ 3 | items: employmentContracts { ``` ![grafik](/uploads/dfd7269a188c1aa570145c8aeac578df/grafik.png)
permcu commented 2025-06-05 15:40:40 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
permcu commented 2025-06-05 17:00:30 +02:00 (Migrated from edugit.org)

I can not reproduce. Can you try again and if applicable please send more detailed instructions for reproduction.

I can not reproduce. Can you try again and if applicable please send more detailed instructions for reproduction.
permcu commented 2025-06-05 17:00:39 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
permcu commented 2025-06-05 17:05:03 +02:00 (Migrated from edugit.org)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=64544&start_sha=621e51c85b74e68eceee5a3a6f27d369f7d9d410#622064dac8cf119ac36fe69a1a7b2691db389ace_50_63)
permcu commented 2025-06-05 17:05:04 +02:00 (Migrated from edugit.org)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=64544&start_sha=621e51c85b74e68eceee5a3a6f27d369f7d9d410#622064dac8cf119ac36fe69a1a7b2691db389ace_26_25)
permcu commented 2025-06-05 17:05:05 +02:00 (Migrated from edugit.org)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=64544&start_sha=621e51c85b74e68eceee5a3a6f27d369f7d9d410#94dfec8c95f2aa0b8780ec608aa2e39425af7b66_72_89)
permcu commented 2025-06-05 17:05:06 +02:00 (Migrated from edugit.org)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=64544&start_sha=621e51c85b74e68eceee5a3a6f27d369f7d9d410#94dfec8c95f2aa0b8780ec608aa2e39425af7b66_58_75)
permcu commented 2025-06-05 17:05:06 +02:00 (Migrated from edugit.org)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=64544&start_sha=621e51c85b74e68eceee5a3a6f27d369f7d9d410#98d6cdc5f0bfe404b194cd0e11a8b6ef6c01bcc0_11_0)
permcu commented 2025-06-05 17:05:07 +02:00 (Migrated from edugit.org)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=64544&start_sha=621e51c85b74e68eceee5a3a6f27d369f7d9d410#f7a540167e33b07e6dbe25dfd9570726547a305c_1_1)
permcu commented 2025-06-05 17:05:07 +02:00 (Migrated from edugit.org)

added 12 commits

  • 621e51c8...0acdc44d - 2 earlier commits
  • 5dbab94f - Create staff AbsenceReasonTag via maintain_default_data
  • d5948fb6 - Allow EmploymentContract end date to be empty
  • 1e885e23 - Change capitalization
  • 8fb8f20f - Remove already done todo
  • accf3d47 - Add AvailabilityTypeQuotas to EmploymentContracts
  • 95f4bcba - Reformat
  • f396dadc - Set more useful default values for working hours
  • 12b5b194 - Guard against unset quotas
  • 51e1c61c - Fix uuid field in employment contract migration
  • 04cc5eef - Exclude uuid in auto generated quotas

Compare with previous version

added 12 commits <ul><li>621e51c8...0acdc44d - 2 earlier commits</li><li>5dbab94f - Create staff AbsenceReasonTag via maintain_default_data</li><li>d5948fb6 - Allow EmploymentContract end date to be empty</li><li>1e885e23 - Change capitalization</li><li>8fb8f20f - Remove already done todo</li><li>accf3d47 - Add AvailabilityTypeQuotas to EmploymentContracts</li><li>95f4bcba - Reformat</li><li>f396dadc - Set more useful default values for working hours</li><li>12b5b194 - Guard against unset quotas</li><li>51e1c61c - Fix uuid field in employment contract migration</li><li>04cc5eef - Exclude uuid in auto generated quotas</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=64544&start_sha=621e51c85b74e68eceee5a3a6f27d369f7d9d410)
permcu commented 2025-06-05 17:10:52 +02:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>a04470b8 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=64548&start_sha=04cc5eefa42491d76a1f78b00d57f47a984d1f03)
permcu commented 2025-06-05 17:15:51 +02:00 (Migrated from edugit.org)

Lint runs locally. The three errors seem caused by missing imports from core. Errors do not happen if code is run. Only here during lint.

Lint runs locally. The three errors seem caused by missing imports from core. Errors do not happen if code is run. Only here during lint.
yuha commented 2025-06-10 10:14:41 +02:00 (Migrated from edugit.org)

TODO: Add timeLoggingCalendarFeeds to individual staff absence reason and availability type quotas

TODO: Add timeLoggingCalendarFeeds to individual staff absence reason and availability type quotas
yuha commented 2025-06-10 10:47:53 +02:00 (Migrated from edugit.org)

TODO: Add duration field in frontend

TODO: Add duration field in frontend
yuha commented 2025-06-10 11:54:33 +02:00 (Migrated from edugit.org)

added 1 commit

  • 3e459ef8 - WIP

Compare with previous version

added 1 commit <ul><li>3e459ef8 - WIP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65039&start_sha=a04470b8d70596217f559de44c7491aef0bebaf6)
hansegucker commented 2025-06-10 17:53:37 +02:00 (Migrated from edugit.org)

.

.
hansegucker commented 2025-06-10 18:02:09 +02:00 (Migrated from edugit.org)

I filled out the minimum data:

grafik

{
  "errors": [
    {
      "message": "Variable '$input' got invalid value {'quota': '0:0:0', 'timeLoggingCalendarFeeds': [], 'availabilityType': '1'} at 'input[0].availabilityTypeQuotasAdd[0]'; Field 'quotaBase' of required type 'TimeDelta!' was not provided.",
      "locations": [
        {
          "line": 1,
          "column": 36
        }
      ]
    },
    {
      "message": "Variable '$input' got invalid value {'quota': '0:0:0', 'timeLoggingCalendarFeeds': [], 'availabilityType': '2'} at 'input[0].availabilityTypeQuotasAdd[1]'; Field 'quotaBase' of required type 'TimeDelta!' was not provided.",
      "locations": [
        {
          "line": 1,
          "column": 36
        }
      ]
    }
  ]
}
I filled out the minimum data: ![grafik](/uploads/78b1aef9afdf9405babc92f5706374ea/grafik.png) ``` { "errors": [ { "message": "Variable '$input' got invalid value {'quota': '0:0:0', 'timeLoggingCalendarFeeds': [], 'availabilityType': '1'} at 'input[0].availabilityTypeQuotasAdd[0]'; Field 'quotaBase' of required type 'TimeDelta!' was not provided.", "locations": [ { "line": 1, "column": 36 } ] }, { "message": "Variable '$input' got invalid value {'quota': '0:0:0', 'timeLoggingCalendarFeeds': [], 'availabilityType': '2'} at 'input[0].availabilityTypeQuotasAdd[1]'; Field 'quotaBase' of required type 'TimeDelta!' was not provided.", "locations": [ { "line": 1, "column": 36 } ] } ] } ```
permcu commented 2025-06-11 14:06:28 +02:00 (Migrated from edugit.org)

OK. Even with this input which is similar to the last you posted I can not reproduce the original error. The new error you encountered seems to be related to Hangzihs WIP commit. Since it is called WIP I think errors could still happen there.

OK. Even with this input which is similar to the last you posted I can not reproduce the original error. The new error you encountered seems to be related to Hangzihs WIP commit. Since it is called WIP I think errors could still happen there.
hansegucker commented 2025-06-11 14:12:27 +02:00 (Migrated from edugit.org)

I have no idea. It just doesn't work and please coordinate with @yuha to solve it.

I have no idea. It just doesn't work and please coordinate with @yuha to solve it.
permcu commented 2025-06-11 14:13:33 +02:00 (Migrated from edugit.org)

Please try without yuhas wip commit. It should work then. That a wip can error seems fine for me. It is not finished.

Please try without yuhas wip commit. It should work then. That a wip can error seems fine for me. It is not finished.
hansegucker commented 2025-06-11 20:26:14 +02:00 (Migrated from edugit.org)

Unkaputte das mal

Unkaputte das mal
hansegucker commented 2025-06-11 20:39:05 +02:00 (Migrated from edugit.org)

grafik

![grafik](/uploads/35f90d7cfdb8e1835b123748e3fe974b/grafik.png)
hansegucker commented 2025-06-11 20:52:19 +02:00 (Migrated from edugit.org)

probably as own model

probably as own model
yuha commented 2025-06-11 21:03:14 +02:00 (Migrated from edugit.org)

TODO: generalize quotas into one model; at least one of absence reason, availability type and time logging calendar feeds all needs to be not empty

TODO: generalize quotas into one model; at least one of absence reason, availability type and time logging calendar feeds all needs to be not empty
yuha commented 2025-06-11 21:04:24 +02:00 (Migrated from edugit.org)

does help to represent something like subquotas for actually delivered substitution lessons

does help to represent something like subquotas for actually delivered substitution lessons
yuha commented 2025-06-11 23:30:31 +02:00 (Migrated from edugit.org)

with durations as generated fields

with durations as generated fields
yuha commented 2025-06-12 15:56:59 +02:00 (Migrated from edugit.org)
see https://edugit.org/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90#note_114700
yuha commented 2025-06-12 16:49:32 +02:00 (Migrated from edugit.org)

added 1 commit

  • 81aef133 - WIP

Compare with previous version

added 1 commit <ul><li>81aef133 - WIP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65170&start_sha=3e459ef8b177722e7ea19c63ed3ce0e93ab82c67)
yuha commented 2025-06-13 18:17:47 +02:00 (Migrated from edugit.org)

added 1 commit

  • 779f21d2 - WIP

Compare with previous version

added 1 commit <ul><li>779f21d2 - WIP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65194&start_sha=81aef133e6d4a29a0da9cd5618d8e6db955f74f5)
yuha commented 2025-06-14 16:07:24 +02:00 (Migrated from edugit.org)

added 1 commit

  • 32426ca4 - WIP

Compare with previous version

added 1 commit <ul><li>32426ca4 - WIP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65221&start_sha=779f21d2b1e944260088a94b6263579d6cc1f92f)
yuha commented 2025-06-17 13:47:21 +02:00 (Migrated from edugit.org)

added 1 commit

  • 229e1d94 - WIP

Compare with previous version

added 1 commit <ul><li>229e1d94 - WIP</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65281&start_sha=32426ca40ae3a08e881048d62ead359966743681)
yuha commented 2025-06-17 14:25:46 +02:00 (Migrated from edugit.org)

added 1 commit

  • d8574b7e - Implement subquotas and seperate time quota model and adapt frontend

Compare with previous version

added 1 commit <ul><li>d8574b7e - Implement subquotas and seperate time quota model and adapt frontend</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65282&start_sha=229e1d94bfc8242192b3cbddc91487b63eea51f2)
yuha commented 2025-06-17 14:26:56 +02:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>f7ea197c - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65283&start_sha=d8574b7e1ae7c1ae935c30e7133233ab08dc1687)
yuha commented 2025-06-17 14:34:10 +02:00 (Migrated from edugit.org)

added 4 commits

  • 2bd63acc - Remove unused code
  • 78f6a783 - Re-introduce encoded duration fields in graphene
  • 23b6e658 - Remove comment
  • 853ad2f6 - Use CRUDList instead of InlineCRUDList

Compare with previous version

added 4 commits <ul><li>2bd63acc - Remove unused code</li><li>78f6a783 - Re-introduce encoded duration fields in graphene</li><li>23b6e658 - Remove comment</li><li>853ad2f6 - Use CRUDList instead of InlineCRUDList</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65287&start_sha=f7ea197c6b885a4318e4347165ef3047eefe54d7)
yuha commented 2025-06-17 14:35:20 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
yuha commented 2025-06-18 10:32:37 +02:00 (Migrated from edugit.org)

added 1 commit

  • 77d54b0d - Add better handling for empty subquotas

Compare with previous version

added 1 commit <ul><li>77d54b0d - Add better handling for empty subquotas</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65323&start_sha=853ad2f66f78e54e6347eaadaab46909d0ee6da8)
yuha commented 2025-06-19 01:51:14 +02:00 (Migrated from edugit.org)

added 2 commits

  • 91bc5500 - Set new quotaBase default value
  • 4ca8d87f - WIP: Add separate field for additional subquotas

Compare with previous version

added 2 commits <ul><li>91bc5500 - Set new quotaBase default value</li><li>4ca8d87f - WIP: Add separate field for additional subquotas</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65493&start_sha=77d54b0d670707cc2607ca473a1f5f641783e450)
yuha commented 2025-06-20 17:41:05 +02:00 (Migrated from edugit.org)

added 1 commit

  • 2331de03 - WIP: Add separate field for additional subquotas

Compare with previous version

added 1 commit <ul><li>2331de03 - WIP: Add separate field for additional subquotas</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65573&start_sha=4ca8d87f0ac81c6a1adc09213f80dbca68cdf893)
yuha commented 2025-06-23 11:39:11 +02:00 (Migrated from edugit.org)

added 5 commits

  • a47e67bf - Add separate field for additional subquotas
  • ef7d849e - Refactor subquotas frontend
  • d4df6906 - Filter __typename prop of quotas when sending
  • 1852ecf5 - Remove done todo
  • b49fef30 - Fix querying for canEdit/canDelete fields

Compare with previous version

added 5 commits <ul><li>a47e67bf - Add separate field for additional subquotas</li><li>ef7d849e - Refactor subquotas frontend</li><li>d4df6906 - Filter __typename prop of quotas when sending</li><li>1852ecf5 - Remove done todo</li><li>b49fef30 - Fix querying for canEdit/canDelete fields</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65599&start_sha=2331de0304a2f9df6e0d569d808a574c052b109f)
yuha commented 2025-06-23 11:41:46 +02:00 (Migrated from edugit.org)

added 1 commit

  • a92a3b27 - WIP: Properly implement M2M/FK extras update/delete

Compare with previous version

added 1 commit <ul><li>a92a3b27 - WIP: Properly implement M2M/FK extras update/delete</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65601&start_sha=b49fef30f7406b14f04d7f12c6081977fadb261a)
hansegucker commented 2025-06-23 21:33:09 +02:00 (Migrated from edugit.org)

That should be a method in the quota model.

That should be a method in the quota model.
hansegucker commented 2025-06-23 21:33:09 +02:00 (Migrated from edugit.org)

That should be a method in the quota model.

That should be a method in the quota model.
hansegucker commented 2025-06-23 21:33:09 +02:00 (Migrated from edugit.org)

TODO

TODO
yuha commented 2025-06-26 03:06:00 +02:00 (Migrated from edugit.org)

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65630&start_sha=a92a3b27f8a27822870ff9fbb4d00d0a2e635c2c#622064dac8cf119ac36fe69a1a7b2691db389ace_174_175)
yuha commented 2025-06-26 03:06:01 +02:00 (Migrated from edugit.org)

added 1 commit

  • a697e748 - WIP: Properly implement M2M/FK extras update/delete

Compare with previous version

added 1 commit <ul><li>a697e748 - WIP: Properly implement M2M/FK extras update/delete</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65630&start_sha=a92a3b27f8a27822870ff9fbb4d00d0a2e635c2c)
yuha commented 2025-06-27 17:45:19 +02:00 (Migrated from edugit.org)

added 1 commit

  • 456481ac - WIP: Properly implement M2M/FK extras update/delete

Compare with previous version

added 1 commit <ul><li>456481ac - WIP: Properly implement M2M/FK extras update/delete</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65649&start_sha=a697e74865110be5a426659256f2c1873c370b2a)
yuha commented 2025-06-29 12:25:06 +02:00 (Migrated from edugit.org)

added 3 commits

  • 442dca33 - Handle absence reason and availability type fields correctly
  • df033d26 - Remove unused todo
  • b0eec305 - Add remove button for subquotas

Compare with previous version

added 3 commits <ul><li>442dca33 - Handle absence reason and availability type fields correctly</li><li>df033d26 - Remove unused todo</li><li>b0eec305 - Add remove button for subquotas</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65661&start_sha=456481ac9bb90a47e171994c9ab15e0383d5c9dd)
yuha commented 2025-06-29 12:35:03 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
yuha commented 2025-06-29 12:35:05 +02:00 (Migrated from edugit.org)

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65663&start_sha=b0eec305a9fc63134376be4f0e0955c97bd6d618#622064dac8cf119ac36fe69a1a7b2691db389ace_33_26)
yuha commented 2025-06-29 12:35:07 +02:00 (Migrated from edugit.org)

changed this line in version 28 of the diff

changed this line in [version 28 of the diff](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65663&start_sha=b0eec305a9fc63134376be4f0e0955c97bd6d618#622064dac8cf119ac36fe69a1a7b2691db389ace_39_26)
yuha commented 2025-06-29 12:35:08 +02:00 (Migrated from edugit.org)

added 1 commit

  • b442ba85 - Move duration iso string generator code in model

Compare with previous version

added 1 commit <ul><li>b442ba85 - Move duration iso string generator code in model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65663&start_sha=b0eec305a9fc63134376be4f0e0955c97bd6d618)
yuha commented 2025-06-29 12:35:59 +02:00 (Migrated from edugit.org)

added 5 commits

  • 49956c24 - Properly implement M2M/FK extras update/delete
  • bbdc2bc6 - Handle absence reason and availability type fields correctly
  • 0a368d65 - Remove unused todo
  • e26dbc6e - Add remove button for subquotas
  • 60507c25 - Move duration iso string generator code in model

Compare with previous version

added 5 commits <ul><li>49956c24 - Properly implement M2M/FK extras update/delete</li><li>bbdc2bc6 - Handle absence reason and availability type fields correctly</li><li>0a368d65 - Remove unused todo</li><li>e26dbc6e - Add remove button for subquotas</li><li>60507c25 - Move duration iso string generator code in model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65665&start_sha=b442ba858e2e35733f86df39a11595585d73b9b2)
yuha commented 2025-06-29 12:38:21 +02:00 (Migrated from edugit.org)

added 1 commit

  • 23919b91 - Remove accidentally added event bar component

Compare with previous version

added 1 commit <ul><li>23919b91 - Remove accidentally added event bar component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65667&start_sha=60507c255030364ccac0ee0ed7d174b9f78bcf4a)
yuha commented 2025-06-29 12:48:07 +02:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>c43ef9fd - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Kolego/-/merge_requests/90/diffs?diff_id=65669&start_sha=23919b91989ba538f15d7864dec81752b7d6a2af)
yuha commented 2025-06-29 12:48:15 +02:00 (Migrated from edugit.org)

requested review from @hansegucker

requested review from @hansegucker
hansegucker commented 2025-06-29 13:04:36 +02:00 (Migrated from edugit.org)

mentioned in commit ea91c75098

mentioned in commit ea91c750985db838761a9ef1f5867ad4e595f8a4
hansegucker (Migrated from edugit.org) merged commit ea91c75098 into master 2025-06-29 13:04:37 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Kolego!153
No description provided.