aleksis/AlekSIS-App-Hjelp
8
0
Fork 0
Code Issues 3 Pull requests 2 Projects Releases 1 Packages Activity Actions

Resolve "Fix send email" #81

Merged
yuha merged 8 commits from 21-fix-send-email into master 2020-05-04 20:14:56 +02:00
Conversation 19 Commits 8 Files changed 2 +33 -11
yuha commented 2020-05-04 16:47:13 +02:00 (Migrated from edugit.org)
Copy link

Closes #21

Closes #21
yuha commented 2020-05-04 16:47:14 +02:00 (Migrated from edugit.org)
Copy link

changed milestone to %"2.0a2"

changed milestone to %"2.0a2"
yuha commented 2020-05-04 16:49:23 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6a054908 - Fix template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/25/diffs?diff_id=2022&start_sha=a0d4433c989682442f5999838ffd3027e5c49764)
nik commented 2020-05-04 16:54:43 +02:00 (Migrated from edugit.org)
Copy link

assigned to @nik

assigned to @nik
yuha commented 2020-05-04 17:34:23 +02:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • 6a054908...0d4d903b - 2 commits from branch master
  • 1456fbfe - Change method to get from email
  • 90f06945 - Merge remote-tracking branch 'remotes/origin/master' into 21-fix-send-email
  • 6088b922 - Add further description for feedback rating
  • 71501637 - Add plain block in template

Compare with previous version

added 6 commits <ul><li>6a054908...0d4d903b - 2 commits from branch <code>master</code></li><li>1456fbfe - Change method to get from email</li><li>90f06945 - Merge remote-tracking branch &#39;remotes/origin/master&#39; into 21-fix-send-email</li><li>6088b922 - Add further description for feedback rating</li><li>71501637 - Add plain block in template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/25/diffs?diff_id=2023&start_sha=6a054908fc35a38696343b92b71db3b29b9da1e8)
yuha commented 2020-05-04 17:34:37 +02:00 (Migrated from edugit.org)
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nik commented 2020-05-04 18:32:43 +02:00 (Migrated from edugit.org)
Copy link

Do not place utility code in teh views model.

Do not place utility code in teh `views` model.
nik commented 2020-05-04 18:33:15 +02:00 (Migrated from edugit.org)
Copy link

This should probably be a method or property on Person.

This should probably be a method or property on Person.
nik commented 2020-05-04 18:34:02 +02:00 (Migrated from edugit.org)
Copy link

s/from/out of/

s/from/out of/
nik commented 2020-05-04 19:20:36 +02:00 (Migrated from edugit.org)
Copy link

Oh and NOT request.user…

Oh and NOT `request.user`…
nik commented 2020-05-04 19:23:35 +02:00 (Migrated from edugit.org)
Copy link

Also, this will probably not work. The From address must not be the address of the user, because SPF and DKIM. So, just do not do that for now. In the future, we can do something about that, but it needs to go into special mail headers.

Also, this will probably not work. The `From` address must not be the address of the user, because SPF and DKIM. So, just do not do that for now. In the future, we can do something about that, but it needs to go into special mail headers.
nik commented 2020-05-04 19:36:21 +02:00 (Migrated from edugit.org)
Copy link

Also, this should probably mostly be moved into the template.

Also, this should probably mostly be moved into the template.
nik commented 2020-05-04 19:54:36 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/25/diffs?diff_id=2028&start_sha=71501637f821418f4d8237d853b0b5a62733e4aa#1d5c742651b598a03a3894a8537d40c474fb340c_16_16)
nik commented 2020-05-04 19:54:36 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/25/diffs?diff_id=2028&start_sha=71501637f821418f4d8237d853b0b5a62733e4aa#1d5c742651b598a03a3894a8537d40c474fb340c_55_50)
nik commented 2020-05-04 19:54:37 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • ff37a7dd - Use mail_sender attribute from Person
  • 4f20c1f1 - Use DMARC-compatible mail senders

Compare with previous version

added 2 commits <ul><li>ff37a7dd - Use mail_sender attribute from Person</li><li>4f20c1f1 - Use DMARC-compatible mail senders</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/25/diffs?diff_id=2028&start_sha=71501637f821418f4d8237d853b0b5a62733e4aa)
nik commented 2020-05-04 19:58:21 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/25/diffs?diff_id=2029&start_sha=4f20c1f12c9a83a8fa824066e149796984e02043#1d5c742651b598a03a3894a8537d40c474fb340c_162_162)
nik commented 2020-05-04 19:58:21 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>78cfcd2a - Replace &quot;from&quot; with &quot;out of&quot;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/25/diffs?diff_id=2029&start_sha=4f20c1f12c9a83a8fa824066e149796984e02043)
nik commented 2020-05-04 19:58:21 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-05-04 20:14:56 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 93d3876036

mentioned in commit 93d38760360a9f73d7f84ec5c903cb842550a387
hansegucker commented 2020-05-04 20:14:56 +02:00 (Migrated from edugit.org)
Copy link

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Hjelp!81
No description provided.