aleksis/AlekSIS-App-Hjelp
Watch
10
0
Fork
You've already forked AlekSIS-App-Hjelp
 0
Code Issues 3 Pull requests Projects Releases 1 Packages 1 Activity Actions

Resolve "Migrate to Vue 3/Vuetify 3" #234

Merged
hansegucker merged 50 commits from 55-migrate-to-vue-3-vuetify-3 into master 2025-11-11 11:18:52 +01:00
Conversation 51 Commits 50 Files changed 58 +1768 -1450
leuckeju commented 2025-09-24 12:59:14 +02:00
Member
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

  • Screenshots are attached (mobile and desktop)
  • Tested on mobile, tablet, and desktop sizes
  • Adhered to frontend guidelines
  • Checked with Firefox Accessibility Checker

Closes #55

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [x] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [x] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [x] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [x] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to frontend guidelines - [ ] Checked with Firefox Accessibility Checker Closes #55
leuckeju commented 2025-10-22 23:42:03 +02:00
Author
Member
Copy link

added 22 commits

  • 4bdb8858...af2aa874 - 12 earlier commits
  • af0ffbf8 - Rework model data structure to support mutation
  • 71d4cd7e - Use name in names list
  • f6941834 - Allow submitting issue form
  • 9042a5f2 - Drop issue form django code
  • 751bae89 - Migrate faq display
  • c16ea0cc - Reformat
  • 3646e9b2 - Allow managing faq models in frontend
  • 219f3fb4 - Delete faq management relicts
  • 94e55f1d - Use correct fields for icons in faq gql schema
  • fc5bd3c9 - Rely on objectschema mechanism for icons in faq

Compare with previous version

added 22 commits <ul><li>4bdb8858...af2aa874 - 12 earlier commits</li><li>af0ffbf8 - Rework model data structure to support mutation</li><li>71d4cd7e - Use name in names list</li><li>f6941834 - Allow submitting issue form</li><li>9042a5f2 - Drop issue form django code</li><li>751bae89 - Migrate faq display</li><li>c16ea0cc - Reformat</li><li>3646e9b2 - Allow managing faq models in frontend</li><li>219f3fb4 - Delete faq management relicts</li><li>94e55f1d - Use correct fields for icons in faq gql schema</li><li>fc5bd3c9 - Rely on objectschema mechanism for icons in faq</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72250&start_sha=4bdb8858a13af2f0bb2c5582171953b0e732fdd4)
leuckeju commented 2025-10-23 09:29:55 +02:00
Author
Member
Copy link

added 3 commits

  • 30befe9f - Fix lint
  • 24cb4b57 - Create a backend schema for question answering
  • 89447932 - Create a frontend schema for question answering

Compare with previous version

added 3 commits <ul><li>30befe9f - Fix lint</li><li>24cb4b57 - Create a backend schema for question answering</li><li>89447932 - Create a frontend schema for question answering</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72251&start_sha=fc5bd3c945e1a8657fa7d2136ab38a438cc4cd60)
leuckeju commented 2025-10-23 09:39:14 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>73804d1a - Update linter to vue3</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72256&start_sha=89447932951a03d139afd5695ff42d4eaf3599a2)
leuckeju commented 2025-10-23 09:44:31 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>38e3b571 - Migrate tox.ini</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72259&start_sha=73804d1aefc9c0781750a504c792f489552fb2bb)
leuckeju commented 2025-10-23 20:09:34 +02:00
Author
Member
Copy link

added 4 commits

  • 24957c31 - Fix lint
  • 894d3d27 - Link between faq display and asking page
  • 18f8e92a - Display success messages for forms in hjelp
  • 7b1c0a33 - Only link to ask faq if permission is set

Compare with previous version

added 4 commits <ul><li>24957c31 - Fix lint</li><li>894d3d27 - Link between faq display and asking page</li><li>18f8e92a - Display success messages for forms in hjelp</li><li>7b1c0a33 - Only link to ask faq if permission is set</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72267&start_sha=38e3b571ccc69ec242e583369b681462ef242265)
leuckeju commented 2025-10-23 20:16:15 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>12ed1303 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72268&start_sha=7b1c0a33b32b74b39291435c5534b8506a61fd87)
leuckeju commented 2025-10-23 20:16:36 +02:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
leuckeju commented 2025-10-23 20:16:38 +02:00
Author
Member
Copy link

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **`tox -e reformat,lint` used** as completed
leuckeju commented 2025-10-23 20:16:45 +02:00
Author
Member
Copy link

marked the checklist item Copyright in apps.py and README.rst up-to-date as completed

marked the checklist item **Copyright in `apps.py` and `README.rst` up-to-date** as completed
leuckeju commented 2025-10-23 20:20:45 +02:00
Author
Member
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>2c0ddf95 - Remove all legacy remains</li><li>46909823 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72270&start_sha=12ed13030073daf625a316a95290efb09fd81ad0)
yuha commented 2025-10-25 23:17:11 +02:00
Member
Copy link
  • UUIDs don't seem to be present, maybe some migrations are lacking? at least i'm getting errors when trying to use the FAQ crud list
  • URLs don't follow the URL scheme (o notation)
* [x] UUIDs don't seem to be present, maybe some migrations are lacking? at least i'm getting errors when trying to use the FAQ crud list * [ ] URLs don't follow the URL scheme (o notation)
yuha commented 2025-10-25 23:18:03 +02:00
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>d4deb95e - Add UUID migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72323&start_sha=46909823c14ad546c0f866da7b730318ae59f2b1)
yuha commented 2025-10-25 23:19:35 +02:00
Member
Copy link

this "jump directly to:" text is also displayed when the rest of the page is empty:

image.png

this "jump directly to:" text is also displayed when the rest of the page is empty: ![image.png](/uploads/76910b51bf813a06ad2195c3ed3de97d/image.png)
yuha commented 2025-10-25 23:22:49 +02:00
Member
Copy link

image.png

image.png

image.png

none of that works? icons aren't displayed properly, i can't flip the "display in FAQ" switch, the position index is non-settable, i can't create questions without associating a section to them (even though this option exists when creating a section, AND i also can't create a section without associating questions due to that field being required), …

![image.png](/uploads/442a066f9cb90d4df01a7a17a6e5ef45/image.png) ![image.png](/uploads/6caab1553da5b8807954b68f161c0e17/image.png) ![image.png](/uploads/2da07b306189bbb0819c75cfa5eeb6ad/image.png) none of that works? icons aren't displayed properly, i can't flip the "display in FAQ" switch, the position index is non-settable, i can't create questions without associating a section to them (even though this option exists when _creating_ a section, AND i also can't create a section without associating questions due to that field being required), …
leuckeju commented 2025-10-25 23:27:03 +02:00
Author
Member
Copy link

Huh
Will check

Huh Will check
leuckeju commented 2025-10-26 21:36:37 +01:00
Author
Member
Copy link

fixed

fixed
leuckeju commented 2025-10-26 21:50:00 +01:00
Author
Member
Copy link

added 6 commits

  • ea7c4347 - Fix tox config
  • 38283e7d - Update objectschemas to represent model
  • c55f70e4 - Use newly introduced o/ routes
  • 1b6ee6be - Show empty message if faq is empty
  • 038bf540 - Default to true for show value in questions as well
  • 42d1e8b8 - Default to current section in question creator

Compare with previous version

added 6 commits <ul><li>ea7c4347 - Fix tox config</li><li>38283e7d - Update objectschemas to represent model</li><li>c55f70e4 - Use newly introduced o/ routes</li><li>1b6ee6be - Show empty message if faq is empty</li><li>038bf540 - Default to true for show value in questions as well</li><li>42d1e8b8 - Default to current section in question creator</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=72329&start_sha=d4deb95ed3b464c628417e079f2d209b377a571b)
leuckeju commented 2025-10-26 21:50:28 +01:00
Author
Member
Copy link

the non-settable stuff is due to a core bug, rest is fixed

the non-settable stuff is due to a core bug, rest is fixed
leuckeju commented 2025-10-26 21:50:41 +01:00
Author
Member
Copy link

resolved all threads

resolved all threads
leuckeju commented 2025-10-26 21:50:49 +01:00
Author
Member
Copy link

marked the checklist item Adhere to URL scheme as completed

marked the checklist item **Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86)** as completed
hansegucker commented 2025-10-28 11:29:38 +01:00
Owner
Copy link

requested review from @hansegucker

requested review from @hansegucker
hansegucker commented 2025-10-28 11:39:29 +01:00
Owner
Copy link

Sounds like the completely wrong rule here ...

Sounds like the completely wrong rule here ...
hansegucker commented 2025-10-28 11:39:29 +01:00
Owner
Copy link

same here

same here
hansegucker commented 2025-10-28 11:39:30 +01:00
Owner
Copy link

Still relevant?

Still relevant?
hansegucker commented 2025-10-28 11:39:30 +01:00
Owner
Copy link

Still relevant?

Still relevant?
hansegucker commented 2025-10-28 11:39:30 +01:00
Owner
Copy link

Maybe you should drop the German comments in the progress ...

Maybe you should drop the German comments in the progress ...
hansegucker commented 2025-10-28 11:39:30 +01:00
Owner
Copy link

same here

same here
hansegucker commented 2025-10-28 11:39:31 +01:00
Owner
Copy link

Less technical please, more like here: https://edugit.org/AlekSIS/official/AlekSIS-App-Resint/-/blob/master/CHANGELOG.rst?ref_type=heads&plain=1#L15

Less technical please, more like here: https://edugit.org/AlekSIS/official/AlekSIS-App-Resint/-/blob/master/CHANGELOG.rst?ref_type=heads&plain=1#L15
hansegucker commented 2025-10-28 11:39:31 +01:00
Owner
Copy link

GraphQL optimizers missing (see check list)

GraphQL optimizers missing (see check list)
hansegucker commented 2025-10-28 11:39:33 +01:00
Owner
Copy link
  • Also some final screenshots are needed for this PR
  • Additionally the docs have to be updated as the screenshots are now completely outdated.

In summary: The checklist is there for a reason.

- Also some final screenshots are needed for this PR - Additionally the docs have to be updated as the screenshots are now completely outdated. In summary: The checklist is there for a reason.
hansegucker commented 2025-10-28 11:39:33 +01:00
Owner
Copy link

requested changes

requested changes
hansegucker commented 2025-10-28 11:39:46 +01:00
Owner
Copy link

marked the checklist item Use permissions for all GraphQL mutations as completed

marked the checklist item **Use permissions for all GraphQL mutations** as completed
hansegucker commented 2025-10-28 11:39:47 +01:00
Owner
Copy link

marked the checklist item Don't use inefficient DB queries as completed

marked the checklist item **Don't use inefficient DB queries** as completed
hansegucker commented 2025-10-28 11:39:54 +01:00
Owner
Copy link

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed
hansegucker commented 2025-10-28 11:42:50 +01:00
Owner
Copy link
Enum 'HjelpFAQQuestionIconChoices' cannot represent value: 'question_answer' (Error code: CORE_201)

Maybe due to old icons? → but shouldn't fail this way

``` Enum 'HjelpFAQQuestionIconChoices' cannot represent value: 'question_answer' (Error code: CORE_201) ``` Maybe due to old icons? → but shouldn't fail this way
hansegucker commented 2025-10-28 11:43:26 +01:00
Owner
Copy link

Report an issue is missing a toolbar title

Report an issue is missing a toolbar title
leuckeju commented 2025-10-28 12:00:46 +01:00
Author
Member
Copy link

how did you reach this error msg?

how did you reach this error msg?
leuckeju commented 2025-11-10 13:41:10 +01:00
Author
Member
Copy link

first one yes, but left open, as not important, but should probably still be looked at later™

first one yes, but left open, as not important, but should probably still be looked at later™
leuckeju commented 2025-11-10 14:38:58 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77938&start_sha=42d1e8b865ea5bbd4b56e76f88e5c1f02eb785da#94d746ef6c0a4226be32c79e10d8bf186e8e149d_20_20)
leuckeju commented 2025-11-10 14:38:59 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77938&start_sha=42d1e8b865ea5bbd4b56e76f88e5c1f02eb785da#94d746ef6c0a4226be32c79e10d8bf186e8e149d_77_77)
leuckeju commented 2025-11-10 14:38:59 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77938&start_sha=42d1e8b865ea5bbd4b56e76f88e5c1f02eb785da#11d7e88b1948e41a45b90f3bd3525021d0cce710_62_62)
leuckeju commented 2025-11-10 14:39:00 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77938&start_sha=42d1e8b865ea5bbd4b56e76f88e5c1f02eb785da#014c86e5f35f112f97cfe3aa7290671fb80bf407_59_57)
leuckeju commented 2025-11-10 14:39:00 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77938&start_sha=42d1e8b865ea5bbd4b56e76f88e5c1f02eb785da#45267e3a9556cafa9cb7b61dab7a3b6659e73aad_15_15)
leuckeju commented 2025-11-10 14:39:01 +01:00
Author
Member
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77938&start_sha=42d1e8b865ea5bbd4b56e76f88e5c1f02eb785da#f6b1ce8657708a024a616bb8f956848f0eaa3bcd_53_60)
leuckeju commented 2025-11-10 14:39:01 +01:00
Author
Member
Copy link

added 7 commits

  • e707d462 - Cleanup open todos
  • c28c0340 - Rephrase changelog entry for vue3
  • be423c24 - Update docs for new vue-based hjelp frontend
  • 566722fe - Fix permission names
  • d8a1d006 - Add toolbar title to issue report page
  • fc407b1a - Use django query optimizer
  • 78188e59 - Add migration for icon changes

Compare with previous version

added 7 commits <ul><li>e707d462 - Cleanup open todos</li><li>c28c0340 - Rephrase changelog entry for vue3</li><li>be423c24 - Update docs for new vue-based hjelp frontend</li><li>566722fe - Fix permission names</li><li>d8a1d006 - Add toolbar title to issue report page</li><li>fc407b1a - Use django query optimizer</li><li>78188e59 - Add migration for icon changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77938&start_sha=42d1e8b865ea5bbd4b56e76f88e5c1f02eb785da)
leuckeju commented 2025-11-10 14:40:39 +01:00
Author
Member
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77940&start_sha=78188e59aaa3c6215d6fe64a1960f81f88a1cf7b#294fae1cace276312ffae067f46dedccfd534683_84_84)
leuckeju commented 2025-11-10 14:40:40 +01:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1077a3aa - Drop german comments</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77940&start_sha=78188e59aaa3c6215d6fe64a1960f81f88a1cf7b)
leuckeju commented 2025-11-10 14:40:54 +01:00
Author
Member
Copy link

requested review from @hansegucker

requested review from @hansegucker
leuckeju commented 2025-11-10 19:07:19 +01:00
Author
Member
Copy link

added 1 commit

  • eff38792 - Use default theme colors in docs screenshots

Compare with previous version

added 1 commit <ul><li>eff38792 - Use default theme colors in docs screenshots</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Hjelp/-/merge_requests/178/diffs?diff_id=77945&start_sha=1077a3aae2f880c1d52d8e49e7793c2990cf9842)
hansegucker commented 2025-11-11 11:18:39 +01:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-11-11 11:18:50 +01:00
Owner
Copy link

mentioned in commit 9d267ca27f

mentioned in commit 9d267ca27f6f2e5103bbf7685972648c2f05bdf5
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Hjelp!234
No description provided.