date_format and tiem_format seem superfluous here, because formatting belongs into templates (and what you use here is the default formatting DJango will apply when simply outputting the datetime or time objects in a template).

`date_format` and `tiem_format` seem superfluous here, because formatting belongs into templates (and what you use here is the default formatting DJango will apply when simply outputting the `datetime` or `time` objects in a template).

nik commented

2020-03-15 13:24:53 +01:00

(Migrated from edugit.org)

    if not calendar_url:

Using boolean not on a string is False if the string is empty or None. This can be a problem when you really want to catch only one of these cases, but if you want both, just use boolean not.

```suggestion:-0+0 if not calendar_url: ``` Using boolean `not` on a string is False if the string is empty or None. This can be a problem when you really want to catch only one of these cases, but if you want both, just use boolean `not`.

nik commented

2020-03-15 13:27:12 +01:00

(Migrated from edugit.org)

Do not use print. Use a logger if you want to notify the administrator, or the messages system if you want to notify the user through the frontend.

Do not use `print`. Use a logger if you want to notify the administrator, or the messages system if you want to notify the user through the frontend.

nik commented

2020-03-15 13:28:14 +01:00

(Migrated from edugit.org)

Now I see that you are constructing strings later on, so you actually do need the formatted strings here.

ZugBahnHof commented

2020-03-15 13:28:50 +01:00

(Migrated from edugit.org)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-App-DashboardFeeds/-/merge_requests/3/diffs?diff_id=1425&start_sha=16dcf3ed3687d246f4158cd546273cc7142a52c3#31f0d71ad804890d3169c5b41ea8814465567be9_63_63)

ZugBahnHof commented

2020-03-15 13:28:51 +01:00

(Migrated from edugit.org)

added 1 commit

3a9f16b7 - Apply suggestion to aleksis/apps/dashboardfeeds/util/event_feed.py

Compare with previous version

added 1 commit <ul><li>3a9f16b7 - Apply suggestion to aleksis/apps/dashboardfeeds/util/event_feed.py</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-DashboardFeeds/-/merge_requests/3/diffs?diff_id=1425&start_sha=16dcf3ed3687d246f4158cd546273cc7142a52c3)

ZugBahnHof commented

2020-03-15 13:55:49 +01:00

(Migrated from edugit.org)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-DashboardFeeds/-/merge_requests/3/diffs?diff_id=1426&start_sha=3a9f16b732168c1f3fa7a90c8074eaf3d96d055f#31f0d71ad804890d3169c5b41ea8814465567be9_70_80)

ZugBahnHof commented

2020-03-15 13:55:49 +01:00

(Migrated from edugit.org)

added 2 commits

ce9d1f88 - Cache calendar events for 5 minutes
d6cf0a8e - Don't print error messages, cache events

Compare with previous version

added 2 commits <ul><li>ce9d1f88 - Cache calendar events for 5 minutes</li><li>d6cf0a8e - Don't print error messages, cache events</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-DashboardFeeds/-/merge_requests/3/diffs?diff_id=1426&start_sha=3a9f16b732168c1f3fa7a90c8074eaf3d96d055f)

nik commented

2020-03-15 14:09:08 +01:00

(Migrated from edugit.org)

https://docs.djangoproject.com/en/3.0/topics/logging/#using-logging

ZugBahnHof commented

2020-03-15 16:34:53 +01:00

(Migrated from edugit.org)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-DashboardFeeds/-/merge_requests/3/diffs?diff_id=1427&start_sha=d6cf0a8e21d40590a2166c6736cd59bb6c34096e#31f0d71ad804890d3169c5b41ea8814465567be9_80_82)

ZugBahnHof commented

2020-03-15 16:34:54 +01:00

(Migrated from edugit.org)

added 1 commit

d362bb47 - Improve logging

Compare with previous version

added 1 commit <ul><li>d362bb47 - Improve logging</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-DashboardFeeds/-/merge_requests/3/diffs?diff_id=1427&start_sha=d6cf0a8e21d40590a2166c6736cd59bb6c34096e)

debdolph commented

2020-03-17 15:51:40 +01:00

(Migrated from edugit.org)

According to the recent changes, i think we can resolve the discussions, @ZugBahnHof ?

ZugBahnHof commented

2020-03-18 09:45:43 +01:00

(Migrated from edugit.org)

resolved all threads

nik commented

2020-03-18 11:39:53 +01:00

(Migrated from edugit.org)

changed the description