Resolve "Use preferences instead of managed group types for school structure" #96

Merged

hansegucker merged 2 commits from 20-use-preferences-instead-of-managed-group-types-for-school-structure into master 2024-06-10 13:40:28 +02:00

Conversation 16 Commits 2 Files changed 11 +233 -161

hansegucker commented 2024-05-23 21:14:51 +02:00 (Migrated from edugit.org)

Copy link

Closes #20

Closes #20

hansegucker commented 2024-05-23 23:13:15 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 1564153a - Use preferences to set group types for school structure

Compare with previous version

added 1 commit <ul><li>1564153a - Use preferences to set group types for school structure</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/45/diffs?diff_id=43325&start_sha=c8ded1461a27f4ddf8f0dd287173eb1766f66090)

hansegucker commented 2024-05-23 23:14:35 +02:00 (Migrated from edugit.org)

Copy link

marked this merge request as ready

marked this merge request as **ready**

hansegucker commented 2024-05-23 23:16:56 +02:00 (Migrated from edugit.org)

Copy link

mentioned in merge request AlekSIS/official/AlekSIS-App-Chronos!401

mentioned in merge request AlekSIS/official/AlekSIS-App-Chronos!401

nik commented 2024-05-23 23:17:52 +02:00 (Migrated from edugit.org)

Copy link

The whole idea of these preferences was to not hard code the terms "grade" and "class".

The whole idea of these preferences was to **not** hard code the terms "grade" and "class".

nik commented 2024-05-23 23:18:46 +02:00 (Migrated from edugit.org)

Copy link

Shouldn't this be covered by the rule?

Shouldn't this be covered by the rule?

hansegucker commented 2024-05-24 09:19:08 +02:00 (Migrated from edugit.org)

Copy link

But the school structure defines its existence about grades and classes.

But the school structure defines its existence about grades and classes.

hansegucker commented 2024-05-24 09:19:26 +02:00 (Migrated from edugit.org)

Copy link

It is covered by the rule except for admins who have all permissions.

It is covered by the rule except for admins who have all permissions.

nik commented 2024-06-08 19:02:59 +02:00 (Migrated from edugit.org)

Copy link

Hard-code it then, remove the preferences, and open an issue to make another app that uses different terms.

Hard-code it then, remove the preferences, and open an issue to make another app that uses different terms.

hansegucker commented 2024-06-09 10:12:23 +02:00 (Migrated from edugit.org)

Copy link

added 14 commits

• 1564153a...b7b8d986 - 13 commits from branch master
• 58be5a14 - Use preferences to set group types for school structure

Compare with previous version

added 14 commits <ul><li>1564153a...b7b8d986 - 13 commits from branch <code>master</code></li><li>58be5a14 - Use preferences to set group types for school structure</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/45/diffs?diff_id=43841&start_sha=1564153a7d97c9912aede0952d920872ec0bfc36)

hansegucker commented 2024-06-10 11:14:50 +02:00 (Migrated from edugit.org)

Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/45/diffs?diff_id=43854&start_sha=58be5a14673d8e5a359e2f5e69c77dfd3f210fd1#d4bb7b09f34b21f88d678ecc9c25d7ad67e3c60f_27_26)

hansegucker commented 2024-06-10 11:14:50 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• d5d51eb7 - Use first and second level group types for school structure

Compare with previous version

added 1 commit <ul><li>d5d51eb7 - Use first and second level group types for school structure</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/45/diffs?diff_id=43854&start_sha=58be5a14673d8e5a359e2f5e69c77dfd3f210fd1)

hansegucker commented 2024-06-10 11:15:11 +02:00 (Migrated from edugit.org)

Copy link


hansegucker commented 2024-06-10 11:15:36 +02:00 (Migrated from edugit.org)

Copy link

resolved all threads

resolved all threads

hansegucker commented 2024-06-10 11:15:47 +02:00 (Migrated from edugit.org)

Copy link

assigned to @nik

assigned to @nik

hansegucker commented 2024-06-10 13:37:29 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• f00f99ce - Use first and second level group types for school structure

Compare with previous version

added 1 commit <ul><li>f00f99ce - Use first and second level group types for school structure</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/45/diffs?diff_id=43867&start_sha=d5d51eb7cfe1dbb8263c62dc857ac77d3a31d828)

hansegucker (Migrated from edugit.org) scheduled this pull request to auto merge when all checks succeed 2024-06-10 13:39:18 +02:00

hansegucker commented 2024-06-10 13:40:28 +02:00 (Migrated from edugit.org)

Copy link

mentioned in commit 708735408d

mentioned in commit 708735408d591805b03dadb41c2ce87352b48467

hansegucker (Migrated from edugit.org) merged commit 708735408d into master 2024-06-10 13:40:28 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Security

  

TeX

Needs LaTeX template

  

auto-update

  

board

done

  

board

ready

  

board

todo

  

check

delete-eslint-rc-js

  

check

update-builddeps-package-json

  

check

update-eslint-rc-js

  

check

update-gitignore

  

check

update-merge-request-template

  

check

update-prettier-ignore

  

check

update-pyproject-toml

  

check

update-renovate-json

  

check

update-tox-ini

  

part

backend

Backend (view code, models, logic, etc.)

  

part

ci

  

part

docs

Issue or addition to the documentation

  

part

frontend

Frontend (templates, etc.)

  

part

i18n

Translation or internationalisation issue

  

part

non-technical

Non-technical (policy, maintenance, etc.) issue or discussion

  

part

packaging

Issue concerning the packaging of AlekSIS and components

  

prio

1

Priority High

  

prio

2

Priority Medium

  

prio

3

Priority Low

  

release-mr-5.x

  

size

large

  

size

medium

  

size

small

  

source

customer

Requested by a customer or affiliated user

  

source

customer::fsmw

  

source

customer::fss

  

source

customer::teckids

  

source

downstream

Issue or merge request from other projects using AlekSIS or parts of it

  

type

breaking

  

type

bug

Bug

  

type

feature

New feature

  

type

refactoring

  

workflow

blocked

Issue is blocked by another issue

  

workflow

confirmed

The bug is reproducible and will be fixed

  

workflow

current-todo

  

workflow

discussing

Needs to be discussed before implementation

  

workflow

new-app

Requires new AlekSIS app, which has to be created

  

workflow

wontfix

The bug is not reproducible or the feature was decided against

No labels

Security

TeX

auto-update

board

done

board

ready

board

todo

check

delete-eslint-rc-js

check

update-builddeps-package-json

check

update-eslint-rc-js

check

update-gitignore

check

update-merge-request-template

check

update-prettier-ignore

check

update-pyproject-toml

check

update-renovate-json

check

update-tox-ini

part

backend

part

ci

part

docs

part

frontend

part

i18n

part

non-technical

part

packaging

prio

1

prio

2

prio

3

release-mr-5.x

size

large

size

medium

size

small

source

customer

source

customer::fsmw

source

customer::fss

source

customer::teckids

source

downstream

type

breaking

type

bug

type

feature

type

refactoring

workflow

blocked

workflow

confirmed

workflow

current-todo

workflow

discussing

workflow

new-app

workflow

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

aleksis/AlekSIS-App-Cursus!96

No description provided.