aleksis/AlekSIS-App-Cursus
8
0
Fork 0
Code Issues 13 Pull requests 2 Projects Releases Packages Activity Actions

Resolve "Adapt to refactored CRUD lists" #75

Merged
magicfelix merged 9 commits from 14-adapt-to-refactored-crud-lists into master 2024-02-24 11:54:30 +01:00
Conversation 20 Commits 9 Files changed 10 +64 -132
magicfelix commented 2024-02-02 09:19:23 +01:00 (Migrated from edugit.org)
Copy link

Closes #14

Closes #14
magicfelix commented 2024-02-12 22:56:29 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 9a74e7c5 - Update core dep and python version
  • 4b4455e8 - Adapt to refactored CRUD lists

Compare with previous version

added 2 commits <ul><li>9a74e7c5 - Update core dep and python version</li><li>4b4455e8 - Adapt to refactored CRUD lists</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39072&start_sha=0896cbe8f1957798ac788b758f17568550287fdd)
magicfelix commented 2024-02-14 19:55:36 +01:00 (Migrated from edugit.org)
Copy link

(I accidently commented on a wrong MR)

Some things do not work yet.

Courses: Click on edit, change something, save. If you didn't change the groups, it returns item.groups is undefined. Same for teachers.

SchoolStructure: Works, but logs warning: Invalid prop: type check failed for prop "defaultItem". Expected Object, got Undefined

Similar warnings appear in other situations. @permcu can you have a look at it? Be aware to use Core 4.0.0.dev3, but with this fix applied (just this branch won't work, because it contains things from master that break something. I think related to additionalfields and/or site removal).

(I accidently commented on a [wrong MR](https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1408#note_87200)) Some things do not work yet. Courses: Click on edit, change something, save. If you didn't change the groups, it returns `item.groups is undefined`. Same for teachers. SchoolStructure: Works, but logs warning: `Invalid prop: type check failed for prop "defaultItem". Expected Object, got Undefined` Similar warnings appear in other situations. @permcu can you have a look at it? Be aware to use Core 4.0.0.dev3, but with [this fix](https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1408) applied (just this branch won't work, because it contains things from master that break something. I think related to additionalfields and/or site removal).
magicfelix commented 2024-02-14 19:56:07 +01:00 (Migrated from edugit.org)
Copy link

mentioned in merge request AlekSIS/official/AlekSIS-Core!1459

mentioned in merge request AlekSIS/official/AlekSIS-Core!1459
magicfelix commented 2024-02-15 21:53:03 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • df076f2c - Fix partially updating courses

Compare with previous version

added 1 commit <ul><li>df076f2c - Fix partially updating courses</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39205&start_sha=4b4455e8e680cb818531ed4573852a897095eb21)
magicfelix commented 2024-02-15 21:53:42 +01:00 (Migrated from edugit.org)
Copy link

Another problem: Variable '$input' got invalid value '5' at 'input[0].lessonQuota'; Int cannot represent non-integer value: '5' when editing the Lesson quota.

Another problem: `Variable '$input' got invalid value '5' at 'input[0].lessonQuota'; Int cannot represent non-integer value: '5'` when editing the Lesson quota.
permcu commented 2024-02-16 12:18:04 +01:00 (Migrated from edugit.org)
Copy link

This one was rather wild. It's a bug in Core.
https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1410
solves it.

This one was rather wild. It's a bug in Core. https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1410 solves it.
hansegucker commented 2024-02-16 21:09:21 +01:00 (Migrated from edugit.org)
Copy link
        for school_class in input:
            school_class["group_type"] = group_type.pk
```suggestion:-1+0 for school_class in input: school_class["group_type"] = group_type.pk ```
hansegucker commented 2024-02-16 21:09:22 +01:00 (Migrated from edugit.org)
Copy link
        for school_grade in input:
            school_grade["group_type"] = group_type.pk
```suggestion:-1+0 for school_grade in input: school_grade["group_type"] = group_type.pk ```
magicfelix commented 2024-02-16 21:36:17 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>55a268a7 - Fix updating subjects</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39284&start_sha=df076f2c15f6921d190a220a284cabdfabd9badf)
magicfelix commented 2024-02-16 22:24:17 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39299&start_sha=55a268a7f6b59fa02491c1fa1cd4b55f307cf73c#a81fc04014516b978c11ae4b968d93b6d93e1dec_207_206)
magicfelix commented 2024-02-16 22:24:17 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>9156f44f - Use python convention</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39299&start_sha=55a268a7f6b59fa02491c1fa1cd4b55f307cf73c)
hansegucker commented 2024-02-17 15:24:07 +01:00 (Migrated from edugit.org)
Copy link

added 19 commits

  • 9156f44f...4347deb7 - 18 commits from branch master
  • b338b690 - Merge branch 'master' into 14-adapt-to-refactored-crud-lists

Compare with previous version

added 19 commits <ul><li>9156f44f...4347deb7 - 18 commits from branch <code>master</code></li><li>b338b690 - Merge branch &#39;master&#39; into 14-adapt-to-refactored-crud-lists</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39330&start_sha=9156f44fa96955c2224781d5b0c0744fc04297b5)
hansegucker commented 2024-02-24 10:43:33 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-02-24 10:43:35 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39577&start_sha=b338b690c1908614e6845231cec79985b08892a2#a81fc04014516b978c11ae4b968d93b6d93e1dec_194_193)
hansegucker commented 2024-02-24 10:43:35 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>18e94035 - Fix variable name</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39577&start_sha=b338b690c1908614e6845231cec79985b08892a2)
hansegucker commented 2024-02-24 11:04:17 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>bfe4096e - Fix lint and reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39579&start_sha=18e94035be0519a1ea62213893b6e2b1db20ab30)
hansegucker commented 2024-02-24 11:04:25 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2024-02-24 11:12:58 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-02-24 11:53:47 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f3b1ebdd - Bump Core version</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/24/diffs?diff_id=39581&start_sha=bfe4096e7f9d241b1cacd9ad13ca8e67dfb1e6d6)
hansegucker commented 2024-02-24 11:54:29 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 1216bacbe9

mentioned in commit 1216bacbe9426ab1a7e17c435616d59fddf8e770
hansegucker (Migrated from edugit.org) merged commit 1216bacbe9 into master 2024-02-24 11:54:30 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Cursus!75
No description provided.