aleksis/AlekSIS-App-Cursus
Watch
10
0
Fork
You've already forked AlekSIS-App-Cursus
 0
Code Issues 11 Pull requests 1 Projects Releases Packages 1 Activity Actions

Resolve "Introduce CourseTypes" #179

Merged
hansegucker merged 23 commits from 51-introduce-coursetypes into master 2026-04-25 12:26:28 +02:00
Conversation 40 Commits 23 Files changed 15 +454 -75
yuha commented 2026-04-23 18:47:07 +02:00
Member
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

Closes #51

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [x] Use permissions for all GraphQL mutations - [x] Use query optimizer for all GraphQL queries - [x] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to [frontend guidelines](https://edugit.org/AlekSIS/official/AlekSIS/-/blob/master/project/frontend_guidelines.rst?ref_type=heads) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/) Closes #51
yuha commented 2026-04-23 18:47:08 +02:00
Author
Member
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2026-04-23 20:00:28 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4c203944 - Add course type model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86334&start_sha=9eb5200db4d5734ee0f5c0d4af6f8f711c9fe4c5)
yuha commented 2026-04-23 20:00:47 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a05c9675 - Add course type rules</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86335&start_sha=4c20394482fffa2c90ded5c07b3af614bc9841a5)
yuha commented 2026-04-23 20:01:33 +02:00
Author
Member
Copy link

added 2 commits

  • 3337333a - Add backend graphql types & queries & mutations for CourseType
  • 084546d1 - Add frontend for CourseType

Compare with previous version

added 2 commits <ul><li>3337333a - Add backend graphql types &amp; queries &amp; mutations for CourseType</li><li>084546d1 - Add frontend for CourseType</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86336&start_sha=a05c96751dcb6b49026f3666198a6e846cfcfe01)
yuha commented 2026-04-23 23:54:37 +02:00
Author
Member
Copy link

added 6 commits

  • 084546d1...6397f262 - 5 commits from branch master
  • 94893ff6 - Merge branch 'master' into 51-introduce-coursetypes

Compare with previous version

added 6 commits <ul><li>084546d1...6397f262 - 5 commits from branch <code>master</code></li><li>94893ff6 - Merge branch &#39;master&#39; into 51-introduce-coursetypes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86352&start_sha=084546d1361e007e58c4e519cacb8cde0a6e4761)
yuha commented 2026-04-23 23:55:13 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7f4f455c - Adapt permission naming</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86353&start_sha=94893ff6a8e226ecb47b217764c8821264bbc3d8)
yuha commented 2026-04-24 00:24:51 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>75cbf109 - Add course type to routes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86355&start_sha=7f4f455cf7387c45d6454f9236b4b5b807c616b1)
yuha commented 2026-04-24 00:26:48 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>20bbcc59 - Fix objectSchema</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86356&start_sha=75cbf109bc292b3fb8bf89f95535fa49fdefb522)
yuha commented 2026-04-24 00:27:33 +02:00
Author
Member
Copy link

added 1 commit

  • 06a1f1c6 - Add i18n values

Compare with previous version

added 1 commit <ul><li>06a1f1c6 - Add i18n values</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86357&start_sha=20bbcc594828919a8dc9fc10d8f9d38bbfef3c49)
yuha commented 2026-04-24 00:29:45 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c1bd0e92 - Add i18n values</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86359&start_sha=06a1f1c6c4dcc48bec90e8d50f05eff6b6620bed)
yuha commented 2026-04-24 00:35:23 +02:00
Author
Member
Copy link

added 1 commit

  • 81eeba50 - Add courseType to course mutations

Compare with previous version

added 1 commit <ul><li>81eeba50 - Add courseType to course mutations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86361&start_sha=c1bd0e924d11b3c83f59a8139e2118d17451aabd)
yuha commented 2026-04-24 00:35:57 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>045f5bf9 - Add missing translation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86362&start_sha=81eeba5026a0a1ff44916557ed07f1579a545570)
yuha commented 2026-04-24 00:40:38 +02:00
Author
Member
Copy link

added 2 commits

  • a8cad476 - Also accept undefined values in CourseTypeChip
  • b6a01bbe - Add person uuid

Compare with previous version

added 2 commits <ul><li>a8cad476 - Also accept undefined values in CourseTypeChip</li><li>b6a01bbe - Add person uuid</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86364&start_sha=045f5bf92a7ef418aae7924bc283cc12053f72a6)
yuha commented 2026-04-24 00:42:17 +02:00
Author
Member
Copy link

added 1 commit

  • 5e071e64 - Add CourseType to Course mutations

Compare with previous version

added 1 commit <ul><li>5e071e64 - Add CourseType to Course mutations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86366&start_sha=b6a01bbe271a85cde65c2c0448248090c681e501)
yuha commented 2026-04-24 00:45:02 +02:00
Author
Member
Copy link

added 1 commit

  • 3e7ff896 - Use other icon for course type menu point

Compare with previous version

added 1 commit <ul><li>3e7ff896 - Use other icon for course type menu point</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86368&start_sha=5e071e64cc629f0c76294efc926b9a74124e5a84)
yuha commented 2026-04-24 00:50:45 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>9b98b93e - Reword choices</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86370&start_sha=3e7ff89626c8f04a3be612f81debf0f17c81e163)
yuha commented 2026-04-24 01:11:20 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>fc9e7df2 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86372&start_sha=9b98b93e04a05b24aaca2f42862ec74b54e164ae)
yuha commented 2026-04-24 01:13:15 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f8a1fa12 - Adapt migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86373&start_sha=fc9e7df2bf43d015eaae991b507d493aa74c29f1)
yuha commented 2026-04-24 17:58:22 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f6cdc48a - Use chip for tracking mode</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86411&start_sha=f8a1fa12025270a37bd9afb3821db16c575bbf5e)
yuha commented 2026-04-24 17:58:48 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3b4f3cb5 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86413&start_sha=f6cdc48a945e17998128dd9a07ddb7257c4434a1)
yuha commented 2026-04-24 18:00:27 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>05d23ecd - Fix wrong translations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86415&start_sha=3b4f3cb548fbd570a358a35694e0e8a23fc8adb0)
yuha commented 2026-04-24 23:28:36 +02:00
Author
Member
Copy link

marked this merge request as ready

marked this merge request as **ready**
yuha commented 2026-04-24 23:28:38 +02:00
Author
Member
Copy link

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **tox \-e reformat,lint used** as completed
yuha commented 2026-04-24 23:28:40 +02:00
Author
Member
Copy link

marked the checklist item Use permissions for all GraphQL mutations as completed

marked the checklist item **Use permissions for all GraphQL mutations** as completed
yuha commented 2026-04-24 23:28:41 +02:00
Author
Member
Copy link

marked the checklist item Use query optimizer for all GraphQL queries as completed

marked the checklist item **Use query optimizer for all GraphQL queries** as completed
yuha commented 2026-04-24 23:28:42 +02:00
Author
Member
Copy link

marked the checklist item Don't use inefficient DB queries as completed

marked the checklist item **Don't use inefficient DB queries** as completed
yuha commented 2026-04-24 23:28:49 +02:00
Author
Member
Copy link

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed
yuha commented 2026-04-24 23:31:55 +02:00
Author
Member
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a6a35331 - Add changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86435&start_sha=05d23ecd7aaefc2185d80c3ba9d8570992485ce4)
yuha commented 2026-04-24 23:35:10 +02:00
Author
Member
Copy link

assigned to @hansegucker and unassigned @yuha

assigned to @hansegucker and unassigned @yuha
hansegucker commented 2026-04-25 12:25:47 +02:00
Owner
Copy link
        permissions = ("cursus.edit_coursetype_rule",)
```suggestion:-0+0 permissions = ("cursus.edit_coursetype_rule",) ```
hansegucker commented 2026-04-25 12:25:47 +02:00
Owner
Copy link
        permissions = ("cursus.delete_coursetype_rule",)
```suggestion:-0+0 permissions = ("cursus.delete_coursetype_rule",) ```
hansegucker commented 2026-04-25 12:25:48 +02:00
Owner
Copy link
        permissions = ("cursus.create_coursetype_rule",)
```suggestion:-0+0 permissions = ("cursus.create_coursetype_rule",) ```
hansegucker commented 2026-04-25 12:25:48 +02:00
Owner
Copy link

left review comments

left review comments
hansegucker commented 2026-04-25 12:26:11 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2026-04-25 12:26:11 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2026-04-25 12:26:15 +02:00
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86448&start_sha=a6a3533186a814c527cd67806746b82571859394#a81fc04014516b978c11ae4b968d93b6d93e1dec_343_343)
hansegucker commented 2026-04-25 12:26:15 +02:00
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86448&start_sha=a6a3533186a814c527cd67806746b82571859394#a81fc04014516b978c11ae4b968d93b6d93e1dec_337_337)
hansegucker commented 2026-04-25 12:26:16 +02:00
Owner
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86448&start_sha=a6a3533186a814c527cd67806746b82571859394#a81fc04014516b978c11ae4b968d93b6d93e1dec_330_330)
hansegucker commented 2026-04-25 12:26:16 +02:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>cc20749c - Fix rule names</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Cursus/-/merge_requests/128/diffs?diff_id=86448&start_sha=a6a3533186a814c527cd67806746b82571859394)
hansegucker commented 2026-04-25 12:26:28 +02:00
Owner
Copy link

mentioned in commit d27935c3aa

mentioned in commit d27935c3aaefaa2d0ee55e82cb7cd6039d4e472f
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hansegucker
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Cursus!179
No description provided.