aleksis/AlekSIS-App-Cursus
8
0
Fork 0
Code Issues 13 Pull requests 2 Projects Releases Packages Activity Actions

Resolve "Implement bundled courses/lessons" #100

Merged
permcu merged 33 commits from 22-implement-bundled-courses-lessons into master 2024-12-24 13:03:58 +01:00
Conversation 55 Commits 33 Files changed 17 +532 -70
permcu commented 2024-06-20 12:17:17 +02:00 (Migrated from edugit.org)
Copy link

Closes #22

Closes #22
permcu commented 2024-06-20 12:17:17 +02:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
permcu commented 2024-06-20 14:22:14 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 76f6a079 - Add children field to Course model
  • 1d86fb44 - Make subject & teachers field on Course model optional

Compare with previous version

added 2 commits <ul><li>76f6a079 - Add children field to Course model</li><li>1d86fb44 - Make subject &amp; teachers field on Course model optional</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=44203&start_sha=b4ce2b25d81b22c397e2cd8c4bab527cff3013e9)
permcu commented 2024-06-21 14:26:00 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • af61d290 - Make subject & teachers field on Course model optional
  • d4695095 - Adapt graphql to updated course model
  • c0c48ca5 - Implement bundled-course frontend
  • d88275e0 - Add resolve-children-method to course-schema

Compare with previous version

added 4 commits <ul><li>af61d290 - Make subject &amp; teachers field on Course model optional</li><li>d4695095 - Adapt graphql to updated course model</li><li>c0c48ca5 - Implement bundled-course frontend</li><li>d88275e0 - Add resolve-children-method to course-schema</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=44248&start_sha=1d86fb445912eba3577bbe74def8a02638fcdaee)
permcu commented 2024-06-25 13:56:14 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • b177962c - Add CourseBundle model
  • fbc53501 - Add CourseBundle rules
  • e41c3eb3 - Add CourseBundle graphql schema
  • c4fb0ce6 - Implement bundled-course frontend

Compare with previous version

added 4 commits <ul><li>b177962c - Add CourseBundle model</li><li>fbc53501 - Add CourseBundle rules</li><li>e41c3eb3 - Add CourseBundle graphql schema</li><li>c4fb0ce6 - Implement bundled-course frontend</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=44346&start_sha=d88275e09e65e5cc7c9f0cf6d4b644c44f8f1e54)
permcu commented 2024-06-26 16:47:11 +02:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 5c5a25fa - Add CourseBundle model
  • 49c08866 - Add CourseBundle rules
  • d294375c - Add CourseBundle graphql schema
  • aa456a7c - Implement bundled-course frontend

Compare with previous version

added 4 commits <ul><li>5c5a25fa - Add CourseBundle model</li><li>49c08866 - Add CourseBundle rules</li><li>d294375c - Add CourseBundle graphql schema</li><li>aa456a7c - Implement bundled-course frontend</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=44400&start_sha=c4fb0ce69f8052b7a91b5d6a41f8453e6befe5e5)
permcu commented 2024-06-26 16:48:13 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 0f767033 - Implement CourseBundle frontend

Compare with previous version

added 1 commit <ul><li>0f767033 - Implement CourseBundle frontend</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=44401&start_sha=aa456a7c756280839aa45a8f081f157177cee00b)
permcu commented 2024-06-27 20:15:15 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • dffe321b - Implement CourseBundle frontend
  • 54ce6866 - Simplify course-list
  • 87db760c - Add create-course-bundle-action to course-list

Compare with previous version

added 3 commits <ul><li>dffe321b - Implement CourseBundle frontend</li><li>54ce6866 - Simplify course-list</li><li>87db760c - Add create-course-bundle-action to course-list</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=44491&start_sha=0f767033787898590f9c6aece995afdcf4ffe27a)
permcu commented 2024-07-17 18:33:54 +02:00 (Migrated from edugit.org)
Copy link

added 10 commits

  • 87db760c...3221c54f - 2 commits from branch master
  • fc444711 - Remove CourseInterface
  • 8203f4f7 - Add CourseBundle model
  • 59a7bc56 - Add CourseBundle rules
  • 3ea68445 - Add CourseBundle graphql schema
  • 7c08486d - Implement CourseBundle frontend
  • fb1f2f3b - Simplify course-list
  • 4c921b1c - Add create-course-bundle-action to course-list
  • d1ab78ba - Create a implicit CourseBundle for every Course on creation

Compare with previous version

added 10 commits <ul><li>87db760c...3221c54f - 2 commits from branch <code>master</code></li><li>fc444711 - Remove CourseInterface</li><li>8203f4f7 - Add CourseBundle model</li><li>59a7bc56 - Add CourseBundle rules</li><li>3ea68445 - Add CourseBundle graphql schema</li><li>7c08486d - Implement CourseBundle frontend</li><li>fb1f2f3b - Simplify course-list</li><li>4c921b1c - Add create-course-bundle-action to course-list</li><li>d1ab78ba - Create a implicit CourseBundle for every Course on creation</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=45445&start_sha=87db760c579837ef90270b4a1c18121b55b7a9bc)
permcu commented 2024-07-17 19:30:53 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 1e6e57fe - Create a implicit CourseBundle for every Course on creation

Compare with previous version

added 1 commit <ul><li>1e6e57fe - Create a implicit CourseBundle for every Course on creation</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=45449&start_sha=d1ab78babe343cb113289b8990b59cbbca5dbfe4)
permcu commented 2024-07-18 11:18:38 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cae80f0d - Remove group field from CourseBundle

Compare with previous version

added 1 commit <ul><li>cae80f0d - Remove group field from CourseBundle</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=45472&start_sha=1e6e57fed251abd2c34ccd5ffb7f33c7c207d842)
permcu commented 2024-07-23 12:45:26 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • de29a16b - Create a implicit CourseBundle for every Course on creation
  • 7dea2645 - Remove group field from CourseBundle

Compare with previous version

added 2 commits <ul><li>de29a16b - Create a implicit CourseBundle for every Course on creation</li><li>7dea2645 - Remove group field from CourseBundle</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=45812&start_sha=cae80f0dd01bdf50b85a20cbe5efde61644442a3)
permcu commented 2024-09-17 17:19:40 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 51e18794 - Fix wrong reference

Compare with previous version

added 1 commit <ul><li>51e18794 - Fix wrong reference</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=47814&start_sha=7dea2645639c1036e2f066a7deaf09b7a58406aa)
permcu commented 2024-09-17 17:39:16 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f98353af - Remove lesson_quota from course-model

Compare with previous version

added 1 commit <ul><li>f98353af - Remove lesson_quota from course-model</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=47818&start_sha=51e187948821a0e5b8cb96bdb640461170eb0f2a)
permcu commented 2024-09-17 17:44:41 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 3092eb9f - Remove lesson_quota from course-frontend

Compare with previous version

added 1 commit <ul><li>3092eb9f - Remove lesson_quota from course-frontend</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=47820&start_sha=f98353af36df1a84b571993e139869f941839ab6)
permcu commented 2024-09-24 12:20:34 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • d12f7a7c - Remove group field from CourseBundle
  • 2fc4aa4d - Fix wrong reference

Compare with previous version

added 2 commits <ul><li>d12f7a7c - Remove group field from CourseBundle</li><li>2fc4aa4d - Fix wrong reference</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=48004&start_sha=3092eb9f39048af7f247871eaef274d7f60a9d0c)
permcu commented 2024-09-24 12:20:52 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f14c842c - Format

Compare with previous version

added 1 commit <ul><li>f14c842c - Format</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=48005&start_sha=2fc4aa4d77a4960fa039e3556ef28a392b05cee6)
permcu commented 2024-09-24 12:23:54 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>f6641ef5 - Remove group field from CourseBundle</li><li>7f9fc6a6 - Fix wrong reference</li><li>ba8be4e0 - Format</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=48006&start_sha=f14c842c60402870694b867863fa8280033649af)
permcu commented 2024-12-14 11:25:08 +01:00 (Migrated from edugit.org)
Copy link

added 31 commits

  • ba8be4e0...0da11b48 - 30 commits from branch master
  • 0407c13f - Merge 'origin/master'

Compare with previous version

added 31 commits <ul><li>ba8be4e0...0da11b48 - 30 commits from branch <code>master</code></li><li>0407c13f - Merge &#39;origin/master&#39;</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52526&start_sha=ba8be4e0659c126c4353210d37982f6452310310)
permcu commented 2024-12-14 21:04:49 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • af188520 - Fix course-bundle-migration
  • 79ea3a42 - Add missing default_room field to CourseType

Compare with previous version

added 2 commits <ul><li>af188520 - Fix course-bundle-migration</li><li>79ea3a42 - Add missing default_room field to CourseType</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52531&start_sha=0407c13feccfa43ec241777f96a4d2a016839e28)
permcu commented 2024-12-15 15:11:08 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 69081adf - Fix wrong reference
  • 7cece7f4 - Remove groups from CourseBundle in frontend as well

Compare with previous version

added 2 commits <ul><li>69081adf - Fix wrong reference</li><li>7cece7f4 - Remove groups from CourseBundle in frontend as well</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52584&start_sha=79ea3a4243c0a0aa47a355d21cbbb7c428271cbe)
permcu commented 2024-12-17 15:35:50 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2aacebb9 - Introduce abstract base-classes for CourseType & CourseBundleType

Compare with previous version

added 1 commit <ul><li>2aacebb9 - Introduce abstract base-classes for CourseType &amp; CourseBundleType</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52676&start_sha=7cece7f4b1ada6a9d7a96c75b59dc56c71a409be)
hansegucker commented 2024-12-18 22:20:06 +01:00 (Migrated from edugit.org)
Copy link

That seems to be an incomplete permission check.

That seems to be an incomplete permission check.
hansegucker commented 2024-12-18 22:22:31 +01:00 (Migrated from edugit.org)
Copy link

We don't use get_queryset anymore (due to breaking performance stuff).

We don't use `get_queryset` anymore (due to breaking performance stuff).
hansegucker commented 2024-12-18 22:22:57 +01:00 (Migrated from edugit.org)
Copy link

I think this should return all groups.

I think this should return all groups.
hansegucker commented 2024-12-18 22:25:51 +01:00 (Migrated from edugit.org)
Copy link
        permission: "cursus.view_course_bundles_rule",
```suggestion:-0+0 permission: "cursus.view_course_bundles_rule", ```
hansegucker commented 2024-12-18 22:25:51 +01:00 (Migrated from edugit.org)
Copy link

Django creates the default global permissions with coursebundle instead of course_bundle. Please also fix in all other places.

Django creates the default global permissions with `coursebundle` instead of `course_bundle`. Please also fix in all other places.
hansegucker commented 2024-12-18 22:25:51 +01:00 (Migrated from edugit.org)
Copy link
        verbose_name = _("Course Bundle")
        verbose_name_plural = _("Course Bundles")
```suggestion:-1+0 verbose_name = _("Course Bundle") verbose_name_plural = _("Course Bundles") ```
hansegucker commented 2024-12-18 22:25:51 +01:00 (Migrated from edugit.org)
Copy link
      path: "course_bundles/",
```suggestion:-0+0 path: "course_bundles/", ```
hansegucker commented 2024-12-18 22:25:51 +01:00 (Migrated from edugit.org)
Copy link

Please rebase/merge with master to fix merge conflicts here.

Please rebase/merge with master to fix merge conflicts here.
hansegucker commented 2024-12-18 22:25:51 +01:00 (Migrated from edugit.org)
Copy link

This field is used in many places outside cursus. We can't just change the API like that.

This field is used in many places outside cursus. We can't just change the API like that.
permcu commented 2024-12-23 13:17:33 +01:00 (Migrated from edugit.org)
Copy link

I must admit I just copied and adapted these rules from courses. It seems incomplete. But courses have the same rule. Maybe @yuha had a reason? I am not sure if I can just change this.

I must admit I just copied and adapted these rules from courses. It seems incomplete. But courses have the same rule. Maybe @yuha had a reason? I am not sure if I can just change this.
permcu commented 2024-12-23 13:34:40 +01:00 (Migrated from edugit.org)
Copy link

After looking @magicfelix changes I deleted it. But actually I am not sure how the permission is checked now. Is it implicit?

After looking @magicfelix changes I deleted it. But actually I am not sure how the permission is checked now. Is it implicit?
permcu commented 2024-12-23 13:35:32 +01:00 (Migrated from edugit.org)
Copy link

Deleted. This was a leftover anyway. You should have a look a the CourseType since it does the same.

Deleted. This was a leftover anyway. You should have a look a the CourseType since it does the same.
permcu commented 2024-12-23 13:45:25 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 21 of the diff

changed this line in [version 21 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52940&start_sha=2aacebb9bec067f2723c0ed6b542c60cc5a43beb#a81fc04014516b978c11ae4b968d93b6d93e1dec_207_193)
permcu commented 2024-12-23 13:45:25 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 21 of the diff

changed this line in [version 21 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52940&start_sha=2aacebb9bec067f2723c0ed6b542c60cc5a43beb#a81fc04014516b978c11ae4b968d93b6d93e1dec_201_193)
permcu commented 2024-12-23 13:45:25 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 21 of the diff

changed this line in [version 21 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52940&start_sha=2aacebb9bec067f2723c0ed6b542c60cc5a43beb#e96ca222daded07c478a6fd5714f11d7723d8722_43_43)
permcu commented 2024-12-23 13:45:26 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 21 of the diff

changed this line in [version 21 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52940&start_sha=2aacebb9bec067f2723c0ed6b542c60cc5a43beb#401af983ee6891f8dfdbaa7498653c506a528fc4_64_64)
permcu commented 2024-12-23 13:45:26 +01:00 (Migrated from edugit.org)
Copy link

added 4 commits

  • 51cfa671 - Remove resolve-groups from BaseCourseBundleType as well
  • 6833efce - Remove deprecated get_queryset from BaseCourseBundleType
  • 5d0fb85f - Do proper view_course_bundles_rule check for course-bundles-frontend
  • 82d7af66 - Fix casing of global view_coursebundle-rule to fit django's default

Compare with previous version

added 4 commits <ul><li>51cfa671 - Remove resolve-groups from BaseCourseBundleType as well</li><li>6833efce - Remove deprecated get_queryset from BaseCourseBundleType</li><li>5d0fb85f - Do proper view_course_bundles_rule check for course-bundles-frontend</li><li>82d7af66 - Fix casing of global view_coursebundle-rule to fit django&#39;s default</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52940&start_sha=2aacebb9bec067f2723c0ed6b542c60cc5a43beb)
permcu commented 2024-12-23 13:47:09 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52941&start_sha=82d7af66bd4d322db81c2516981de9b2b0f58ad3#dc9af7f637aa2d75ba19639c488e89c261e0d52b_64_63)
permcu commented 2024-12-23 13:47:10 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • cb42c95d - Change casing of course-bundle-model-name

Compare with previous version

added 1 commit <ul><li>cb42c95d - Change casing of course-bundle-model-name</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52941&start_sha=82d7af66bd4d322db81c2516981de9b2b0f58ad3)
permcu commented 2024-12-23 14:02:01 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 23 of the diff

changed this line in [version 23 of the diff](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52946&start_sha=cb42c95dec2b4d15306c4f94f370c57c6ee2dd36#e96ca222daded07c478a6fd5714f11d7723d8722_36_36)
permcu commented 2024-12-23 14:02:03 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 48002557 - Change casing of course-bundle-frontend-path
  • 0840355a - Revert breaking API-change in SubjectField by making it optional

Compare with previous version

added 2 commits <ul><li>48002557 - Change casing of course-bundle-frontend-path</li><li>0840355a - Revert breaking API-change in SubjectField by making it optional</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52946&start_sha=cb42c95dec2b4d15306c4f94f370c57c6ee2dd36)
permcu commented 2024-12-23 14:08:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 2f4d9a7a - Remove unused gqlQuery-prop from CreateCourse

Compare with previous version

added 1 commit <ul><li>2f4d9a7a - Remove unused gqlQuery-prop from CreateCourse</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52947&start_sha=0840355a85ef976f9939a533cf67e906aa997c66)
permcu commented 2024-12-23 14:18:54 +01:00 (Migrated from edugit.org)
Copy link

added 22 commits

  • 2f4d9a7a...467ddf99 - 21 commits from branch master
  • 968f66a2 - Merge 'origin/master'

Compare with previous version

added 22 commits <ul><li>2f4d9a7a...467ddf99 - 21 commits from branch <code>master</code></li><li>968f66a2 - Merge &#39;origin/master&#39;</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52952&start_sha=2f4d9a7adebd10baee43a57afe1bbe249ba8b2c2)
permcu commented 2024-12-23 14:32:00 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 04e21e78 - Do not return-object in CreateCourse

Compare with previous version

added 1 commit <ul><li>04e21e78 - Do not return-object in CreateCourse</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52954&start_sha=968f66a2d60dd477b30d03757c1b98b0f70b6cbc)
permcu commented 2024-12-23 17:42:11 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c6d9a5b0 - Change course_bundle's german-translation

Compare with previous version

added 1 commit <ul><li>c6d9a5b0 - Change course_bundle&#39;s german-translation</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52967&start_sha=04e21e78174e4c0b751dfaa98f0d00f10ecf0eb6)
permcu commented 2024-12-23 18:14:19 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0c4c8f31 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52971&start_sha=c6d9a5b0bcefe27fc0c680784cb54909c3a823da)
yuha commented 2024-12-24 00:03:35 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2024-12-24 01:07:01 +01:00 (Migrated from edugit.org)
Copy link

I don't know what should actually be checked here – since the cursus.view_course_bundles_rule rule is only used for determining whether users can access the course bundles management route/see the respective menu point, the check doesn't seem to be that incomplete to me. I used the same logic for courses since it didn't really make sense to me to allow anyone else (including teachers related to courses) to see their courses in this CRUD list view (and do CRUD stuff with them) since that is a typical administrational task done by some specifically designated people (who can be attributed with the global permission to do so)

I don't know what _should_ actually be checked here – since the `cursus.view_course_bundles_rule` rule is only used for determining whether users can access the course bundles management route/see the respective menu point, the check doesn't seem to be that incomplete to me. I used the same logic for courses since it didn't really make sense to me to allow anyone else (including teachers related to courses) to see their courses in this CRUD list view (and do CRUD stuff with them) since that is a typical administrational task done by some specifically designated people (who can be attributed with the global permission to do so)
yuha commented 2024-12-24 01:07:01 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
ZugBahnHof commented 2024-12-24 12:28:42 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>9b17c607 - Use different icon for bundles</li><li>78726fda - Reformat</li><li>4a553144 - Drop duplicate TeacherType</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52978&start_sha=0c4c8f31007013c80bd922fce3ceb122706cf551)
ZugBahnHof commented 2024-12-24 12:41:29 +01:00 (Migrated from edugit.org)
Copy link

image

![image](/uploads/08ba8a25d76bfbd97b038a43769d7838/image.png)
hansegucker commented 2024-12-24 13:03:21 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f48af833 - Update changelog and readme</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Cursus/-/merge_requests/49/diffs?diff_id=52981&start_sha=4a553144e75e383563990488fc24ce96d5495387)
hansegucker commented 2024-12-24 13:03:22 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2024-12-24 13:03:58 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit fb87b08d4a

mentioned in commit fb87b08d4ab1e0a10f2af95ce2bf8b84a853d48c
hansegucker (Migrated from edugit.org) merged commit fb87b08d4a into master 2024-12-24 13:03:59 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Cursus!100
No description provided.