Resolve "Reimplement notification system on base of new calendar system" #664

Merged
hansegucker merged 24 commits from 209-reimplement-notification-system-on-base-of-new-calendar-system into master 2024-12-23 12:55:49 +01:00
Member

Closes #209

Closes #209
Author
Member

assigned to @yuha

assigned to @yuha
Author
Member

added 2 commits

  • aaff4460 - Normalise cancelled value also on create
  • f5ada65d - Add id field in amend lesson patch mutation

Compare with previous version

added 2 commits <ul><li>aaff4460 - Normalise cancelled value also on create</li><li>f5ada65d - Add id field in amend lesson patch mutation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=46303&start_sha=24e0a5e7911e2cf23b7aa00bcf271d01f64183c2)
Author
Member

added 1 commit

  • 85f04429 - WIP: Add alarms

Compare with previous version

added 1 commit <ul><li>85f04429 - WIP: Add alarms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=46305&start_sha=f5ada65d21bcaf7c14c2c84a305793fade742d89)
Author
Member

added 1 commit

  • 6768d2ea - WIP: Add alarms

Compare with previous version

added 1 commit <ul><li>6768d2ea - WIP: Add alarms</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=46890&start_sha=85f0442956f27b44fdf8c06403d9c6a565312e6c)
Author
Member

added 1 commit

  • eb6e2cf5 - WIP: Implement calendar alarms for LessonEvent

Compare with previous version

added 1 commit <ul><li>eb6e2cf5 - WIP: Implement calendar alarms for LessonEvent</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=47104&start_sha=6768d2eae4fd808ea5fb00e722164fcfbc37f192)
Author
Member

added 2 commits

  • 31428640 - Implement calendar alarms for LessonEvent
  • f261ac0b - WIP: Add status-based handling of notifications

Compare with previous version

added 2 commits <ul><li>31428640 - Implement calendar alarms for LessonEvent</li><li>f261ac0b - WIP: Add status-based handling of notifications</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=47110&start_sha=eb6e2cf5e54c41fc7cb5e11da069eaad31b4733d)
Author
Member

added 1 commit

  • 095d8169 - WIP: Add status-based handling of notifications

Compare with previous version

added 1 commit <ul><li>095d8169 - WIP: Add status-based handling of notifications</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=47182&start_sha=f261ac0bacadcd255b8a69717f5d2c1d939d8b65)
Author
Member

added 1 commit

  • b41d9752 - Add status-based handling of notifications

Compare with previous version

added 1 commit <ul><li>b41d9752 - Add status-based handling of notifications</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=47651&start_sha=095d81692b7b46e7ab2f77cd7b280e0c370d05d0)
Author
Member

added 32 commits

  • b41d9752...50ba0341 - 31 commits from branch master
  • 10911241 - Merge branch 'master' into 209-reimplement-notification-system-on-base-of-new-calendar-system

Compare with previous version

added 32 commits <ul><li>b41d9752...50ba0341 - 31 commits from branch <code>master</code></li><li>10911241 - Merge branch &#39;master&#39; into 209-reimplement-notification-system-on-base-of-new-calendar-system</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=47759&start_sha=b41d9752095ca2a5d199889e703027e163a6f225)
Owner

TODO

TODO
Author
Member

added 80 commits

  • 10911241...1e99a991 - 79 commits from branch master
  • 4152489d - Merge branch 'master' into 209-reimplement-notification-system-on-base-of-new-calendar-system

Compare with previous version

added 80 commits <ul><li>10911241...1e99a991 - 79 commits from branch <code>master</code></li><li>4152489d - Merge branch &#39;master&#39; into 209-reimplement-notification-system-on-base-of-new-calendar-system</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=49966&start_sha=1091124192fd591aa9a0be8ecdfc3d3c13144757)
Author
Member

TODO: allow for generating multiple alarms for one event

TODO: allow for generating multiple alarms for one event
Author
Member

created #266 to continue this discussion

created #266 to continue this discussion
Author
Member

mentioned in issue #266

mentioned in issue #266
Author
Member

TODO: find to get URL of timetable pages in backend from object ID and calendar week without hard coding anything

TODO: find to get URL of timetable pages _in backend_ from object ID and calendar week _without_ hard coding anything
Author
Member

created #267 to continue this discussion

created #267 to continue this discussion
Author
Member

mentioned in issue #267

mentioned in issue #267
Author
Member

resolved all threads

resolved all threads
Author
Member

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=49971&start_sha=4152489dcf1c0426fd90c8727ab7295b3c61ee7e#aff889560e418df674a6887a541974fc95f8cd36_550_548)
Author
Member

added 3 commits

Compare with previous version

added 3 commits <ul><li>6b412f9c - Remove todo</li><li>2ce60077 - Remove further TODOs</li><li>8c073c73 - Add missing import</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=49971&start_sha=4152489dcf1c0426fd90c8727ab7295b3c61ee7e)
Author
Member

added 1 commit

Compare with previous version

added 1 commit <ul><li>b39e5ca4 - Remove fixmes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=49973&start_sha=8c073c73aa8be7c5bb04bef76625d51db2778f5d)
Author
Member

FIXME: Hide preferences related to the time notifications are sent conditionally (is this even possible?), depending on the trigger mode selected

FIXME: Hide preferences related to the time notifications are sent conditionally (is this even possible?), depending on the trigger mode selected
Author
Member

FIXME: In some (?) cases, this is incomplete (e.g. room names are missing). I can't recreate this right now, but this probably needs some further investigation.

FIXME: In some (?) cases, this is incomplete (e.g. room names are missing). I can't recreate this right now, but this probably needs some further investigation.
Author
Member

created #268 to continue this discussion

created #268 to continue this discussion
Author
Member

mentioned in issue #268

mentioned in issue #268
Author
Member

resolved all threads

resolved all threads
Author
Member

created #269 to continue this discussion

created #269 to continue this discussion
Author
Member

mentioned in issue #269

mentioned in issue #269
Author
Member

marked this merge request as ready

marked this merge request as **ready**
Author
Member

TODO: Also create alarms when substitution is deleted (how? idk)

TODO: Also create alarms when substitution is deleted (how? idk)
Author
Member

created #270 to continue this discussion

created #270 to continue this discussion
Author
Member

resolved all threads

resolved all threads
Author
Member

mentioned in issue #270

mentioned in issue #270
Author
Member

added 3 commits

  • 07f8fdd6 - Add missing import
  • 08f1feab - Reformat
  • 5d499530 - Add receiver to handle amending lesson teacher m2m field changes

Compare with previous version

added 3 commits <ul><li>07f8fdd6 - Add missing import</li><li>08f1feab - Reformat</li><li>5d499530 - Add receiver to handle amending lesson teacher m2m field changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=49977&start_sha=b39e5ca4307a16c4ca01fdfe0627122fdebe0771)
Author
Member

assigned to @hansegucker and unassigned @yuha

assigned to @hansegucker and unassigned @yuha
Owner

Why this change?

Why this change?
Owner

Should use a ChoiceEnum

Should use a ChoiceEnum
Owner

Move logic from this method and save method above to a class method of LessonEventAlarm

Move logic from this method and save method above to a class method of LessonEventAlarm
Owner

Write property on LessonEventAlarm to check this.

Write property on LessonEventAlarm to check this.
Owner

How does trigger work? Does it know both absolute datetimes and relative timedeltas?

How does trigger work? Does it know both absolute datetimes and relative timedeltas?
Author
Member

I have no clue. Doesn't seem to me as if this is relevant for the functionality of this MR

I have no clue. Doesn't seem to me as if this is relevant for the functionality of this MR
Author
Member
yes, just as the relevant specification states. see https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs#2e44ad1f61249cf0440bea20d23bd07cc7f3a61a_1947_2026
Author
Member

could be confusing to users though…? what do you think?

could be confusing to users though…? what do you think?
Author
Member

added 1 commit

  • 46484262 - Add property indicating if sent notifications exist

Compare with previous version

added 1 commit <ul><li>46484262 - Add property indicating if sent notifications exist</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52868&start_sha=5d49953000703cbaa453e63b001634c8ec9922b8)
Author
Member

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52869&start_sha=46484262885e6ddaae1ffa0e69a8bc34c51e9f00#aff889560e418df674a6887a541974fc95f8cd36_512_512)
Author
Member

added 1 commit

  • 46ab9d4f - Add property indicating if sent notifications exist

Compare with previous version

added 1 commit <ul><li>46ab9d4f - Add property indicating if sent notifications exist</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52869&start_sha=46484262885e6ddaae1ffa0e69a8bc34c51e9f00)
Author
Member

added 1 commit

  • c896a89e - Move update/create follow up logic in own method

Compare with previous version

added 1 commit <ul><li>c896a89e - Move update/create follow up logic in own method</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52871&start_sha=46ab9d4fbd15e4d84450a96329894f756c4ca095)
Author
Member

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52872&start_sha=c896a89e0f7684beac53544902550e11f7af498b#aff889560e418df674a6887a541974fc95f8cd36_229_228)
Author
Member

added 1 commit

  • 4ddbc01e - Restore formerly used teacher list property logic

Compare with previous version

added 1 commit <ul><li>4ddbc01e - Restore formerly used teacher list property logic</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52872&start_sha=c896a89e0f7684beac53544902550e11f7af498b)
Author
Member

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52873&start_sha=4ddbc01e8b7d902e1bc25c3c5398a83cfb2a6647#aff889560e418df674a6887a541974fc95f8cd36_512_512)
Author
Member

added 1 commit

  • 14be2006 - Use enum for lesson event alarm status choices

Compare with previous version

added 1 commit <ul><li>14be2006 - Use enum for lesson event alarm status choices</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52873&start_sha=4ddbc01e8b7d902e1bc25c3c5398a83cfb2a6647)
Author
Member

added 207 commits

  • 14be2006...774786f1 - 206 commits from branch master
  • 1b4fabe7 - Merge branch 'master' into 209-reimplement-notification-system-on-base-of-new-calendar-system

Compare with previous version

added 207 commits <ul><li>14be2006...774786f1 - 206 commits from branch <code>master</code></li><li>1b4fabe7 - Merge branch &#39;master&#39; into 209-reimplement-notification-system-on-base-of-new-calendar-system</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52878&start_sha=14be20067e1dc52cfd9f49ff3420f74923d9823c)
Author
Member

added 1 commit

Compare with previous version

added 1 commit <ul><li>77e56aee - Fix migration dependency</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52880&start_sha=1b4fabe7e0846c6541381f212dc98bd5956b5d47)
Author
Member

added 1 commit

Compare with previous version

added 1 commit <ul><li>ef27a146 - Change choices in migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52882&start_sha=77e56aee5458c2425e1b58817ebebf239d3e948f)
Author
Member

changed this line in version 21 of the diff

changed this line in [version 21 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52884&start_sha=ef27a1460e4816a3a5fa1c739de7524dac05c912#aff889560e418df674a6887a541974fc95f8cd36_661_669)
Author
Member

added 1 commit

  • c03be012 - Move lesson event alarm status choices

Compare with previous version

added 1 commit <ul><li>c03be012 - Move lesson event alarm status choices</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52884&start_sha=ef27a1460e4816a3a5fa1c739de7524dac05c912)
Author
Member

added 1 commit

Compare with previous version

added 1 commit <ul><li>ab112eeb - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52886&start_sha=c03be012170dcff6fd4f9a6b81c0abf744ca3126)
Author
Member

resolved all threads

resolved all threads
Author
Member

TODO: Handle m2m teacher field changes in a more elegant way – right now, changing teachers of an event linked to an existing alarm generates an unnecessary amount of notifications (including duplicated ones)

TODO: Handle m2m teacher field changes in a more elegant way – right now, changing teachers of an event linked to an existing alarm generates an unnecessary amount of notifications (including duplicated ones)
Author
Member

created #279 to continue this discussion

created #279 to continue this discussion
Author
Member

mentioned in issue #279

mentioned in issue #279
Author
Member

resolved all threads

resolved all threads
Owner

Can users deactivate sending timetable notifications?

Can users deactivate sending timetable notifications?
Owner

Also please write a piece of changelog.

Also please write a piece of changelog.
Author
Member

no

no
Author
Member

should I just add a site preference that allows admins to do so?

should I just add a site preference that allows admins to do so?
Author
Member

.

.
Author
Member

added 1 commit

  • 60dbd0ff - Add preference controlling whether notifications relating to substitution lessons should be sent

Compare with previous version

added 1 commit <ul><li>60dbd0ff - Add preference controlling whether notifications relating to substitution lessons should be sent</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52927&start_sha=ab112eebb999021cd03c7c559416ef1716ff6465)
Author
Member

resolved all threads

resolved all threads
Author
Member

added 1 commit

Compare with previous version

added 1 commit <ul><li>aca9672b - Add changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/360/diffs?diff_id=52929&start_sha=60dbd0ff5aa33d7d7d8248e60cedf9dff2ec46b7)
Owner

resolved all threads

resolved all threads
Owner

created #280 to continue this discussion

created #280 to continue this discussion
Owner

mentioned in issue #280

mentioned in issue #280
Owner

mentioned in commit d27dc18e95

mentioned in commit d27dc18e95b74453733ab94dc6730d82db992c96
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Chronos!664
No description provided.