Resolve "Reimplement notification system on base of new calendar system" #664
No reviewers
Labels
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
aleksis/AlekSIS-App-Chronos!664
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "209-reimplement-notification-system-on-base-of-new-calendar-system"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #209
assigned to @yuha
added 2 commits
aaff4460- Normalise cancelled value also on createf5ada65d- Add id field in amend lesson patch mutationCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 2 commits
31428640- Implement calendar alarms for LessonEventCompare with previous version
added 1 commit
Compare with previous version
added 1 commit
b41d9752- Add status-based handling of notificationsCompare with previous version
added 32 commits
master10911241- Merge branch 'master' into 209-reimplement-notification-system-on-base-of-new-calendar-systemCompare with previous version
TODO
added 80 commits
master4152489d- Merge branch 'master' into 209-reimplement-notification-system-on-base-of-new-calendar-systemCompare with previous version
TODO: allow for generating multiple alarms for one event
created #266 to continue this discussion
mentioned in issue #266
TODO: find to get URL of timetable pages in backend from object ID and calendar week without hard coding anything
created #267 to continue this discussion
mentioned in issue #267
resolved all threads
changed this line in version 10 of the diff
added 3 commits
6b412f9c- Remove todo2ce60077- Remove further TODOs8c073c73- Add missing importCompare with previous version
added 1 commit
b39e5ca4- Remove fixmesCompare with previous version
FIXME: Hide preferences related to the time notifications are sent conditionally (is this even possible?), depending on the trigger mode selected
FIXME: In some (?) cases, this is incomplete (e.g. room names are missing). I can't recreate this right now, but this probably needs some further investigation.
created #268 to continue this discussion
mentioned in issue #268
resolved all threads
created #269 to continue this discussion
mentioned in issue #269
marked this merge request as ready
TODO: Also create alarms when substitution is deleted (how? idk)
created #270 to continue this discussion
resolved all threads
mentioned in issue #270
added 3 commits
07f8fdd6- Add missing import08f1feab- Reformat5d499530- Add receiver to handle amending lesson teacher m2m field changesCompare with previous version
assigned to @hansegucker and unassigned @yuha
Why this change?
Should use a ChoiceEnum
Move logic from this method and save method above to a class method of LessonEventAlarm
Write property on LessonEventAlarm to check this.
How does trigger work? Does it know both absolute datetimes and relative timedeltas?
I have no clue. Doesn't seem to me as if this is relevant for the functionality of this MR
yes, just as the relevant specification states. see https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/1523/diffs#2e44ad1f61249cf0440bea20d23bd07cc7f3a61a_1947_2026
could be confusing to users though…? what do you think?
added 1 commit
Compare with previous version
changed this line in version 14 of the diff
added 1 commit
46ab9d4f- Add property indicating if sent notifications existCompare with previous version
added 1 commit
c896a89e- Move update/create follow up logic in own methodCompare with previous version
changed this line in version 16 of the diff
added 1 commit
4ddbc01e- Restore formerly used teacher list property logicCompare with previous version
changed this line in version 17 of the diff
added 1 commit
14be2006- Use enum for lesson event alarm status choicesCompare with previous version
added 207 commits
master1b4fabe7- Merge branch 'master' into 209-reimplement-notification-system-on-base-of-new-calendar-systemCompare with previous version
added 1 commit
77e56aee- Fix migration dependencyCompare with previous version
added 1 commit
ef27a146- Change choices in migrationCompare with previous version
changed this line in version 21 of the diff
added 1 commit
c03be012- Move lesson event alarm status choicesCompare with previous version
added 1 commit
ab112eeb- ReformatCompare with previous version
resolved all threads
TODO: Handle m2m teacher field changes in a more elegant way – right now, changing teachers of an event linked to an existing alarm generates an unnecessary amount of notifications (including duplicated ones)
created #279 to continue this discussion
mentioned in issue #279
resolved all threads
Can users deactivate sending timetable notifications?
Also please write a piece of changelog.
no
should I just add a site preference that allows admins to do so?
.
added 1 commit
60dbd0ff- Add preference controlling whether notifications relating to substitution lessons should be sentCompare with previous version
resolved all threads
added 1 commit
aca9672b- Add changelogCompare with previous version
resolved all threads
created #280 to continue this discussion
mentioned in issue #280
mentioned in commit
d27dc18e95