Resolve "[3.0] Drop Room from model" #588

Merged

hansegucker merged 10 commits from 192-3-0-drop-room-from-model into master 2023-01-18 01:14:03 +01:00

Conversation 44 Commits 10 Files changed 12 +69 -60

lukasw commented 2022-11-20 16:51:54 +01:00

Contributor

Copy link

Closes #192

Closes #192

lukasw commented 2022-11-20 16:51:55 +01:00

Author

Contributor

Copy link

assigned to @lukasw

assigned to @lukasw

lukasw commented 2022-12-01 20:52:39 +01:00

Author

Contributor

Copy link

added 1 commit

• 9dedaebb - Add Migration for moving room object from chronos to core

Compare with previous version

added 1 commit <ul><li>9dedaebb - Add Migration for moving room object from chronos to core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=25762&start_sha=f6ec9c07abebb11139e96b1d1ecf180c2e213562)

lukasw commented 2022-12-14 19:48:22 +01:00

Author

Contributor

Copy link

added 1 commit

• 796012d1 - Rename Migration from core

Compare with previous version

added 1 commit <ul><li>796012d1 - Rename Migration from core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=25917&start_sha=9dedaebb16b9e8e2a5f1a1c6d3849edf85694250)

tteichler commented 2022-12-16 17:22:18 +01:00

Owner

Copy link

added 15 commits

• 796012d1...a852cd29 - 13 commits from branch master
• e8b416e3 - Merge branch 'master' into 192-3-0-drop-room-from-model
• 9943056c - Rename migration

Compare with previous version

added 15 commits <ul><li>796012d1...a852cd29 - 13 commits from branch <code>master</code></li><li>e8b416e3 - Merge branch &#39;master&#39; into 192-3-0-drop-room-from-model</li><li>9943056c - Rename migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26034&start_sha=796012d1b3e38b0130fa2dbd9c038a6740e19976)

tteichler commented 2022-12-17 14:37:25 +01:00

Owner

Copy link

marked this merge request as ready

marked this merge request as **ready**

nik commented 2022-12-17 16:45:05 +01:00

Owner

Copy link

https://www.youtube.com/watch?v=kqeEfqe6gMw

https://www.youtube.com/watch?v=kqeEfqe6gMw

nik commented 2022-12-17 16:45:10 +01:00

Owner

Copy link

assigned to @nik and unassigned @lukasw

assigned to @nik and unassigned @lukasw

nik commented 2022-12-17 16:45:27 +01:00

Owner

Copy link

https://www.youtube.com/watch?v=kqeEfqe6gMw

https://www.youtube.com/watch?v=kqeEfqe6gMw

nik commented 2022-12-17 16:45:37 +01:00

Owner

Copy link

https://www.youtube.com/watch?v=kqeEfqe6gMw

https://www.youtube.com/watch?v=kqeEfqe6gMw

nik commented 2022-12-17 16:46:04 +01:00

Owner

Copy link

Absolute imports from aleksis.* before relative imports.

Absolute imports from `aleksis.*` before relative imports.

nik commented 2022-12-17 16:46:20 +01:00

Owner

Copy link

https://www.youtube.com/watch?v=kqeEfqe6gMw

https://www.youtube.com/watch?v=kqeEfqe6gMw

nik commented 2022-12-17 16:46:41 +01:00

Owner

Copy link

Why?

Why?

nik commented 2022-12-17 16:46:56 +01:00

Owner

Copy link

Why?

Why?

nik commented 2022-12-17 16:47:29 +01:00

Owner

Copy link

Why?

This also seems very wrong, because we do not have such a name here…

Why? This also seems very wrong, because we do not have such a name here…

nik commented 2022-12-17 16:47:55 +01:00

Owner

Copy link

Why?

Why?

nik commented 2022-12-17 16:48:03 +01:00

Owner

Copy link

Why?

Why?

nik commented 2022-12-17 16:48:17 +01:00

Owner

Copy link

Why?

Why?

nik commented 2022-12-17 16:48:36 +01:00

Owner

Copy link

The search index needs to be mvoed to core, obviously.

The search index needs to be mvoed to core, obviously.

tteichler commented 2022-12-18 11:29:02 +01:00

Owner

Copy link

resolved all threads

resolved all threads

tteichler commented 2022-12-18 11:29:08 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#653524cc5fbcf98d03df7335f9ecb088b9f9e4b2_9_9)

tteichler commented 2022-12-18 11:29:09 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#a70d4908df56432841a9180a1ba5872b47af7f4d_20_20)

tteichler commented 2022-12-18 11:29:09 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#d29e260234e8f51493408c2f159582b39a59f964_12_12)

tteichler commented 2022-12-18 11:29:10 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#9caea954f7ed53b37db271f2480f2845b0dd1aaf_29_31)

tteichler commented 2022-12-18 11:29:11 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#319a7c83fcc24607af30696b3d940f4e0f4d96e0_11_11)

tteichler commented 2022-12-18 11:29:11 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#aff889560e418df674a6887a541974fc95f8cd36_444_444)

tteichler commented 2022-12-18 11:29:12 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#aff889560e418df674a6887a541974fc95f8cd36_519_521)

tteichler commented 2022-12-18 11:29:12 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#aff889560e418df674a6887a541974fc95f8cd36_551_553)

tteichler commented 2022-12-18 11:29:12 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#aff889560e418df674a6887a541974fc95f8cd36_732_734)

tteichler commented 2022-12-18 11:29:13 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#aff889560e418df674a6887a541974fc95f8cd36_1069_1071)

tteichler commented 2022-12-18 11:29:13 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#aff889560e418df674a6887a541974fc95f8cd36_1215_1217)

tteichler commented 2022-12-18 11:29:13 +01:00

Owner

Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75#83b54db9e94bed5cebea392f51e19c08299f119f_3_0)

tteichler commented 2022-12-18 11:29:14 +01:00

Owner

Copy link

added 2 commits

• febc825e - Reformat and sort imports
• f5306988 - Fix models ForeignKeys, move search index to core

Compare with previous version

added 2 commits <ul><li>febc825e - Reformat and sort imports</li><li>f5306988 - Fix models ForeignKeys, move search index to core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26147&start_sha=9943056cbe80900286599758c45685d6c7d40b75)

tteichler commented 2022-12-18 11:40:45 +01:00

Owner

Copy link

added 1 commit

• d110e5f7 - Fix models ForeignKeys, move search index to core

Compare with previous version

added 1 commit <ul><li>d110e5f7 - Fix models ForeignKeys, move search index to core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26150&start_sha=f530698864d666dfbe1d0a34aef59429bf78dad5)

tteichler commented 2022-12-18 11:47:53 +01:00

Owner

Copy link

added 1 commit

• eba8450c - Fix models ForeignKeys, move search index to core

Compare with previous version

added 1 commit <ul><li>eba8450c - Fix models ForeignKeys, move search index to core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26152&start_sha=d110e5f7b65e23b6f52056bf6185575b90031b47)

tteichler commented 2022-12-18 20:14:53 +01:00

Owner

Copy link

added 2 commits

• 2f5e734b - Bump core dependency
• fababe86 - Merge branch '192-3-0-drop-room-from-model' of...

Compare with previous version

added 2 commits <ul><li>2f5e734b - Bump core dependency</li><li>fababe86 - Merge branch &#39;192-3-0-drop-room-from-model&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26231&start_sha=eba8450c481425c26e468e7b71154c04607c4f08)

tteichler commented 2022-12-19 18:08:17 +01:00

Owner

Copy link

added 1 commit

• d8174ab0 - Bump resint

Compare with previous version

added 1 commit <ul><li>d8174ab0 - Bump resint</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26275&start_sha=fababe864052798abae917a15478645e108296f9)

nik commented 2022-12-20 14:38:42 +01:00

Owner

Copy link

The respective MR in core is still missing.

The respective MR in core is still missing.

yuha commented 2022-12-28 17:44:32 +01:00

Member

Copy link

This migration is actually named "0047[...]" in AlekSIS-Core so that migrating currently fails.

This migration is actually named "0047[...]" in AlekSIS-Core so that migrating currently fails.

yuha commented 2022-12-28 17:45:55 +01:00

Member

Copy link

        ('core', '0047_add_room_model'),

```suggestion:-0+0 ('core', '0047_add_room_model'), ```

yuha commented 2022-12-28 17:46:26 +01:00

Member

Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26455&start_sha=d8174ab0c98d05ae3e9de6944fb02c26f21cea3e#556ee853cb5717f96bb07be7ee7c6069e3bb30de_10_10)

yuha commented 2022-12-28 17:46:27 +01:00

Member

Copy link

added 1 commit

• fa2759e2 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>fa2759e2 - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26455&start_sha=d8174ab0c98d05ae3e9de6944fb02c26f21cea3e)

yuha commented 2022-12-28 17:47:33 +01:00

Member

Copy link

added 1 commit

• 4a7a6502 - Rename faulty reference to core migration

Compare with previous version

added 1 commit <ul><li>4a7a6502 - Rename faulty reference to core migration</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/284/diffs?diff_id=26456&start_sha=fa2759e238faef2be48c0231407b05da42e9752e)

hansegucker commented 2023-01-04 19:15:36 +01:00

Owner

Copy link

resolved all threads

resolved all threads

nik merged commit 426bdd2a03 into master 2023-01-18 01:14:03 +01:00

nik commented 2023-01-18 01:14:11 +01:00

Owner

Copy link

mentioned in commit 426bdd2a03

mentioned in commit 426bdd2a037af77b345cf80b1225905d72ae7027

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Security

  

TeX

Needs LaTeX template

  

auto-update

  

board

done

  

board

ready

  

board

todo

  

check

delete-eslint-rc-js

  

check

update-builddeps-package-json

  

check

update-eslint-rc-js

  

check

update-gitignore

  

check

update-merge-request-template

  

check

update-prettier-ignore

  

check

update-pyproject-toml

  

check

update-renovate-json

  

check

update-tox-ini

  

part

backend

Backend (view code, models, logic, etc.)

  

part

ci

  

part

docs

Issue or addition to the documentation

  

part

frontend

Frontend (templates, etc.)

  

part

i18n

Translation or internationalisation issue

  

part

non-technical

Non-technical (policy, maintenance, etc.) issue or discussion

  

part

packaging

Issue concerning the packaging of AlekSIS and components

  

prio

1

Priority High

  

prio

2

Priority Medium

  

prio

3

Priority Low

  

release-mr-5.x

  

size

large

  

size

medium

  

size

small

  

source

customer

Requested by a customer or affiliated user

  

source

customer::fsmw

  

source

customer::fss

  

source

customer::teckids

  

source

downstream

Issue or merge request from other projects using AlekSIS or parts of it

  

type

breaking

  

type

bug

Bug

  

type

feature

New feature

  

type

refactoring

  

workflow

blocked

Issue is blocked by another issue

  

workflow

confirmed

The bug is reproducible and will be fixed

  

workflow

current-todo

  

workflow

discussing

Needs to be discussed before implementation

  

workflow

new-app

Requires new AlekSIS app, which has to be created

  

workflow

wontfix

The bug is not reproducible or the feature was decided against

  

source::aleksolotl

No labels

Security

TeX

auto-update

board

done

board

ready

board

todo

check

delete-eslint-rc-js

check

update-builddeps-package-json

check

update-eslint-rc-js

check

update-gitignore

check

update-merge-request-template

check

update-prettier-ignore

check

update-pyproject-toml

check

update-renovate-json

check

update-tox-ini

part

backend

part

ci

part

docs

part

frontend

part

i18n

part

non-technical

part

packaging

prio

1

prio

2

prio

3

release-mr-5.x

size

large

size

medium

size

small

source

customer

source

customer::fsmw

source

customer::fss

source

customer::teckids

source

downstream

type

breaking

type

bug

type

feature

type

refactoring

workflow

blocked

workflow

confirmed

workflow

current-todo

workflow

discussing

workflow

new-app

workflow

wontfix

source::aleksolotl

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

nik

5 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

aleksis/AlekSIS-App-Chronos!588

No description provided.