aleksis/AlekSIS-App-Chronos
8
0
Fork 0
Code Issues 51 Pull requests 5 Projects Releases 4 Packages Activity Actions

Resolve "Notification for changes in the substitution plan" #546

Merged
hansegucker merged 13 commits from 50-notification-for-changes-in-the-substitution-plan into master 2022-03-20 10:22:36 +01:00
Conversation 54 Commits 13 Files changed 11 +818 -3
hansegucker commented 2022-02-10 15:45:24 +01:00 (Migrated from edugit.org)
Copy link

Closes #50

Closes #50
hansegucker commented 2022-02-10 15:45:25 +01:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2022-02-15 13:05:29 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 51bee1cd - Write a change tracker and implement basic notifications for timetable changes
  • d945f909 - Add tests for change tracker and notifications

Compare with previous version

added 2 commits <ul><li>51bee1cd - Write a change tracker and implement basic notifications for timetable changes</li><li>d945f909 - Add tests for change tracker and notifications</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18548&start_sha=01373e623357c737afc5e988040d69c04e1b06ec)
hansegucker commented 2022-02-15 13:10:27 +01:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker commented 2022-02-16 19:47:08 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Send notifications only when the object affects a specific time period in the future (next day, 24/48 hours, something like that) as completed

marked the checklist item **Send notifications only when the object affects a specific time period in the future (next day, 24/48 hours, something like that)** as completed
hansegucker commented 2022-02-16 20:17:56 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 60105717 - Don't send notifications for changes in irrelevant time range

Compare with previous version

added 1 commit <ul><li>60105717 - Don&#39;t send notifications for changes in irrelevant time range</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18566&start_sha=d945f90967cfe2480ebd8f2e97494feb8ee7a87d)
hansegucker commented 2022-02-17 14:26:38 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Site preference for globally activating/deactivating notifications as completed

marked the checklist item **Site preference for globally activating/deactivating notifications** as completed
hansegucker commented 2022-02-17 14:26:40 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Person preference for activating/deactivating notifications as completed

marked the checklist item **Person preference for activating/deactivating notifications** as completed
hansegucker commented 2022-02-17 14:38:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 103f9bfe - Add preferences for timetable change notifications

Compare with previous version

added 1 commit <ul><li>103f9bfe - Add preferences for timetable change notifications</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18585&start_sha=6010571707afa5781d37ae68fd3a0ee5b30ba00d)
hansegucker commented 2022-02-17 16:37:32 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 22b0c216 - Add mode for sending notifications for the next day

Compare with previous version

added 1 commit <ul><li>22b0c216 - Add mode for sending notifications for the next day</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18586&start_sha=103f9bfe4b0bdf3960588d84c300bac3b2957a19)
hansegucker commented 2022-02-17 16:37:39 +01:00 (Migrated from edugit.org)
Copy link

marked the checklist item Preference for point of time when notifications for longer existing objects should be sent (see above) as completed

marked the checklist item **Preference for point of time when notifications for longer existing objects should be sent (see above)** as completed
hansegucker commented 2022-02-17 16:37:50 +01:00 (Migrated from edugit.org)
Copy link

changed the description

changed the description
hansegucker commented 2022-02-17 16:37:53 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2022-02-17 16:37:56 +01:00 (Migrated from edugit.org)
Copy link

assigned to @nik and unassigned @hansegucker

assigned to @nik and unassigned @hansegucker
hansegucker commented 2022-02-17 16:40:54 +01:00 (Migrated from edugit.org)
Copy link

TODO:

  • Update docs
  • Update changelog
  • Fix tests
TODO: - [x] Update docs - [x] Update changelog - [x] Fix tests
nik commented 2022-02-17 17:00:41 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2022-02-17 17:18:10 +01:00 (Migrated from edugit.org)
Copy link

Please move this below the imports

Please move this below the imports
nik commented 2022-02-17 17:18:11 +01:00 (Migrated from edugit.org)
Copy link

Don't use Dict, List, and Type.

Don't use `Dict`, `List`, and `Type`.
nik commented 2022-02-17 17:18:11 +01:00 (Migrated from edugit.org)
Copy link

Don't type kwargs.

Don't type `kwargs`.
nik commented 2022-02-17 17:18:11 +01:00 (Migrated from edugit.org)
Copy link

Much of this looks as though it should go into the template. But I might be mistaken.

Much of this looks as though it should go into the template. But I might be mistaken.
nik commented 2022-02-17 17:18:11 +01:00 (Migrated from edugit.org)
Copy link

Missing doc string (it is a private method, but yet...)

Missing doc string (it is a private method, but yet...)
nik commented 2022-02-17 17:18:11 +01:00 (Migrated from edugit.org)
Copy link

That doesn't calrify the need for the above private method. Please document why this feature needs to run code post-migration.

That doesn't calrify the need for the above private method. Please document why this feature needs to run code post-migration.
nik commented 2022-02-17 17:18:11 +01:00 (Migrated from edugit.org)
Copy link

Missing doc string

Missing doc string
nik commented 2022-02-17 17:18:11 +01:00 (Migrated from edugit.org)
Copy link

Why does this need a getter method?

Why does this need a getter method?
nik commented 2022-02-17 17:18:11 +01:00 (Migrated from edugit.org)
Copy link

WHy don't we send notifications imemdiately when the change gets known?

WHy don't we send notifications imemdiately when the change gets known?
hansegucker commented 2022-02-17 19:27:14 +01:00 (Migrated from edugit.org)
Copy link

Into which template?

Into which template?
hansegucker commented 2022-02-17 19:28:18 +01:00 (Migrated from edugit.org)
Copy link

The TeacherPropertiesMixin used in this model depends on a get_teachers method. So, before the methods and properties provided through the mixin weren't usable.

The _TeacherPropertiesMixin_ used in this model depends on a `get_teachers` method. So, before the methods and properties provided through the mixin weren't usable.
hansegucker commented 2022-02-17 19:29:30 +01:00 (Migrated from edugit.org)
Copy link

We do that for changes which affects the current/next day. But if there is a newly created substitution for in two weeks, we don't want to send a notification two weeks in advance.

We do that for changes which affects the current/next day. But if there is a newly created substitution for in two weeks, we don't want to send a notification two weeks in advance.
nik commented 2022-02-17 20:48:09 +01:00 (Migrated from edugit.org)
Copy link

Into the notification templa… oh, we don't have templates for notifications? Sad thing. OK, so this should go here, plus into a core feature request for notification templates ;).

Into the notification templa… oh, we don't have templates for notifications? Sad thing. OK, so this should go here, plus into a core feature request for notification templates ;).
nik commented 2022-02-17 20:49:39 +01:00 (Migrated from edugit.org)
Copy link

Then this, or the breakpoint for deciding whether to notify now or later, should be configurable. Probably with two settings, one for "notify imemdiately for changes within the next n days" and one for "notify for all changes on the next day"

Then this, or the breakpoint for deciding whether to notify now or later, should be configurable. Probably with two settings, one for "notify imemdiately for changes within the next n days" and one for "notify for all changes on the next day"
hansegucker commented 2022-02-18 21:28:29 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18619&start_sha=22b0c2167e54fe97112075142da4c96317506690#055e900658e7f4604530de6adbd628bcc68a9c54_1_1)
hansegucker commented 2022-02-18 21:28:29 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18619&start_sha=22b0c2167e54fe97112075142da4c96317506690#055e900658e7f4604530de6adbd628bcc68a9c54_91_90)
hansegucker commented 2022-02-18 21:28:30 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18619&start_sha=22b0c2167e54fe97112075142da4c96317506690#aff889560e418df674a6887a541974fc95f8cd36_473_473)
hansegucker commented 2022-02-18 21:28:31 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 135f081e - Tidy notification and change tracker code

Compare with previous version

added 1 commit <ul><li>135f081e - Tidy notification and change tracker code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18619&start_sha=22b0c2167e54fe97112075142da4c96317506690)
hansegucker commented 2022-02-18 21:31:56 +01:00 (Migrated from edugit.org)
Copy link

https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/659

https://edugit.org/AlekSIS/official/AlekSIS-Core/-/issues/659
hansegucker commented 2022-02-24 20:34:55 +01:00 (Migrated from edugit.org)
Copy link

Blocked by https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/983 ~"workflow::blocked"

\label ~"workflow::blocked"

Blocked by https://edugit.org/AlekSIS/official/AlekSIS-Core/-/merge_requests/983 ~"workflow::blocked" \label ~"workflow::blocked"
hansegucker commented 2022-02-24 20:38:14 +01:00 (Migrated from edugit.org)
Copy link

mentioned in merge request AlekSIS-App-Untis!431

mentioned in merge request AlekSIS-App-Untis!431
hansegucker commented 2022-02-24 20:38:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 1fbbee9b - Either directly send notifications or delay them for later

Compare with previous version

added 1 commit <ul><li>1fbbee9b - Either directly send notifications or delay them for later</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=18945&start_sha=135f081e0af38f5988894b7285053ea8060670c3)
hansegucker commented 2022-02-25 13:52:52 +01:00 (Migrated from edugit.org)
Copy link

added 3h of time spent

added 3h of time spent
hansegucker commented 2022-02-27 17:49:45 +01:00 (Migrated from edugit.org)
Copy link

added 8 commits

  • 1fbbee9b...cf095d0b - 7 commits from branch master
  • 386df0f5 - Merge branch 'master' into 50-notification-for-changes-in-the-substitution-plan

Compare with previous version

added 8 commits <ul><li>1fbbee9b...cf095d0b - 7 commits from branch <code>master</code></li><li>386df0f5 - Merge branch &#39;master&#39; into 50-notification-for-changes-in-the-substitution-plan</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19032&start_sha=1fbbee9ba5b726b2852c55687f239bb72aaaa974)
hansegucker commented 2022-02-27 18:23:18 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • b63d92e0 - Reformat
  • e0f2bc46 - Fix notification test

Compare with previous version

added 2 commits <ul><li>b63d92e0 - Reformat</li><li>e0f2bc46 - Fix notification test</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19034&start_sha=386df0f52f029a248bf221169842e69a66608738)
hansegucker commented 2022-02-27 18:25:11 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f96bab22 - Update changelog

Compare with previous version

added 1 commit <ul><li>f96bab22 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19035&start_sha=e0f2bc4659630518e446f8fa41f8cf7164ac5dd6)
hansegucker commented 2022-02-27 18:31:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • a82e0fcb - [Docs] Add information on how to use notifications for users

Compare with previous version

added 1 commit <ul><li>a82e0fcb - [Docs] Add information on how to use notifications for users</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19037&start_sha=f96bab220d1fc3a285ae50aa2ecac0cf043d2319)
hansegucker commented 2022-02-27 18:31:55 +01:00 (Migrated from edugit.org)
Copy link

added 20m of time spent

added 20m of time spent
hansegucker commented 2022-03-07 20:11:49 +01:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • a82e0fcb...e8b7ce48 - 2 commits from branch master
  • aefb48d7 - Merge remote-tracking branch 'origin/master' into...

Compare with previous version

added 3 commits <ul><li>a82e0fcb...e8b7ce48 - 2 commits from branch <code>master</code></li><li>aefb48d7 - Merge remote-tracking branch &#39;origin/master&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19243&start_sha=a82e0fcb68821c4567e1a44d97a3f55dea4f93a1)
hansegucker commented 2022-03-07 20:36:31 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f9b976ac - [Docs] Add information about setting up notifications in admin handbook

Compare with previous version

added 1 commit <ul><li>f9b976ac - [Docs] Add information about setting up notifications in admin handbook</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19247&start_sha=aefb48d71697b3a798c938b78d56bb8e6ff345ed)
hansegucker commented 2022-03-08 18:48:00 +01:00 (Migrated from edugit.org)
Copy link

added 1h of time spent

added 1h of time spent
hansegucker commented 2022-03-12 22:06:55 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 90f3359f - Depend on current Core to include scheduled notifications

Compare with previous version

added 1 commit <ul><li>90f3359f - Depend on current Core to include scheduled notifications</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19481&start_sha=f9b976ac9a45cde9ebba5f4e6949b0d1de4c34ba)
hansegucker commented 2022-03-12 22:12:04 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2022-03-12 22:12:11 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
nik commented 2022-03-12 22:16:18 +01:00 (Migrated from edugit.org)
Copy link

No newline at end of file

No newline at end of file
hansegucker commented 2022-03-12 22:22:31 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2022-03-12 22:22:38 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19488&start_sha=90f3359f564970e27adb939139ce8ca2c941090c#260712586d86d3a8474cb4979e81906bbf6e4e26_21_21)
hansegucker commented 2022-03-12 22:22:39 +01:00 (Migrated from edugit.org)
Copy link

added 13 commits

  • 7aca0719 - Write a change tracker and implement basic notifications for timetable changes
  • 31043aa6 - Add tests for change tracker and notifications
  • 637d35d9 - Don't send notifications for changes in irrelevant time range
  • d0b7fcaa - Add preferences for timetable change notifications
  • 9cf9fa33 - Add mode for sending notifications for the next day
  • 473cef6d - Tidy notification and change tracker code
  • 3a28ee0b - Either directly send notifications or delay them for later
  • 640c12f7 - Reformat
  • 4a5b7ad9 - Fix notification test
  • af211f86 - Update changelog
  • 0184f392 - [Docs] Add information on how to use notifications for users
  • 547bc550 - [Docs] Add information about setting up notifications in admin handbook
  • 1820081a - Depend on current Core to include scheduled notifications

Compare with previous version

added 13 commits <ul><li>7aca0719 - Write a change tracker and implement basic notifications for timetable changes</li><li>31043aa6 - Add tests for change tracker and notifications</li><li>637d35d9 - Don&#39;t send notifications for changes in irrelevant time range</li><li>d0b7fcaa - Add preferences for timetable change notifications</li><li>9cf9fa33 - Add mode for sending notifications for the next day</li><li>473cef6d - Tidy notification and change tracker code</li><li>3a28ee0b - Either directly send notifications or delay them for later</li><li>640c12f7 - Reformat</li><li>4a5b7ad9 - Fix notification test</li><li>af211f86 - Update changelog</li><li>0184f392 - [Docs] Add information on how to use notifications for users</li><li>547bc550 - [Docs] Add information about setting up notifications in admin handbook</li><li>1820081a - Depend on current Core to include scheduled notifications</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/242/diffs?diff_id=19488&start_sha=90f3359f564970e27adb939139ce8ca2c941090c)
nik (Migrated from edugit.org) merged commit 6f667b881b into master 2022-03-20 10:22:36 +01:00
nik commented 2022-03-20 10:22:38 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 6f667b881b

mentioned in commit 6f667b881bb28b5b8acf8cea625ad651c8782d11
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Chronos!546
No description provided.