aleksis/AlekSIS-App-Chronos
8
0
Fork 0
Code Issues 51 Pull requests 5 Projects Releases 4 Packages Activity Actions

WIP: Draft: Allow to manage time periods in frontend #500

Closed
debdolph wants to merge 6 commits from create-timeperiods into master
pull from: create-timeperiods
merge into: aleksis:master
Conversation 29 Commits 6 Files changed 11 +205 -9
debdolph commented 2021-08-14 21:12:24 +02:00 (Migrated from edugit.org)
Copy link
No description provided.
debdolph commented 2021-08-14 21:13:53 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>03aa10f2 - Update changelog</li><li>256fb70c - Update authors</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11170&start_sha=aa6da8b0479d9857d73beb3e71878172d5368650)
debdolph commented 2021-08-14 21:41:38 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 9e407a42 - Add missing imports

Compare with previous version

added 1 commit <ul><li>9e407a42 - Add missing imports</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11172&start_sha=256fb70c9dfd8d3a22267dff02eafe599849c9b7)
debdolph commented 2021-08-15 11:57:04 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>09b78ef0 - Add missing imports</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11176&start_sha=9e407a42fe7f4ac0b9569c438f8dcefbaa7a978f)
debdolph commented 2021-08-15 11:59:09 +02:00 (Migrated from edugit.org)
Copy link

requested review from @nik

requested review from @nik
debdolph commented 2021-08-15 11:59:13 +02:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2021-08-15 12:02:23 +02:00 (Migrated from edugit.org)
Copy link

I think there are some rules missing (create/edit).

I think there are some rules missing (create/edit).
hansegucker commented 2021-08-15 12:02:23 +02:00 (Migrated from edugit.org)
Copy link
    permission_required = "chronos.edit_timeperiod_rule"
```suggestion:-0+0 permission_required = "chronos.edit_timeperiod_rule" ```
hansegucker commented 2021-08-15 12:02:24 +02:00 (Migrated from edugit.org)
Copy link

Please add a check if the user is allowed to create time periods and show the button just then.

Please add a check if the user is allowed to create time periods and show the button just then.
hansegucker commented 2021-08-15 12:02:48 +02:00 (Migrated from edugit.org)
Copy link

Please add a delete view. 😉

Please add a delete view. 😉
hansegucker commented 2021-08-15 12:03:09 +02:00 (Migrated from edugit.org)
Copy link

Oh, and please fix the pipeline.

Oh, and please fix the pipeline.
debdolph commented 2021-08-15 12:05:53 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 46011756 - Allow to delete time periods

Compare with previous version

added 1 commit <ul><li>46011756 - Allow to delete time periods</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11179&start_sha=09b78ef049752cc70770dc8f84870639597cbe97)
debdolph commented 2021-08-15 12:10:49 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • d4d81eaf - Allow to delete time periods

Compare with previous version

added 1 commit <ul><li>d4d81eaf - Allow to delete time periods</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11181&start_sha=460117566d9474ed747485115bbabe0ee410ddc3)
debdolph commented 2021-08-15 12:28:51 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>523c8e61 - Allow to delete time periods</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11183&start_sha=d4d81eaf53d24f74fdc1672222feded6a83c6bf0)
debdolph commented 2021-08-15 12:39:27 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
debdolph commented 2021-08-15 12:40:39 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11185&start_sha=523c8e616609fa7cf2ed378224604d8c364725d0#ecdd005d84163aee544a13d63f60c6ae48790539_392_392)
debdolph commented 2021-08-15 12:40:39 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11185&start_sha=523c8e616609fa7cf2ed378224604d8c364725d0#f4bcdbe1f5c437e91f48a78de4eea09a1f01e2a8_15_12)
debdolph commented 2021-08-15 12:40:40 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>9c255ef5 - Add permissions</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/196/diffs?diff_id=11185&start_sha=523c8e616609fa7cf2ed378224604d8c364725d0)
hansegucker commented 2021-08-15 12:50:07 +02:00 (Migrated from edugit.org)
Copy link
    has_global_perm("chronos.change_timeperiod")
    | has_object_perm("chronos.edit_timeperiod", TimePeriod)
```suggestion:-1+0 has_global_perm("chronos.change_timeperiod") | has_object_perm("chronos.edit_timeperiod", TimePeriod) ```
hansegucker commented 2021-08-15 12:50:08 +02:00 (Migrated from edugit.org)
Copy link
    has_global_perm("chronos.add_timeperiod")
```suggestion:-1+0 has_global_perm("chronos.add_timeperiod") ```
hansegucker commented 2021-08-15 12:50:08 +02:00 (Migrated from edugit.org)
Copy link
    has_global_perm("chronos.delete_timeperiod")
    | has_object_perm("chronos.delete_timeperiod", TimePeriod)
```suggestion:-1+0 has_global_perm("chronos.delete_timeperiod") | has_object_perm("chronos.delete_timeperiod", TimePeriod) ```
hansegucker commented 2021-08-15 12:50:09 +02:00 (Migrated from edugit.org)
Copy link
add_perm("chronos.delete_timeperiod_rule", delete_time_periods_predicate)
```suggestion:-0+0 add_perm("chronos.delete_timeperiod_rule", delete_time_periods_predicate) ```
hansegucker commented 2021-08-15 12:50:09 +02:00 (Migrated from edugit.org)
Copy link
add_perm("chronos.create_timeperiod_rule", create_time_periods_predicate)
```suggestion:-0+0 add_perm("chronos.create_timeperiod_rule", create_time_periods_predicate) ```
hansegucker commented 2021-08-15 12:50:09 +02:00 (Migrated from edugit.org)
Copy link
    permission_required = "chronos.view_timeperiods_rule"
```suggestion:-0+0 permission_required = "chronos.view_timeperiods_rule" ```
hansegucker commented 2021-08-15 12:50:10 +02:00 (Migrated from edugit.org)
Copy link
add_perm("chronos.view_timeperiods_rule", view_time_periods_predicate)
```suggestion:-0+0 add_perm("chronos.view_timeperiods_rule", view_time_periods_predicate) ```
hansegucker commented 2021-08-15 12:50:10 +02:00 (Migrated from edugit.org)
Copy link
    has_global_perm("chronos.view_timeperiod")
    | has_any_object("chronos.view_timeperiod", TimePeriod)
```suggestion:-1+0 has_global_perm("chronos.view_timeperiod") | has_any_object("chronos.view_timeperiod", TimePeriod) ```
hansegucker commented 2021-08-15 12:50:10 +02:00 (Migrated from edugit.org)
Copy link

In general: Please pay attention to name the rules and permissions correctly.

https://docs.djangoproject.com/en/3.2/topics/auth/default/#default-permissions

In general: Please pay attention to name the rules and permissions correctly. https://docs.djangoproject.com/en/3.2/topics/auth/default/#default-permissions
hansegucker commented 2021-09-14 17:52:15 +02:00 (Migrated from edugit.org)
Copy link

marked this merge request as draft

marked this merge request as **draft**
nik commented 2022-01-06 16:14:54 +01:00 (Migrated from edugit.org)
Copy link

mentioned in issue #161

mentioned in issue #161
hansegucker commented 2023-03-01 19:36:39 +01:00 (Migrated from edugit.org)
Copy link

Closed in favor of general redesign

Closed in favor of general redesign
hansegucker (Migrated from edugit.org) closed this pull request 2023-03-01 19:36:40 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Chronos!500
No description provided.