Watch

Resolve "next_lesson doesn't correctly work with changing validity ranges and probably also year changes" #448

Merged

hansegucker merged 2 commits from 122-next_lesson-doesn-t-correctly-work-with-changing-validity-ranges-and-probably-also-year-changes into master

2021-03-26 12:51:10 +01:00

hansegucker commented

2021-03-25 20:58:29 +01:00

Owner

Closes #122

hansegucker commented

2021-03-25 20:59:56 +01:00

Author

Owner

assigned to @nik and unassigned @hansegucker

hansegucker commented

2021-03-25 20:59:57 +01:00

Author

Owner

marked this merge request as ready

marked this merge request as **ready**

hansegucker commented

2021-03-25 21:00:03 +01:00

Author

Owner

added 1 commit

acb39b03 - Make next_lesson work with multiple validity ranges and year changes

Compare with previous version

added 1 commit <ul><li>acb39b03 - Make next_lesson work with multiple validity ranges and year changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/144/diffs?diff_id=6354&start_sha=9c92bdfc442abe451fc05364ec73414fc6672f8c)

hansegucker commented

2021-03-25 21:05:15 +01:00

Author

Owner

Blocked by AlekSIS/libs/python-calendarweek!311

nik commented

2021-03-25 21:51:42 +01:00

Owner

Please make this

if validity_index == 0:
    return None

This gets rid of one level of indentation for the following code.

Same for line 456.

Please make this ```python if validity_index == 0: return None ``` This gets rid of one level of indentation for the following code. Same for line 456.

nik commented

2021-03-25 22:24:02 +01:00

Owner

I released calendarweek 0.5.0, please update the dependency.

nik commented

2021-03-25 22:46:16 +01:00

Owner

Ah, it's a core dependency.

Normally, we would now have to bump the core version and depend on it, but as our semantic versioning is not in order yet I will ignore this for now and hope for the best.

Ah, it's a core dependency. Normally, we would now have to bump the core version and depend on it, but as our semantic versioning is not in order yet I will ignore this for now and hope for the best.

hansegucker commented

2021-03-26 09:08:19 +01:00

Author

Owner

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/144/diffs?diff_id=6398&start_sha=acb39b03ea202148ee7b901ff93aed9fc7fe2539#601948d5f8dd219a0874cb98a4b16b80f18d0628_439_439)

hansegucker commented

2021-03-26 09:08:21 +01:00

Author

Owner

added 1 commit

47cbec5a - Make next_lesson work with multiple validity ranges and year changes

Compare with previous version

added 1 commit <ul><li>47cbec5a - Make next_lesson work with multiple validity ranges and year changes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/144/diffs?diff_id=6398&start_sha=acb39b03ea202148ee7b901ff93aed9fc7fe2539)

hansegucker commented

2021-03-26 09:08:36 +01:00

Author

Owner

Done.

hansegucker commented

2021-03-26 09:08:37 +01:00

Author

Owner

resolved all threads

hansegucker commented

2021-03-26 09:08:47 +01:00

Author

Owner

added 16 commits

47cbec5a...56930943 - 15 commits from branch master
df9366d3 - Merge branch 'master' into...

Compare with previous version

added 16 commits <ul><li>47cbec5a...56930943 - 15 commits from branch <code>master</code></li><li>df9366d3 - Merge branch 'master' into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/144/diffs?diff_id=6399&start_sha=47cbec5a56323e8f2decf1ddbab477d95691c069)

nik merged commit 606c9b228a into master

2021-03-26 12:51:10 +01:00

nik commented

2021-03-26 12:51:15 +01:00

Owner

mentioned in commit 606c9b228a

mentioned in commit 606c9b228a9b96ac5530362d3da316e064a2c436