Resolve "PDF export for timetables" #381

Merged
hansegucker merged 22 commits from 51-pdf-export-for-timetables into master 2021-05-04 19:19:32 +02:00
Member

Closes #51

Closes #51
Author
Member

added 1 commit

  • e6ae2fc1 - DO NOT PUSH -- TIMETABLE EXPORT

Compare with previous version

added 1 commit <ul><li>e6ae2fc1 - DO NOT PUSH -- TIMETABLE EXPORT</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=3271&start_sha=50fd338d26689c8b69c1f38c381077194aeceee9)
lloydmeins commented 2020-10-21 09:12:46 +02:00 (Migrated from edugit.org)

added 18 commits

  • e6ae2fc1...aec695be - 16 commits from branch master
  • 73265f7c - Merge branch 'master' into 51-pdf-export-for-timetables
  • ce382f88 - Fix view of regular plans

Compare with previous version

added 18 commits <ul><li>e6ae2fc1...aec695be - 16 commits from branch <code>master</code></li><li>73265f7c - Merge branch &#39;master&#39; into 51-pdf-export-for-timetables</li><li>ce382f88 - Fix view of regular plans</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=3510&start_sha=e6ae2fc1d0bd91b5631180d57ed4014916d589c2)
Owner

@lloydmeins Please give us an update on this. Do you need any help or support?

@lloydmeins Please give us an update on this. Do you need any help or support?
lloydmeins commented 2020-12-10 12:44:47 +01:00 (Migrated from edugit.org)

I think it would be good if @hansegucker and I would meet and work on it for some time.

I think it would be good if @hansegucker and I would meet and work on it for some time.
lloydmeins commented 2020-12-11 14:30:48 +01:00 (Migrated from edugit.org)

added 1 commit

  • 7283ea07 - Safe files for reinstallation of local AlekSIS system

Compare with previous version

added 1 commit <ul><li>7283ea07 - Safe files for reinstallation of local AlekSIS system</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4013&start_sha=ce382f8802f18fe279a7b79b805e85d0f5d07cd1)
lloydmeins commented 2021-01-24 12:10:44 +01:00 (Migrated from edugit.org)

added 106 commits

  • 7283ea07...36d38608 - 105 commits from branch master
  • 83487c15 - Merge branch 'master' into 51-pdf-export-for-timetables

Compare with previous version

added 106 commits <ul><li>7283ea07...36d38608 - 105 commits from branch <code>master</code></li><li>83487c15 - Merge branch &#39;master&#39; into 51-pdf-export-for-timetables</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4494&start_sha=7283ea075b043476f6e2b86c88cf68e841d70643)
lloydmeins commented 2021-01-24 13:08:44 +01:00 (Migrated from edugit.org)

added 1 commit

  • 1060c69a - Export timetable as pdf

Compare with previous version

added 1 commit <ul><li>1060c69a - Export timetable as pdf</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4496&start_sha=83487c155ee85901c013ae586542f9e4ad6b79c7)
lloydmeins commented 2021-01-24 13:10:59 +01:00 (Migrated from edugit.org)

assigned to @lloydmeins

assigned to @lloydmeins
lloydmeins commented 2021-01-24 13:11:16 +01:00 (Migrated from edugit.org)

unassigned @lloydmeins

unassigned @lloydmeins
Owner

assigned to @fph

assigned to @fph
Owner

assigned to @nik and unassigned @fph

assigned to @nik and unassigned @fph
Owner

requested review from @ZugBahnHof

requested review from @ZugBahnHof
Owner

added 1 commit

  • 6bf52d7b - Reformat

Compare with previous version

added 1 commit <ul><li>6bf52d7b - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4497&start_sha=1060c69ade238c60ea17147ba2e90e5241a4de85)
lloydmeins commented 2021-01-24 13:16:45 +01:00 (Migrated from edugit.org)

added 2 commits

  • b1ad2918 - Remove import of not used modules
  • 15084872 - Merge remote-tracking branch 'origin/51-pdf-export-for-timetables' into...

Compare with previous version

added 2 commits <ul><li>b1ad2918 - Remove import of not used modules</li><li>15084872 - Merge remote-tracking branch &#39;origin/51-pdf-export-for-timetables&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4498&start_sha=6bf52d7bd6efbdd4a0959457bbbf2a975f9101be)
lloydmeins commented 2021-01-24 14:16:24 +01:00 (Migrated from edugit.org)

added 1 commit

  • 2d0a7778 - Remove second page of pdf

Compare with previous version

added 1 commit <ul><li>2d0a7778 - Remove second page of pdf</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4500&start_sha=15084872c8fd8aa0ca4a62ececadad5b27a27b3f)
Owner

added 7 commits

  • 3bbf9f14 - DO NOT PUSH -- TIMETABLE EXPORT
  • 9813018d - Safe files for reinstallation of local AlekSIS system
  • 7305efe5 - Export timetable as pdf
  • 446d06c8 - Remove import of not used modules
  • dbf181fe - Reformat
  • a5f7cd58 - Remove second page of pdf
  • 58efb529 - Use PDF rendering tools from core

Compare with previous version

added 7 commits <ul><li>3bbf9f14 - DO NOT PUSH -- TIMETABLE EXPORT</li><li>9813018d - Safe files for reinstallation of local AlekSIS system</li><li>7305efe5 - Export timetable as pdf</li><li>446d06c8 - Remove import of not used modules</li><li>dbf181fe - Reformat</li><li>a5f7cd58 - Remove second page of pdf</li><li>58efb529 - Use PDF rendering tools from core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4509&start_sha=2d0a777872554f73754348956b32ee3c0711a3a6)
Owner

added 4 commits

  • 177d518a - Export timetable as pdf
  • 539998bc - Remove import of not used modules
  • 7f1f4628 - Remove second page of pdf
  • a6c31590 - Use PDF rendering tools from core

Compare with previous version

added 4 commits <ul><li>177d518a - Export timetable as pdf</li><li>539998bc - Remove import of not used modules</li><li>7f1f4628 - Remove second page of pdf</li><li>a6c31590 - Use PDF rendering tools from core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4510&start_sha=58efb529f6380c875fb47ca69c3133a2517c5c90)
Owner

added 5 commits

  • 08bf4821 - Add templates and files for PDF export of timetables
  • efbf13f3 - Export timetable as pdf
  • b393ad2c - Remove import of not used modules
  • cd27bfc9 - Remove second page of pdf
  • ce2016aa - Use PDF rendering tools from core

Compare with previous version

added 5 commits <ul><li>08bf4821 - Add templates and files for PDF export of timetables</li><li>efbf13f3 - Export timetable as pdf</li><li>b393ad2c - Remove import of not used modules</li><li>cd27bfc9 - Remove second page of pdf</li><li>ce2016aa - Use PDF rendering tools from core</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4511&start_sha=a6c31590e596d9e5965e8ec75326cb74c300bc33)
Owner

added 1 commit

Compare with previous version

added 1 commit <ul><li>4cd826f2 - Reformat and fix lint</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4512&start_sha=ce2016aa5799d8f743312f8bb41e2175796ac9f4)
Author
Member

??

??
lloydmeins commented 2021-01-25 10:52:03 +01:00 (Migrated from edugit.org)

Can you please elaborate on what you mean exactly. "??" is not a good indicator.

Can you please elaborate on what you mean exactly. "??" is not a good indicator.
Author
Member

What does {# Show short weekdays on tablets #} mean in this context?

What does `{# Show short weekdays on tablets #}` mean in this context?
Owner

I guess it means that on smaller screen sizes, weekday headers are abbreviated.

If the UI behaviour is different on some devices, please post screenshots showing that!

I guess it means that on smaller screen sizes, weekday headers are abbreviated. If the UI behaviour is different on some devices, please post screenshots showing that!
Author
Member

I think, this is simply old code, from another template, because the pdf won't change on other display sizes

I think, this is simply old code, from another template, because the pdf won't change on other display sizes
Owner

Ah oh, it's the PDF :D

Ah oh, it's the PDF :D
Owner

requested review from @hansegucker and removed review request for @ZugBahnHof

requested review from @hansegucker and removed review request for @ZugBahnHof
Owner

Can you please fix the margins here, @lloydmeins?
image

Can you please fix the margins here, @lloydmeins? ![image](/uploads/5f4f9769084f860ac4bda10290ac43d5/image.png)
Owner

And it would be nice if the PDF makes use of Roboto as font family.

And it would be nice if the PDF makes use of Roboto as font family.
lloydmeins commented 2021-02-08 17:10:39 +01:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>759e6fbd - Change font to Roboto</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4700&start_sha=4cd826f218d88cbb513b98871a4c315c81da3ca9)
Owner

Blocked by AlekSIS/official/AlekSIS-Core#357

Blocked by AlekSIS/official/AlekSIS-Core#357
Owner

added 11 commits

  • 759e6fbd...48c5e565 - 10 commits from branch master
  • 85752ec4 - Merge branch 'master' into 51-pdf-export-for-timetables

Compare with previous version

added 11 commits <ul><li>759e6fbd...48c5e565 - 10 commits from branch <code>master</code></li><li>85752ec4 - Merge branch &#39;master&#39; into 51-pdf-export-for-timetables</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4900&start_sha=759e6fbde2017765ab236107bb191f2bd39bb086)
Owner

added 2 commits

  • 1dd8ab4f - [Print] Show timetable title in page header
  • 202be435 - Reformat timetable_print.html

Compare with previous version

added 2 commits <ul><li>1dd8ab4f - [Print] Show timetable title in page header</li><li>202be435 - Reformat timetable_print.html</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4902&start_sha=85752ec4ed6f44ecf5ac5bc311a46771f0e5e14f)
Owner

resolved all threads

resolved all threads
Owner

Done.

Done.
Owner

resolved all threads

resolved all threads
Owner

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4903&start_sha=202be435d6f9cc8f4db7dfff1e39f932d127a135#449f6813d13833328f02fe019beb989ab515e3ef_21_20)
Owner

added 1 commit

  • d518c48e - Reformat timetable_print.html

Compare with previous version

added 1 commit <ul><li>d518c48e - Reformat timetable_print.html</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=4903&start_sha=202be435d6f9cc8f4db7dfff1e39f932d127a135)
Owner

added 47 commits

  • d518c48e...8edc56a5 - 46 commits from branch master
  • f839aae1 - Merge branch 'master' into 51-pdf-export-for-timetables

Compare with previous version

added 47 commits <ul><li>d518c48e...8edc56a5 - 46 commits from branch <code>master</code></li><li>f839aae1 - Merge branch &#39;master&#39; into 51-pdf-export-for-timetables</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=6478&start_sha=d518c48e0066838912dbd99779825d5bcf155a07)
Owner

added 1 commit

  • 241ea05f - Add absolute URL to all static URLs for printing via electron-pdf

Compare with previous version

added 1 commit <ul><li>241ea05f - Add absolute URL to all static URLs for printing via electron-pdf</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=6485&start_sha=f839aae110b7a3a8fbd7457fc26d89d17dcbf313)
Owner

Please remove these superfluous lines.

Please remove these superfluous lines.
Owner

Unrelated change.

Unrelated change.
Owner

added 6 commits

  • 241ea05f...eb7baabd - 4 commits from branch master
  • 2d7c8af0 - Merge remote-tracking branch 'origin/master' into 51-pdf-export-for-timetables
  • 8a81a899 - [Printout] Remove static_prefix for static files

Compare with previous version

added 6 commits <ul><li>241ea05f...eb7baabd - 4 commits from branch <code>master</code></li><li>2d7c8af0 - Merge remote-tracking branch &#39;origin/master&#39; into 51-pdf-export-for-timetables</li><li>8a81a899 - [Printout] Remove static_prefix for static files</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7025&start_sha=241ea05f753e7ff46adcee293706a803be7c5779)
Owner

added 1 commit

  • 3c824401 - Use render_pdf for the substitutions print view, too

Compare with previous version

added 1 commit <ul><li>3c824401 - Use render_pdf for the substitutions print view, too</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7294&start_sha=8a81a899b79adf0b85bb80bca714ce43e555ea02)
Owner

@lloydmeins This is now longer blocked! 🎉

@lloydmeins This is now longer blocked! :tada:
Owner

added 5 commits

  • 3c824401...69fda47f - 4 commits from branch master
  • f5c1befe - Merge branch 'master' into 51-pdf-export-for-timetables

Compare with previous version

added 5 commits <ul><li>3c824401...69fda47f - 4 commits from branch <code>master</code></li><li>f5c1befe - Merge branch &#39;master&#39; into 51-pdf-export-for-timetables</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7661&start_sha=3c824401a887e3311afcb782f2f89235eecb2d29)
lloydmeins commented 2021-04-28 12:20:34 +02:00 (Migrated from edugit.org)

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7736&start_sha=f5c1befec8c274fd7b30d8f34a10be9e937e65d1#a3769fa6184f26d2cd15bf997ff3aaa6805c5228_4_1)
lloydmeins commented 2021-04-28 12:20:34 +02:00 (Migrated from edugit.org)

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7736&start_sha=f5c1befec8c274fd7b30d8f34a10be9e937e65d1#152bcee5cc9dfa7b5535eb91054f20917b6053bb_13_13)
lloydmeins commented 2021-04-28 12:20:35 +02:00 (Migrated from edugit.org)

added 1 commit

  • 224de424 - Resolve unrelated changes and remove superfluous lines

Compare with previous version

added 1 commit <ul><li>224de424 - Resolve unrelated changes and remove superfluous lines</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7736&start_sha=f5c1befec8c274fd7b30d8f34a10be9e937e65d1)
lloydmeins commented 2021-04-28 12:22:57 +02:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>57606698 - Reuse proper term for colour</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7737&start_sha=224de42477a060d6316aa236faa41ef9b8080786)
lloydmeins commented 2021-04-28 12:27:05 +02:00 (Migrated from edugit.org)

added 1 commit

  • 4c4e04bc - Remove unnecessary template names

Compare with previous version

added 1 commit <ul><li>4c4e04bc - Remove unnecessary template names</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7739&start_sha=576066984a5998e8c589d380051539333d4677ed)
lloydmeins commented 2021-04-28 12:27:25 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
lloydmeins commented 2021-04-28 12:28:12 +02:00 (Migrated from edugit.org)

marked this merge request as ready

marked this merge request as **ready**
lloydmeins commented 2021-04-28 12:33:02 +02:00 (Migrated from edugit.org)

added 1 commit

  • b253cd36 - Reformat in order for the pipeline to succeed

Compare with previous version

added 1 commit <ul><li>b253cd36 - Reformat in order for the pipeline to succeed</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7740&start_sha=4c4e04bc12215b16eb5842881a60293554aef995)
Owner

approved this merge request

approved this merge request
Owner

@nik Please review and merge.

@nik Please review and merge.
Owner

Please drop trailing newlines

Please drop trailing newlines
Owner

What is the reason for this change?

What is the reason for this change?
Owner

Why?

Why?
lloydmeins commented 2021-05-04 10:45:08 +02:00 (Migrated from edugit.org)

As there is also the possibility to access the pdf version on the smart plan we need to make sure that the gathered plan is the regular one.

As there is also the possibility to access the pdf version on the smart plan we need to make sure that the gathered plan is the regular one.
lloydmeins commented 2021-05-04 10:50:06 +02:00 (Migrated from edugit.org)

changed this line in version 26 of the diff

changed this line in [version 26 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7900&start_sha=b253cd368a4f164c359dda8a333cecc6acf6b450#a3769fa6184f26d2cd15bf997ff3aaa6805c5228_34_33)
lloydmeins commented 2021-05-04 10:50:08 +02:00 (Migrated from edugit.org)

added 1 commit

Compare with previous version

added 1 commit <ul><li>2d354396 - Remove trailing newlines</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7900&start_sha=b253cd368a4f164c359dda8a333cecc6acf6b450)
lloydmeins commented 2021-05-04 10:51:36 +02:00 (Migrated from edugit.org)

To prevent an argument overload.

To prevent an argument overload.
lloydmeins commented 2021-05-04 11:08:29 +02:00 (Migrated from edugit.org)

resolved all threads

resolved all threads
lloydmeins commented 2021-05-04 13:41:37 +02:00 (Migrated from edugit.org)

added 3 commits

  • 2d354396...810c363e - 2 commits from branch master
  • 9f9be1fc - Merge branch 'master' into 51-pdf-export-for-timetables

Compare with previous version

added 3 commits <ul><li>2d354396...810c363e - 2 commits from branch <code>master</code></li><li>9f9be1fc - Merge branch &#39;master&#39; into 51-pdf-export-for-timetables</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/77/diffs?diff_id=7913&start_sha=2d3543961557625999c17da2e3c4f2752fce5694)
lloydmeins commented 2021-05-04 13:44:29 +02:00 (Migrated from edugit.org)

marked this merge request as draft

marked this merge request as **draft**
lloydmeins commented 2021-05-04 13:45:53 +02:00 (Migrated from edugit.org)

marked this merge request as ready

marked this merge request as **ready**
nik merged commit 577c6da31d into master 2021-05-04 19:19:32 +02:00
Owner

mentioned in commit 577c6da31d

mentioned in commit 577c6da31da8555e81a7d75a6e06f0a4af424201
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Chronos!381
No description provided.