aleksis/AlekSIS-App-Chronos
Watch
10
0
Fork
You've already forked AlekSIS-App-Chronos
 0
Code Issues 49 Pull requests 4 Projects Releases 4 Packages 1 Activity Actions

Show announcements in timetable views #345

Merged
hansegucker merged 9 commits from feature/show-announcements-in-timetable-views into master 2020-03-20 16:09:21 +01:00
Conversation 26 Commits 9 Files changed 11 +32 -112
hansegucker commented 2020-03-17 15:41:03 +01:00
Owner
Copy link

Blocked by https://edugit.org/AlekSIS/official/AlekSIS/-/merge_requests/184

Closes #63

Blocked by https://edugit.org/AlekSIS/official/AlekSIS/-/merge_requests/184 Closes #63
hansegucker commented 2020-03-17 15:41:04 +01:00
Author
Owner
Copy link

changed milestone to %"2.0a2"

changed milestone to %"2.0a2"
hansegucker commented 2020-03-17 15:41:20 +01:00
Author
Owner
Copy link

mentioned in merge request AlekSIS!488

mentioned in merge request AlekSIS!488
nik commented 2020-03-17 21:18:27 +01:00
Owner
Copy link

Please use the API provided by ExtensibleModel to inject methods.

Please use the API provided by `ExtensibleModel` to inject methods.
hansegucker commented 2020-03-17 21:18:48 +01:00
Author
Owner
Copy link

How?

How?
nik commented 2020-03-17 21:20:36 +01:00
Owner
Copy link

Announcement.method(…)

`Announcement.method(…)`
nik commented 2020-03-17 21:21:12 +01:00
Owner
Copy link

Probably .classmethod for clarity (I will add it)

Probably `.classmethod` for clarity (I will add it)
hansegucker commented 2020-03-18 15:14:04 +01:00
Author
Owner
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/41/diffs?diff_id=1442&start_sha=f5aaaf03e86917ff68f12b24d582937f97daa473#aff889560e418df674a6887a541974fc95f8cd36_561_560)
hansegucker commented 2020-03-18 15:14:05 +01:00
Author
Owner
Copy link

added 2 commits

  • 49cb122f - Rename queryset methods for announcements
  • 1ed1dd51 - Use API provided through ExtensibleModel to extend announcement query set

Compare with previous version

added 2 commits <ul><li>49cb122f - Rename queryset methods for announcements</li><li>1ed1dd51 - Use API provided through ExtensibleModel to extend announcement query set</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/41/diffs?diff_id=1442&start_sha=f5aaaf03e86917ff68f12b24d582937f97daa473)
hansegucker commented 2020-03-18 15:16:46 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-03-19 10:59:33 +01:00
Author
Owner
Copy link

@nik It's ready to merge.

@nik It's ready to merge.
nik commented 2020-03-19 11:01:54 +01:00
Owner
Copy link

Please move this to model_extensions.py.

Please move this to `model_extensions.py`.
hansegucker commented 2020-03-19 11:02:34 +01:00
Author
Owner
Copy link

Also this?

Also this?
nik commented 2020-03-19 11:04:19 +01:00
Owner
Copy link

Everythin that extends a foreign model.

Everythin that extends a foreign model.
hansegucker commented 2020-03-19 11:04:38 +01:00
Author
Owner
Copy link

OK

OK
hansegucker commented 2020-03-19 11:41:03 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2020-03-19 11:41:06 +01:00
Author
Owner
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/41/diffs?diff_id=1449&start_sha=1ed1dd51900c4c8505c69b18235ed7d1b4c1c635#aff889560e418df674a6887a541974fc95f8cd36_560_555)
hansegucker commented 2020-03-19 11:41:06 +01:00
Author
Owner
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/41/diffs?diff_id=1449&start_sha=1ed1dd51900c4c8505c69b18235ed7d1b4c1c635#aff889560e418df674a6887a541974fc95f8cd36_561_555)
hansegucker commented 2020-03-19 11:41:08 +01:00
Author
Owner
Copy link

added 1 commit

  • edfd5296 - Move extensions for announcement model to model_extensions.py

Compare with previous version

added 1 commit <ul><li>edfd5296 - Move extensions for announcement model to model_extensions.py</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Chronos/-/merge_requests/41/diffs?diff_id=1449&start_sha=1ed1dd51900c4c8505c69b18235ed7d1b4c1c635)
nik commented 2020-03-19 12:21:03 +01:00
Owner
Copy link

Unnecessary import?

Unnecessary import?
hansegucker commented 2020-03-19 12:22:07 +01:00
Author
Owner
Copy link

Missing import: 940bfa7d

Missing import: 940bfa7d
nik commented 2020-03-19 12:27:21 +01:00
Owner
Copy link

Maybe we should add a mechanism for form_extensions.py just like for model extensions?

Maybe we should add a mechanism for `form_extensions.py` just like for model extensions?
hansegucker commented 2020-03-19 12:29:05 +01:00
Author
Owner
Copy link

Seems like a good idea.

Seems like a good idea.
nik commented 2020-03-20 16:09:13 +01:00
Owner
Copy link

Will open new issue for the refactoring.

Will open new issue for the refactoring.
nik commented 2020-03-20 16:09:14 +01:00
Owner
Copy link

resolved all threads

resolved all threads
nik commented 2020-03-20 16:09:21 +01:00
Owner
Copy link

merged

merged
nik commented 2020-03-20 16:09:22 +01:00
Owner
Copy link

mentioned in commit 30e640c9f9

mentioned in commit 30e640c9f9cb0fa869e0fba3b178afe213c73d8b
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Chronos!345
No description provided.