aleksis/AlekSIS-App-CSVImport
Watch
10
0
Fork
You've already forked AlekSIS-App-CSVImport
 0
Code Issues 16 Pull requests 4 Projects Releases 2 Packages Activity Actions

General CSV importer (reloaded) #92

Merged
hansegucker merged 82 commits from feature/general-csv-importer-v2 into master 2020-11-08 17:26:22 +01:00
Conversation 35 Commits 82 Files changed 52 +4459 -964
hansegucker commented 2020-11-08 14:08:43 +01:00
Owner
Copy link

Close #12

Close #11

Close #12 Close #11
hansegucker commented 2020-11-08 14:12:06 +01:00
Author
Owner
Copy link

added 1 commit

  • d53454e3 - Update copyright and project URL

Compare with previous version

added 1 commit <ul><li>d53454e3 - Update copyright and project URL</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3618&start_sha=3b7fd530866cd339fab1de504a223de640d5f142)
nik commented 2020-11-08 14:36:15 +01:00
Owner
Copy link

This naming will break things. Use another module name (or none at all — it should really be either a data migration (preferrably) or a method on the respective model. In both cases, the ideal way is to define the templates in data files and load these.

This naming will break things. Use another module name (or none at all — it should really be either a data migration (preferrably) or a method on the respective model. In both cases, the ideal way is to define the templates in data files and load these.
nik commented 2020-11-08 14:36:15 +01:00
Owner
Copy link

Why are there choices forthis instead of a text field?

Also, why is there an option for a single tab, but not for a single space, or a single whitespace character, or multiple tabs, or multiple spaces ;)?

Why are there choices forthis instead of a text field? Also, why is there an option for a single tab, but not for a single space, or a single whitespace character, or multiple tabs, or multiple spaces ;)?
nik commented 2020-11-08 14:36:16 +01:00
Owner
Copy link
        default=True, verbose_name=_("Has the CSV file an own header row?")
```suggestion:-0+0 default=True, verbose_name=_("Has the CSV file an own header row?") ```
nik commented 2020-11-08 14:36:16 +01:00
Owner
Copy link

Choices constants should reside inside the model class, by the way.

Choices constants should reside inside the model class, by the way.
nik commented 2020-11-08 14:36:17 +01:00
Owner
Copy link

What is a "department group"?

What is a "department group"?
nik commented 2020-11-08 14:36:18 +01:00
Owner
Copy link

Maybe this should be a MultipleChoicePreference then?

Maybe this should be a `MultipleChoicePreference` then?
nik commented 2020-11-08 14:36:19 +01:00
Owner
Copy link

Huh?

Huh?
nik commented 2020-11-08 14:36:20 +01:00
Owner
Copy link

It seems like this is one of the rare occasions where the use of an asterisk import (and accompanying __all__ magic constant in .field_types is appropriate.

It seems like this is one of the rare occasions where the use of an asterisk import (and accompanying `__all__` magic constant in `.field_types` is appropriate.
nik commented 2020-11-08 14:36:21 +01:00
Owner
Copy link

As stated above, the default templates should not reside in the code.

I will take care of a DDL for that.

As stated above, the default templates should not reside in the code. I will take care of a DDL for that.
nik commented 2020-11-08 14:36:21 +01:00
Owner
Copy link

Please add test cases for American date formats (i.e. the case where '2020-12-11' != '2020-12-12'). It should test with changing language settings.

Please add test cases for American date formats (i.e. the case where `'2020-12-11' != '2020-12-12'`). It should test with changing language settings.
nik commented 2020-11-08 14:36:22 +01:00
Owner
Copy link

We should not have "Pedasos helpers" anymore after this transition.

We should not have "Pedasos helpers" anymore after this transition.
nik commented 2020-11-08 14:37:10 +01:00
Owner
Copy link

Please merge the migrations.

Please merge the migrations.
hansegucker commented 2020-11-08 16:08:46 +01:00
Author
Owner
Copy link

added 1 commit

  • 36554fb0 - Improve preferences and settings by choices and extra values

Compare with previous version

added 1 commit <ul><li>36554fb0 - Improve preferences and settings by choices and extra values</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3625&start_sha=d53454e3e7f3536115f1f5961f37d981795821f9)
hansegucker commented 2020-11-08 16:11:38 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3626&start_sha=36554fb0f5f6ecb92c4f81fe6af5faabac4a784a#28efd6e53b5d3111abe7bd20c76fe5ff341582e3_26_26)
hansegucker commented 2020-11-08 16:11:40 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3626&start_sha=36554fb0f5f6ecb92c4f81fe6af5faabac4a784a#ffcc96a6a1027d894ecbdf7a1b40816c1cfbb674_39_39)
hansegucker commented 2020-11-08 16:11:42 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3626&start_sha=36554fb0f5f6ecb92c4f81fe6af5faabac4a784a#4fbeb1e0f02b7e3e1437c4fbe36f48ce4bf9b07c_26_0)
hansegucker commented 2020-11-08 16:11:43 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3626&start_sha=36554fb0f5f6ecb92c4f81fe6af5faabac4a784a#4fbeb1e0f02b7e3e1437c4fbe36f48ce4bf9b07c_54_0)
hansegucker commented 2020-11-08 16:11:44 +01:00
Author
Owner
Copy link

added 1 commit

  • b3cfb41b - Rename templates to default_templates.py and fix typo

Compare with previous version

added 1 commit <ul><li>b3cfb41b - Rename templates to default_templates.py and fix typo</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3626&start_sha=36554fb0f5f6ecb92c4f81fe6af5faabac4a784a)
hansegucker commented 2020-11-08 16:12:36 +01:00
Author
Owner
Copy link

As the count of languages is very large, it slows down the UI massively, so I decided not to use a choice field.

As the count of languages is very large, it slows down the UI massively, so I decided not to use a choice field.
hansegucker commented 2020-11-08 16:15:33 +01:00
Author
Owner
Copy link

added 1 commit

  • a2660c09 - Use asterisk import in default_templates.py

Compare with previous version

added 1 commit <ul><li>a2660c09 - Use asterisk import in default_templates.py</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3628&start_sha=b3cfb41b8a7df428c2c7d7767af479347f8d9011)
hansegucker commented 2020-11-08 16:17:42 +01:00
Author
Owner
Copy link

added 1 commit

  • 7a19acc6 - Remove all occurences of Pedasos

Compare with previous version

added 1 commit <ul><li>7a19acc6 - Remove all occurences of Pedasos</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3629&start_sha=a2660c09a8e8012bb8e38c45193abc98ed6a9af3)
hansegucker commented 2020-11-08 16:27:12 +01:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3630&start_sha=7a19acc6f5774a22ebe476aa5938e398b51d3763#ffcc96a6a1027d894ecbdf7a1b40816c1cfbb674_15_12)
hansegucker commented 2020-11-08 16:27:13 +01:00
Author
Owner
Copy link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3630&start_sha=7a19acc6f5774a22ebe476aa5938e398b51d3763#ffcc96a6a1027d894ecbdf7a1b40816c1cfbb674_43_38)
hansegucker commented 2020-11-08 16:27:16 +01:00
Author
Owner
Copy link

added 1 commit

  • 1b310a3f - Let users set own separators (independent of choices)

Compare with previous version

added 1 commit <ul><li>1b310a3f - Let users set own separators (independent of choices)</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3630&start_sha=7a19acc6f5774a22ebe476aa5938e398b51d3763)
nik commented 2020-11-08 16:35:53 +01:00
Owner
Copy link

added 2 commits

  • 84327d68 - Move default templates to data file
  • 226afe8c - Merge branch 'feature/general-csv-importer-v2' of...

Compare with previous version

added 2 commits <ul><li>84327d68 - Move default templates to data file</li><li>226afe8c - Merge branch &#39;feature/general-csv-importer-v2&#39; of...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3631&start_sha=1b310a3f9303b8700e5d9f3cef77410c6d044b8c)
nik commented 2020-11-08 16:37:15 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>67d2865d - Update copyright</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3632&start_sha=226afe8c65e0550e0faf8c2ed87dbd90a20816c7)
hansegucker commented 2020-11-08 16:38:38 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
nik commented 2020-11-08 16:40:57 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>663a0dcc - Rename template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3633&start_sha=67d2865dbed7a2741450885cbcc043dc0f652eea)
nik commented 2020-11-08 16:42:15 +01:00
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>334e9306 - Fix use of os</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3634&start_sha=663a0dcce54d57c1e1fa1c33e014f891ada2f7be)
hansegucker commented 2020-11-08 17:00:44 +01:00
Author
Owner
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3635&start_sha=334e93063fcfa04da6238bfad8eaf87afed49af3#78b44eae98b14155fe83a7f3fea829a828185011_3_0)
hansegucker commented 2020-11-08 17:00:45 +01:00
Author
Owner
Copy link

added 3 commits

  • 1d9de49a - Advance and fix tests
  • c66daf25 - Reformat
  • db222948 - Merge remote-tracking branch 'origin/feature/general-csv-importer-v2' into...

Compare with previous version

added 3 commits <ul><li>1d9de49a - Advance and fix tests</li><li>c66daf25 - Reformat</li><li>db222948 - Merge remote-tracking branch &#39;origin/feature/general-csv-importer-v2&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3635&start_sha=334e93063fcfa04da6238bfad8eaf87afed49af3)
hansegucker commented 2020-11-08 17:07:35 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>80e9d7ee - Fix some typos and reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3637&start_sha=db222948d57a86bec90627d90e57d9480727e5de)
hansegucker commented 2020-11-08 17:16:21 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>dfcaceba - Merge migrations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-CSVImport/-/merge_requests/17/diffs?diff_id=3639&start_sha=80e9d7ee101555579e38b68aa7ecf3fbcfdb5c2c)
nik scheduled this pull request to auto merge when all checks succeed 2020-11-08 17:17:49 +01:00
nik canceled auto merging this pull request when all checks succeed 2020-11-08 17:26:10 +01:00
nik commented 2020-11-08 17:26:19 +01:00
Owner
Copy link

mentioned in commit 16c1e14e66

mentioned in commit 16c1e14e663232f099730ecb7825f4bcb032b8ab
nik merged commit 16c1e14e66 into master 2020-11-08 17:26:22 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-CSVImport!92
No description provided.