aleksis/AlekSIS-App-Buelleten
8
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Activity Actions

Resolve "Migrate to vue3 frontend" #69

Merged
yuha merged 24 commits from 12-migrate-to-vue3-frontend into master 2025-10-02 19:39:57 +02:00
Conversation 42 Commits 24 Files changed 30 +1172 -533
yuha commented 2025-09-24 16:49:58 +02:00 (Migrated from edugit.org)
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

  • Screenshots are attached (mobile and desktop)
  • Tested on mobile, tablet, and desktop sizes
  • Adhered to frontend guidelines
  • Checked with Firefox Accessibility Checker

Closes #12

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [x] Documentation (incl. Screenshots) up-to-date - [x] Copyright in `apps.py` and `README.rst` up-to-date - [x] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [x] Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86) - [x] Tested with admin account - [x] Tested with normal account (based on permissions) ## Backend checklist - [x] Use permissions for all GraphQL mutations - [x] Use query optimizer for all GraphQL queries - [x] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [x] Screenshots are attached (mobile and desktop) - [x] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to frontend guidelines - [ ] Checked with Firefox Accessibility Checker Closes #12
yuha commented 2025-09-24 16:49:59 +02:00 (Migrated from edugit.org)
Copy link

assigned to @yuha

assigned to @yuha
yuha commented 2025-09-24 16:50:09 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item tox -e reformat,lint used as completed

marked the checklist item **`tox -e reformat,lint` used** as completed
yuha commented 2025-09-24 16:52:36 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Changelog updated/No update necessary as completed

marked the checklist item **Changelog updated/No update necessary** as completed
yuha commented 2025-09-24 16:52:55 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Documentation (incl. Screenshots) up-to-date as completed

marked the checklist item **Documentation (incl. Screenshots) up-to-date** as completed
yuha commented 2025-09-24 16:54:18 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Copyright in apps.py and README.rst up-to-date as completed

marked the checklist item **Copyright in `apps.py` and `README.rst` up-to-date** as completed
yuha commented 2025-09-24 16:54:20 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item (Unit) tests for new feature/regression tests for bug fixes (only if useful) as completed

marked the checklist item **(Unit) tests for new feature/regression tests for bug fixes (only if useful)** as completed
yuha commented 2025-09-24 16:54:21 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Adhere to URL scheme as completed

marked the checklist item **Adhere to [URL scheme](https://edugit.org/AlekSIS/official/AlekSIS/-/issues/86)** as completed
yuha commented 2025-09-24 16:54:22 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Tested with admin account as completed

marked the checklist item **Tested with admin account** as completed
yuha commented 2025-09-24 16:54:26 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Use permissions for all GraphQL mutations as completed

marked the checklist item **Use permissions for all GraphQL mutations** as completed
yuha commented 2025-09-24 16:54:27 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Use query optimizer for all GraphQL queries as completed

marked the checklist item **Use query optimizer for all GraphQL queries** as completed
yuha commented 2025-09-24 16:54:28 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Don't use inefficient DB queries as completed

marked the checklist item **Don't use inefficient DB queries** as completed
yuha commented 2025-09-24 16:54:47 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>79beff38 - Add copyright</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71671&start_sha=3c436e016660d4ca2abb36c539e3f30d84f6c539)
yuha commented 2025-09-24 17:01:13 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Screenshots are attached (mobile and desktop) as completed

marked the checklist item **Screenshots are attached (mobile and desktop)** as completed
yuha commented 2025-09-24 17:01:13 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Tested on mobile, tablet, and desktop sizes as completed

marked the checklist item **Tested on mobile, tablet, and desktop sizes** as completed
yuha commented 2025-09-24 17:01:44 +02:00 (Migrated from edugit.org)
Copy link

Screenshot From 2025-09-24 17-01-05.png

Screenshot From 2025-09-24 17-00-35.png

Screenshot From 2025-09-24 17-00-24.png

Screenshot From 2025-09-24 17-00-19.png

![Screenshot From 2025-09-24 17-01-05.png](/uploads/c2d61afca97704ae0cb0a59d2175ed78/Screenshot_From_2025-09-24_17-01-05.png) ![Screenshot From 2025-09-24 17-00-35.png](/uploads/9bfeae8f3a1119f96db3f3d4bc7bc2e0/Screenshot_From_2025-09-24_17-00-35.png) ![Screenshot From 2025-09-24 17-00-24.png](/uploads/9c99c560f62d27e129875f2e11662485/Screenshot_From_2025-09-24_17-00-24.png) ![Screenshot From 2025-09-24 17-00-19.png](/uploads/8d59213269432f8d261a6a511fd5f26f/Screenshot_From_2025-09-24_17-00-19.png)
yuha commented 2025-09-24 17:05:35 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>aa188261 - Add toolbar title</li><li>151f8b73 - Make foreign url slide urls clickable</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71673&start_sha=79beff389e576425c7d1b919b514f0443b58e890)
yuha commented 2025-09-24 17:07:18 +02:00 (Migrated from edugit.org)
Copy link

marked the checklist item Tested with normal account (based on permissions) as completed

marked the checklist item **Tested with normal account (based on permissions)** as completed
yuha commented 2025-09-24 17:07:22 +02:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker and unassigned @yuha

assigned to @hansegucker and unassigned @yuha
yuha commented 2025-09-24 23:23:29 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>bbf4896e - Fix routes</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71687&start_sha=151f8b739df78a0bd1fd1b32b11f8084d972a5bb)
hansegucker commented 2025-10-01 19:08:22 +02:00 (Migrated from edugit.org)
Copy link

@yuha Please fix lint.

@yuha Please fix lint.
yuha commented 2025-10-02 11:01:42 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a2f549f4 - Reformat</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71811&start_sha=bbf4896eee1cf60e70b572c9bef802dfe3de1cc9)
yuha commented 2025-10-02 11:01:42 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-10-02 13:57:47 +02:00 (Migrated from edugit.org)
Copy link

This shouldn't use option API.

This shouldn't use option API.
hansegucker commented 2025-10-02 13:57:47 +02:00 (Migrated from edugit.org)
Copy link

This is also option API and should be composition API.

This is also option API and should be composition API.
hansegucker commented 2025-10-02 13:57:48 +02:00 (Migrated from edugit.org)
Copy link

Composition API

Composition API
hansegucker commented 2025-10-02 13:57:48 +02:00 (Migrated from edugit.org)
Copy link

Please drop the API URL here, it's not part of the frontend.

Please drop the API URL here, it's not part of the frontend.
hansegucker commented 2025-10-02 13:57:48 +02:00 (Migrated from edugit.org)
Copy link

What's the purpose of those empty objects?

What's the purpose of those empty objects?
hansegucker commented 2025-10-02 13:57:48 +02:00 (Migrated from edugit.org)
Copy link

Year?

Year?
hansegucker commented 2025-10-02 13:57:49 +02:00 (Migrated from edugit.org)
Copy link

Year?

Year?
hansegucker commented 2025-10-02 13:57:49 +02:00 (Migrated from edugit.org)
Copy link

left review comments

left review comments
yuha commented 2025-10-02 16:57:36 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71827&start_sha=a2f549f496f3187424f3654b684a94e15af33d7f#99743fdf83408f11bb7018acfad6fd7e64cd8b91_15_15)
yuha commented 2025-10-02 16:57:36 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71827&start_sha=a2f549f496f3187424f3654b684a94e15af33d7f#f1aa713398ec396046a42b50dec6dd13f106a497_2_1)
yuha commented 2025-10-02 16:57:37 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71827&start_sha=a2f549f496f3187424f3654b684a94e15af33d7f#b4763214df0941d1b8cc93c4f243f8fdd8cd745f_118_148)
yuha commented 2025-10-02 16:57:38 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 4dc07eba - Use composition API

Compare with previous version

added 1 commit <ul><li>4dc07eba - Use composition API</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71827&start_sha=a2f549f496f3187424f3654b684a94e15af33d7f)
yuha commented 2025-10-02 16:58:26 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f437de71 - Use composition API</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71828&start_sha=4dc07eba698fa21d9f1be56b7dab633300a599ae)
yuha commented 2025-10-02 19:17:49 +02:00 (Migrated from edugit.org)
Copy link

i thought that would have been an unrelated change since has already been there

i thought that would have been an unrelated change since has already been there
yuha commented 2025-10-02 19:32:17 +02:00 (Migrated from edugit.org)
Copy link

type and content don't exist as model fields – they are used to show information about the polymorphic objects that may be included in a slide query (such as type: "static content slide" or smth like that). displayGroup and order are listed there in order to guarantee a reasonable header order. i couldn't think of a better way of doing so

type and content don't exist as model fields – they are used to show information about the polymorphic objects that may be included in a slide query (such as type: "static content slide" or smth like that). displayGroup and order are listed there in order to guarantee a reasonable header order. i couldn't think of a better way of doing so
yuha commented 2025-10-02 19:33:07 +02:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
yuha commented 2025-10-02 19:33:11 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71840&start_sha=f437de710410282a2fe9af1704c8479f6478f3a1#d3102cc93172a0dccacbf87eba1044935a825593_22_22)
yuha commented 2025-10-02 19:33:12 +02:00 (Migrated from edugit.org)
Copy link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71840&start_sha=f437de710410282a2fe9af1704c8479f6478f3a1#561b88e19de321ca62c7590bbb350765fb110905_22_22)
yuha commented 2025-10-02 19:33:12 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 52a62e78 - Use correct years in copyright

Compare with previous version

added 1 commit <ul><li>52a62e78 - Use correct years in copyright</li></ul> [Compare with previous version](/AlekSIS/onboarding/AlekSIS-App-Buelleten/-/merge_requests/56/diffs?diff_id=71840&start_sha=f437de710410282a2fe9af1704c8479f6478f3a1)
hansegucker commented 2025-10-02 19:39:56 +02:00 (Migrated from edugit.org)
Copy link

mentioned in commit 5a2f92f522

mentioned in commit 5a2f92f52267a1c1ef408cf08e62d819064cc4be
hansegucker (Migrated from edugit.org) merged commit 5a2f92f522 into master 2025-10-02 19:39:58 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Buelleten!69
No description provided.