aleksis/AlekSIS-App-Alsijil
Watch
10
0
Fork
You've already forked AlekSIS-App-Alsijil
 0
Code Issues 48 Pull requests 7 Projects Releases 3 Packages 1 Activity Actions

Resolve "Add export functionality to absence statistics page" #867

Merged
hansegucker merged 7 commits from 267-add-export-functionality-to-absence-statistics-page into master 2025-02-03 20:15:44 +01:00
Conversation 39 Commits 7 Files changed 15 +508 -208
hansegucker commented 2025-01-24 18:28:19 +01:00
Owner
Copy link

Closes #267

Closes #267
hansegucker commented 2025-01-25 15:58:18 +01:00
Author
Owner
Copy link

added 1 commit

  • 89930f5d - Refactor generation of statistics to statistics builder

Compare with previous version

added 1 commit <ul><li>89930f5d - Refactor generation of statistics to statistics builder</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=54894&start_sha=9e24f1eecdfeceeca07495d9fab637698e4b90d0)
hansegucker commented 2025-01-25 16:26:05 +01:00
Author
Owner
Copy link

added 1 commit

  • 4822847b - Add coursebook printout for single persons

Compare with previous version

added 1 commit <ul><li>4822847b - Add coursebook printout for single persons</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=54909&start_sha=89930f5d13503cc79b9947058bc103103e5313e6)
hansegucker commented 2025-01-25 16:26:57 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2025-01-25 16:27:01 +01:00
Author
Owner
Copy link

assigned to @nik

assigned to @nik
nik commented 2025-01-25 16:43:51 +01:00
Owner
Copy link

Group.school_term is an optional field and can legitimately reference None.

`Group.school_term` is an optional field and can legitimately reference `None`.
nik commented 2025-01-25 16:43:51 +01:00
Owner
Copy link

Does this add a subquery, or is it evaluated separately?

Does this add a subquery, or is it evaluated separately?
nik commented 2025-01-25 16:43:51 +01:00
Owner
Copy link

See above.

See above.
nik commented 2025-01-25 16:43:51 +01:00
Owner
Copy link
        if not (result.status == SUCCESS and file_object.file):

Like that?

Or does the result status have to be different from SUCCESS and, in additoin to that, the file field have to be set despite of the error, to qualify as failed?

```suggestion:-0+0 if not (result.status == SUCCESS and file_object.file): ``` Like that? Or does the result status have to be different from SUCCESS and, in additoin to that, the `file` field have to be set despite of the error, to qualify as failed?
nik commented 2025-01-25 16:43:51 +01:00
Owner
Copy link

Exception must never be raised verbatim.

`Exception` must never be raised verbatim.
nik commented 2025-01-25 16:43:51 +01:00
Owner
Copy link

Why is it _number_of_steps if the last step is always 4?

Why is it `_number_of_steps` if the last step is always 4?
nik commented 2025-01-25 16:43:51 +01:00
Owner
Copy link

This URL looks strange. For too many reasons to list. Please provide examples how this is called.

This URL looks strange. For too many reasons to list. Please provide examples how this is called.
nik commented 2025-01-25 16:43:52 +01:00
Owner
Copy link

Missing doc string.

Missing doc string.
nik commented 2025-01-25 16:43:52 +01:00
Owner
Copy link

Missing doc string.

Missing doc string.
nik commented 2025-01-25 16:43:52 +01:00
Owner
Copy link

Too big and too undocumented to review.

Too big and too undocumented to review.
hansegucker commented 2025-01-27 15:04:27 +01:00
Author
Owner
Copy link

This is kind of unrelated for this MR, I will open a new issue to tackle this.

This is kind of unrelated for this MR, I will open a new issue to tackle this.
hansegucker commented 2025-01-27 15:04:50 +01:00
Author
Owner
Copy link

created #354 to continue this discussion

created #354 to continue this discussion
hansegucker commented 2025-01-27 15:04:51 +01:00
Author
Owner
Copy link

mentioned in issue #354

mentioned in issue #354
hansegucker commented 2025-01-27 15:05:26 +01:00
Author
Owner
Copy link

It does add a subquery.

It does add a subquery.
hansegucker commented 2025-01-27 18:13:09 +01:00
Author
Owner
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55004&start_sha=4822847b541f99d4177b4e5e8cc379073811eebb#d2a919c3b091581c6d8cea2bc9c00a665ee84c29_84_86)
hansegucker commented 2025-01-27 18:13:11 +01:00
Author
Owner
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55004&start_sha=4822847b541f99d4177b4e5e8cc379073811eebb#d2a919c3b091581c6d8cea2bc9c00a665ee84c29_96_100)
hansegucker commented 2025-01-27 18:13:12 +01:00
Author
Owner
Copy link

changed this file in version 3 of the diff

changed this file in [version 3 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55004&start_sha=4822847b541f99d4177b4e5e8cc379073811eebb#5b96fcc62e02879ff959e696108194aa671b238f)
hansegucker commented 2025-01-27 18:13:12 +01:00
Author
Owner
Copy link

added 1 commit

  • 52a77a8b - Add some docstrings and types for statistics builder

Compare with previous version

added 1 commit <ul><li>52a77a8b - Add some docstrings and types for statistics builder</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55004&start_sha=4822847b541f99d4177b4e5e8cc379073811eebb)
hansegucker commented 2025-01-27 18:17:47 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-01-27 19:00:52 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55006&start_sha=52a77a8bf4185a56ac5269e3aaff523ba7cdfef0#8de4b5a713b0a0eea72a081858ba99059b5ed282_200_202)
hansegucker commented 2025-01-27 19:00:53 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55006&start_sha=52a77a8bf4185a56ac5269e3aaff523ba7cdfef0#8de4b5a713b0a0eea72a081858ba99059b5ed282_201_202)
hansegucker commented 2025-01-27 19:00:54 +01:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55006&start_sha=52a77a8bf4185a56ac5269e3aaff523ba7cdfef0#8de4b5a713b0a0eea72a081858ba99059b5ed282_203_205)
hansegucker commented 2025-01-27 19:00:55 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6978f1c5 - Fix PDF generation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55006&start_sha=52a77a8bf4185a56ac5269e3aaff523ba7cdfef0)
leuckeju commented 2025-01-27 20:14:36 +01:00
Member
Copy link

The constraint that there can only be one use_ call is not enforced

The constraint that there can only be one `use_` call is not enforced
leuckeju commented 2025-01-27 20:15:14 +01:00
Member
Copy link

Unclear what the problem is → include error message; also in other places in the builder…

Unclear what the problem is → include error message; also in other places in the builder…
leuckeju commented 2025-01-27 20:16:11 +01:00
Member
Copy link

Why do these parentheses exist here?

Why do these parentheses exist here?
hansegucker commented 2025-01-27 20:27:01 +01:00
Author
Owner
Copy link

Good question ...

Good question ...
hansegucker commented 2025-01-27 20:34:12 +01:00
Author
Owner
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55012&start_sha=6978f1c5a3c2bb31267951ad96f1bfb6bb664227#5b96fcc62e02879ff959e696108194aa671b238f_20_20)
hansegucker commented 2025-01-27 20:34:12 +01:00
Author
Owner
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55012&start_sha=6978f1c5a3c2bb31267951ad96f1bfb6bb664227#5b96fcc62e02879ff959e696108194aa671b238f_90_90)
hansegucker commented 2025-01-27 20:34:13 +01:00
Author
Owner
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55012&start_sha=6978f1c5a3c2bb31267951ad96f1bfb6bb664227#8de4b5a713b0a0eea72a081858ba99059b5ed282_170_166)
hansegucker commented 2025-01-27 20:34:13 +01:00
Author
Owner
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a4b9dfea - Improve statistics builder</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55012&start_sha=6978f1c5a3c2bb31267951ad96f1bfb6bb664227)
hansegucker commented 2025-01-27 20:35:09 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2025-01-29 20:37:23 +01:00
Author
Owner
Copy link

@hansegucker Merge master

@hansegucker Merge master
hansegucker commented 2025-02-03 20:14:14 +01:00
Author
Owner
Copy link

added 16 commits

  • a4b9dfea...16e45edd - 14 commits from branch master
  • 44c07a7e - Merge branch 'master' into 267-add-export-functionality-to-absence-statistics-page
  • 7c8f8e7f - Fix full register for persons after changing template paths

Compare with previous version

added 16 commits <ul><li>a4b9dfea...16e45edd - 14 commits from branch <code>master</code></li><li>44c07a7e - Merge branch &#39;master&#39; into 267-add-export-functionality-to-absence-statistics-page</li><li>7c8f8e7f - Fix full register for persons after changing template paths</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/477/diffs?diff_id=55317&start_sha=a4b9dfea25f939598d540813889c779bd0e19ce6)
hansegucker commented 2025-02-03 20:15:44 +01:00
Author
Owner
Copy link

mentioned in commit f84e6bc757

mentioned in commit f84e6bc757eaf4b1e73a6597d4a2b014573a3961
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Alsijil!867
No description provided.