aleksis/AlekSIS-App-Alsijil
8
0
Fork 0
Code Issues 51 Pull requests 10 Projects Releases 3 Packages Activity Actions

Resolve "Add export functionality to course book" #812

Merged
permcu merged 105 commits from 258-add-export-functionality-to-course-book into master 2024-12-07 21:51:04 +01:00
Conversation 121 Commits 105 Files changed 28 +916 -1079
permcu commented 2024-10-17 13:18:31 +02:00 (Migrated from edugit.org)
Copy link

Closes #258

Closes #258
permcu commented 2024-10-17 13:18:31 +02:00 (Migrated from edugit.org)
Copy link

assigned to @hansegucker

assigned to @hansegucker
permcu commented 2024-10-17 13:37:12 +02:00 (Migrated from edugit.org)
Copy link

added 72 commits

  • 812c7ecb...61623dc1 - 62 earlier commits
  • e68baa81 - Respet `onlyShowCount` in ExtraMarkChip.vue
  • 9600f28f - Display chips for absence reasons and extramarks
  • 12b68860 - Show tardinesses in group statistics table
  • 0b99184e - Simplify translations
  • 4c265ccf - Show (currently inactive) "Details" button
  • e77cfa11 - Make chips dense and center aligned
  • 667648fc - Reformat
  • 765fc1bc - Improve statistic queries, fix some bugs, include tardiness
  • f1aab9f2 - Use person chip for person column
  • 1773f233 - Merge origin/266-add-statistics-page-for-absences

Compare with previous version

added 72 commits <ul><li>812c7ecb...61623dc1 - 62 earlier commits</li><li>e68baa81 - Respet `onlyShowCount` in ExtraMarkChip.vue</li><li>9600f28f - Display chips for absence reasons and extramarks</li><li>12b68860 - Show tardinesses in group statistics table</li><li>0b99184e - Simplify translations</li><li>4c265ccf - Show (currently inactive) &quot;Details&quot; button</li><li>e77cfa11 - Make chips dense and center aligned</li><li>667648fc - Reformat</li><li>765fc1bc - Improve statistic queries, fix some bugs, include tardiness</li><li>f1aab9f2 - Use person chip for person column</li><li>1773f233 - Merge origin/266-add-statistics-page-for-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=48908&start_sha=812c7ecbb673bb96eabb416538a13b0eea8372a1)
permcu commented 2024-10-19 13:00:41 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • 733b485e - Merge branch master into 266-add-statistics-page-for-absences
  • 9af9c13c - Revert "Comment out task"
  • 57d6738c - Split register-template and make it configurable
  • 75cbbc2b - Rename now configurable full_register to register
  • 84ef1c75 - Capture TODOs

Compare with previous version

added 5 commits <ul><li>733b485e - Merge branch master into 266-add-statistics-page-for-absences</li><li>9af9c13c - Revert &quot;Comment out task&quot;</li><li>57d6738c - Split register-template and make it configurable</li><li>75cbbc2b - Rename now configurable full_register to register</li><li>84ef1c75 - Capture TODOs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49039&start_sha=1773f2339ac3a33b51e85f1884ee7c996f1c6eb1)
permcu commented 2024-10-19 13:04:00 +02:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 9ba6ab51 - Rename now configurable full_register to register_for_group
  • e198fa6f - Capture TODOs

Compare with previous version

added 2 commits <ul><li>9ba6ab51 - Rename now configurable full_register to register_for_group</li><li>e198fa6f - Capture TODOs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49040&start_sha=84ef1c75312341a1e9bd4578bcbe54c618e9626d)
permcu commented 2024-10-23 10:33:48 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • d4157f87 - Capture TODOs

Compare with previous version

added 1 commit <ul><li>d4157f87 - Capture TODOs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49077&start_sha=e198fa6ff23934fcaa29e860118f3a9d4aafbddb)
permcu commented 2024-10-24 11:53:44 +02:00 (Migrated from edugit.org)
Copy link

added 3 commits

  • 26ea069c - Split register-template and make it configurable
  • b6a41a4d - Rename now configurable full_register to register_for_group
  • b0d967dc - Capture TODOs

Compare with previous version

added 3 commits <ul><li>26ea069c - Split register-template and make it configurable</li><li>b6a41a4d - Rename now configurable full_register to register_for_group</li><li>b0d967dc - Capture TODOs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49170&start_sha=d4157f876a25d7e16df54440c3d8f92e0f327ef6)
permcu commented 2024-10-24 12:49:16 +02:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 5a087c1a - Wire register_for_group to url and thread parameters through

Compare with previous version

added 1 commit <ul><li>5a087c1a - Wire register_for_group to url and thread parameters through</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49171&start_sha=b0d967dc00eac1ca29aae7c8fcae1ad9f1b877b3)
permcu commented 2024-10-24 21:14:31 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • fbbc2e79 - Wire register_for_group to url and thread parameters through
  • e47314b8 - Adapt the register_teachers_and_subjects_table to the new datamodel
  • 68909450 - Adapt the register_cover to the new datamodel
  • 0b8cc230 - Adapt the register_abbreviations to the new datamodel
  • f91e1944 - Properly use django template filters in teachers_and_subjects_table

Compare with previous version

added 5 commits <ul><li>fbbc2e79 - Wire register_for_group to url and thread parameters through</li><li>e47314b8 - Adapt the register_teachers_and_subjects_table to the new datamodel</li><li>68909450 - Adapt the register_cover to the new datamodel</li><li>0b8cc230 - Adapt the register_abbreviations to the new datamodel</li><li>f91e1944 - Properly use django template filters in teachers_and_subjects_table</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49175&start_sha=5a087c1a1819f9ecbc51b12ff40b4be9076ad65d)
permcu commented 2024-10-25 20:56:40 +02:00 (Migrated from edugit.org)
Copy link

added 5 commits

  • 9c422c5b - Adapt the register_abbreviations to the new datamodel
  • 462b81f7 - Properly use django template filters in teachers_and_subjects_table
  • b70dea9d - Adapt the register_members_table to the new datamodel
  • b1e27b20 - Reduce queries for teachers_and_subjects_table with prefetch
  • dd4ca492 - WIP Adapt the person_overview to the new datamodel

Compare with previous version

added 5 commits <ul><li>9c422c5b - Adapt the register_abbreviations to the new datamodel</li><li>462b81f7 - Properly use django template filters in teachers_and_subjects_table</li><li>b70dea9d - Adapt the register_members_table to the new datamodel</li><li>b1e27b20 - Reduce queries for teachers_and_subjects_table with prefetch</li><li>dd4ca492 - WIP Adapt the person_overview to the new datamodel</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49190&start_sha=f91e194457f06a5ec35fa2fd0d20a0c8541713a0)
permcu commented 2024-10-28 11:57:09 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • d0810857 - Adapt the person_overview to the new datamodel

Compare with previous version

added 1 commit <ul><li>d0810857 - Adapt the person_overview to the new datamodel</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49257&start_sha=dd4ca49299d97619f9f2ba455725714fa2baeccc)
permcu commented 2024-10-28 13:42:20 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 91b88c4f - Adapt the person_overview to the new datamodel

Compare with previous version

added 1 commit <ul><li>91b88c4f - Adapt the person_overview to the new datamodel</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49260&start_sha=d0810857598145bbfaf6e59a9a7dbc1c49fb3b3b)
permcu commented 2024-10-28 14:33:40 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 12aafbf1 - Fix and simplify person_overview filtering

Compare with previous version

added 1 commit <ul><li>12aafbf1 - Fix and simplify person_overview filtering</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49262&start_sha=91b88c4fac2a0fd06c076cb25c800c6864d950d4)
permcu commented 2024-10-28 16:14:17 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • aee8c0bd - Deduplicate
  • 9b3362c4 - WIP Adapt the coursebook-printout to the new datamodel

Compare with previous version

added 2 commits <ul><li>aee8c0bd - Deduplicate</li><li>9b3362c4 - WIP Adapt the coursebook-printout to the new datamodel</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49263&start_sha=12aafbf14dbd17c4bc651435d498bf17ae74161c)
permcu commented 2024-10-28 16:38:59 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 07a4804f - WIP Adapt the coursebook-printout to the new datamodel

Compare with previous version

added 1 commit <ul><li>07a4804f - WIP Adapt the coursebook-printout to the new datamodel</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49264&start_sha=9b3362c492023ffec4b4639d746fbd2a2186d87c)
permcu commented 2024-10-28 16:40:24 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 1b4d6501 - WIP Adapt the coursebook-printout to the new datamodel

Compare with previous version

added 1 commit <ul><li>1b4d6501 - WIP Adapt the coursebook-printout to the new datamodel</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49265&start_sha=07a4804f37d0cf4a084eeceb15d4b68ae8278be8)
permcu commented 2024-10-30 15:03:38 +01:00 (Migrated from edugit.org)
Copy link

added 11 commits

  • 10f6a645 - 1 earlier commit
  • 53245fb5 - Adapt the firt-part of the coursebook-template to the new datamodel
  • cccfa48a - Factor out the notable_participations and personal_notes prefetch
  • 2dc28493 - Consider different related names for personal_notes
  • 41f66b0d - Expose select_related from participation and personal_note prefetch
  • 2fc91bab - Properly prefetch and sort documentations
  • 34e22655 - Adapt the coursebook-template's absences to the new datamodel
  • a7aa9e28 - Adapt the coursebook-template's peronal-notes to the new datamodel
  • 5061222c - Finish the coursebook-template
  • 4fa766a9 - Tidy the coursebook-template
  • 351b377f - Cleanup old code from generate_full_register_printout in tasks.py

Compare with previous version

added 11 commits <ul><li>10f6a645 - 1 earlier commit</li><li>53245fb5 - Adapt the firt-part of the coursebook-template to the new datamodel</li><li>cccfa48a - Factor out the notable_participations and personal_notes prefetch</li><li>2dc28493 - Consider different related names for personal_notes</li><li>41f66b0d - Expose select_related from participation and personal_note prefetch</li><li>2fc91bab - Properly prefetch and sort documentations</li><li>34e22655 - Adapt the coursebook-template&#39;s absences to the new datamodel</li><li>a7aa9e28 - Adapt the coursebook-template&#39;s peronal-notes to the new datamodel</li><li>5061222c - Finish the coursebook-template</li><li>4fa766a9 - Tidy the coursebook-template</li><li>351b377f - Cleanup old code from generate_full_register_printout in tasks.py</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49337&start_sha=1b4d6501e36a057710ece38fff4403693aed238a)
hansegucker commented 2024-10-30 17:41:01 +01:00 (Migrated from edugit.org)
Copy link

@permcu Please update with current changes from @ZugBahnHof

@permcu Please update with current changes from @ZugBahnHof
hansegucker commented 2024-10-30 17:53:52 +01:00 (Migrated from edugit.org)
Copy link
<h5>{% blocktrans %}Contact Details{% endblocktrans %}</h5>
```suggestion:-0+0 <h5>{% blocktrans %}Contact Details{% endblocktrans %}</h5> ```
hansegucker commented 2024-10-30 17:53:52 +01:00 (Migrated from edugit.org)
Copy link
<h4>{% trans 'Personal Overview' %}: {{ person.last_name }}, {{ person.first_name }}</h4>
```suggestion:-0+0 <h4>{% trans 'Personal Overview' %}: {{ person.last_name }}, {{ person.first_name }}</h4> ```
hansegucker commented 2024-10-30 17:53:52 +01:00 (Migrated from edugit.org)
Copy link
    <h5>{% trans 'Absences and Tardiness' %}</h5>
```suggestion:-0+0 <h5>{% trans 'Absences and Tardiness' %}</h5> ```
hansegucker commented 2024-10-30 17:53:52 +01:00 (Migrated from edugit.org)
Copy link
    <h5>{% trans 'Extra Marks' %}</h5>
```suggestion:-0+0 <h5>{% trans 'Extra Marks' %}</h5> ```
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link

TODO

There is a method of Documentation, I think, that should do the formatting for you.

TODO There is a method of Documentation, I think, that should do the formatting for you.
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link
<h5>{% trans 'Absences and Tardinesses' %}</h5>
```suggestion:-0+0 <h5>{% trans 'Absences and Tardinesses' %}</h5> ```
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link
<h5>{% trans 'Personal Notes' %}</h5>
```suggestion:-0+0 <h5>{% trans 'Personal Notes' %}</h5> ```
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link

Same as above, but all teachers and name as fallback

Same as above, but all teachers and name as fallback
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link

Yeah, well, we ignore this for now.

Yeah, well, we ignore this for now.
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link
  <h5>{% trans "Absence Reasons" %}</h5>

Also would do this in one table and add not counted as absent in the respective rows

```suggestion:-0+0 <h5>{% trans "Absence Reasons" %}</h5> ``` Also would do this in one table and add `not counted as absent` in the respective rows
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link
  <h5>{% trans "Available Extra Marks" %}</h5>
```suggestion:-0+0 <h5>{% trans "Available Extra Marks" %}</h5> ```
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link

TODO

TODO
hansegucker commented 2024-10-30 17:53:53 +01:00 (Migrated from edugit.org)
Copy link
    <th>{% trans 'Time' %}</th>
```suggestion:-0+0 <th>{% trans 'Time' %}</th> ```
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link
    <th>{% trans 'Topic' %}</th>
```suggestion:-0+0 <th>{% trans 'Topic' %}</th> ```
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link

This should use the color of the absence reason.

This should use the color of the absence reason.
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link

No, archive has to be complete.

No, archive has to be complete.
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link

All teachers!

All teachers!
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link
  <h1>{% trans 'Class Register' %}</h1>
```suggestion:-0+0 <h1>{% trans 'Class Register' %}</h1> ```
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link
<h4>{% trans 'Persons in Group' %} {{ group.name }}</h4>

Use blocktrans with placeholder

```suggestion:-0+0 <h4>{% trans 'Persons in Group' %} {{ group.name }}</h4> ``` Use blocktrans with placeholder
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link

Yes

Yes
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link

That doesn't seem to correct because the table will be empty if there aren't any groups.

That doesn't seem to correct because the table will be empty if there aren't any groups.
hansegucker commented 2024-10-30 17:53:54 +01:00 (Migrated from edugit.org)
Copy link
  {% trans "Class Register:" %} {{ group.name }}

Also use blocktrans with placeholder

```suggestion:-0+0 {% trans "Class Register:" %} {{ group.name }} ``` Also use blocktrans with placeholder
hansegucker commented 2024-10-30 17:53:55 +01:00 (Migrated from edugit.org)
Copy link
      {% include "alsijil/partials/register_teachers_and_subjects_table.html" with groups=group.child_groups only %}
```suggestion:-0+0 {% include "alsijil/partials/register_teachers_and_subjects_table.html" with groups=group.child_groups only %} ```
hansegucker commented 2024-10-30 17:53:55 +01:00 (Migrated from edugit.org)
Copy link
        "print/group/<int:id_>",
```suggestion:-0+0 "print/group/<int:id_>", ```
hansegucker commented 2024-10-30 17:53:55 +01:00 (Migrated from edugit.org)
Copy link
def full_register_for_group(request: HttpRequest, id_: int) -> HttpResponse:
```suggestion:-0+0 def full_register_for_group(request: HttpRequest, id_: int) -> HttpResponse: ```
permcu commented 2024-11-04 10:14:02 +01:00 (Migrated from edugit.org)
Copy link

Done. But his changes were unrelated to mine.

Done. But his changes were unrelated to mine.
permcu commented 2024-11-04 10:15:41 +01:00 (Migrated from edugit.org)
Copy link

added 27 commits

  • 351b377f...f03929a2 - 17 earlier commits
  • c46a2427 - Update statistical queries to reflect schema changes
  • b88f7fd3 - Use new queries
  • abfc8bc5 - Query more documentation fields
  • 5b2d5b99 - Allow mode swithcing on person statistics
  • 376c272a - Show note
  • fbc06654 - Show Rearrange list item title
  • 03cc18b2 - Apply ripple effect to list items
  • ada3a164 - Fix date rendering
  • 270ccd17 - Print only absences with class_register as absence_reason_tags
  • 36061dd0 - Merge branch origin/266-add-statistics-page-for-absences

Compare with previous version

added 27 commits <ul><li>351b377f...f03929a2 - 17 earlier commits</li><li>c46a2427 - Update statistical queries to reflect schema changes</li><li>b88f7fd3 - Use new queries</li><li>abfc8bc5 - Query more documentation fields</li><li>5b2d5b99 - Allow mode swithcing on person statistics</li><li>376c272a - Show note</li><li>fbc06654 - Show Rearrange list item title</li><li>03cc18b2 - Apply ripple effect to list items</li><li>ada3a164 - Fix date rendering</li><li>270ccd17 - Print only absences with class_register as absence_reason_tags</li><li>36061dd0 - Merge branch origin/266-add-statistics-page-for-absences</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49747&start_sha=351b377fee3f91da879fbb534927090c8f2280b2)
permcu commented 2024-11-04 10:20:00 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#53a8b6cdf665e2523bf590da37c605fcb6b294b8_3_3)
permcu commented 2024-11-04 10:20:00 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#53a8b6cdf665e2523bf590da37c605fcb6b294b8_1_1)
permcu commented 2024-11-04 10:20:00 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#53a8b6cdf665e2523bf590da37c605fcb6b294b8_42_42)
permcu commented 2024-11-04 10:20:01 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#53a8b6cdf665e2523bf590da37c605fcb6b294b8_69_69)
permcu commented 2024-11-04 10:20:01 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#53a8b6cdf665e2523bf590da37c605fcb6b294b8_82_82)
permcu commented 2024-11-04 10:20:01 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#53a8b6cdf665e2523bf590da37c605fcb6b294b8_111_111)
permcu commented 2024-11-04 10:20:02 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#c952fdb0a7b024994385465283ba32029d012904_16_16)
permcu commented 2024-11-04 10:20:02 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#c952fdb0a7b024994385465283ba32029d012904_38_38)
permcu commented 2024-11-04 10:20:02 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#3b67042d9097d50f2bba0899f4d9ff5a55f88bd5_7_7)
permcu commented 2024-11-04 10:20:02 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#3b67042d9097d50f2bba0899f4d9ff5a55f88bd5_9_9)
permcu commented 2024-11-04 10:20:03 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#31e98e3c030f4ab97856019e83e30b65a6354318_2_2)
permcu commented 2024-11-04 10:20:03 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#202bb4faafb69f00ab33bd4f46135a336b2386f3_1_1)
permcu commented 2024-11-04 10:20:04 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 17 of the diff

changed this line in [version 17 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909#35d09d1fcc5dbfbdbddd4f36c8917e0bc2996600_6_6)
permcu commented 2024-11-04 10:20:05 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • c601a021 - Edit coursebook text-snippets - mostly casing

Compare with previous version

added 1 commit <ul><li>c601a021 - Edit coursebook text-snippets - mostly casing</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49748&start_sha=36061dd0e35b4a80f747cc992dfd00aea2639909)
permcu commented 2024-11-04 10:21:44 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49749&start_sha=c601a0211a878d39ed01f12b34026b105f10d16e#9b0b789046f23eb95ff88842a58da7c6b3436b54_7_7)
permcu commented 2024-11-04 10:21:46 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 4ae917d5 - Change url of coursebook-printout

Compare with previous version

added 1 commit <ul><li>4ae917d5 - Change url of coursebook-printout</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49749&start_sha=c601a0211a878d39ed01f12b34026b105f10d16e)
permcu commented 2024-11-04 10:22:24 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 19 of the diff

changed this line in [version 19 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49750&start_sha=4ae917d535e4e6108154c4bbc55b324277c29554#35d09d1fcc5dbfbdbddd4f36c8917e0bc2996600_40_40)
permcu commented 2024-11-04 10:22:25 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • f7b37872 - Add missing closing tag

Compare with previous version

added 1 commit <ul><li>f7b37872 - Add missing closing tag</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49750&start_sha=4ae917d535e4e6108154c4bbc55b324277c29554)
permcu commented 2024-11-04 10:26:50 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 20 of the diff

changed this line in [version 20 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49751&start_sha=f7b378724d3aac108303b5eeb33a6ff2bf9b7b7d#17fa7705c025f0876e0fe2c72d23ddad96fcf6f2_45_45)
permcu commented 2024-11-04 10:26:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • e6ca507f - Rename view of coursebook-printout

Compare with previous version

added 1 commit <ul><li>e6ca507f - Rename view of coursebook-printout</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49751&start_sha=f7b378724d3aac108303b5eeb33a6ff2bf9b7b7d)
permcu commented 2024-11-04 10:29:31 +01:00 (Migrated from edugit.org)
Copy link

There is an extra group.name column if there are more than one group. This is intended to show child groups. If still unclear have a look a the prev. template. This table generalizes what prev. where two tables.

There is an extra group.name column if there are more than one group. This is intended to show child groups. If still unclear have a look a the prev. template. This table generalizes what prev. where two tables.
permcu commented 2024-11-04 10:30:25 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 21 of the diff

changed this line in [version 21 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49752&start_sha=e6ca507f86ea392ccb1e3d915ff85a62d2c61cc5#202bb4faafb69f00ab33bd4f46135a336b2386f3_40_40)
permcu commented 2024-11-04 10:30:27 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • be40cb9f - Resolve TODO

Compare with previous version

added 1 commit <ul><li>be40cb9f - Resolve TODO</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49752&start_sha=e6ca507f86ea392ccb1e3d915ff85a62d2c61cc5)
permcu commented 2024-11-04 10:38:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 407e1031 - Use blocktrans in heading of register_members_table

Compare with previous version

added 1 commit <ul><li>407e1031 - Use blocktrans in heading of register_members_table</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49754&start_sha=be40cb9f434b25faf6e0f94ff321c997a343e9e2)
permcu commented 2024-11-04 10:39:29 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 23 of the diff

changed this line in [version 23 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49755&start_sha=407e103193352ffedb114f398e5126db3759c1d4#3b67042d9097d50f2bba0899f4d9ff5a55f88bd5_79_79)
permcu commented 2024-11-04 10:39:30 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • b4403125 - Resolve MAYBE

Compare with previous version

added 1 commit <ul><li>b4403125 - Resolve MAYBE</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49755&start_sha=407e103193352ffedb114f398e5126db3759c1d4)
permcu commented 2024-11-04 10:44:27 +01:00 (Migrated from edugit.org)
Copy link

How should count as absent be indicated then? Or no distinction?

How should count as absent be indicated then? Or no distinction?
permcu commented 2024-11-04 10:46:59 +01:00 (Migrated from edugit.org)
Copy link

It was missing already. I can choose something when I've seen the printout.

It was missing already. I can choose something when I've seen the printout.
permcu commented 2024-11-04 10:56:57 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49756&start_sha=b44031253e69ecaefba481ff3d1268974c7430dc#53a8b6cdf665e2523bf590da37c605fcb6b294b8_103_101)
permcu commented 2024-11-04 10:56:57 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49756&start_sha=b44031253e69ecaefba481ff3d1268974c7430dc#53a8b6cdf665e2523bf590da37c605fcb6b294b8_131_127)
permcu commented 2024-11-04 10:56:58 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49756&start_sha=b44031253e69ecaefba481ff3d1268974c7430dc#3b67042d9097d50f2bba0899f4d9ff5a55f88bd5_87_87)
permcu commented 2024-11-04 10:56:59 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • bb4f61de - Add get_teachers_short_names-method to Documentation
  • 39564060 - Use get_teachers_short_names-method in coursebook-template

Compare with previous version

added 2 commits <ul><li>bb4f61de - Add get_teachers_short_names-method to Documentation</li><li>39564060 - Use get_teachers_short_names-method in coursebook-template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49756&start_sha=b44031253e69ecaefba481ff3d1268974c7430dc)
permcu commented 2024-11-04 10:57:26 +01:00 (Migrated from edugit.org)
Copy link

I could not find such a method and created it myself now.

I could not find such a method and created it myself now.
permcu commented 2024-11-04 11:10:17 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49762&start_sha=395640603294f0bbbf6e8a0d507d3f1c71a8a775#3b67042d9097d50f2bba0899f4d9ff5a55f88bd5_58_58)
permcu commented 2024-11-04 11:10:19 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 881d2ce7 - Show absence_reasons in register_coursebook in their colour
  • 2994693e - Show absence_reasons in their colour in rest of coursebook-printout

Compare with previous version

added 2 commits <ul><li>881d2ce7 - Show absence_reasons in register_coursebook in their colour</li><li>2994693e - Show absence_reasons in their colour in rest of coursebook-printout</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49762&start_sha=395640603294f0bbbf6e8a0d507d3f1c71a8a775)
permcu commented 2024-11-04 11:10:45 +01:00 (Migrated from edugit.org)
Copy link

Done & also did it everywhere else absence-reasons are printed.

Done & also did it everywhere else absence-reasons are printed.
permcu commented 2024-11-04 11:56:58 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 9b3d0633 - Rename coursebook-filters-component to coursebook-controls
  • 5e55a064 - Add print button to coursebook

Compare with previous version

added 2 commits <ul><li>9b3d0633 - Rename coursebook-filters-component to coursebook-controls</li><li>5e55a064 - Add print button to coursebook</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49777&start_sha=2994693eb2d27033a8ec6a53c87669f55c5771e8)
permcu commented 2024-11-04 15:13:41 +01:00 (Migrated from edugit.org)
Copy link

added 19 commits

  • 5e55a064...e1e416fd - 9 earlier commits
  • 1af576c1 - Show absence_reasons in their colour in rest of coursebook-printout
  • 1c68c321 - Rename coursebook-filters-component to coursebook-controls
  • 64724594 - Add print button to coursebook
  • 4ed99604 - Introduce a coursebook-print-dialog
  • 48b8e9c0 - Add a title to the coursebook-print-dialog
  • 2016b446 - Handle loading in the coursebook-print-dialog
  • ccb26fb3 - Add group-selection to the coursebook-print-dialog
  • 5ecc6779 - Add checkboxes for included parts to the coursebook-print-dialog
  • 9da714c5 - Add buttons to the coursebook-print-dialog
  • dfcef6af - Implement print-method for the coursebook-print-dialog

Compare with previous version

added 19 commits <ul><li>5e55a064...e1e416fd - 9 earlier commits</li><li>1af576c1 - Show absence_reasons in their colour in rest of coursebook-printout</li><li>1c68c321 - Rename coursebook-filters-component to coursebook-controls</li><li>64724594 - Add print button to coursebook</li><li>4ed99604 - Introduce a coursebook-print-dialog</li><li>48b8e9c0 - Add a title to the coursebook-print-dialog</li><li>2016b446 - Handle loading in the coursebook-print-dialog</li><li>ccb26fb3 - Add group-selection to the coursebook-print-dialog</li><li>5ecc6779 - Add checkboxes for included parts to the coursebook-print-dialog</li><li>9da714c5 - Add buttons to the coursebook-print-dialog</li><li>dfcef6af - Implement print-method for the coursebook-print-dialog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49849&start_sha=5e55a064262001bed2980cdc8ac6db7bbc7f596d)
permcu commented 2024-11-05 11:21:00 +01:00 (Migrated from edugit.org)
Copy link

added 9 commits

  • 7d20b0e6 - Fix route to coursebook-printout
  • c3f5cf28 - Update import
  • 8d89bf54 - Fix annotate_person_statistics_from_documentations
  • f8fb1d62 - Change generate_full_register_printout to list of groups
  • 90f0b00d - Change register_printout-template to list of groups
  • 110c5036 - Properly provide group wrapped in list in template
  • e29cc26a - Remove TODO
  • 62b5086c - Make frontend & route handle list of groups
  • 2e63f870 - Remove (nonfunctioning) back_url-check

Compare with previous version

added 9 commits <ul><li>7d20b0e6 - Fix route to coursebook-printout</li><li>c3f5cf28 - Update import</li><li>8d89bf54 - Fix annotate_person_statistics_from_documentations</li><li>f8fb1d62 - Change generate_full_register_printout to list of groups</li><li>90f0b00d - Change register_printout-template to list of groups</li><li>110c5036 - Properly provide group wrapped in list in template</li><li>e29cc26a - Remove TODO</li><li>62b5086c - Make frontend &amp; route handle list of groups</li><li>2e63f870 - Remove (nonfunctioning) back_url-check</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49888&start_sha=dfcef6af003615fc79c18e3c59f16432fbb77d50)
permcu commented 2024-11-05 11:29:41 +01:00 (Migrated from edugit.org)
Copy link

added 6 commits

  • d1465a0c - Change generate_full_register_printout to list of groups
  • e288bad8 - Change register_printout-template to list of groups
  • 1c3ea3ec - Properly provide group wrapped in list in template
  • 7d1220be - Remove TODO
  • de33a5e2 - Make frontend & route handle list of groups
  • 7e5cd3b7 - Remove (nonfunctioning) back_url-check

Compare with previous version

added 6 commits <ul><li>d1465a0c - Change generate_full_register_printout to list of groups</li><li>e288bad8 - Change register_printout-template to list of groups</li><li>1c3ea3ec - Properly provide group wrapped in list in template</li><li>7d1220be - Remove TODO</li><li>de33a5e2 - Make frontend &amp; route handle list of groups</li><li>7e5cd3b7 - Remove (nonfunctioning) back_url-check</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49889&start_sha=2e63f870d9c8a6172807ba673016fdcb2166276e)
permcu commented 2024-11-05 20:58:59 +01:00 (Migrated from edugit.org)
Copy link

added 19 commits

  • 7e5cd3b7...b09738e9 - 9 earlier commits
  • 65dcb1d3 - Add include-switches to context
  • 2aeb5b53 - Add load-tags to register-printout-subtemplates
  • 2b09fef0 - Fix closing paren
  • ef34f1e9 - Remove the python-tuple-trap
  • 8e13ec80 - Make coursebook-print-dialog a bit prettier
  • 28f5098d - Add today to context
  • 427df430 - Add missing import
  • 0cff6a3b - Properly parse get-params in full_register_for_group-view
  • 080a56f6 - Default tardiness_sum to 0 if None
  • a06da45a - Fix register_printout-templates

Compare with previous version

added 19 commits <ul><li>7e5cd3b7...b09738e9 - 9 earlier commits</li><li>65dcb1d3 - Add include-switches to context</li><li>2aeb5b53 - Add load-tags to register-printout-subtemplates</li><li>2b09fef0 - Fix closing paren</li><li>ef34f1e9 - Remove the python-tuple-trap</li><li>8e13ec80 - Make coursebook-print-dialog a bit prettier</li><li>28f5098d - Add today to context</li><li>427df430 - Add missing import</li><li>0cff6a3b - Properly parse get-params in full_register_for_group-view</li><li>080a56f6 - Default tardiness_sum to 0 if None</li><li>a06da45a - Fix register_printout-templates</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=49918&start_sha=7e5cd3b71da9d72d7b6a96142c0dd93a58f6cf39)
permcu commented 2024-11-13 16:02:50 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 31 of the diff

changed this line in [version 31 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=50300&start_sha=a06da45aea15a70e9f19b55f506dd0647ed51155#3b67042d9097d50f2bba0899f4d9ff5a55f88bd5_33_44)
permcu commented 2024-11-13 16:02:51 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 5d92d9f6 - Add missing loop over documentations in coursebook-printout

Compare with previous version

added 1 commit <ul><li>5d92d9f6 - Add missing loop over documentations in coursebook-printout</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=50300&start_sha=a06da45aea15a70e9f19b55f506dd0647ed51155)
permcu commented 2024-11-14 19:20:12 +01:00 (Migrated from edugit.org)
Copy link

added 54 commits

  • 5d92d9f6...76e65406 - 25 commits from branch master
  • 76e65406...61732927 - 19 earlier commits
  • b3e94ed8 - Order statistics desc by time
  • 592425bc - Reformat
  • 13fbb415 - Add (disabled) print button
  • 726d95d3 - Apply 1 suggestion(s) to 1 file(s)
  • 048c091a - Merge branch 'master' into 266-add-statistics-page-for-absences
  • be3ee4d5 - Limit page width
  • e4fdd4c4 - Move note to the side
  • d4ea461e - Move statistics card to bottomsheet on mobile
  • 2e511a6c - Reformat
  • 39ebfb19 - Merge 'origin/266-add-statistics-page-for-absences'

Compare with previous version

added 54 commits <ul><li>5d92d9f6...76e65406 - 25 commits from branch <code>master</code></li><li>76e65406...61732927 - 19 earlier commits</li><li>b3e94ed8 - Order statistics desc by time</li><li>592425bc - Reformat</li><li>13fbb415 - Add (disabled) print button</li><li>726d95d3 - Apply 1 suggestion(s) to 1 file(s)</li><li>048c091a - Merge branch &#39;master&#39; into 266-add-statistics-page-for-absences</li><li>be3ee4d5 - Limit page width</li><li>e4fdd4c4 - Move note to the side</li><li>d4ea461e - Move statistics card to bottomsheet on mobile</li><li>2e511a6c - Reformat</li><li>39ebfb19 - Merge &#39;origin/266-add-statistics-page-for-absences&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=50360&start_sha=5d92d9f608ef0c6eef22bdc013254b64c350110d)
hansegucker commented 2024-12-01 17:14:09 +01:00 (Migrated from edugit.org)
Copy link

No distinction

No distinction
hansegucker commented 2024-12-01 17:15:58 +01:00 (Migrated from edugit.org)
Copy link

Debug print

Debug print
hansegucker commented 2024-12-01 17:17:04 +01:00 (Migrated from edugit.org)
Copy link
        "include_teachers_and_subjects_table": "Tabelle mit Lehrkräften und Fächern",
```suggestion:-0+0 "include_teachers_and_subjects_table": "Tabelle mit Lehrkräften und Fächern", ```
hansegucker commented 2024-12-01 17:17:32 +01:00 (Migrated from edugit.org)
Copy link
        "include_members_table": "Tabelle aller Gruppenmitglieder mit Statistiken",
```suggestion:-0+0 "include_members_table": "Tabelle aller Gruppenmitglieder mit Statistiken", ```
hansegucker commented 2024-12-01 17:18:48 +01:00 (Migrated from edugit.org)
Copy link
        "include_person_overviews": "Detailseiten für alle Gruppenmitglieder",
```suggestion:-0+0 "include_person_overviews": "Detailseiten für alle Gruppenmitglieder", ```
permcu commented 2024-12-05 20:08:52 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 34 of the diff

changed this line in [version 34 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51544&start_sha=39ebfb198d1f6a16af72a47cb7f5d5818eeed773#8c1e920a9c379111d64c8818f1b515708d752b40_111_110)
permcu commented 2024-12-05 20:08:52 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 34 of the diff

changed this line in [version 34 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51544&start_sha=39ebfb198d1f6a16af72a47cb7f5d5818eeed773#8c1e920a9c379111d64c8818f1b515708d752b40_110_110)
permcu commented 2024-12-05 20:08:52 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 34 of the diff

changed this line in [version 34 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51544&start_sha=39ebfb198d1f6a16af72a47cb7f5d5818eeed773#8c1e920a9c379111d64c8818f1b515708d752b40_112_110)
permcu commented 2024-12-05 20:08:53 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f3a4cf12 - Format translations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51544&start_sha=39ebfb198d1f6a16af72a47cb7f5d5818eeed773)
permcu commented 2024-12-06 19:49:49 +01:00 (Migrated from edugit.org)
Copy link

added 15 commits

  • f3a4cf12...f5d8ea11 - 5 earlier commits
  • c07a966f - Fix spelling
  • e82d8b2d - Add clarifying TODO
  • 6386ff6f - Fix typo
  • 3e796c4d - Fix prefetch_personal_notes
  • 45714ec8 - Add another default-value for tardiness
  • 8337b07c - Guard against extra_mark is None
  • bd28b2cc - Show absence-reasons in one table
  • 0456af8e - Edit extra-marks-heading
  • 5d773942 - Put parens around extra-mark-short-names as well
  • f0923e32 - Pass absence-reasons to person-overviews

Compare with previous version

added 15 commits <ul><li>f3a4cf12...f5d8ea11 - 5 earlier commits</li><li>c07a966f - Fix spelling</li><li>e82d8b2d - Add clarifying TODO</li><li>6386ff6f - Fix typo</li><li>3e796c4d - Fix prefetch_personal_notes</li><li>45714ec8 - Add another default-value for tardiness</li><li>8337b07c - Guard against extra_mark is None</li><li>bd28b2cc - Show absence-reasons in one table</li><li>0456af8e - Edit extra-marks-heading</li><li>5d773942 - Put parens around extra-mark-short-names as well</li><li>f0923e32 - Pass absence-reasons to person-overviews</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51657&start_sha=f3a4cf12709b0e01087346ad43fd9f49a0cc4381)
permcu commented 2024-12-06 19:51:06 +01:00 (Migrated from edugit.org)
Copy link

changed this line in version 36 of the diff

changed this line in [version 36 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51658&start_sha=f0923e32217e15477009cc6a84fd2a629a56f92c#ab03abedb3add5316d4664cb8c11f7da291dc5e6_136_136)
permcu commented 2024-12-06 19:51:07 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>283cf2e0 - Remove debug print</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51658&start_sha=f0923e32217e15477009cc6a84fd2a629a56f92c)
permcu commented 2024-12-06 19:58:42 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 5f1e1fba - Remove reference to non-existing lessons-day-head-css-class

Compare with previous version

added 1 commit <ul><li>5f1e1fba - Remove reference to non-existing lessons-day-head-css-class</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51660&start_sha=283cf2e0dd9656bb20f7e6dd5c1b4ca0f53c3a62)
permcu commented 2024-12-06 19:59:00 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
permcu commented 2024-12-06 20:09:21 +01:00 (Migrated from edugit.org)
Copy link

Here is a current register-printout:

register-printout.pdf

Unresolved issues:

  • Personal Overview does not show the person's name in the heading.
  • Personal Overview does not show personal_notes with attached note.
    If only a note the row is missing and if note and extra_mark only the extra_mark shows.
  • Au contraire the coursebook does not show personal_notes with extra_marks.
    If there is an attached extra_mark the note is not shown at all.

Last two seem like a backend (tasks.py) issue. But I can not reproduce it at the shell. There it works just fine.

The looks are preserved from before.

Please have a look at personal overviews if they are still as intended.

I think the day in the coursebook should have date - but where. Or maybe add week indicators back in.

Also the AlekSIS-Logo is missing. I do not know why it does not show. The server serves it.

Here is a current register-printout: [register-printout.pdf](/uploads/edf81a1ec2abb787a7264082793bade3/register-printout.pdf) Unresolved issues: - Personal Overview does not show the person's name in the heading. - Personal Overview does not show personal_notes with attached note. If only a note the row is missing and if note and extra_mark only the extra_mark shows. - Au contraire the coursebook does not show personal_notes with extra_marks. If there is an attached extra_mark the note is not shown at all. Last two seem like a backend (tasks.py) issue. But I can not reproduce it at the shell. There it works just fine. The looks are preserved from before. Please have a look at personal overviews if they are still as intended. I think the day in the coursebook should have date - but where. Or maybe add week indicators back in. Also the AlekSIS-Logo is missing. I do not know why it does not show. The server serves it.
hansegucker commented 2024-12-06 22:00:30 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>96c01c8b - Tidy up coursebook export</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51803&start_sha=5f1e1fba344db3ba72abbf40312a97855b4c894b)
permcu commented 2024-12-07 12:27:16 +01:00 (Migrated from edugit.org)
Copy link

added 33 commits

  • 96c01c8b...28ec5cbc - 32 commits from branch master
  • 34d510f9 - Merge 'origin/master'

Compare with previous version

added 33 commits <ul><li>96c01c8b...28ec5cbc - 32 commits from branch <code>master</code></li><li>34d510f9 - Merge &#39;origin/master&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51834&start_sha=96c01c8b76c4cc73776a40cccafafb65a0b93002)
hansegucker commented 2024-12-07 13:53:38 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 641ec995 - Fix templates for coursebook export
  • a77056f6 - Add validation to coursebook print dialog

Compare with previous version

added 2 commits <ul><li>641ec995 - Fix templates for coursebook export</li><li>a77056f6 - Add validation to coursebook print dialog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51838&start_sha=34d510f9365852c5adfc89e17f9002157155018d)
hansegucker commented 2024-12-07 13:54:12 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>24251792 - Update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51840&start_sha=a77056f61db8de69f8f57fdddaf77b34c78bb0f3)
permcu commented 2024-12-07 15:03:06 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 08a67360 - Fixup the tidyup

Compare with previous version

added 1 commit <ul><li>08a67360 - Fixup the tidyup</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51853&start_sha=24251792b44c6895684e23e86f8fa3af750fc3a9)
permcu commented 2024-12-07 15:26:00 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

  • 0d1ddeae - Fix indentation

Compare with previous version

added 1 commit <ul><li>0d1ddeae - Fix indentation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51858&start_sha=08a67360758e30944ac13c325856ab08789f752b)
permcu commented 2024-12-07 15:40:22 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>925c6d5a - Fixup the tidyup</li><li>a3e135c9 - Fix indentation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51861&start_sha=0d1ddeae9cb6946f218936e112b4d40d88753222)
permcu commented 2024-12-07 16:42:46 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f993c9b7 - Fix the fix</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51866&start_sha=a3e135c9685755e31adc4c095aeac5dc567de52b)
permcu commented 2024-12-07 20:04:50 +01:00 (Migrated from edugit.org)
Copy link

mentioned in merge request AlekSIS-Core!2053

mentioned in merge request AlekSIS-Core!2053
permcu commented 2024-12-07 20:36:47 +01:00 (Migrated from edugit.org)
Copy link

Finally everything works:)

It now needs the MR in Core mentioned above.

register-printout.pdf

Still please have a look at the person-overview pages. Are they as intended? They seem misaligned for me & could still need some styling. (I just left them as I found them for now - apart from fixing table-page-break-issues)

@hansegucker Why the restrictions on which parts to print? The printout is fully modular = the user could print whatever he wants.

@hansegucker Please have a look at the changes to the coursebook date in the last commit. I prefer it. But not sure if should keep.

Finally everything works:) It now needs the MR in Core mentioned above. [register-printout.pdf](/uploads/89a2965b498c25905f3a5e7ec4d92327/register-printout.pdf) Still please have a look at the person-overview pages. Are they as intended? They seem misaligned for me & could still need some styling. (I just left them as I found them for now - apart from fixing table-page-break-issues) @hansegucker Why the restrictions on which parts to print? The printout is fully modular = the user could print whatever he wants. @hansegucker Please have a look at the changes to the coursebook date in the last commit. I prefer it. But not sure if should keep.
permcu commented 2024-12-07 20:38:18 +01:00 (Migrated from edugit.org)
Copy link

added 2 commits

  • 971043c4 - Fix the coursebook-print-dialog-validation
  • a6e2a7f4 - Add day-name to date display in coursebook-printout

Compare with previous version

added 2 commits <ul><li>971043c4 - Fix the coursebook-print-dialog-validation</li><li>a6e2a7f4 - Add day-name to date display in coursebook-printout</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51885&start_sha=f993c9b7a8cb211027d83ed62578400f5daceec9)
hansegucker commented 2024-12-07 20:39:30 +01:00 (Migrated from edugit.org)
Copy link

@hansegucker Why the restrictions on which parts to print? The printout is fully modular = the user could print whatever he wants.

Yeah, but he has to include at least one page with information (cover and abbreviations don't count).

> @hansegucker Why the restrictions on which parts to print? The printout is fully modular = the user could print whatever he wants. Yeah, but he has to include at least one page with information (cover and abbreviations don't count).
permcu commented 2024-12-07 20:40:42 +01:00 (Migrated from edugit.org)
Copy link

Why? I would say: Power to the user. If she just needs a cover give her a cover.

Why? I would say: Power to the user. If she just needs a cover give her a cover.
hansegucker commented 2024-12-07 20:41:13 +01:00 (Migrated from edugit.org)
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-12-07 20:41:23 +01:00 (Migrated from edugit.org)
Copy link

marked this merge request as ready

marked this merge request as **ready**
permcu commented 2024-12-07 21:00:33 +01:00 (Migrated from edugit.org)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>fbca4c69 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/422/diffs?diff_id=51887&start_sha=a6e2a7f41f9f2d02ea9daf826944f58abf9d6cd1)
hansegucker (Migrated from edugit.org) merged commit 1b72b30971 into master 2024-12-07 21:51:04 +01:00
hansegucker commented 2024-12-07 21:51:06 +01:00 (Migrated from edugit.org)
Copy link

mentioned in commit 1b72b30971

mentioned in commit 1b72b309711b79e1698c7c0831ffe449efb8437a
hansegucker commented 2024-12-16 12:37:49 +01:00 (Migrated from edugit.org)
Copy link

mentioned in issue #267

mentioned in issue #267
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aleksis/AlekSIS-App-Alsijil!812
No description provided.