Resolve "Add absence overview page" #753

Merged

yuha merged 41 commits from 264-add-absence-overview-page into master 2024-07-22 16:33:49 +02:00

Conversation 38 Commits 41 Files changed 19 +560 -376

yuha commented 2024-06-06 16:23:26 +02:00 (Migrated from edugit.org)

Copy link

Closes #264

Closes #264

yuha commented 2024-06-06 16:23:26 +02:00 (Migrated from edugit.org)

Copy link

assigned to @yuha

assigned to @yuha

yuha commented 2024-06-06 16:26:41 +02:00 (Migrated from edugit.org)

Copy link

added 47 commits

• 84768a91...a3ec31e4 - 37 earlier commits
• 55a6d158 - Touch documentations when opening manage students dialog
• af53a492 - Add loading state to participation list
• 05bf55e6 - Reformat
• 68a59686 - Fix some permissions for absences
• 257c5d3c - Improve creation of participation statuses
• 28332a17 - Fix layout for absence reason chip in list
• f5c2d1a0 - Make select for groups and courses faster
• ab826b29 - Avoid unnecessary queries to fetch related data
• 0c756e6f - Make creation of participation statuses more efficient
• bcf33900 - Track whether participation has been filled already

Compare with previous version

added 47 commits <ul><li>84768a91...a3ec31e4 - 37 earlier commits</li><li>55a6d158 - Touch documentations when opening manage students dialog</li><li>af53a492 - Add loading state to participation list</li><li>05bf55e6 - Reformat</li><li>68a59686 - Fix some permissions for absences</li><li>257c5d3c - Improve creation of participation statuses</li><li>28332a17 - Fix layout for absence reason chip in list</li><li>f5c2d1a0 - Make select for groups and courses faster</li><li>ab826b29 - Avoid unnecessary queries to fetch related data</li><li>0c756e6f - Make creation of participation statuses more efficient</li><li>bcf33900 - Track whether participation has been filled already</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=43658&start_sha=84768a913f44451437475a07b327e2d9944a7656)

yuha commented 2024-06-06 18:14:14 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 003f8836 - Use generic infinite scrolling component for coursebook

Compare with previous version

added 1 commit <ul><li>003f8836 - Use generic infinite scrolling component for coursebook</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=43697&start_sha=bcf33900b0daa482c7130733a7bd32953e7302f5)

yuha commented 2024-06-11 16:21:05 +02:00 (Migrated from edugit.org)

Copy link

added 9 commits

• fff690ea - Show buttons if selection exists
• 0a573394 - Make mutation batchable
• a900f43b - Display loading symbols when changing participations with multi actions
• 021838a2 - Translate extra marks and personal notes to german
• 2ab15b13 - Activate person links in lessoninfo
• c23274f1 - Show non-compact version of LessonInfo in Studentdialog
• 2e64db7b - Add color to absence reasons
• dc851092 - Create better stats in LessonNotes
• 08a9742e - Merge branch '261-add-absence-management-to-course-book-student-dialog' into...

Compare with previous version

added 9 commits <ul><li>fff690ea - Show buttons if selection exists</li><li>0a573394 - Make mutation batchable</li><li>a900f43b - Display loading symbols when changing participations with multi actions</li><li>021838a2 - Translate extra marks and personal notes to german</li><li>2ab15b13 - Activate person links in lessoninfo</li><li>c23274f1 - Show non-compact version of LessonInfo in Studentdialog</li><li>2e64db7b - Add color to absence reasons</li><li>dc851092 - Create better stats in LessonNotes</li><li>08a9742e - Merge branch &#39;261-add-absence-management-to-course-book-student-dialog&#39; into...</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=43917&start_sha=003f88369e617510a0da6fe2182e7b27a65a1449)

yuha commented 2024-06-15 11:55:07 +02:00 (Migrated from edugit.org)

Copy link

added 2 commits

• 01a51440 - Remove unused methods from Coursebook component
• 58173188 - Add switching between coursebook modes

Compare with previous version

added 2 commits <ul><li>01a51440 - Remove unused methods from Coursebook component</li><li>58173188 - Add switching between coursebook modes</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44070&start_sha=08a9742e08bcf584a7a6fe1c654deee1009e78a6)

yuha commented 2024-06-15 21:02:02 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 6287a939 - WIP: Integrate absences overview into coursebook main component

Compare with previous version

added 1 commit <ul><li>6287a939 - WIP: Integrate absences overview into coursebook main component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44077&start_sha=581731882efa7f87b5948dadfeddac93372fbbc6)

yuha commented 2024-06-18 11:48:26 +02:00 (Migrated from edugit.org)

Copy link

added 2 commits

• d42dcf34 - Fix slot template prop naming
• d0ecfa93 - Fix select/deselect participation mechanism

Compare with previous version

added 2 commits <ul><li>d42dcf34 - Fix slot template prop naming</li><li>d0ecfa93 - Fix select/deselect participation mechanism</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44141&start_sha=6287a939cd50efaaa4e4d3e5cda843b8f3d3774c)

yuha commented 2024-06-18 11:49:05 +02:00 (Migrated from edugit.org)

Copy link

added 3 commits

• 83ad08b3 - Integrate absences overview into coursebook main component
• 0652a0a9 - Fix slot template prop naming
• 3000459d - Fix select/deselect participation mechanism

Compare with previous version

added 3 commits <ul><li>83ad08b3 - Integrate absences overview into coursebook main component</li><li>0652a0a9 - Fix slot template prop naming</li><li>3000459d - Fix select/deselect participation mechanism</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44142&start_sha=d0ecfa9386b71edbe96d71da464264538dc8a1ef)

yuha commented 2024-06-18 12:01:54 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• f7678f6c - Fix select/deselect participation mechanism

Compare with previous version

added 1 commit <ul><li>f7678f6c - Fix select/deselect participation mechanism</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44144&start_sha=3000459d7c6efff4d496df82363283f117c3b594)

yuha commented 2024-06-18 21:57:21 +02:00 (Migrated from edugit.org)

Copy link

added 2 commits

• e6842e46 - Fix issue with click handling
• 97ea3007 - Beautify action bar

Compare with previous version

added 2 commits <ul><li>e6842e46 - Fix issue with click handling</li><li>97ea3007 - Beautify action bar</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44151&start_sha=f7678f6cd56770a13b6d79e98f92b6ced4899b5d)

yuha commented 2024-06-19 17:37:41 +02:00 (Migrated from edugit.org)

Copy link

added 2 commits

• 5d048059 - Refine layout
• a8643ee3 - Make absence reason buttons actually work & generalise participation mutation process in mixin

Compare with previous version

added 2 commits <ul><li>5d048059 - Refine layout</li><li>a8643ee3 - Make absence reason buttons actually work &amp; generalise participation mutation process in mixin</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44167&start_sha=97ea300776f9083672f53c67099956896840070e)

yuha commented 2024-06-19 17:42:48 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 039c3215 - Hide participations with present status

Compare with previous version

added 1 commit <ul><li>039c3215 - Hide participations with present status</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44168&start_sha=a8643ee399a8ee98f23341f19612c4edc27267ad)

yuha commented 2024-06-19 20:38:54 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 4a0d6189 - Add filter for lessons with absent students

Compare with previous version

added 1 commit <ul><li>4a0d6189 - Add filter for lessons with absent students</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44189&start_sha=039c3215997a5378a3c2f1b0e8c4dc5b10fddcdb)

yuha commented 2024-06-19 20:40:20 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 16ddfe70 - Reformat

Compare with previous version

added 1 commit <ul><li>16ddfe70 - Reformat</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44190&start_sha=4a0d618969697c4103af4011bc03e2c39d216685)

yuha commented 2024-06-19 20:50:27 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• e6f0c517 - Use absence reason group select component

Compare with previous version

added 1 commit <ul><li>e6f0c517 - Use absence reason group select component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44191&start_sha=16ddfe709026701963516a1484dfba86cbfff4b1)

yuha commented 2024-06-19 23:13:00 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• c237f248 - Make absence reason select card single-line

Compare with previous version

added 1 commit <ul><li>c237f248 - Make absence reason select card single-line</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44193&start_sha=e6f0c51793333e60999c47896eefada5eeb43a06)

yuha commented 2024-06-20 00:28:15 +02:00 (Migrated from edugit.org)

Copy link

added 23 commits

• c237f248...496c787d - 22 commits from branch master
• 6ffc4eee - Merge branch 'release/4.0.0.dev1' into 'master'

Compare with previous version

added 23 commits <ul><li>c237f248...496c787d - 22 commits from branch <code>master</code></li><li>6ffc4eee - Merge branch &#39;release/4.0.0.dev1&#39; into &#39;master&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44194&start_sha=c237f2486411864dd74d40636e82c70fe85893a1)

yuha commented 2024-07-03 15:02:20 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 0c7f7943 - Remove unused list item action

Compare with previous version

added 1 commit <ul><li>0c7f7943 - Remove unused list item action</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44682&start_sha=6ffc4eeea069a9042ad531ac6892b34d9a0db054)

yuha commented 2024-07-03 17:53:29 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• d4d3a8c8 - Automatically deselect participations after action is finished

Compare with previous version

added 1 commit <ul><li>d4d3a8c8 - Automatically deselect participations after action is finished</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44685&start_sha=0c7f7943850917d1d50f5d522ac2ec923db475c0)

yuha commented 2024-07-03 17:54:09 +02:00 (Migrated from edugit.org)

Copy link

marked this merge request as ready

marked this merge request as **ready**

yuha commented 2024-07-03 17:54:13 +02:00 (Migrated from edugit.org)

Copy link

assigned to @hansegucker and unassigned @yuha

assigned to @hansegucker and unassigned @yuha

yuha commented 2024-07-03 17:54:17 +02:00 (Migrated from edugit.org)

Copy link

requested review from @ZugBahnHof

requested review from @ZugBahnHof

yuha commented 2024-07-03 17:55:21 +02:00 (Migrated from edugit.org)

Copy link

added 2 commits

• 3782988f - Reformat
• f7367c25 - Remove unused expanded dialog code

Compare with previous version

added 2 commits <ul><li>3782988f - Reformat</li><li>f7367c25 - Remove unused expanded dialog code</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=44687&start_sha=d4d3a8c8d6c2a6d7c245360e54a22aaba4cf39da)

yuha commented 2024-07-03 20:43:16 +02:00 (Migrated from edugit.org)

Copy link

• switches too much height
• mobile design is not vorhanden
• show only lessons with absences by default
• align the absencereason chips correctly
• align checkbox to warndreieck
• mark-as-box should be more compact
• make everything more compact 😠

* switches too much height * mobile design is not vorhanden * show only lessons with absences by default * align the absencereason chips correctly * align checkbox to warndreieck * mark-as-box should be more compact * make everything more compact :angry:

yuha commented 2024-07-03 20:43:35 +02:00 (Migrated from edugit.org)

Copy link

😠

:angry:

hansegucker commented 2024-07-14 16:31:55 +02:00 (Migrated from edugit.org)

Copy link

                        not doc.participations.exists()

?

```suggestion:-0+0 not doc.participations.exists() ``` ?

yuha commented 2024-07-15 14:04:02 +02:00 (Migrated from edugit.org)

Copy link

added 212 commits

• f7367c25...f4335195 - 200 commits from branch master
• f4335195...ee476c10 - 2 earlier commits
• 7407503a - Give more space to notes in absences
• d4c331f2 - Cleanup layout of participationlist
• 7b5314a8 - Wrap filters correctly
• 8ed6f540 - Merge branch 'master' into absenzen
• ac315e3b - Separate mixins to silence errors
• 5c767dcd - Use correct loader for infinite
• db883df7 - Display correct title based on pageType
• 16ed21ce - Simplify markup
• 07f91fad - Hide absences fab if necessary
• e2c9c0fe - Fix modal action components

Compare with previous version

added 212 commits <ul><li>f7367c25...f4335195 - 200 commits from branch <code>master</code></li><li>f4335195...ee476c10 - 2 earlier commits</li><li>7407503a - Give more space to notes in absences</li><li>d4c331f2 - Cleanup layout of participationlist</li><li>7b5314a8 - Wrap filters correctly</li><li>8ed6f540 - Merge branch &#39;master&#39; into absenzen</li><li>ac315e3b - Separate mixins to silence errors</li><li>5c767dcd - Use correct loader for infinite</li><li>db883df7 - Display correct title based on pageType</li><li>16ed21ce - Simplify markup</li><li>07f91fad - Hide absences fab if necessary</li><li>e2c9c0fe - Fix modal action components</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=45205&start_sha=f7367c25b6c577fea481559428607976ef273b7a)

hansegucker commented 2024-07-15 21:39:04 +02:00 (Migrated from edugit.org)

Copy link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=45209&start_sha=e2c9c0fe6316423999cbd79fb8d3346e085435ea#780f294f550e4cd96aa99e7069b309c8b842f1d2_570_570)

hansegucker commented 2024-07-15 21:39:10 +02:00 (Migrated from edugit.org)

Copy link

added 3 commits

• d1a71be8 - Add missing data to GraphQL responses
• ffdf582e - Reformat
• fe81ec8a - Fix and improve absences query for coursebook

Compare with previous version

added 3 commits <ul><li>d1a71be8 - Add missing data to GraphQL responses</li><li>ffdf582e - Reformat</li><li>fe81ec8a - Fix and improve absences query for coursebook</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=45209&start_sha=e2c9c0fe6316423999cbd79fb8d3346e085435ea)

yuha commented 2024-07-18 12:37:02 +02:00 (Migrated from edugit.org)

Copy link

added 8 commits

• fe81ec8a...bd54ca82 - 7 commits from branch master
• 1ae099f8 - Merge branch 'master' into 264-add-absence-overview-page

Compare with previous version

added 8 commits <ul><li>fe81ec8a...bd54ca82 - 7 commits from branch <code>master</code></li><li>1ae099f8 - Merge branch &#39;master&#39; into 264-add-absence-overview-page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=45492&start_sha=fe81ec8a99ca9543811afaccf9f6067935a18540)

yuha commented 2024-07-18 12:42:22 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 9f273388 - Remove debug print

Compare with previous version

added 1 commit <ul><li>9f273388 - Remove debug print</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=45501&start_sha=1ae099f87f0ed72c543b26ec130b8ca7a8608009)

yuha commented 2024-07-18 13:45:52 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• d9b6e80e - Remove row gap in absence overview list items

Compare with previous version

added 1 commit <ul><li>d9b6e80e - Remove row gap in absence overview list items</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=45529&start_sha=9f273388fb25ca2467628351ed7f715347106dd4)

hansegucker commented 2024-07-21 21:05:22 +02:00 (Migrated from edugit.org)

Copy link

created #308 to continue this discussion

created #308 to continue this discussion

hansegucker commented 2024-07-21 21:05:22 +02:00 (Migrated from edugit.org)

Copy link

resolved all threads

resolved all threads

hansegucker commented 2024-07-21 21:05:22 +02:00 (Migrated from edugit.org)

Copy link

mentioned in issue #308

mentioned in issue #308

hansegucker commented 2024-07-21 21:42:55 +02:00 (Migrated from edugit.org)

Copy link

added 3 commits

• d9b6e80e...d1512a60 - 2 commits from branch master
• fcdec253 - Merge branch 'master' into 264-add-absence-overview-page

Compare with previous version

added 3 commits <ul><li>d9b6e80e...d1512a60 - 2 commits from branch <code>master</code></li><li>fcdec253 - Merge branch &#39;master&#39; into 264-add-absence-overview-page</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=45702&start_sha=d9b6e80ef5bfb4e85208e4a64dc55baf6694cc90)

hansegucker commented 2024-07-22 16:30:30 +02:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 0be3ad66 - Drop CoursebookEmptyMessage in favor of generic infite scrolling component

Compare with previous version

added 1 commit <ul><li>0be3ad66 - Drop CoursebookEmptyMessage in favor of generic infite scrolling component</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/363/diffs?diff_id=45730&start_sha=fcdec253cde23021431f35eecb5b4dc8e658393e)

hansegucker (Migrated from edugit.org) merged commit 21b45e30b7 into master 2024-07-22 16:33:49 +02:00

hansegucker commented 2024-07-22 16:33:52 +02:00 (Migrated from edugit.org)

Copy link

mentioned in commit 21b45e30b7

mentioned in commit 21b45e30b73fab9032b0f89e3bbf147984c4b025

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Security

  

TeX

Needs LaTeX template

  

auto-update

  

board

done

  

board

ready

  

board

todo

  

check

delete-eslint-rc-js

  

check

update-builddeps-package-json

  

check

update-eslint-rc-js

  

check

update-gitignore

  

check

update-merge-request-template

  

check

update-prettier-ignore

  

check

update-pyproject-toml

  

check

update-renovate-json

  

check

update-tox-ini

  

part

backend

Backend (view code, models, logic, etc.)

  

part

ci

  

part

docs

Issue or addition to the documentation

  

part

frontend

Frontend (templates, etc.)

  

part

i18n

Translation or internationalisation issue

  

part

non-technical

Non-technical (policy, maintenance, etc.) issue or discussion

  

part

packaging

Issue concerning the packaging of AlekSIS and components

  

prio

1

Priority High

  

prio

2

Priority Medium

  

prio

3

Priority Low

  

release-mr-5.x

  

size

large

  

size

medium

  

size

small

  

source

customer

Requested by a customer or affiliated user

  

source

customer::fsmw

  

source

customer::fss

  

source

customer::teckids

  

source

downstream

Issue or merge request from other projects using AlekSIS or parts of it

  

type

breaking

  

type

bug

Bug

  

type

feature

New feature

  

type

refactoring

  

workflow

blocked

Issue is blocked by another issue

  

workflow

confirmed

The bug is reproducible and will be fixed

  

workflow

current-todo

  

workflow

discussing

Needs to be discussed before implementation

  

workflow

new-app

Requires new AlekSIS app, which has to be created

  

workflow

wontfix

The bug is not reproducible or the feature was decided against

No labels

Security

TeX

auto-update

board

done

board

ready

board

todo

check

delete-eslint-rc-js

check

update-builddeps-package-json

check

update-eslint-rc-js

check

update-gitignore

check

update-merge-request-template

check

update-prettier-ignore

check

update-pyproject-toml

check

update-renovate-json

check

update-tox-ini

part

backend

part

ci

part

docs

part

frontend

part

i18n

part

non-technical

part

packaging

prio

1

prio

2

prio

3

release-mr-5.x

size

large

size

medium

size

small

source

customer

source

customer::fsmw

source

customer::fss

source

customer::teckids

source

downstream

type

breaking

type

bug

type

feature

type

refactoring

workflow

blocked

workflow

confirmed

workflow

current-todo

workflow

discussing

workflow

new-app

workflow

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

aleksis/AlekSIS-App-Alsijil!753

No description provided.