aleksis/AlekSIS-App-Alsijil
Watch
10
0
Fork
You've already forked AlekSIS-App-Alsijil
 0
Code Issues 48 Pull requests 7 Projects Releases 3 Packages 1 Activity Actions

WIP: Draft: Resolve "Migrate to new data model" #729

Merged
hansegucker merged 13 commits from 246-roadmap-migrate-to-new-data-model into master 2024-04-23 21:24:27 +02:00
Conversation 31 Commits 13 Files changed 10 +742 -5
magicfelix commented 2023-08-08 13:06:19 +02:00
Member
Copy link

Closes #246

Closes #246
magicfelix commented 2023-08-09 11:12:50 +02:00
Author
Member
Copy link

added 2 commits

  • 73b75742 - Adapt to Core 4.0 managed_by feature
  • 2f375716 - WIP: Add models for calendar-based data model

Compare with previous version

added 2 commits <ul><li>73b75742 - Adapt to Core 4.0 managed_by feature</li><li>2f375716 - WIP: Add models for calendar-based data model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=33547&start_sha=60df77b5a56875c27be1401c2e595140d9e1c5b8)
magicfelix commented 2023-08-12 17:01:57 +02:00
Author
Member
Copy link

added 1 commit

  • 6ea54473 - WIP: Add models for calendar-based data model

Compare with previous version

added 1 commit <ul><li>6ea54473 - WIP: Add models for calendar-based data model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=33645&start_sha=2f375716d56857b3b3fd90d1c6d9ed181453df57)
magicfelix commented 2023-08-13 17:02:43 +02:00
Author
Member
Copy link

added 1 commit

  • 620ca595 - Add models for calendar-based data model

Compare with previous version

added 1 commit <ul><li>620ca595 - Add models for calendar-based data model</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=33661&start_sha=6ea544731c53a21dc27ec7c8b68a6e97407e7da7)
magicfelix commented 2023-08-15 01:59:23 +02:00
Author
Member
Copy link

added 1 commit

  • a28e8ece - Add GraphQL schema for Documentation

Compare with previous version

added 1 commit <ul><li>a28e8ece - Add GraphQL schema for Documentation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=33725&start_sha=620ca59521e0985f7a39fc5dc6142c2fc72565fc)
magicfelix commented 2023-08-30 21:04:23 +02:00
Author
Member
Copy link

added 1 commit

  • aa23fffe - WIP: Add permissions for Documentation

Compare with previous version

added 1 commit <ul><li>aa23fffe - WIP: Add permissions for Documentation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=34018&start_sha=a28e8eceb0b612f2325ed501bcb6673cca459be5)
magicfelix commented 2023-09-12 18:50:24 +02:00
Author
Member
Copy link

added 1 commit

  • cf394d14 - WIP: Add permissions for Documentation

Compare with previous version

added 1 commit <ul><li>cf394d14 - WIP: Add permissions for Documentation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=34257&start_sha=aa23fffeacbef858c24cc3d3a8540de97cd4992d)
magicfelix commented 2023-09-12 18:50:50 +02:00
Author
Member
Copy link

added 1 commit

  • 16097f1a - Correct verbose names

Compare with previous version

added 1 commit <ul><li>16097f1a - Correct verbose names</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=34258&start_sha=cf394d14bfb9f27e933b203253f94c6314f9f0d3)
magicfelix commented 2023-09-12 19:30:37 +02:00
Author
Member
Copy link

added 4 commits

  • 0c7f38ac - WIP: Add permissions for Documentation
  • caddeaf6 - Correct verbose names
  • f7dee2f0 - Remove obsolete code
  • 1d404533 - Return only documentations a user is allowed to view

Compare with previous version

added 4 commits <ul><li>0c7f38ac - WIP: Add permissions for Documentation</li><li>caddeaf6 - Correct verbose names</li><li>f7dee2f0 - Remove obsolete code</li><li>1d404533 - Return only documentations a user is allowed to view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=34259&start_sha=16097f1a35ce6948ab5b422836d56ba3979c8031)
hansegucker commented 2023-10-18 20:21:21 +02:00
Owner
Copy link

added 2 commits

  • 5e6f6a33 - Add some verbose names for new class register models
  • b39b1de6 - Update models

Compare with previous version

added 2 commits <ul><li>5e6f6a33 - Add some verbose names for new class register models</li><li>b39b1de6 - Update models</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=35105&start_sha=1d404533d07e93a85424eef7475bc1e0b19cf4d7)
magicfelix commented 2023-11-29 17:50:46 +01:00
Author
Member
Copy link

added 1 commit

  • 5331c712 - Set mutation fields explicitly

Compare with previous version

added 1 commit <ul><li>5331c712 - Set mutation fields explicitly</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=36542&start_sha=b39b1de631be112ab1d838ea94abd5a6d3472a9b)
hansegucker commented 2023-12-29 17:46:21 +01:00
Owner
Copy link
                check=Q(course__isnull=True) ^ Q(lesson_event__isnull=True),
```suggestion:-0+0 check=Q(course__isnull=True) ^ Q(lesson_event__isnull=True), ```
hansegucker commented 2024-01-10 22:12:46 +01:00
Owner
Copy link

changed title from Draft: Resolve "{-[ROADMAP] -}Migrate to new data model" to Draft: Resolve "Migrate to new data model"

changed title from **Draft: Resolve "{-[ROADMAP] -}Migrate to new data model"** to **Draft: Resolve "Migrate to new data model"**
hansegucker commented 2024-01-10 22:26:12 +01:00
Owner
Copy link

Merge according to Dev Meeting decision

Merge according to Dev Meeting decision
hansegucker commented 2024-01-11 17:57:16 +01:00
Owner
Copy link

added 39 commits

  • 5331c712...b9a45f25 - 30 commits from branch master
  • 79517819 - Add models for calendar-based data model
  • 52a9cd14 - Add GraphQL schema for Documentation
  • 97e41acf - WIP: Add permissions for Documentation
  • 26b4e2b2 - Correct verbose names
  • dd092e32 - Remove obsolete code
  • b6701825 - Return only documentations a user is allowed to view
  • 428c5a8c - Add some verbose names for new class register models
  • fc19c951 - Update models
  • 467aada0 - Set mutation fields explicitly

Compare with previous version

added 39 commits <ul><li>5331c712...b9a45f25 - 30 commits from branch <code>master</code></li><li>79517819 - Add models for calendar-based data model</li><li>52a9cd14 - Add GraphQL schema for Documentation</li><li>97e41acf - WIP: Add permissions for Documentation</li><li>26b4e2b2 - Correct verbose names</li><li>dd092e32 - Remove obsolete code</li><li>b6701825 - Return only documentations a user is allowed to view</li><li>428c5a8c - Add some verbose names for new class register models</li><li>fc19c951 - Update models</li><li>467aada0 - Set mutation fields explicitly</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=37991&start_sha=5331c712e7736b1932fe6320faf77463126b6aec)
hansegucker commented 2024-01-11 21:46:53 +01:00
Owner
Copy link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=38001&start_sha=467aada0762d2a8fea67cdb8befc3d46d916c309#780f294f550e4cd96aa99e7069b309c8b842f1d2_557_540)
hansegucker commented 2024-01-11 21:46:53 +01:00
Owner
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>3fca9a1f - Fix lint</li><li>9ea0ed66 - Update models and fix migrations</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=38001&start_sha=467aada0762d2a8fea67cdb8befc3d46d916c309)
yuha commented 2024-01-23 19:48:50 +01:00
Member
Copy link

shouldn't this field (and the two following ones) also be set to null=True

shouldn't this field (and the two following ones) also be set to `null=True`
hansegucker commented 2024-01-23 19:52:11 +01:00
Owner
Copy link

No, it's a CharField and on such fields we only make use of blank=True (so we allow "", but not None).

No, it's a CharField and on such fields we only make use of blank=True (so we allow "", but not `None`).
yuha commented 2024-02-06 22:11:09 +01:00
Member
Copy link

TODO: Add color to ExtraMark and make it configurable whether an extra mark is shown in coursebook

TODO: Add color to `ExtraMark` and make it configurable whether an extra mark is shown in coursebook
yuha commented 2024-03-16 01:15:03 +01:00
Member
Copy link

TODO: Add teacher field

TODO: Add teacher field
yuha commented 2024-03-16 02:00:29 +01:00
Member
Copy link

added 1 commit

  • ddb5bfba - Add teachers field to documentation

Compare with previous version

added 1 commit <ul><li>ddb5bfba - Add teachers field to documentation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=40687&start_sha=9ea0ed6661f2f9273ef28f0040ed994239331b41)
yuha commented 2024-03-16 02:02:05 +01:00
Member
Copy link

added 1 commit

  • 1792cf1f - Add teachers field to documentation

Compare with previous version

added 1 commit <ul><li>1792cf1f - Add teachers field to documentation</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=40689&start_sha=ddb5bfba201e6274e8f0ea18f7a61f5091ee8199)
yuha commented 2024-03-16 02:06:21 +01:00
Member
Copy link

added 1 commit

  • eced46b8 - Add color and show in coursebook fields to ExtraMark

Compare with previous version

added 1 commit <ul><li>eced46b8 - Add color and show in coursebook fields to ExtraMark</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/339/diffs?diff_id=40691&start_sha=1792cf1f7f4575fe90b96d7fa4eae3ab74fac0dc)
hansegucker commented 2024-04-17 20:57:34 +02:00
Owner
Copy link

This should be amends.

This should be `amends`.
yuha commented 2024-04-18 12:45:41 +02:00
Member
Copy link

what do you mean by that?

what do you mean by that?
magicfelix commented 2024-04-18 12:49:39 +02:00
Author
Member
Copy link

A lesson event is the planned future. A documentation represents, what really happened (in this planned event). Because of this close relation (the lesson event and documentation are somehow the „same” logical event), the amends logic should be used.

A lesson event is the planned future. A documentation represents, what really happened (in this planned event). Because of this close relation (the lesson event and documentation are somehow the „same” logical event), the amends logic should be used.
leuckeju commented 2024-04-23 11:43:33 +02:00
Member
Copy link

This was - sadly - done in the coursebook branch, the respective changes should probably be cherry-picked into this branch somehow

This was - sadly - done in the coursebook branch, the respective changes should probably be cherry-picked into this branch somehow
yuha commented 2024-04-23 12:21:06 +02:00
Member
Copy link

@magicfelix

@magicfelix
hansegucker commented 2024-04-23 21:27:02 +02:00
Owner
Copy link

created #279 to continue this discussion

created #279 to continue this discussion
hansegucker commented 2024-04-23 21:27:02 +02:00
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2024-04-23 21:27:02 +02:00
Owner
Copy link

mentioned in issue #279

mentioned in issue #279
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Alsijil!729
No description provided.