aleksis/AlekSIS-App-Alsijil
Watch
10
0
Fork
You've already forked AlekSIS-App-Alsijil
 0
Code Issues 48 Pull requests 7 Projects Releases 3 Packages 1 Activity Actions

Resolve "Custom excuse types aren't counted correctly in generate_person_list_with_class_register_statistics" #716

Merged
hansegucker merged 2 commits from 240-custom-excuse-types-aren-t-counted-correctly-in into prepare-release-3.0b0 2023-04-15 23:14:19 +02:00
Conversation 14 Commits 2 Files changed 2 +2 -1
hansegucker commented 2023-03-23 19:32:04 +01:00
Owner
Copy link

Closes #240

Closes #240
hansegucker commented 2023-03-23 19:32:05 +01:00
Author
Owner
Copy link

assigned to @nik

assigned to @nik
hansegucker commented 2023-03-23 19:32:25 +01:00
Author
Owner
Copy link

added 3 commits

Compare with previous version

added 3 commits <ul><li>f0ae124a - Activate linting of frontend files</li><li>e311aae2 - Reformat</li><li>af849ace - Bump version to 3.0b0 and update changelog</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/326/diffs?diff_id=28928&start_sha=7684a2db4783b02f1f2736fcd183ffe5cb06df31)
hansegucker changed target branch from master to prepare-release-3.0b0 2023-03-23 19:32:32 +01:00
hansegucker commented 2023-03-23 20:08:27 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2023-03-23 20:08:30 +01:00
Author
Owner
Copy link

added 1 commit

  • a4a45020 - Fix distinct query for absences with custom excuse types

Compare with previous version

added 1 commit <ul><li>a4a45020 - Fix distinct query for absences with custom excuse types</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/326/diffs?diff_id=28951&start_sha=af849ace832b940ca6b514bf7304091129fa0a9a)
hansegucker commented 2023-03-23 20:12:52 +01:00
Author
Owner
Copy link

added 6 commits

  • a4a45020...a1ba1e42 - 5 commits from branch prepare-release-3.0b0
  • 75b6bc28 - Merge branch 'prepare-release-3.0b0' into '240-custom-excuse-types-aren-t-counted-correctly-in'

Compare with previous version

added 6 commits <ul><li>a4a45020...a1ba1e42 - 5 commits from branch <code>prepare-release-3.0b0</code></li><li>75b6bc28 - Merge branch &#39;prepare-release-3.0b0&#39; into &#39;240-custom-excuse-types-aren-t-counted-correctly-in&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/326/diffs?diff_id=28952&start_sha=a4a45020f85d0a8779c8c9d9e171a41722ebef66)
nik commented 2023-03-23 20:33:47 +01:00
Owner
Copy link

Instead of what?

Instead of what?
hansegucker commented 2023-03-23 20:35:29 +01:00
Author
Owner
Copy link

Instead of the real sum

Instead of the real sum
nik commented 2023-04-04 21:40:26 +02:00
Owner
Copy link

Shouldn't every absence be coutned exactly as 1? Does that mean the bug is that some absences were counted as 0?

Or was the final sum always 0 or 1?

* Absences with custom excuse types were not counted correctly.
Shouldn't every absence be coutned exactly as 1? Does that mean the bug is that some absences were counted as 0? Or was the **final sum** always 0 or 1? ```suggestion:-0+0 * Absences with custom excuse types were not counted correctly. ```
hansegucker commented 2023-04-14 11:44:26 +02:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2023-04-14 11:44:33 +02:00
Author
Owner
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/326/diffs?diff_id=29180&start_sha=75b6bc288347313e5e5a69480609981d0a2f9dfc#45267e3a9556cafa9cb7b61dab7a3b6659e73aad_18_19)
hansegucker commented 2023-04-14 11:44:33 +02:00
Author
Owner
Copy link

added 3 commits

  • db7676cf - Fix distinct query for absences with custom excuse types
  • 441c8fcb - Use id of the respectie ExtraMark and ExcuseType object when using them as column aliases
  • 8459bbab - Correct the redirect_url used to show a generated PDF printout of a class register

Compare with previous version

added 3 commits <ul><li>db7676cf - Fix distinct query for absences with custom excuse types</li><li>441c8fcb - Use id of the respectie ExtraMark and ExcuseType object when using them as column aliases</li><li>8459bbab - Correct the redirect_url used to show a generated PDF printout of a class register</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/326/diffs?diff_id=29180&start_sha=75b6bc288347313e5e5a69480609981d0a2f9dfc)
hansegucker commented 2023-04-14 11:45:48 +02:00
Author
Owner
Copy link

added 8 commits

  • 8459bbab...1870ffa0 - 7 commits from branch prepare-release-3.0b0
  • 2fa8af88 - Fix distinct query for absences with custom excuse types

Compare with previous version

added 8 commits <ul><li>8459bbab...1870ffa0 - 7 commits from branch <code>prepare-release-3.0b0</code></li><li>2fa8af88 - Fix distinct query for absences with custom excuse types</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/326/diffs?diff_id=29182&start_sha=8459bbabc39bea894254a0f628b209be33fb6f15)
hansegucker commented 2023-04-15 23:13:21 +02:00
Author
Owner
Copy link

added 3 commits

  • 2fa8af88...3990cdd3 - 2 commits from branch prepare-release-3.0b0
  • 71aad3cf - Merge branch 'prepare-release-3.0b0' into '240-custom-excuse-types-aren-t-counted-correctly-in'

Compare with previous version

added 3 commits <ul><li>2fa8af88...3990cdd3 - 2 commits from branch <code>prepare-release-3.0b0</code></li><li>71aad3cf - Merge branch &#39;prepare-release-3.0b0&#39; into &#39;240-custom-excuse-types-aren-t-counted-correctly-in&#39;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/326/diffs?diff_id=29274&start_sha=2fa8af88c1601eb6c5fa09f92f1296cd59827280)
hansegucker commented 2023-04-15 23:14:18 +02:00
Author
Owner
Copy link

mentioned in commit e43c579c6b

mentioned in commit e43c579c6b0e0fb3c64cec1ff69b02e027165f08
hansegucker merged commit e43c579c6b into prepare-release-3.0b0 2023-04-15 23:14:19 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Alsijil!716
No description provided.