Resolve "Improve week view for mobile devices (size s)" #626

Merged

ZugBahnHof merged 19 commits from 186-improve-week-view-for-mobile-devices-size-s into master 2021-12-20 14:03:44 +01:00

Conversation 27 Commits 19 Files changed 4 +284 -97

ZugBahnHof commented 2021-10-13 11:43:09 +02:00 (Migrated from edugit.org)

Copy link

Closes #186

Closes #186

ZugBahnHof commented 2021-10-13 11:43:10 +02:00 (Migrated from edugit.org)

Copy link

assigned to @ZugBahnHof

assigned to @ZugBahnHof

ZugBahnHof commented 2021-10-31 22:48:09 +01:00 (Migrated from edugit.org)

Copy link

added 3 commits

• 67303103 - Remove old mobile view
• 336766cd - Redesign mobile view using horizontal cards
• ba7b826b - Toggle card view using JS

Compare with previous version

added 3 commits <ul><li>67303103 - Remove old mobile view</li><li>336766cd - Redesign mobile view using horizontal cards</li><li>ba7b826b - Toggle card view using JS</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=12861&start_sha=66d10d95e03f522a814b1848ce8a6a69a5bfc344)

ZugBahnHof commented 2021-10-31 23:09:06 +01:00 (Migrated from edugit.org)

Copy link

added 2 commits

• 28e36757 - Fix browser specific styling bugs
• 824db340 - Reduce the card left margin

Compare with previous version

added 2 commits <ul><li>28e36757 - Fix browser specific styling bugs</li><li>824db340 - Reduce the card left margin</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=12862&start_sha=ba7b826b299a461f5091ac9fdef434cdd54d1d4b)

ZugBahnHof commented 2021-11-02 10:49:39 +01:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 07c6f22f - Use a browser independet way of rotating

Compare with previous version

added 1 commit <ul><li>07c6f22f - Use a browser independet way of rotating</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=12875&start_sha=824db340b799a3755b5bba90ee138c19dfd46763)

ZugBahnHof commented 2021-11-04 20:53:39 +01:00 (Migrated from edugit.org)

Copy link

added 3 commits

• 39fd33f3 - Remove item line
• 44faa2f3 - Fix dd margin
• d80f3203 - Display some data in one line

Compare with previous version

added 3 commits <ul><li>39fd33f3 - Remove item line</li><li>44faa2f3 - Fix dd margin</li><li>d80f3203 - Display some data in one line</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=12977&start_sha=07c6f22ffe8c1a901b5199744817430c557cb5a0)

ZugBahnHof commented 2021-11-04 21:15:08 +01:00 (Migrated from edugit.org)

Copy link

added 1 commit

• ef59ab86 - Change unfold button text

Compare with previous version

added 1 commit <ul><li>ef59ab86 - Change unfold button text</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=12979&start_sha=d80f3203831873a2149f2f78fb80cd4bd6ea228d)

ZugBahnHof commented 2021-11-05 16:10:50 +01:00 (Migrated from edugit.org)

Copy link

added 1 commit

• b9d69d1a - Display homework correctly

Compare with previous version

added 1 commit <ul><li>b9d69d1a - Display homework correctly</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=13059&start_sha=ef59ab8641bcf88ddab545a02080600e2e7328ce)

hansegucker commented 2021-11-11 16:10:28 +01:00 (Migrated from edugit.org)

Copy link

@ZugBahnHof Is there already some progress with trying to introduce new tabs?

@ZugBahnHof Is there already some progress with trying to introduce new tabs?

ZugBahnHof commented 2021-12-14 11:54:18 +01:00 (Migrated from edugit.org)

Copy link

added 38 commits

• b9d69d1a...4d263ea3 - 37 commits from branch master
• 2c8668e6 - Merge branch master into branch 186-improve-week-view-for-mobile-devices-size-s

Compare with previous version

added 38 commits <ul><li>b9d69d1a...4d263ea3 - 37 commits from branch <code>master</code></li><li>2c8668e6 - Merge branch master into branch 186-improve-week-view-for-mobile-devices-size-s</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=14475&start_sha=b9d69d1af5d247d1c652f239ffa6d9dc3c914bfa)

ZugBahnHof commented 2021-12-18 13:40:56 +01:00 (Migrated from edugit.org)

Copy link

added 3 commits

• 568ffb77 - Move tabs into navbar
• 7aa0d336 - Toggle week_view filters
• ce73bbfb - Fix margin bug on horizontal scrolling cards

Compare with previous version

added 3 commits <ul><li>568ffb77 - Move tabs into navbar</li><li>7aa0d336 - Toggle week_view filters</li><li>ce73bbfb - Fix margin bug on horizontal scrolling cards</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=14684&start_sha=2c8668e63637afae0b032fe180f8240f4d7c7a71)

ZugBahnHof commented 2021-12-18 13:44:46 +01:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 346722de - Redesign error

Compare with previous version

added 1 commit <ul><li>346722de - Redesign error</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=14686&start_sha=ce73bbfbd0049addb6e82eb563ab60e0ec775c65)

hansegucker commented 2021-12-18 13:46:33 +01:00 (Migrated from edugit.org)

Copy link

Please remove this debug print. Please also use a JS file for this code.

Please remove this debug print. Please also use a JS file for this code.

ZugBahnHof commented 2021-12-18 13:52:05 +01:00 (Migrated from edugit.org)

Copy link

Mobile

   [Mobile](/uploads/d4c1aab7b313bc68152eec578b0a4b90/Mobile) 

ZugBahnHof commented 2021-12-18 13:56:28 +01:00 (Migrated from edugit.org)

Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=14688&start_sha=346722def59c33f56e65affa901a2a857a14e2b8#5462fbda1c5072ebd898ac7347ff9122c9e8e9ac_458_443)

ZugBahnHof commented 2021-12-18 13:56:28 +01:00 (Migrated from edugit.org)

Copy link

added 1 commit

• b90fd90e - Move week_view JS to separate file

Compare with previous version

added 1 commit <ul><li>b90fd90e - Move week_view JS to separate file</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=14688&start_sha=346722def59c33f56e65affa901a2a857a14e2b8)

ZugBahnHof commented 2021-12-18 13:56:33 +01:00 (Migrated from edugit.org)

Copy link

resolved all threads

resolved all threads

ZugBahnHof commented 2021-12-18 17:48:46 +01:00 (Migrated from edugit.org)

Copy link

added 1 commit

• 02f36978 - Reformat week_view template

Compare with previous version

added 1 commit <ul><li>02f36978 - Reformat week_view template</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=14697&start_sha=b90fd90e04be41dd09699367dc24115d176a5de4)

ZugBahnHof commented 2021-12-18 17:48:56 +01:00 (Migrated from edugit.org)

Copy link

marked this merge request as ready

marked this merge request as **ready**

hansegucker commented 2021-12-19 09:33:32 +01:00 (Migrated from edugit.org)

Copy link

Oh, and please update the changelog.

Oh, and please update the changelog.

ZugBahnHof commented 2021-12-20 11:31:03 +01:00 (Migrated from edugit.org)

Copy link

added 1 commit

• f29c38c3 - Update CHANGELOG.rst

Compare with previous version

added 1 commit <ul><li>f29c38c3 - Update CHANGELOG.rst</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/236/diffs?diff_id=14772&start_sha=02f36978c423dfc197c4cf68931c26efaf049cb4)

ZugBahnHof commented 2021-12-20 11:34:21 +01:00 (Migrated from edugit.org)

Copy link

Did so. Please review @hansegucker

Did so. Please review @hansegucker

ZugBahnHof commented 2021-12-20 11:34:21 +01:00 (Migrated from edugit.org)

Copy link

resolved all threads

resolved all threads

nik commented 2021-12-20 13:59:32 +01:00 (Migrated from edugit.org)

Copy link

assigned to @hansegucker and unassigned @ZugBahnHof

assigned to @hansegucker and unassigned @ZugBahnHof

nik commented 2021-12-20 13:59:35 +01:00 (Migrated from edugit.org)

Copy link

requested review from @nik

requested review from @nik

nik commented 2021-12-20 14:00:19 +01:00 (Migrated from edugit.org)

Copy link

approved this merge request

approved this merge request

hansegucker commented 2021-12-20 14:03:44 +01:00 (Migrated from edugit.org)

Copy link

mentioned in commit 7ade1fd7a7

mentioned in commit 7ade1fd7a74a055b763a5e832d15b0b106975034

hansegucker (Migrated from edugit.org) merged commit 7ade1fd7a7 into master 2021-12-20 14:03:44 +01:00

nik (Migrated from edugit.org) approved these changes 2026-07-19 21:40:20 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

nik

Labels

Clear labels   

Security

  

TeX

Needs LaTeX template

  

auto-update

  

board

done

  

board

ready

  

board

todo

  

check

delete-eslint-rc-js

  

check

update-builddeps-package-json

  

check

update-eslint-rc-js

  

check

update-gitignore

  

check

update-merge-request-template

  

check

update-prettier-ignore

  

check

update-pyproject-toml

  

check

update-renovate-json

  

check

update-tox-ini

  

part

backend

Backend (view code, models, logic, etc.)

  

part

ci

  

part

docs

Issue or addition to the documentation

  

part

frontend

Frontend (templates, etc.)

  

part

i18n

Translation or internationalisation issue

  

part

non-technical

Non-technical (policy, maintenance, etc.) issue or discussion

  

part

packaging

Issue concerning the packaging of AlekSIS and components

  

prio

1

Priority High

  

prio

2

Priority Medium

  

prio

3

Priority Low

  

release-mr-5.x

  

size

large

  

size

medium

  

size

small

  

source

customer

Requested by a customer or affiliated user

  

source

customer::fsmw

  

source

customer::fss

  

source

customer::teckids

  

source

downstream

Issue or merge request from other projects using AlekSIS or parts of it

  

type

breaking

  

type

bug

Bug

  

type

feature

New feature

  

type

refactoring

  

workflow

blocked

Issue is blocked by another issue

  

workflow

confirmed

The bug is reproducible and will be fixed

  

workflow

current-todo

  

workflow

discussing

Needs to be discussed before implementation

  

workflow

new-app

Requires new AlekSIS app, which has to be created

  

workflow

wontfix

The bug is not reproducible or the feature was decided against

No labels

Security

TeX

auto-update

board

done

board

ready

board

todo

check

delete-eslint-rc-js

check

update-builddeps-package-json

check

update-eslint-rc-js

check

update-gitignore

check

update-merge-request-template

check

update-prettier-ignore

check

update-pyproject-toml

check

update-renovate-json

check

update-tox-ini

part

backend

part

ci

part

docs

part

frontend

part

i18n

part

non-technical

part

packaging

prio

1

prio

2

prio

3

release-mr-5.x

size

large

size

medium

size

small

source

customer

source

customer::fsmw

source

customer::fss

source

customer::teckids

source

downstream

type

breaking

type

bug

type

feature

type

refactoring

workflow

blocked

workflow

confirmed

workflow

current-todo

workflow

discussing

workflow

new-app

workflow

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

aleksis/AlekSIS-App-Alsijil!626

No description provided.