aleksis/AlekSIS-App-Alsijil
Watch
10
0
Fork
You've already forked AlekSIS-App-Alsijil
 0
Code Issues 48 Pull requests 7 Projects Releases 3 Packages 1 Activity Actions

Resolve "Improve design of detail view for one register object" #625

Merged
hansegucker merged 16 commits from 189-improve-design-of-detail-view-for-one-register-object into master 2021-12-04 23:58:35 +01:00
Conversation 25 Commits 16 Files changed 15 +757 -578
hansegucker commented 2021-09-20 15:06:28 +02:00
Owner
Copy link

Closes #189

Closes #189
hansegucker commented 2021-09-20 15:06:29 +02:00
Author
Owner
Copy link

assigned to @hansegucker

assigned to @hansegucker
hansegucker commented 2021-10-20 19:58:17 +02:00
Author
Owner
Copy link

Desktop

image

Tablet

image

Mobile

image

# Desktop ![image](/uploads/5b16ab1993b8f6c79ef27a7fa9b00027/image.png) # Tablet ![image](/uploads/cd426ae2e3073e4c24e7694b27b2a1b2/image.png) # Mobile ![image](/uploads/ea75bc5e0f67ce7cb10d02f3d9911cd8/image.png)
hansegucker commented 2021-10-20 20:04:27 +02:00
Author
Owner
Copy link

added 1 commit

  • ed31cbff - Optimize lesson overview for mobile and tablet devices

Compare with previous version

added 1 commit <ul><li>ed31cbff - Optimize lesson overview for mobile and tablet devices</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/235/diffs?diff_id=12392&start_sha=94f525d9bbf4bffcd8d7c3226ea4b3a3cf6e4830)
hansegucker commented 2021-10-20 20:05:13 +02:00
Author
Owner
Copy link

assigned to @nik and unassigned @hansegucker

assigned to @nik and unassigned @hansegucker
hansegucker commented 2021-10-20 20:05:21 +02:00
Author
Owner
Copy link

requested review from @ZugBahnHof

requested review from @ZugBahnHof
hansegucker commented 2021-10-20 20:05:27 +02:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-10-22 08:03:37 +02:00
Author
Owner
Copy link

added 5 commits

  • ed31cbff...66d10d95 - 2 commits from branch master
  • ad91bb5c - Merge branch 'master' into 189-improve-design-of-detail-view-for-one-register-object
  • 7fde4479 - Update changelog
  • 77fd11dd - Bump AlekSIS-App-Chronos to 2.0rc3 as it includes necessary features

Compare with previous version

added 5 commits <ul><li>ed31cbff...66d10d95 - 2 commits from branch <code>master</code></li><li>ad91bb5c - Merge branch &#39;master&#39; into 189-improve-design-of-detail-view-for-one-register-object</li><li>7fde4479 - Update changelog</li><li>77fd11dd - Bump AlekSIS-App-Chronos to 2.0rc3 as it includes necessary features</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/235/diffs?diff_id=12434&start_sha=ed31cbff7e6006c259dd4cbd9be279fd70451d7f)
hansegucker commented 2021-10-22 11:20:19 +02:00
Author
Owner
Copy link

added 3 commits

  • 77fd11dd...b9944ff1 - 2 commits from branch master
  • 6975d6ba - Merge branch 'master' into 189-improve-design-of-detail-view-for-one-register-object

Compare with previous version

added 3 commits <ul><li>77fd11dd...b9944ff1 - 2 commits from branch <code>master</code></li><li>6975d6ba - Merge branch &#39;master&#39; into 189-improve-design-of-detail-view-for-one-register-object</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/235/diffs?diff_id=12454&start_sha=77fd11ddcb35726ae2382f576d9276232d23e5cb)
hansegucker commented 2021-11-02 11:03:18 +01:00
Author
Owner
Copy link

marked this merge request as draft

marked this merge request as **draft**
hansegucker commented 2021-11-17 21:22:48 +01:00
Author
Owner
Copy link

added 15 commits

  • 6975d6ba...4ee6c811 - 13 commits from branch master
  • bcb020f5 - Merge branch 'update/dev-dependencies' into...
  • 317f3e8b - Merge branch 'master' into 189-improve-design-of-detail-view-for-one-register-object

Compare with previous version

added 15 commits <ul><li>6975d6ba...4ee6c811 - 13 commits from branch <code>master</code></li><li>bcb020f5 - Merge branch &#39;update/dev-dependencies&#39; into...</li><li>317f3e8b - Merge branch &#39;master&#39; into 189-improve-design-of-detail-view-for-one-register-object</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/235/diffs?diff_id=13572&start_sha=6975d6ba785b7836d115128386bf9c8f5c003bff)
hansegucker commented 2021-11-23 17:12:07 +01:00
Author
Owner
Copy link

added 1 commit

  • 9e37998c - Use icon tabs and new navigation buttons to restructure the register object view

Compare with previous version

added 1 commit <ul><li>9e37998c - Use icon tabs and new navigation buttons to restructure the register object view</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/235/diffs?diff_id=13678&start_sha=317f3e8b634a64a658bb64f26fe15d9de6d77e5a)
hansegucker commented 2021-11-23 17:12:40 +01:00
Author
Owner
Copy link

~"workflow::blocked" by AlekSIS/official/AlekSIS-Core!1179

~"workflow::blocked" by AlekSIS/official/AlekSIS-Core!1179
hansegucker commented 2021-11-23 17:17:54 +01:00
Author
Owner
Copy link

With some feedback by @ZugBahnHof und @lloydmeins, I built a new variant using icon tabs:

Desktop

Desktop

Tablet

Tablet

Mobile

image

@ZugBahnHof @lloydmeins @fph @nik Please review this and give me some feedback so we could get this done and move over to make the stable release of Alsijil.

With some feedback by @ZugBahnHof und @lloydmeins, I built a new variant using icon tabs: ## Desktop ![Desktop](/uploads/f6ec0d988504cd5df053f1d0b3800b5d/image.png) ## Tablet ![Tablet](/uploads/71097823c17adc4a209506c8a18ecb1b/image.png) ## Mobile ![image](/uploads/f44d5768db22dcf2524c3852565b3106/image.png) @ZugBahnHof @lloydmeins @fph @nik Please review this and give me some feedback so we could get this done and move over to make the stable release of Alsijil.
yuha commented 2021-11-26 00:10:39 +01:00
Member
Copy link

I really like that one. Not overcrowded like some earlier attempts.

I really like that one. Not overcrowded like some earlier attempts.
hansegucker commented 2021-11-28 20:44:29 +01:00
Author
Owner
Copy link

mentioned in merge request AlekSIS-Core!1179

mentioned in merge request AlekSIS-Core!1179
leuckeju commented 2021-11-29 15:15:36 +01:00
Member
Copy link

it's definetly better, but still not perfect I'd say

it's definetly better, but still not perfect I'd say
hansegucker commented 2021-12-01 17:07:07 +01:00
Author
Owner
Copy link

added 1 commit

  • 5aa7a2bf - Depend on AlekSIS-Core 2.2 for icon tabs

Compare with previous version

added 1 commit <ul><li>5aa7a2bf - Depend on AlekSIS-Core 2.2 for icon tabs</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/235/diffs?diff_id=13990&start_sha=9e37998c1c71748b880d18cdad7faff6a85d1d52)
hansegucker commented 2021-12-01 20:10:39 +01:00
Author
Owner
Copy link

Feedback talk with @ZugBahnHof:

  • Week button in secondary color
  • Fix padding in top nav bar
  • Lesson status chip under
  • Fix icons (same icons in some parts)
  • Check how button looks without full width
  • All buttons of nav header in one row on m, l, xl
Feedback talk with @ZugBahnHof: - [x] Week button in secondary color - [x] Fix padding in top nav bar - [x] Lesson status chip under - [x] Fix icons (same icons in some parts) - [x] Check how button looks without full width - [x] All buttons of nav header in one row on m, l, xl
hansegucker commented 2021-12-01 21:12:54 +01:00
Author
Owner
Copy link

added 5 commits

  • 7acd4035 - Unify paddings on lesson overview page
  • a763cc29 - Use icon warning for "Missing data" to avoid a clash with "Previous lesson"
  • 6300757a - Restructure button nav bar on lesson overview page
  • bd57aa3c - Remove misleading comment
  • 12f11db2 - Move lesson status chip under lesson heading

Compare with previous version

added 5 commits <ul><li>7acd4035 - Unify paddings on lesson overview page</li><li>a763cc29 - Use icon warning for &quot;Missing data&quot; to avoid a clash with &quot;Previous lesson&quot;</li><li>6300757a - Restructure button nav bar on lesson overview page</li><li>bd57aa3c - Remove misleading comment</li><li>12f11db2 - Move lesson status chip under lesson heading</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/235/diffs?diff_id=13997&start_sha=5aa7a2bfdbff42902a6831461558b544790074fc)
hansegucker commented 2021-12-01 21:12:58 +01:00
Author
Owner
Copy link

resolved all threads

resolved all threads
hansegucker commented 2021-12-04 23:19:52 +01:00
Author
Owner
Copy link

Last feedback (from teachers):
2021-12-04.pdf

Main points:

  • Replace "Notes" by "Persons"
  • Show save button also on top of lesson documentation tab
Last feedback (from teachers): [2021-12-04.pdf](/uploads/bb503062f49ef0c275b4214a4c40a529/2021-12-04.pdf) Main points: - [x] Replace "Notes" by "Persons" - [x] Show save button also on top of lesson documentation tab
hansegucker commented 2021-12-04 23:28:19 +01:00
Author
Owner
Copy link

added 2 commits

  • 380cc3db - Add second save button for lesson documentation tab on small devices
  • 64acfa79 - Replace tab title "Notes" by "Persons"

Compare with previous version

added 2 commits <ul><li>380cc3db - Add second save button for lesson documentation tab on small devices</li><li>64acfa79 - Replace tab title &quot;Notes&quot; by &quot;Persons&quot;</li></ul> [Compare with previous version](/AlekSIS/official/AlekSIS-App-Alsijil/-/merge_requests/235/diffs?diff_id=14148&start_sha=12f11db263c6e87c0be7dac371c1ba38471887ef)
hansegucker commented 2021-12-04 23:28:47 +01:00
Author
Owner
Copy link

marked this merge request as ready

marked this merge request as **ready**
hansegucker commented 2021-12-04 23:29:14 +01:00
Author
Owner
Copy link

Okay, @nik @ZugBahnHof, now comes the final review. From my point of view, this can be merged afterwards.

Okay, @nik @ZugBahnHof, now comes the final review. From my point of view, this can be merged afterwards.
nik merged commit 73aef4f1ee into master 2021-12-04 23:58:35 +01:00
nik commented 2021-12-04 23:58:37 +01:00
Owner
Copy link

mentioned in commit 73aef4f1ee

mentioned in commit 73aef4f1ee07ba3cf45c8413e91baa9865e41668
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nik
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-App-Alsijil!625
No description provided.